Re: [LEDE-DEV] [PATCH] ag71xx: Add back napi_complete_done.

2017-10-17 Thread rosenp
Well that's embarasing :). Forgot to add _done. Not enough coffee. On Tue, 2017-10-17 at 22:16 +0100, Kevin Darbyshire-Bryant wrote: > > On 17/10/17 21:52, ros...@gmail.com wrote: > > I'll take your word for it since I have no hardware to test on. > > I'd say it has a huge impact on performance

Re: [LEDE-DEV] [PATCH] ag71xx: Add back napi_complete_done.

2017-10-17 Thread Kevin Darbyshire-Bryant
On 17/10/17 21:52, ros...@gmail.com wrote: I'll take your word for it since I have no hardware to test on. I'd say it has a huge impact on performance irrespective of hardware 'cos the patch as supplied doesn't actually compile ;-) CC drivers/net/ethernet/atheros/ag71xx/ag71xx_main

Re: [LEDE-DEV] [PATCH] ag71xx: Add back napi_complete_done.

2017-10-17 Thread rosenp
I'll take your word for it since I have no hardware to test on. On Tue, 2017-10-17 at 21:44 +0200, Felix Fietkau wrote: > On 2017-10-17 18:51, Rosen Penev wrote: > > This should have no impact on the recently discovered performance > > regression. > > > > Signed-off-by: Rosen Penev > > When GRO

Re: [LEDE-DEV] [PATCH] ag71xx: Add back napi_complete_done.

2017-10-17 Thread Felix Fietkau
On 2017-10-17 18:51, Rosen Penev wrote: > This should have no impact on the recently discovered performance regression. > > Signed-off-by: Rosen Penev When GRO is not used, this makes no difference at all. - Felix ___ Lede-dev mailing list Lede-dev@li

Re: [LEDE-DEV] [PATCH] ag71xx: Add back napi_complete_done.

2017-10-17 Thread Kevin Darbyshire-Bryant
On 17/10/17 17:51, Rosen Penev wrote: This should have no impact on the recently discovered performance regression. Signed-off-by: Rosen Penev --- With the greatest will in the world, should isn't the same as doesn't :-) Any testing? Cheers, Kevin ___

[LEDE-DEV] [PATCH] ag71xx: Add back napi_complete_done.

2017-10-17 Thread Rosen Penev
This should have no impact on the recently discovered performance regression. Signed-off-by: Rosen Penev --- .../ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c| 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/linux/ar71xx/files/drivers/net/ethern