Re: [LEDE-DEV] [PATCH][ubox] Fixes log read starvation issue after threshold reached

2017-07-14 Thread Petr Štetiar
Jo-Philipp Wich [2017-07-12 23:34:13]: Hi, > Do you have an easy test case for this? Is piping ~16K plaintext to the > logger enough to trigger the starvation? I'd like to understand the > problem some more before judging the patch. I was trying to fix probably similar issue back in March, but

Re: [LEDE-DEV] [PATCH][ubox] Fixes log read starvation issue after threshold reached

2017-07-13 Thread Felix Fietkau
On 2017-07-13 14:45, Ron Brash wrote: > Hi Felix, > > Is there a situation where an incomplete read could be forced? We just > found that the reads would be stalled previously because events were not > consumed and managed correctly. > > Any other suggestions? :) Try checking for s->eof. - Felix

Re: [LEDE-DEV] [PATCH][ubox] Fixes log read starvation issue after threshold reached

2017-07-13 Thread Felix Fietkau
On 2017-07-11 21:04, Ron Brash wrote: > This patch fixes a logread starvation error, which occurs after many > logs are generated (around 16k if defaults are used). The log read > process seems to halt silently and yet continues running. A restart > of the log services fixes it. > > This is probl

Re: [LEDE-DEV] [PATCH][ubox] Fixes log read starvation issue after threshold reached

2017-07-12 Thread Jo-Philipp Wich
Hi Ron, thanks for your effort in sharing your fixes. I have troubles understanding your patch, please find some comments inline below. ~ Jo -- On 07/11/2017 09:04 PM, Ron Brash wrote: > This patch fixes a logread starvation error, which occurs after many > logs are generated (around 16k if de

[LEDE-DEV] [PATCH][ubox] Fixes log read starvation issue after threshold reached

2017-07-11 Thread Ron Brash
This patch fixes a logread starvation error, which occurs after many logs are generated (around 16k if defaults are used). The log read process seems to halt silently and yet continues running. A restart of the log services fixes it. This is problematic because logs should be logged, instead of s