Re: [LEDE-DEV] [OpenWrt-Devel] Enable DCO check on Github OpenWrt organisation

2018-01-21 Thread Stijn Tintel
On 21-01-18 19:21, Jo-Philipp Wich wrote: > Hi, > > ACK from me as well. > >> ACK to enable it for packages, not sure if it makes sense for core as we >> enforce this in the project git repo already, and Github is just a mirror. > It does make sense to provide immediate feedback on Github pull requ

Re: [LEDE-DEV] [OpenWrt-Devel] Enable DCO check on Github OpenWrt organisation

2018-01-21 Thread Stijn Tintel
On 19-01-18 15:02, Piotr Dymacz wrote: > > > On 19.01.2018 13:09, Etienne Champetier wrote: > >> We can also make it mandatory (show "required" on the fail test line) >> Also this is a good minimum check to have on ALL repo >> There are many ways to do it, enabling DCO is a 2 minutes job (if >> som

Re: [LEDE-DEV] [OpenWrt-Devel] Enable DCO check on Github OpenWrt organisation

2018-01-21 Thread Jo-Philipp Wich
Hi, ACK from me as well. > ACK to enable it for packages, not sure if it makes sense for core as we > enforce this in the project git repo already, and Github is just a mirror. It does make sense to provide immediate feedback on Github pull requests I assume. ~ Jo __

Re: [LEDE-DEV] [OpenWrt-Devel] Enable DCO check on Github OpenWrt organisation

2018-01-19 Thread Piotr Dymacz
Hi Etienne, On 19.01.2018 13:09, Etienne Champetier wrote: Hi Piotr, 2018-01-19 9:54 GMT+01:00 Piotr Dymacz : Hi Etienne, On 18.01.2018 22:59, Etienne Champetier wrote: Hi All, Could someone enable this https://github.com/integration/dco on the whole OpenWrt github org? (or at least on the

Re: [LEDE-DEV] [OpenWrt-Devel] Enable DCO check on Github OpenWrt organisation

2018-01-19 Thread Etienne Champetier
Hi Piotr, 2018-01-19 9:54 GMT+01:00 Piotr Dymacz : > Hi Etienne, > > On 18.01.2018 22:59, Etienne Champetier wrote: >> >> Hi All, >> >> Could someone enable this https://github.com/integration/dco on the >> whole OpenWrt github org? (or at least on the packages repo) > > > I think that packages re

Re: [LEDE-DEV] [OpenWrt-Devel] Enable DCO check on Github OpenWrt organisation

2018-01-19 Thread Piotr Dymacz
Hi Etienne, On 18.01.2018 22:59, Etienne Champetier wrote: Hi All, Could someone enable this https://github.com/integration/dco on the whole OpenWrt github org? (or at least on the packages repo) I think that packages repository already uses Travis CI which checks for such thing like a missi