[LEDE-DEV] [PATCH] procd: service_handle_set() should use SERVICE_SET_NAME rather than SERVICE_ATTR_NAME

2017-10-04 Thread pme . lebleu
The SERVICE_SET_NAME belongs to enum SERVICE_SET_, not SERVICE_ATTR_NAME. Signed-off-by: Pierre Lebleu --- service/service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/service/service.c b/service/service.c index 02a29fa..9c798aa 100644 --- a/service/service.c +++ b/s

[LEDE-DEV] [PATCH][RFC] procd: service: add data within the service itself

2017-10-04 Thread pme . lebleu
From: Pierre Lebleu It gives the ability to create firewall data within the service itself rather than within an instance. Signed-off-by: Pierre Lebleu --- service/service.c | 45 +++-- service/service.h | 2 ++ 2 files changed, 45 insertions(+), 2 dele

[LEDE-DEV] [PATCH] procd: service_handle_set() should use SERVICE_SET_NAME rather than SERVICE_ATTR_NAME

2017-10-04 Thread pme . lebleu
From: Pierre Lebleu Signed-off-by: Pierre Lebleu --- service/service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/service/service.c b/service/service.c index 02a29fa..9c798aa 100644 --- a/service/service.c +++ b/service/service.c @@ -267,7 +267,7 @@ service_handle_set(s

[LEDE-DEV] [PATCH v2 8/9] firewall3: display the section type for UBUS rules

2017-05-04 Thread pme . lebleu
From: Pierre Lebleu It gives the ability to display the section type for rules pushed via procd services and netifd interface firewall data. Signed-off-by: Pierre Lebleu --- ubus.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/ubus.c b/ubus.c i

[LEDE-DEV] [PATCH v2 7/9] firewall3: add UBUS support for include scripts

2017-05-04 Thread pme . lebleu
From: Pierre Lebleu It gives the ability to include scripts via procd services and netifd interface firewall data. Signed-off-by: Pierre Lebleu --- Notes: v1->v2: - remove the assignements within the "if" - add a new function check_include() - use warn_section() rather than warn() inc

[LEDE-DEV] [PATCH v2 4/9] firewall3: add UBUS support for redirect sections

2017-05-04 Thread pme . lebleu
From: Pierre Lebleu It gives the ability to create redirect rules via procd services and netifd interface firewall data. Signed-off-by: Pierre Lebleu --- Notes: v1->v2: - remove the assignements within the "if" - add a new function check_redirect() - use warn_section() rather than warn(

[LEDE-DEV] [PATCH v2 9/9] firewall3: add check_snat() function

2017-05-04 Thread pme . lebleu
From: Pierre Lebleu The snat rule check is done by a function to avoid the walking through the list twice. Signed-off-by: Pierre Lebleu --- snats.c | 182 +++ 1 file changed, 90 insertions(+), 92 deletions(-) diff --git a/snats.c b/

[LEDE-DEV] [PATCH v2 6/9] firewall3: add UBUS support for ipset sections

2017-05-04 Thread pme . lebleu
From: Pierre Lebleu It gives the ability to create ipset rules via procd services and netifd interface firewall data. Signed-off-by: Pierre Lebleu --- Notes: v1->v2: - remove the assignements within the "if" - add a new function check_ipset() - use warn_section() rather than warn() ip

[LEDE-DEV] [PATCH v2 2/9] firewall3: replace warn_rule() by warn_section()

2017-05-04 Thread pme . lebleu
From: Pierre Lebleu Replace the wan_rule() by warn_section() in order to make it reusable by the other section type. Signed-off-by: Pierre Lebleu --- rules.c | 37 ++--- utils.h | 10 ++ 2 files changed, 24 insertions(+), 23 deletions(-) diff --git

[LEDE-DEV] [PATCH v2 5/9] firewall3: add UBUS support for forwarding sections

2017-05-04 Thread pme . lebleu
From: Pierre Lebleu It gives the ability to create forward rules via procd services and netifd interface firewall data. Signed-off-by: Pierre Lebleu --- Notes: v1->v2: - remove the assignements within the "if" - add a new function check_forward() - use warn_section() rather than warn()

[LEDE-DEV] [PATCH v2 3/9] firewall3: add fw3_attr_parse_name_type() function

2017-05-04 Thread pme . lebleu
From: Pierre Lebleu Move the name and type parsing out of the rule file in order to make it reusable by others. Signed-off-by: Pierre Lebleu --- rules.c | 16 +++- snats.c | 16 +++- utils.c | 19 +++ utils.h |3 +++ 4 files changed, 36 inserti

[LEDE-DEV] [PATCH v2 1/9] firewall3: check the return value of fw3_parse_options()

2017-05-04 Thread pme . lebleu
From: Pierre Lebleu The return value of fw3_parse_options() should be checked. Signed-off-by: Pierre Lebleu --- Notes: v1->v2: - do not make the fw3_parse_options() error fatal defaults.c |3 ++- forwards.c |3 ++- includes.c |3 ++- ipsets.c |3 ++- zones.c|3 ++