[LEDE-DEV] [PATCH] lantiq: Shortcut non-pppoa interfaces in dsl_notify

2017-03-15 Thread Oswald Buddenhagen
No need to query 'up' and 'auto' when they are not going to be used. Signed-off-by: Oswald Buddenhagen --- target/linux/lantiq/base-files/sbin/dsl_notify.sh | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/target/linux/lantiq/base-files/s

Re: [LEDE-DEV] externalizing package management?

2017-01-11 Thread Oswald Buddenhagen
On Wed, Jan 11, 2017 at 11:00:04AM +0100, Jo-Philipp Wich wrote: > > in my understanding, sysupgrade images (and uimages) are a pretty > > uniform archive format, > > Actually they're not. There are factory and sysupgrade images which are > renamed tars, there are trx images, there are FIT images,

Re: [LEDE-DEV] how to make sysupgrade not drop user-installed packages

2017-01-11 Thread Oswald Buddenhagen
On Wed, Jan 11, 2017 at 10:54:10AM +0100, Jo-Philipp Wich wrote: > > there doesn't appear to be anything hard about having the build bots > > include a file into /etc which contains the _current_ repository > > url, subdirectory, and image name. > > you forget that up until very recently the same

Re: [LEDE-DEV] externalizing package management?

2017-01-10 Thread Oswald Buddenhagen
On Sun, Jan 08, 2017 at 08:42:25PM +0100, Jo-Philipp Wich wrote: > the imagebuilder should support all that already and it likely fills the > "powerful desktop tools" part your concept requires. > i answered that in my other mail already. anyway, specifically regarding the existing imagebuilder,

Re: [LEDE-DEV] how to make sysupgrade not drop user-installed packages

2017-01-10 Thread Oswald Buddenhagen
On Sun, Jan 08, 2017 at 08:38:04PM +0100, Jo-Philipp Wich wrote: > Right now it cannot be provided unless we provide suitable meta data for > that on the server side or - preferably - inside the image itself. > i actually had that typed out already, but deleted it because it seems like a complete

Re: [LEDE-DEV] externalizing package management?

2017-01-08 Thread Oswald Buddenhagen
On Sun, Jan 08, 2017 at 02:16:55PM +0100, Stefan Lippers-Hollmann wrote: > Using imagebuilder (and keeping the existing configs, which is the > default for sysupgrade) seems to tick all of your boxes, doesn't it? > not quite. obviously, wrapping the image builder into a script solves the upgrade

[LEDE-DEV] externalizing package management?

2017-01-08 Thread Oswald Buddenhagen
moin, openwrt aims to be a "proper" linux distribution, and therefore comes with on-device package management. but we know that to be a problem for the more space-constrained devices. also, the space constraints make the package manager pretty dumb by modern standards. both issues have been raise

Re: [LEDE-DEV] how to make sysupgrade not drop user-installed packages

2017-01-08 Thread Oswald Buddenhagen
On Sat, Jan 07, 2017 at 11:31:01PM +0100, Magnus Kroken wrote: > On 07.01.2017 19.04, Oswald Buddenhagen wrote: > > the idea would be to simply dump the list of user-installed packages into > > a config file which is preserved by sysupgrade. now, firstboot would see > > tha

[LEDE-DEV] how to make sysupgrade not drop user-installed packages

2017-01-07 Thread Oswald Buddenhagen
moin, i'm wondering what could be done about the nuisance that after a sysupgrade one needs to manually re-install the user-installed packages. the documented process is pretty much algorithmic, so it seems like a shame that it's not (mostly) automated. the idea would be to simply dump the list o

Re: [LEDE-DEV] [OpenWrt-Devel] Talks between OpenWrt and LEDE

2016-12-27 Thread Oswald Buddenhagen
On Tue, Dec 27, 2016 at 08:28:25AM +0100, John Crispin wrote: > On 27/12/2016 08:08, David Lang wrote: > > On Mon, 26 Dec 2016, Kathy Giori wrote: > >> On Wed, Dec 21, 2016 at 11:31 PM, John Crispin wrote: > >>> i am still very much in favour of having 2 trees, one stable and one dev > >>> tree. t

Re: [LEDE-DEV] [PATCH 6/6] lantiq: use ath9k device tree bindings binding/owl-loader

2016-11-24 Thread Oswald Buddenhagen
On Wed, Nov 23, 2016 at 07:36:33AM +0100, Bastian Bittorf wrote: > * Martin Blumenstingl [23.11.2016 07:22]: > > + case $board in > > better: "$board" > no, not better. the case discriminator is not word-split (and quoting even breaks on some ancient shell). __

Re: [LEDE-DEV] [PATCH] busybox: prevent globbing, splitting

2016-10-14 Thread Oswald Buddenhagen
On Fri, Oct 14, 2016 at 07:54:53PM +0200, Jan-Tarek Butt wrote: > - ntpservers=$(ubus call network.interface dump | jsonfilter -e > "@.interface[$filter]['data']['ntpserver']") > + ntpservers="$(ubus call network.interface dump | jsonfilter -e > "@.interface[$filter]['data']['ntpserver']"

Re: [LEDE-DEV] [PATCH v2] uboot-envtools: remove function vals and fix indentation

2016-10-06 Thread Oswald Buddenhagen
this commit message is cryptic; i had to read the patch to understand what you mean. there seems to be a pattern. ;) also, technically speaking, you're not _fixing_ the indentation, as it was canonical. you're using a less known shell feature to _improve_ it. (fwiw, i dislike that the syntax _requ

Re: [LEDE-DEV] Call defines for minifying scripting languages

2016-10-03 Thread Oswald Buddenhagen
On Mon, Oct 03, 2016 at 01:00:19PM +0200, Jan-Tarek Butt wrote: > My Idea ist to create calldefs to minify all scriptes there are > interpreted by run time. > > 1. Reducing memory size on firmware images. > this is absolutely negligible. as others already pointed out, scripts compress quite well.

Re: [LEDE-DEV] Speedport W504V | ARV8539PW22 - gets very hot !

2016-10-01 Thread Oswald Buddenhagen
On Sat, Oct 01, 2016 at 12:49:49PM +0200, Dennis Schneck wrote: > I have a Speedport W504V | ARV8539PW22, but i gets very hot (without > doing anything, only power on some minutes). > define "very hot". the box has a power consumption of around 5w when the dsl connection is down, and goes up to alm

Re: [LEDE-DEV] [patch master 15/15] read without -r will mangle backslashes

2016-10-01 Thread Oswald Buddenhagen
re subject: many of your commit message summaries don't comply with the imperative style generally expected. in the descriptions, you should mention what "terrible" things the patches prevent in practice, including when the answer is "nothing" and thus the change is just a clarification. ___

Re: [LEDE-DEV] [patch master 11/15] Consider using { cmd1; cmd2; } >> file instead of individual redirects

2016-10-01 Thread Oswald Buddenhagen
On Fri, Sep 30, 2016 at 10:02:25PM +0200, Jan-Tarek Butt wrote: > diff --git a/scripts/config/lxdialog/check-lxdialog.sh > b/scripts/config/lxdialog/check-lxdialog.sh > - echo " *** Unable to find the ncurses libraries or the" 1>&2 > - echo " *** required header files."

Re: [LEDE-DEV] [patch master 14/15] Expressions don't expand in single quotes, use double quotes for that

2016-10-01 Thread Oswald Buddenhagen
On Sat, Oct 01, 2016 at 12:49:23AM +0200, Lars Kruse wrote: > I think, this is just a change based on style preferences, or? > Using single quotes specifically for situation where expansion is not intended > feels quite explicite and clear to me - thus personally I would prefer to > stick > with s

Re: [LEDE-DEV] [patch master 13/15] To read lines rather than words, pipe/redirect to a 'while read' loop

2016-10-01 Thread Oswald Buddenhagen
On Sat, Oct 01, 2016 at 12:44:36AM +0200, Lars Kruse wrote: > Am Fri, 30 Sep 2016 22:02:27 +0200 schrieb Jan-Tarek Butt : > > > --- > > scripts/deptest.sh | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/scripts/deptest.sh b/scripts/deptest.sh > > index 8c85

Re: [LEDE-DEV] [patch master 12/15] use * instead of @ to concatenate

2016-10-01 Thread Oswald Buddenhagen
On Sat, Oct 01, 2016 at 12:37:24AM +0200, Lars Kruse wrote: > Am Fri, 30 Sep 2016 22:02:26 +0200 schrieb Jan-Tarek Butt : > > > - cc="$@" > > + cc="$*" > > as far as I understand $* and $@, there should be no difference in this > context, or? > which is exactly the reason to

Re: [LEDE-DEV] [patch master 10/15] quote literal {

2016-10-01 Thread Oswald Buddenhagen
On Sat, Oct 01, 2016 at 12:30:22AM +0200, Lars Kruse wrote: > Am Fri, 30 Sep 2016 22:02:24 +0200 schrieb Jan-Tarek Butt : > > > --- > > scripts/getver.sh | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/scripts/getver.sh b/scripts/getver.sh > > index f8b4ed3..27

Re: [LEDE-DEV] [patch master 08/15] Use $(..) instead of legacy `..`

2016-10-01 Thread Oswald Buddenhagen
On Fri, Sep 30, 2016 at 10:02:22PM +0200, Jan-Tarek Butt wrote: > diff --git a/scripts/deptest.sh b/scripts/deptest.sh > - for pkg in `cat tmp/.packagedeps | grep CONFIG_PACKAGE | grep -v > curdir | sed -e 's,.*[/=]\s*,,' | sort -u`; do > + for pkg in $(cat tmp/.packagedeps | grep CONFIG

Re: [LEDE-DEV] [patch master 05/15] Use cd ... || exit in case cd fails

2016-10-01 Thread Oswald Buddenhagen
On Sat, Oct 01, 2016 at 12:05:16AM +0200, Lars Kruse wrote: > Am Fri, 30 Sep 2016 22:02:19 +0200 schrieb Jan-Tarek Butt : > > - libdirs="$libdirs $(cd "$libdir"; pwd)/" > > + libdirs="$libdirs $(cd "$libdir" || exit; > > pwd)/" fi > > I am not su

Re: [LEDE-DEV] [patch master 05/15] Use cd ... || exit in case cd fails

2016-10-01 Thread Oswald Buddenhagen
On Fri, Sep 30, 2016 at 10:02:19PM +0200, Jan-Tarek Butt wrote: > diff --git a/scripts/get_source_date_epoch.sh > b/scripts/get_source_date_epoch.sh > -[ -n "$TOPDIR" ] && cd "$TOPDIR" > +[ -n "$TOPDIR" ] && cd "$TOPDIR" || exit > diff --git a/scripts/getver.sh b/scripts/getver.sh > -[ -n "$TOPDIR

Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

2016-10-01 Thread Oswald Buddenhagen
On Fri, Sep 30, 2016 at 11:50:09PM +0200, Lars Kruse wrote: > Am Fri, 30 Sep 2016 22:02:15 +0200 schrieb Jan-Tarek Butt : > > - for pattern in $(eval echo $spec); do > > - find $libdirs -name "$pattern.so*" | sort -u > > + for pattern in $(eval echo "$spec"); d

Re: [LEDE-DEV] [RFC] lantiq: fix ath5k EEPROM loading

2016-08-24 Thread Oswald Buddenhagen
On Tue, Aug 23, 2016 at 09:14:36PM +0200, Mathias Kresin wrote: > With 12fe4b579801ea812b64fc7e689716cd39c895ec I switched the ath5k > eeprom extraction to an alternate code path. Unfortunately this code > seams to be broken since ages and broke the ath5k EEPROM extraction. > i have no particular

Re: [LEDE-DEV] [PATCH v2 1/2] lantiq: unmacro tp-link boards

2016-05-31 Thread Oswald Buddenhagen
On Mon, May 30, 2016 at 11:54:05AM +0200, Alexander Couzens wrote: > even it's a little bit verbose, unmacrod board descriptions are much > easier to read and to understand. > you're undoing work by hauke et. al from just a few weeks ago. ;) while it's certainly true that the macros complicate ma

Re: [LEDE-DEV] I've come round to your way of thinking

2016-05-26 Thread Oswald Buddenhagen
On Thu, May 26, 2016 at 12:38:42AM -0400, Daniel Curran-Dickinson wrote: > I'm sorry [...] > no worries. :) > despite how overly strong you come into this discussion. > yeah, i'm known for being not exactly the greatest diplomat. :} ___ Lede-dev mailing

Re: [LEDE-DEV] OpenWRT tree vs LEDE tree

2016-05-21 Thread Oswald Buddenhagen
On Fri, May 20, 2016 at 10:58:19AM +0200, Jo-Philipp Wich wrote: > Oswald wrote: > > well, that's kinda the key here, isn't it? i don't know whether the > > lede infrastructure and participation was technically open from the > > start, but the fact that nobody except "the cabal" knew about it > > m

Re: [LEDE-DEV] OpenWRT tree vs LEDE tree

2016-05-20 Thread Oswald Buddenhagen
On Fri, May 20, 2016 at 04:13:37AM -0400, Daniel Curran-Dickinson wrote: > On 16-05-20 04:08 AM, Oswald Buddenhagen wrote: > >> > > the whole point of my side sentence was to give a hint that maybe my > > impressions and suggestions are not entirely unfounded or discard

Re: [LEDE-DEV] OpenWRT tree vs LEDE tree

2016-05-20 Thread Oswald Buddenhagen
On Fri, May 20, 2016 at 03:26:42AM -0400, Daniel Curran-Dickinson wrote: > On 16-05-20 03:13 AM, Oswald Buddenhagen wrote: > > On Thu, May 19, 2016 at 10:40:21PM -0400, Daniel Curran-Dickinson wrote: > >>> anyway, that's my perspective as an outsider (who has 15 years o

Re: [LEDE-DEV] OpenWRT tree vs LEDE tree

2016-05-20 Thread Oswald Buddenhagen
On Thu, May 19, 2016 at 10:40:21PM -0400, Daniel Curran-Dickinson wrote: > > anyway, that's my perspective as an outsider (who has 15 years of > > experience in some *big* openly governed communities) ... > > Since you obviously feel there are other communities doing this right, > perhaps you'd li

Re: [LEDE-DEV] OpenWRT tree vs LEDE tree

2016-05-19 Thread Oswald Buddenhagen
On Thu, May 19, 2016 at 04:40:34PM +0200, Jo-Philipp Wich wrote: > Bjørn wrote: > > Yes, this is extremely unfair. Just like the I'm sure some > > developers saw the original LEDE announcement. Good intentions are > > not enough. It's the result that matters. > > I certainly agree but we should