Re: [LEDE-DEV] [PATCH] uci/file: replace mktemp() with mkstemp()

2017-09-17 Thread Maxim Gorbachyov
On Sun, Sep 17, 2017 at 4:06 PM, Stijn Tintel wrote: >> Because mktemp() is evil. > Hi, please add a reference when making such claims. "Never use mktemp() ... every use of mktemp() is a security risk" https://linux.die.net/man/3/mktemp I thought it's obvious. _

[LEDE-DEV] [PATCH] uci/file: replace mktemp() with mkstemp()

2017-09-16 Thread Maxim Gorbachyov
Because mktemp() is evil. Signed-off-by: Maxim Gorbachyov --- file.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/file.c b/file.c index 494c649..ad0355b 100644 --- a/file.c +++ b/file.c @@ -28,6 +28,7 @@ #include #include #include +#include