Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Mats Karrman
On 2016-06-15 15:16, Felix Fietkau wrote: On 2016-06-15 15:13, Hans Dedecker wrote: >> On Wed, Jun 15, 2016 at 11:58 AM, Felix Fietkau >> wrote: >>> On 2016-06-15 11:39, Conor O'Gorman wrote: On 09/06/16 03:20, Yousong Zhou wrote: > Fix a race condition when do_sigchld, uloop_cancel

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Mats Karrman
On 2016-06-15 13:20, Yousong Zhou wrote: On 15 June 2016 at 17:58, Felix Fietkau wrote: On 2016-06-09 04:20, Yousong Zhou wrote: Fix a race condition when do_sigchld, uloop_cancelled were set just before epoll_wait(timeout=-1), resulting the loop stuck in the syscall without noticing the even

Re: [LEDE-DEV] libubox, procd: init process hangs

2016-06-09 Thread Mats Karrman
On 2016-06-08 23:43, Xinxing Hu wrote: Hi Yousong, Thanks a lot for you patch. I tried it a little bit, and till now everything looks OK. It seems this issue is solved by your patch. Not sure whether Mats (the original reporter of this issue) still see the issue or not. Unfortunately I hav

Re: [LEDE-DEV] libubox, procd: init process hangs

2016-05-19 Thread Mats Karrman
On 2016-05-18 15:09, Mats Karrman wrote: On 2016-05-18 14:03, Felix Fietkau wrote: On 2016-05-18 14:00, Mats Karrman wrote: On 2016-05-18 13:01, Felix Fietkau wrote: On 2016-05-18 11:38, Mats Karrman wrote: On 2016-05-17 17:31, Mats Karrman wrote: On 2016-05-17 13:29, Felix Fietkau

Re: [LEDE-DEV] libubox, procd: init process hangs

2016-05-18 Thread Mats Karrman
On 2016-05-18 13:01, Felix Fietkau wrote: On 2016-05-18 11:38, Mats Karrman wrote: On 2016-05-17 17:31, Mats Karrman wrote: On 2016-05-17 13:29, Felix Fietkau wrote: I just took a look at the code and uloop's processing of signals looked a bit racy to me. I've pushed a commit tha

Re: [LEDE-DEV] libubox, procd: init process hangs

2016-05-18 Thread Mats Karrman
On 2016-05-17 17:31, Mats Karrman wrote: On 2016-05-17 13:29, Felix Fietkau wrote: I just took a look at the code and uloop's processing of signals looked a bit racy to me. I've pushed a commit that makes it use signalfd if available. I also found that waitpid wasn't being re

Re: [LEDE-DEV] libubox, procd: init process hangs

2016-05-17 Thread Mats Karrman
On 2016-05-17 13:29, Felix Fietkau wrote: I just took a look at the code and uloop's processing of signals looked a bit racy to me. I've pushed a commit that makes it use signalfd if available. I also found that waitpid wasn't being retried on signal interrupt, so I added an extra check there. T

[LEDE-DEV] libubox, procd: init process hangs

2016-05-17 Thread Mats Karrman
Hi Felix, others, I have been experiencing problems with the init scripts dispatch suddenly stopping (indefinitely). This happens maybe once in 100 reboots. After inserting a new start script that launches another daemon (cgrulesengd) very early in the boot process, the failures started to co