Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH] blobmsg_json: handle conversion of large integers from JSON

2016-10-25 Thread Eyal Birger
Hi, On Wed, Oct 19, 2016 at 1:10 PM, Florian Larysch wrote: > Currently, libubox uses json_object_get_int when converting a JSON > document into a blobmsg. However, json-c stores integers as int64_t > values and may clamp the value when asked to return it as an int32_t. > > Always use json_object

[LEDE-DEV] [PATCH] uloop: handle waker pipe write() return value

2016-06-19 Thread Eyal Birger
Recent glibc warns if result of read() or write() is unused. Added a retry in case of EINTR, all other faults are silently discarded. Signed-off-by: Eyal Birger - - I was not able to reproduce the EINTR case, but it seems to be the right thing to do - Retrying on EAGAIN in this case

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH libubox] blobmsg_json: add new functions blobmsg_format_json_value*

2016-06-06 Thread Eyal Birger
On Sat, Jun 4, 2016 at 6:27 PM, Matthias Schiffer wrote: > On 06/03/2016 04:55 PM, Eyal Birger wrote: >> >> Hi, >> >>> On 3 Jun 2016, at 13:11, Matthias Schiffer >>> wrote: >>> >> (snip) >>> >>> 1) and 2) would allow blob

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH netifd 1/3] device: Fix device find failure in avl list due to device name change

2016-06-06 Thread Eyal Birger
Hi Hans, On Mon, Jun 6, 2016 at 1:03 PM, Hans Dedecker wrote: > As device name is used as key in avl list a device name change will break the > avl find logic. > Function device_set_ifname offers api to set the device name and re-inserts > the avl node in the list > when the avl key value is ch

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH libubox] blobmsg_json: add new functions blobmsg_format_json_value*

2016-06-03 Thread Eyal Birger
Hi, > On 3 Jun 2016, at 13:11, Matthias Schiffer > wrote: > (snip) > > 1) and 2) would allow blobmsg to store everything that json-c can (with the > caveat that json-c stores integers as int64 internally, while blobmsg_json > uses int32) - We also noticed this as a problem for us since when

[LEDE-DEV] [PATCH] mdnsd: interface: enable looped back messages

2016-05-22 Thread Eyal Birger
When the IP_MULTICAST_LOOP/IPV6_MULTICAST_LOOP socket options are not enabled, locally generated queries are ignored by mdnsd; This prevents local applications from being able to discover locally published services. Signed-off-by: Eyal Birger --- interface.c | 8 1 file changed, 4