Re: [LEDE-DEV] [PATCH 2/3] ag71xx: Remove ___cacheline_aligned from ring structs.

2018-02-06 Thread Rosen Penev
On Tue, Feb 6, 2018 at 8:27 PM, Florian Fainelli wrote: > On February 6, 2018 2:27:29 PM PST, Rosen Penev wrote: >>Qualcomm's struct members and inner workings of their driver are all >>different. >>While this might make sense for their driver, it seems to hurt here. In >>iperf3, i've seen incons

Re: [LEDE-DEV] [PATCH 2/3] ag71xx: Remove ___cacheline_aligned from ring structs.

2018-02-06 Thread Florian Fainelli
On February 6, 2018 2:27:29 PM PST, Rosen Penev wrote: >Qualcomm's struct members and inner workings of their driver are all >different. >While this might make sense for their driver, it seems to hurt here. In >iperf3, i've seen inconsistent results including a drop of 100mbps on >an >Archer C7v4.

[LEDE-DEV] CONFIG_ALL_NONSHARED=y leads to build failures on four targets

2018-02-06 Thread Daniel Gimpelevich
I am sending this to the list at Hauke's request. I had edited the following script to abort on error: https://gist.github.com/mkresin/64aca8673dd5452a1b5ab93dbf77b2d4 In total, it aborted 4 times, on ath25, malta, mediatek, and uml. On ath25, the build error was in the "wrt55agv2-spidevs" package

[LEDE-DEV] [PATCH 3/3] ag71xx: Switch to napi_alloc_frag.

2018-02-06 Thread Rosen Penev
Seems to perform slightly better. Signed-off-by: Rosen Penev --- .../ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c b/target/linu

[LEDE-DEV] [PATCH 1/3] ag71xx: Remove timestamp struct member and use trans_start instead

2018-02-06 Thread Rosen Penev
Small speedup for TX. Based on a Qualcomm commit. ag->timestamp = jiffies was not replaced with netif_trans_update(dev) because of this quote: It should be noted that after this series several instances of netif_trans_update() are useless (if they occur in .ndo_start_xmit and driver doesn't set

[LEDE-DEV] [PATCH 2/3] ag71xx: Remove ___cacheline_aligned from ring structs.

2018-02-06 Thread Rosen Penev
Qualcomm's struct members and inner workings of their driver are all different. While this might make sense for their driver, it seems to hurt here. In iperf3, i've seen inconsistent results including a drop of 100mbps on an Archer C7v4. This patch keeps the results high and relatively consistent.