Re: [LEDE-DEV] [PATCH] base-files: rc.common: fix enable() return code and logic

2017-12-27 Thread Roman Yeryomin
On 2017-12-26 10:39, Karl Palsson wrote: Roman Yeryomin wrote: On 2017-12-21 21:35, Roman Yeryomin wrote: > In current state, if there is STOP but no START, enbale() > will return 0 (success), which is wrong. > Moreover there is no need to check for START/STOP twice. > Instead, add err variable

[LEDE-DEV] [PATCH] treewide: move nand_do_upgrade call to platform_do_upgrade

2017-12-27 Thread Mathias Kresin
Calling nand_do_upgrade() from platform_pre_upgrade() was deprecated with 30f61a34b4cf ("base-files: always use staged sysupgrade"). Update the platform upgrade code to use platform_do_upgrade() for NAND images as well. Signed-off-by: Mathias Kresin --- .../apm821xx/base-files/lib/upgrade/platf

[LEDE-DEV] [PATCH] treewide: remove obsolete sysupgrade watchdog kill

2017-12-27 Thread Mathias Kresin
The watchdog kill command was meant for busybox watchdog. Busybox watchdog was replaced by the procd watchdog mid 2013 with commit df7ce9301a25 ("busybox: disable the watchdog utility by default"), which makes the kill command obsolete since quite some time. Signed-off-by: Mathias Kresin --- tar

[LEDE-DEV] [PATCH 2/2] base-files: gpio switch: set output value with direction

2017-12-27 Thread Mathias Kresin
Use the "low" and "high" values to configure the GPIO as an output with that initial value. It ensures that the gpio doesn't have a unwanted value during the time the direction is set to ouput and the actual value is applied. We don't need to take care of the GPIO polarity for now, since our expor

[LEDE-DEV] [PATCH 1/2] base-files: gpio_switch: start before boot state done is set

2017-12-27 Thread Mathias Kresin
Start gpio_switch before the boot state is set to up/initialised/done. This way the exported GPIOs are available at the time rc.local is started. Cc: Lars Kruse Signed-off-by: Mathias Kresin --- package/base-files/files/etc/init.d/gpio_switch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [LEDE-DEV] layerscape build bot problem

2017-12-27 Thread Hauke Mehrtens
Hi Yangbo Lu, It looks like build bot can now build the layerscape target. The last build was successful for the 32 and the 64 bit version: http://phase1.builds.lede-project.org/grid Thanks for fixing this. Hauke On 12/25/2017 09:07 AM, Y.b. Lu wrote: > Hi Hauke, > > Created the pull request.