Re: [Lazarus] Redundant assigned(X) and (X is Txxx) in Laz. sources

2018-01-12 Thread Mattias Gaertner via Lazarus
On Sat, 13 Jan 2018 13:01:33 +0800 Dennis via Lazarus wrote: >[...] > I am now confused, so > in FPC, it is safe to just use: if LookupRoot is TWinControl >instead of > if assigned(LookupRoot) and (LookupRoot is TWinControl) then Yes. > is it safe to > with LookupRoot a

Re: [Lazarus] Redundant assigned(X) and (X is Txxx) in Laz. sources

2018-01-12 Thread Dennis via Lazarus
Mattias Gaertner via Lazarus wrote: On Fri, 12 Jan 2018 21:44:47 +0200 Juha Manninen via Lazarus wrote: On Fri, Jan 12, 2018 at 8:38 PM, Vojtěch Čihák via Lazarus wrote: I wrote a small routine to search Lazarus sources and it found about 60 places similar to this (taborderdlg.pas, line 39

Re: [Lazarus] Redundant assigned(X) and (X is Txxx) in Laz. sources

2018-01-12 Thread Mattias Gaertner via Lazarus
On Fri, 12 Jan 2018 21:44:47 +0200 Juha Manninen via Lazarus wrote: > On Fri, Jan 12, 2018 at 8:38 PM, Vojtěch Čihák via Lazarus > wrote: > > I wrote a small routine to search Lazarus sources and it found about 60 > > places similar to this (taborderdlg.pas, line 398): > > > > if Assigned(Lookup

Re: [Lazarus] Redundant assigned(X) and (X is Txxx) in Laz. sources

2018-01-12 Thread Juha Manninen via Lazarus
On Fri, Jan 12, 2018 at 8:38 PM, Vojtěch Čihák via Lazarus wrote: > I wrote a small routine to search Lazarus sources and it found about 60 > places similar to this (taborderdlg.pas, line 398): > > if Assigned(LookupRoot) and (LookupRoot is TWinControl) then begin > > Should I make a patch for all

[Lazarus] Redundant assigned(X) and (X is Txxx) in Laz. sources

2018-01-12 Thread Vojtěch Čihák via Lazarus
Hi,   I wrote a small routine to search Lazarus sources and it found about 60 places similar to this (taborderdlg.pas, line 398):   if Assigned(LookupRoot) and (LookupRoot is TWinControl) then begin   Should I make a patch for all occurences?   V. --