Re: [Lazarus] New TMaskList [forked from: TMask revisited]

2021-10-27 Thread Bart via lazarus
On Tue, Oct 26, 2021 at 10:44 PM Bart wrote: > I'll have a go at it then To simplify matters I decided to remove the CreateWindows and CreateNative constructors for TMaskList. The CreateWindows skipped the population of fMasksWindows, but that is a small price to pay IMO. I can't have this as a

Re: [Lazarus] New TMaskList [forked from: TMask revisited]

2021-10-26 Thread Bart via lazarus
On Tue, Oct 26, 2021 at 7:20 PM Bart wrote: > So, now we have: > TMask > TMaskWindows About naming: We have MatchesWindowsMask(List), but TMaskWindows. That's not very logical or consistent. Either we should rename TMaskWindows to TWindowsMask, or fase out MatchesWindowsMask(List) in favour of

Re: [Lazarus] New TMaskList [forked from: TMask revisited]

2021-10-26 Thread Bart via lazarus
On Tue, Oct 26, 2021 at 9:15 PM Juha Manninen via lazarus wrote: > Yes, sounds OK, I'll have a go at it then > but it cannot cover CreateSysNative which is now used in procedure > TFileSearcher.Search. > The IFDEF can be placed there directly of course. Probably better. -- Bart -- _

Re: [Lazarus] New TMaskList [forked from: TMask revisited]

2021-10-26 Thread Juha Manninen via lazarus
On Tue, Oct 26, 2021 at 8:24 PM Bart via lazarus < lazarus@lists.lazarus-ide.org> wrote: > However, now that we have a dedicated TMaskWindows, wouldn't it also > make more sense to have a TMaskListWindows class? > > The TMaskList constructors > constructor CreateWindows(const aValue: String; a

[Lazarus] New TMaskList [forked from: TMask revisited]

2021-10-26 Thread Bart via lazarus
Hi, So, now we have: TMask TMaskWindows TMaskList TMaskList also caters for the old TMask.MatchesWindowsMask. However, now that we have a dedicated TMaskWindows, wouldn't it also make more sense to have a TMaskListWindows class? The TMaskList constructors constructor CreateWindows(const aVa