kvm "--help" and "--version" are not implemented, so remove them to
avoid ambiguous.
Signed-off-by: walimis
---
tools/kvm/builtin-help.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/kvm/builtin-help.c b/tools/kvm/builtin-help.c
index e89
kvm "--help" and "--version" are not implemented, so remove them to
avoid ambiguous.
Signed-off-by: Liming Wang
---
tools/kvm/builtin-help.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/kvm/builtin-help.c b/tools/kvm/builtin-help.c
index e89cd5c..e70044a 100644
doesn't prompt anything.
BTW, do you always login as "root" user?
walimis
>
>> ---
>> 爐ools/kvm/kvm-cmd.c | ? 11 ++-
>> ?1 files changed, 10 insertions(+), 1 deletions(-)
>>
>> diff --git a/tools/kvm/kvm-cmd.c b/tools/kvm/kvm-cm
On Wed, Aug 10, 2011 at 08:30:19AM +0300, Pekka Enberg wrote:
>On 8/10/11 8:03 AM, walimis wrote:
>>On Wed, Aug 10, 2011 at 08:02:01AM +0300, Pekka Enberg wrote:
>>>On Wed, Aug 10, 2011 at 5:44 AM, Liming Wang wrote:
>>>>handle failure of calling command fun
On Wed, Aug 10, 2011 at 08:53:53AM +0300, Pekka Enberg wrote:
>On Wed, Aug 10, 2011 at 8:33 AM, walimis wrote:
>>>>Yes. Because I'm using ubuntu and if I don't use sudo to execute
>>>>"kvm pause", pause command can't work and doesn't prom
On Wed, Aug 10, 2011 at 09:35:12AM +0300, Pekka Enberg wrote:
>On Wed, Aug 10, 2011 at 9:12 AM, walimis wrote:
>> On Wed, Aug 10, 2011 at 08:53:53AM +0300, Pekka Enberg wrote:
>>>On Wed, Aug 10, 2011 at 8:33 AM, walimis wrote:
>>>>>>Yes. Because I'
t;
>>>>> @@ -57,8 +58,10 @@ int term_putc(int who, char *addr, int cnt)
>>>>> if (who != active_console)
>>>>> return -1;
>>>>>
>>>>> -while (cnt--)
>>>>> -fprintf(stdout, "%c
>>to print and by printing it we wrote junk to the users terminal.
>>
>>Signed-off-by: Sasha Levin
>
>This doesn't seem to work for me. As soon as we switch to userspace,
>I don't get any output from serial console.
It works for me.
walimis
>
>>--
:/sbin/getty -L ttyS0 9600 vt100
>>
>> in guest's /etc/inittab.
>
>No I didn't but that's not really a solution to the problem. We can't
>expect people to configure guest userspace for something as basic as
>console.
My suggestion is that we don't need t
dev.config.num_pages -= 256;
>> +if ((s32)bdev.config.num_pages < 0){
>
>imo it's worth doing this check before the decrement instead of casting
>to signed here.
You mean that check whether num_pages less than 256 or equal to 0?
>
>you also need to wrap the 'if
> +/* signal placeholder if not enable balloon */
>> +signal(SIGKVMADDMEM, handle_empty);
>
>You can just do this:
> signal(SIGKVMADDMEM, SIG_IGN);
>
>For both, and avoid the empty handler.
good. New patch will be sent.
walimis
>
>> +signal(SIGKVM
;+ if (!(dev->mcr & (UART_MCR_LOOP | UART_MCR_OUT2)))
I assume it was your mistake to include this part?
walimis
> term_putc(CONSOLE_8250, addr, size * count);
>
> dev->iir= UART_IIR_NO_INT;
>
>+ int i;
>+
>+ for (i = 0; i < KVM_NR_CPUS; i++)
>+ if (kvm_cpus[i])
>+ pthread_kill(kvm_cpus[i]->thread, SIGKVMEXIT);
if so, can we remove "pthread_kill(pthread_self(), SIGKVMEXIT)" from
kvm_cpu_signal_handler?
t;
>I'll fix it up myself. You can use the scripts/checkpatch script to
>check for this kind of trivial coding style issues before sending a
>patch out.
OK, I will take note next time.
walimis
>
>> bdev.config.num_pages -= 256;
>>+ }
>>
>>
blem for you?
>
>Yup. But gpm still can not work, it complains can not open /dev/psaux.
Do you enable mouse/ps2 option in the kernel?
walimis
>
>
>--
>Best Regards,
>Asias He
>--
>To unsubscribe from this list: send the line "unsubscribe kvm" in
>the body of
u want to compare it to yours or try it out.
>
>Tried it with your config, it works fine here.
So the issue seems to be the rootfs?
walimis
>
>Strange...
>
>--
>
>Sasha.
>
>--
>To unsubscribe from this list: send the line "unsubscribe kvm" in
>the bod
;,kvm_cmd_version,NULL, 0 },
>+ { "--version", kvm_cmd_version,NULL, 0 },
Although it works, I think it's not good way to implement a option
as a command.
walimis
> { "stop", kvm_cmd_stop,
On Fri, Aug 12, 2011 at 06:39:46PM +0300, Pekka Enberg wrote:
>On Fri, 12 Aug 2011, walimis wrote:
>>>@@ -24,6 +24,7 @@ struct cmd_struct kvm_commands[] = {
>>> { "balloon",kvm_cmd_balloon,NULL, 0 },
>>> { "list&qu
On Fri, Aug 12, 2011 at 06:47:19PM +0300, Sasha Levin wrote:
>On Fri, 2011-08-12 at 23:22 +0800, walimis wrote:
>> On Fri, Aug 12, 2011 at 06:20:54PM +0300, Sasha Levin wrote:
>> >Signed-off-by: Sasha Levin
>> >---
>> > tools/kvm/kvm-cmd.c |1 +
>
quot;);
>+ break;
>+ case VIRTIO_BALLOON_S_MAJFLT:
>+ printf("The number of major page faults that have
>occurred:");
>+ break;
>+ case VIRTIO_BALLOON_S_MINFLT:
>+
l.\n", name);
>>+ return kill(pid, SIGKVMMEMSTAT);
>>+}
>
>I applied the patch but I think we should come up with a mechanism to
>transport the output back to the command. Doing the printout in the
netlink or unix socket?
walimis
>guest terminal isn't going to work in
ld also be removed (unless we fix the
>kernel to support them :) ).
>
>IMO this can go either way, theres no reason to keep support for
>multiple devices besides making development a bit easier.
OK, as you said, we can keep it for development.
walimis
--
To unsubscribe from this list: se
22 matches
Mail list logo
