Hi,
My colleague happened to find that when installing a Guest,
we cannot access to it by VNC because of the missing
parameter "--vnclisten=0.0.0.0" in virt-install.
Here is the patch, please comment! :)
Signed-off-by: Gu Yanhua
---
client/virt/libvirt_vm.py |8
1 files changed
6 PM, Lucas Meneghel Rodrigues wrote:
> On 12/30/2011 03:26 AM, tangchen wrote:
>> Hi,
>>
>> My colleague happened to find that when installing a Guest,
>> we cannot access to it by VNC because of the missing
>> parameter "--vnclisten=0.0.0.0" in virt-install.
hi~
I noticed that there is no configuration for RHEL6.2 in
/client/virt/guest-os.cfg.sample.
Here is the patch.
Please comment!:)
Signed-off-by: tangchen
---
client/virt/guest-os.cfg.sample | 36
1 files changed, 36 insertions(+), 0 deletions(-)
diff
utils.run()'s parameter "ignore_status" is set to "True" in virsh_cmd().
In this case we are not able to know whether the command succeeds.
This patch sets it to "False", and utils.run() will throw an exception
when command fails.
Signed-off-by: Tang Chen
---
client/virt/libvirt_vm.py |2
Hi~
1. There is no muigrate() function in class VM in libvirt_vm.py.
2. There is no tests for libvirt in client/tests/libvirt.
So, I would like to add some tests for libvirt.
Here are three patches,
1. Add a migrate() function for class VM in libvirt_vm.py, which
encapsulates "virsh migrat
This adds configuration for "virsh migrate" test.
Signed-off-by: Tang Chen
---
client/virt/subtests.cfg.sample | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/client/virt/subtests.cfg.sample b/client/virt/subtests.cfg.sample
index 843de30..97e62e9 100644
--
This patch adds a migrate() function for libvirt, which is a encapsulation for
"virsh migrate" command.
Signed-off-by: Tang Chen
---
client/virt/libvirt_vm.py | 212 +
1 files changed, 212 insertions(+), 0 deletions(-)
diff --git a/client/virt/libv
This patch tests the "virsh migrate" command with --live parameter.
Signed-off-by: Tang Chen
---
client/tests/libvirt/tests/virsh_migrate.py | 33 +++
1 files changed, 33 insertions(+), 0 deletions(-)
create mode 100644 client/tests/libvirt/tests/virsh_migrate.py
dif
Hi,
Thanks, Lucas.
I have tested the patch you re-sent and it works well :)
Cheers!
On 12/22/2010 03:43 AM, Lucas Meneghel Rodrigues wrote:
I happen to see that the "qemu-img commit" subcommand test in
qemu_img.py is empty, and it is "pass" by default.
I'm not very sure why it has not been imp
On 07/26/2014 04:44 AM, Jan Kiszka wrote:
On 2014-07-23 21:42, Tang Chen wrote:
This patch only handle "L1 and L2 vm share one apic access page" situation.
When L1 vm is running, if the shared apic access page is migrated, mmu_notifier
will
request all vcpus to exit to L0, and reload apic acc
Hi Gleb,
Would you please help to review these patches ?
Thanks.
On 08/27/2014 06:17 PM, Tang Chen wrote:
ept identity pagetable and apic access page in kvm are pinned in memory.
As a result, they cannot be migrated/hot-removed.
But actually they don't need to be pinned in memory.
[For ept i
Hi Gleb,
On 09/03/2014 12:00 AM, Gleb Natapov wrote:
..
+static void vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
+{
+ /*
+* apic access page could be migrated. When the page is being migrated,
+* GUP will wait till the migrate entry is replaced with the new pte
Hi Gleb,
By the way, when testing nested vm, I started L1 and L2 vm with
-cpu XXX, -x2apic
But with or with out this patch 5/6, when migrating apic access page,
the nested vm didn't corrupt.
We cannot migrate L2 vm because it pinned some other pages in memory.
Without this patch, if we
Hi Gleb,
On 09/03/2014 11:04 PM, Gleb Natapov wrote:
On Wed, Sep 03, 2014 at 09:42:30AM +0800, tangchen wrote:
Hi Gleb,
On 09/03/2014 12:00 AM, Gleb Natapov wrote:
..
+static void vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
+{
+ /*
+* apic access page could be
On 09/11/2014 05:33 PM, Paolo Bonzini wrote:
This patch is not against the latest KVM tree. The call to
nested_get_page is now in nested_get_vmcs12_pages, and you have to
handle virtual_apic_page in a similar manner.
Hi Paolo,
Thanks for the reviewing.
This patch-set is against Linux v3.17-r
On 09/11/2014 05:21 PM, Paolo Bonzini wrote:
Il 11/09/2014 07:38, Tang Chen ha scritto:
apic access page is pinned in memory. As a result, it cannot be
migrated/hot-removed.
Actually, it is not necessary to be pinned.
The hpa of apic access page is stored in VMCS APIC_ACCESS_ADDR pointer. Whe
On 09/11/2014 05:17 PM, Paolo Bonzini wrote:
..
@@ -7645,7 +7642,7 @@ static struct kvm_vcpu *vmx_create_vcpu(struct kvm *kvm,
unsigned int id)
kvm->arch.ept_identity_map_addr =
VMX_EPT_IDENTITY_PAGETABLE_ADDR;
err = -E
Hi Gleb, Paolo,
On 09/11/2014 10:47 PM, Gleb Natapov wrote:
On Thu, Sep 11, 2014 at 04:37:39PM +0200, Paolo Bonzini wrote:
Il 11/09/2014 16:31, Gleb Natapov ha scritto:
What if the page being swapped out is L1's APIC access page? We don't
run prepare_vmcs12 in that case because it's an L2->L0
Hi Paolo,
On 09/11/2014 10:24 PM, Paolo Bonzini wrote:
Il 11/09/2014 16:21, Gleb Natapov ha scritto:
As far as I can tell the if that is needed there is:
if (!is_guest_mode() || !(vmcs12->secondary_vm_exec_control &
ECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES))
write(PIC_ACCESS_ADDR)
In othe
19 matches
Mail list logo