Re: [Qemu-devel] [RFC v3 31/56] ac97: convert to memory API

2011-07-10 Thread malc
On Sun, 10 Jul 2011, Avi Kivity wrote: > fixes BAR sizing as well. I find this patch disgusting, the read and write handlers in particular. [..snip..] -- mailto:av1...@comtv.ru -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.o

Re: [Qemu-devel] [RFC v3 31/56] ac97: convert to memory API

2011-07-11 Thread malc
On Mon, 11 Jul 2011, Avi Kivity wrote: > On 07/11/2011 04:42 AM, Anthony Liguori wrote: > > On 07/10/2011 03:33 PM, malc wrote: > > > On Sun, 10 Jul 2011, Avi Kivity wrote: > > > > > > > fixes BAR sizing as well. > > > > > > I f

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Alexander Graf wrote: > > On 25.07.2011, at 12:09, Avi Kivity wrote: > > > On 07/25/2011 01:04 PM, Alexander Graf wrote: > >> On 25.07.2011, at 12:02, Avi Kivity wrote: > >> > >> > On 07/25/2011 12:56 PM, Alexander Graf wrote: > >> >> > > >> >> > That argument can be u

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Anthony Liguori wrote: > On 07/25/2011 09:30 AM, Max Filippov wrote: > > > > > > > > qemu_malloc() is type-unsafe as it returns a void pointer. > > > > > > > > Introduce > > > > > > > > QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. > > > > > > > > > > > > > > J

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Avi Kivity wrote: > On 07/25/2011 05:47 PM, malc wrote: > > Right right.. only g_new aborts on zero.. > > > > "If n_structs is 0 it returns NULL > <http://developer.gnome.org/glib/2.28/glib-Standard-Macros.html#NULL:CAPS>. " Right yo

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Avi Kivity wrote: > As with the rest of the memory API, the caller associates an eventfd > with an address, and the memory API takes care of registering or > unregistering when the address is made visible or invisible to the > guest. > > Signed-off-by: Avi Kivity [..snip..]

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Avi Kivity wrote: > On 07/25/2011 06:16 PM, malc wrote: > > On Mon, 25 Jul 2011, Avi Kivity wrote: > > > > > As with the rest of the memory API, the caller associates an eventfd > > > with an address, and the memory API takes care of re

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Avi Kivity wrote: > On 07/25/2011 06:22 PM, malc wrote: > > > > > +} > > > > > +if (a.fd< b.fd) { > > > > > +return true; > > > > > +} else { > >

Re: [Qemu-devel] [PATCH] memory: use signed arithmetic

2011-08-02 Thread malc
On Tue, 2 Aug 2011, Avi Kivity wrote: > When trying to map an alias of a ram region, where the alias starts at > address A and we map it into address B, and A > B, we had an arithmetic > underflow. Because we use unsigned arithmetic, the underflow converted > into a large number which failed addr

Re: [Qemu-devel] [PATCH v3 14/39] ac97: convert to memory API

2011-08-05 Thread malc
On Fri, 5 Aug 2011, Anthony Liguori wrote: > On 08/04/2011 08:06 AM, Avi Kivity wrote: > > fixes BAR sizing as well. > > > > Reviewed-by: Richard Henderson > > Signed-off-by: Avi Kivity > > Reviewed-by: Anthony Liguori > > Malc, please Ack > Ok, ple

Re: [Qemu-devel] [PATCH v4 14/39] ac97: convert to memory API

2011-08-09 Thread malc
On Mon, 8 Aug 2011, Avi Kivity wrote: > fixes BAR sizing as well. I'm fine with this version, thanks. [..snip..] -- mailto:av1...@comtv.ru -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [Qemu-devel] [PATCH v4 17/39] es1370: convert to memory API

2011-08-09 Thread malc
On Mon, 8 Aug 2011, Avi Kivity wrote: Fine with this too, thanks. [..snip..] -- mailto:av1...@comtv.ru -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types

2011-08-09 Thread malc
On Mon, 8 Aug 2011, Peter Maydell wrote: > On 8 August 2011 13:56, Avi Kivity wrote: > > QEMU deals with a lot of fixed width integer types; their names > > (uint64_t etc) are clumsy to use and take up a lot of space. > > > > Following Linux, introduce shorter names, for example U64 for > > uint6

Re: qemu-kvm 1.1.1 hangs using 100% CPU when using ES1370 emulation

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Michael Tokarev wrote: > Hello Mike, Vassili. > > On 23.08.2012 20:16, Mike Gerber wrote: > > Hi, > > > > I'm using a KVM guest to stream audio using darkice to an icecast2 server > > on the > > same guest. The guest uses an emulated ES1370 sound card to capture the > > ho

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 07:40:56PM +, Blue Swirl wrote: > > On Mon, Aug 27, 2012 at 7:24 PM, Michael S. Tsirkin wrote: > > > On Mon, Aug 27, 2012 at 07:12:27PM +, Blue Swirl wrote: > > >> On Mon, Aug 27, 2012 at 7:06 PM, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Anthony Liguori wrote: > Blue Swirl writes: > > > On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: > >> On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: > >>> On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > >>> > On 27.08.2012 22:56, Blue Swi

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-18 Thread malc
On Tue, 18 Oct 2011, Michael S. Tsirkin wrote: > On Tue, Oct 18, 2011 at 02:23:29PM +0200, Jan Kiszka wrote: > > On 2011-10-18 14:05, Michael S. Tsirkin wrote: > > > On Mon, Oct 17, 2011 at 09:15:47PM +0200, Jan Kiszka wrote: > > >> On 2011-10-17 15:43, Michael S. Tsirkin wrote: > > >>> On Mon, Oc

Re: [PATCH 00/13] AMD IOMMU emulation patchset

2011-01-29 Thread malc
On Sat, 29 Jan 2011, Eduard - Gabriel Munteanu wrote: > Hi everybody, > > I'm a bit late, I know, school kept me busy. > > But here it is. I hope I answered your previous concerns in this patchset. Let > me know what you think, I hope this gets merged soon. Some testing would be > great. > > Th

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread malc
On Mon, 5 Mar 2012, Blue Swirl wrote: > On Mon, Mar 5, 2012 at 15:17, Avi Kivity wrote: > > On 03/05/2012 05:15 PM, Anthony Liguori wrote: > >>> The other alternative is to s/target_phys_addr_t/uint64_t/ in the memory > >>> API.  I think 32-on-32 is quite rare these days, so it wouldn't be much >

Re: KVM: High CPU load with audio enabled

2010-11-09 Thread malc
problems? > > > > Yes, sound in 0.13 appears to be broken. It is looping in > > select/read loop forever, read returns EAGAIN and select > > says the filedescriptor is ready. > > Try to set QEMU_AUDIO_DAC_TRY_POLL=0 for the environment of the qemu > process

Re: assigned EHCI USB headset not working

2011-06-09 Thread malc
On Thu, 9 Jun 2011, Jan Kiszka wrote: > On 2011-06-09 17:13, malc wrote: > > On Thu, 9 Jun 2011, Jan Kiszka wrote: > > [..snip..] > > Sound output over (at least) ALSA is not smoothly working in polled > mode. It's similar to [1], which is yet uns

Re: assigned EHCI USB headset not working

2011-06-09 Thread malc
e invoking qemu helps? It > >> depends on your host-side interface. Using ALSA here, it is generally > >> required. > >> > >> Note that this discussion rather belongs on qemu-devel. > > > > Thank you very much. Setting the variable did the trick. > &g

Re: [Qemu-devel] [PATCH 2/3] kvm-userspace: kvmppc: fix hostlonbits detection when cross compiling v2

2008-09-30 Thread malc
On Tue, 30 Sep 2008, [EMAIL PROTECTED] wrote: From: Christian Ehrhardt <[EMAIL PROTECTED]> *update* further debugging according to some requests revealed that ARCH_CFLAGS does not contain all CFLAGS that might be needed, especially those supplied via extra-cflags. Therefore people supplying thi

Re: [Qemu-devel] [PATCH 2/3] kvm-userspace: kvmppc: fix hostlonbits detection when cross compiling v2

2008-09-30 Thread malc
On Tue, 30 Sep 2008, [EMAIL PROTECTED] wrote: From: Christian Ehrhardt <[EMAIL PROTECTED]> The commit message of r5364, the revision which basically exists because of your posts, was somehow butchered and as such doesn't include any references, i'm very sorry about that. The above line was th

Re: [Qemu-devel] Re: Question about KVM and PC speaker

2009-05-12 Thread malc
On Wed, 13 May 2009, Sebastian Herbszt wrote: > Jan Kiszka wrote: > > Sebastian Herbszt wrote: > > > With the modified vgabios (see below) it does beep on bochs on vista, > > > but not on qemu. > > > > Works fine for me! > > > > Did you check twice that your modified vgabios is actually loaded b

Re: [Qemu-devel] Re: Question about KVM and PC speaker

2009-05-14 Thread malc
On Thu, 14 May 2009, Sebastian Herbszt wrote: > malc wrote: > > On Wed, 13 May 2009, Sebastian Herbszt wrote: > > > > > Jan Kiszka wrote: > > > > Moreover, does sound work at all with your qemu? > > > > The image I tried [1] issues two beeps after

Re: [Qemu-devel] [PATCH] Inter-VM shared memory PCI device

2010-03-11 Thread malc
On Thu, 11 Mar 2010, Nick Piggin wrote: > On Thu, Mar 11, 2010 at 03:10:47AM +, Jamie Lokier wrote: > > Paul Brook wrote: > > > > > In a cross environment that becomes extremely hairy. For example the > > > > > x86 > > > > > architecture effectively has an implicit write barrier before every

Re: [Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-28 Thread malc
On Sun, 28 Mar 2010, Jamie Lokier wrote: > Avi Kivity wrote: > > ioctls encode the buffer size into the ioctl number, so in theory strace > > doesn't need to be taught about an ioctl to show its buffer. > > Unfortunately ioctl numbers don't always follow that rule :-( It's not a rule to begin w

Re: [PATCH] [RFC] Add support for a USB audio device model

2010-09-10 Thread malc
On Fri, 10 Sep 2010, H. Peter Anvin wrote: > I discovered that none of the audio device models supported by current > Qemu/KVM appear to be supported out of the box on Win7 64 bit (AC97 > works fine on 32 bit). The most logical ways to fix that would be to > add a long-term supportable audio devi

Re: [Qemu-devel] Re: [PATCH] [RFC] Add support for a USB audio device model

2010-09-11 Thread malc
On Fri, 10 Sep 2010, H. Peter Anvin wrote: > On 09/10/2010 07:47 PM, H. Peter Anvin wrote: > > On 09/10/2010 06:08 PM, H. Peter Anvin wrote: > >> > >> Any remotely recent stock distro should have support for it. I say > >> "should", because I haven't actually tested it with a Linux guest yet. > >

Re: [Qemu-devel] [RFC PATCH 1/7] Generic IOMMU layer

2010-07-14 Thread malc
On Wed, 14 Jul 2010, Eduard - Gabriel Munteanu wrote: > This provides an API for abstracting IOMMU functions. Hardware emulation > code can use it to request address translation and access checking. In > the absence of an emulated IOMMU, no translation/checking happens and > I/O goes through as be

Re: [Qemu-devel] [RFC PATCH 7/7] ac97: IOMMU support

2010-07-14 Thread malc
On Wed, 14 Jul 2010, Eduard - Gabriel Munteanu wrote: > Memory accesses must go through the IOMMU layer. > > Signed-off-by: Eduard - Gabriel Munteanu > --- > hw/ac97.c | 20 +--- > 1 files changed, 17 insertions(+), 3 deletions(-) Fine with me. [..snip..] -- mailto:av1...@

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-08-02 Thread malc
On Mon, 2 Aug 2010, Christian Brunner wrote: > After the release of ceph 0.21 I felt it was about time to re-submit > the qemu block driver for ceph: > > This is an updated block driver for the distributed file system Ceph > (http://ceph.newdream.net/). This driver uses librados (which > is part

Re: [Qemu-devel] [PATCH 7/7] ac97: use the PCI memory access interface

2010-08-15 Thread malc
On Sun, 15 Aug 2010, Eduard - Gabriel Munteanu wrote: > This allows the device to work properly with an emulated IOMMU. Fine with me. [..snip..] -- mailto:av1...@comtv.ru -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org Mor

Re: [Qemu-devel] [PATCH v2 6/8] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti

2009-02-03 Thread malc
On Tue, 3 Feb 2009, Anthony Liguori wrote: > Blue Swirl wrote: > > On 2/3/09, Alex Williamson wrote: > > > > > Make use of the new RX_MODE control virtqueue class by dropping > > > packets the guest doesn't want to see. > > > > > > Signed-off-by: Alex Williamson > > > > > > > > >

Re: [Qemu-devel] Re: [PATCH v2 4/8] qemu:virtio-net: Add a virtqueue for control commands from the guest

2009-02-04 Thread malc
On Wed, 4 Feb 2009, Alex Williamson wrote: [..snip..] > > +static void virtio_net_handle_ctrl(VirtIODevice *vdev, VirtQueue *vq) > +{ > +struct virtio_net_ctrl_hdr ctrl; > +virtio_net_ctrl_ack status = VIRTIO_NET_ERR; > +VirtQueueElement elem; > + > +while (virtqueue_pop(vq, &el