Re: [PATCH 3/3] ARM: EXYNOS5250: Register architected timers

2013-03-14 Thread Sergei Shtylyov
Hello. On 14-03-2013 4:59, Alexander Graf wrote: When running on an exynos 5250 SoC, we don't initialize the architected timers. The chip however supports architected timers. When we don't initialize them, KVM will try to access them and run into NULL pointer dereferences attempting to do so

Re: [PATCH 05/18] KVM/MIPS32-VZ: VZ-ASE assembler wrapper functions to set GuestIDs

2013-05-19 Thread Sergei Shtylyov
Hello. On 19-05-2013 9:47, Sanjay Lal wrote: Signed-off-by: Sanjay Lal --- arch/mips/kvm/kvm_vz_locore.S | 74 +++ 1 file changed, 74 insertions(+) create mode 100644 arch/mips/kvm/kvm_vz_locore.S diff --git a/arch/mips/kvm/kvm_vz_locore.S b/arch

Re: [PATCH] vhost_net: clear msg.control for non-zerocopy case during tx

2013-06-05 Thread Sergei Shtylyov
Hello. On 05-06-2013 11:40, Jason Wang wrote: When we decide not use zero-copy, msg.control should be set to NULL otherwise macvtap/tap may set zerocopy callbacks which may decrease the kref of ubufs wrongly. Bug were introduced by commit cedb9bdce099206290a2bdd02ce47a7b253b6a84 (vhost-net:

Re: [PATCH] vhost_net: clear msg.control for non-zerocopy case during tx

2013-06-06 Thread Sergei Shtylyov
Hello. On 06/06/2013 07:27 AM, Jason Wang wrote: When we decide not use zero-copy, msg.control should be set to NULL otherwise macvtap/tap may set zerocopy callbacks which may decrease the kref of ubufs wrongly. Bug were introduced by commit cedb9bdce099206290a2bdd02ce47a7b253b6a84 (vhost-net:

Re: [PATCH] get 2% or more performance improved by reducing spin_lock race

2013-06-07 Thread Sergei Shtylyov
Hello. On 07-06-2013 11:31, Qinchuanyu wrote: the wake_up_process func is included by spin_lock/unlock in vhost_work_queue, but it could be done outside the spin_lock. I have test it with kernel 3.0.27 and guest suse11-sp2 using iperf, the num as below. orignal

Re: [PATCH 20/31] mips/kvm: Hook into TLB fault handlers.

2013-06-07 Thread Sergei Shtylyov
Hello. On 06/08/2013 03:03 AM, David Daney wrote: From: David Daney If the CPU is operating in guest mode when a TLB related excpetion occurs, give KVM a chance to do emulation. Signed-off-by: David Daney --- arch/mips/mm/fault.c | 8 arch/mips/mm/tlbex-fault.S | 6 ++

Re: [PATCH 03/31] mips/kvm: Fix 32-bitisms in kvm_locore.S

2013-06-14 Thread Sergei Shtylyov
Hello. On 14-06-2013 17:09, Ralf Baechle wrote: diff --git a/arch/mips/kvm/kvm_locore.S b/arch/mips/kvm/kvm_locore.S index dca2aa6..e86fa2a 100644 --- a/arch/mips/kvm/kvm_locore.S +++ b/arch/mips/kvm/kvm_locore.S @@ -310,7 +310,7 @@ NESTED (MIPSX(GuestException), CALLFRAME_SIZ, ra) LONG_S

Re: [PATCH net] vhost-net: fix use-after-free in vhost_net_flush

2013-06-20 Thread Sergei Shtylyov
Hello. On 20-06-2013 15:48, Michael S. Tsirkin wrote: vhost_net_ubuf_put_and_wait has a confusing name: it will actually also free it's argument. Thus since commit 1280c27f8e29acf4af2da914e80ec27c3dbd5c01 Please also specify that commit's summary line in parens. vhost_net_flush tries to

Re: [PATCH] ARM: KVM: Simplify tracepoint text

2013-08-10 Thread Sergei Shtylyov
Hello. On 08/09/2013 07:41 AM, Christoffer Dall wrote: The tracepoint for kvm_guest_fault was extremely long, make it a slightly bit shorter. Signed-off-by: Christoffer Dall --- arch/arm/kvm/trace.h |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/arm/

Re: [PATCH V2 4/6] vhost_net: determine whether or not to use zerocopy at one time

2013-08-30 Thread Sergei Shtylyov
Hello. On 08/30/2013 08:29 AM, Jason Wang wrote: Currently, even if the packet length is smaller than VHOST_GOODCOPY_LEN, if upend_idx != done_idx we still set zcopy_used to true and rollback this choice later. This could be avoided by determine zerocopy once by checking all conditions at one t

Re: [PATCH] vhost/scsi: use vmalloc for order-10 allocation

2013-09-17 Thread Sergei Shtylyov
Hello. On 09/17/2013 11:21 AM, Michael S. Tsirkin wrote: As vhost scsi device struct is large, if the device is created on a busy system, kzalloc() might fail, so this patch does a fallback to vzalloc(). As vmalloc() adds overhead on data-path, add __GFP_REPEAT to kzalloc() flags to do this

Re: [PATCH v7 28/46] vhost: make features 64 bit

2014-11-30 Thread Sergei Shtylyov
Hello. On 11/30/2014 6:11 PM, Michael S. Tsirkin wrote: We need to use bit 32 for virtio 1.0 Signed-off-by: Michael S. Tsirkin Reviewed-by: Jason Wang --- drivers/vhost/vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vhost.h b/drivers/vhos

Re: [PATCH 15/20] MIPS: If KVM is enabled then use the KVM specific routine to flush the TLBs on a ASID wrap

2012-11-01 Thread Sergei Shtylyov
Hello. On 31-10-2012 19:20, Sanjay Lal wrote: Signed-off-by: Sanjay Lal --- arch/mips/include/asm/mmu_context.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/mips/include/asm/mmu_context.h b/arch/mips/include/asm/mmu_context.h index 9b02cfb..9c7024c 100644 --- a/arch/mip

Re: [PATCH 14/20] MIPS: Use the UM bit instead of the CU0 enable bit in the status register to figure out the stack for saving regs.

2012-11-01 Thread Sergei Shtylyov
Hello. On 31-10-2012 19:20, Sanjay Lal wrote: Signed-off-by: Sanjay Lal --- arch/mips/include/asm/stackframe.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/mips/include/asm/stackframe.h b/arch/mips/include/asm/stackframe.h index cb41af5..59c9245 100644 -

Re: [PATCH 14/20] MIPS: Use the UM bit instead of the CU0 enable bit in the status register to figure out the stack for saving regs.

2012-11-01 Thread Sergei Shtylyov
On 31-10-2012 19:20, Sanjay Lal wrote: Signed-off-by: Sanjay Lal --- arch/mips/include/asm/stackframe.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/mips/include/asm/stackframe.h b/arch/mips/include/asm/stackframe.h index cb41af5..59c9245 100644 --- a/arc

Re: [PATCH v4 13/13] ARM: KVM: Add VGIC configuration option

2012-11-10 Thread Sergei Shtylyov
Hello. On 10-11-2012 19:45, Christoffer Dall wrote: From: Marc Zyngier It is now possible to select the VGIC configuration option. Signed-off-by: Marc Zyngier Signed-off-by: Christoffer Dall --- arch/arm/kvm/Kconfig |7 +++ 1 file changed, 7 insertions(+) diff --git a/arc

Re: [PATCH 11/11] kvm tools: Modify term_putc to write more than one char

2014-05-07 Thread Sergei Shtylyov
Hello. On 06-05-2014 19:51, Andreas Herrmann wrote: From: David Daney It is a performance enhancement. When running in a simulator, each system call to write a character takes a lot of time. Batching them up decreases the overhead (in the root kernel) of each virtio console write. Signe

Re: [PATCH v2 09/18] KVM/MIPS32: COP0 accesses profiling.

2012-11-22 Thread Sergei Shtylyov
Hello. On 22-11-2012 6:34, Sanjay Lal wrote: Signed-off-by: Sanjay Lal --- arch/mips/kvm/kvm_mips_stats.c | 81 ++ 1 file changed, 81 insertions(+) create mode 100644 arch/mips/kvm/kvm_mips_stats.c diff --git a/arch/mips/kvm/kvm_mips_stats.c b/ar

Re: [PATCH v5 12/12] ARM: KVM: Add VGIC configuration option

2013-01-09 Thread Sergei Shtylyov
Hello. On 08-01-2013 22:42, Christoffer Dall wrote: From: Marc Zyngier It is now possible to select the VGIC configuration option. Signed-off-by: Marc Zyngier Signed-off-by: Christoffer Dall --- arch/arm/kvm/Kconfig |8 1 file changed, 8 insertions(+) diff --git a/ar

Re: [PATCH 2/4] vhost: move features to core

2015-09-10 Thread Sergei Shtylyov
Hello. On 09/10/2015 10:23 AM, Michael S. Tsirkin wrote: virtio 1 and any layout are core features, move them there. This fixes vhost test. Signed-off-by: Michael S. Tsirkin [...] diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c index d9c501e..f2882ac 100644 --- a/drivers/vhost/tes

Re: [PATCH] vhost/net: length miscalculation

2015-01-07 Thread Sergei Shtylyov
Hello. On 01/07/2015 11:55 AM, Michael S. Tsirkin wrote: commit 8b38694a2dc8b18374310df50174f1e4376d6824 vhost/net: virtio 1.0 byte swap had this chunk: - heads[headcount - 1].len += datalen; + heads[headcount - 1].len = cpu_to_vhost32(vq, len - datalen); This adds datalen w