On 07/09/2012 12:13 AM, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Alexander Graf [mailto:ag...@suse.de]
>> Sent: Saturday, July 07, 2012 1:21 PM
>> To: Wood Scott-B07421
>> Cc: Bhushan Bharat-R65777; kvm-...@vger.kernel.org; kvm@vger.kernel.org;
>> Bhushan
>> Bharat
On 07/07/2012 02:50 AM, Alexander Graf wrote:
>
> On 07.07.2012, at 01:37, Scott Wood wrote:
>
>> On 07/06/2012 08:17 AM, Alexander Graf wrote:
>>> On 28.06.2012, at 08:17, Bharat Bhushan wrote:
>>>> +/*
>>>> + * The timer system can almost deal w
On 07/16/2012 12:18 PM, Alexander Graf wrote:
>> +/*
>> + * Return the number of jiffies until the next timeout. If the
> timeout is
>> + * longer than the NEXT_TIMER_MAX_DELTA, that
>
> then?
>
>> return NEXT_TIMER_MAX_DELTA
>> + * instead.
>
> I can read code.
Come on, it's not exactly x++;
On 07/17/2012 09:35 AM, Alexander Graf wrote:
> On 07/17/2012 04:13 PM, Bhushan Bharat-R65777 wrote:
>>
>>> -Original Message-
>>> From: kvm-ppc-ow...@vger.kernel.org
>>> [mailto:kvm-ppc-ow...@vger.kernel.org] On
>>> Behalf Of Alexander Graf
>>> Sent: Tuesday, July 17, 2012 7:31 PM
>>> To:
On 07/17/2012 06:31 AM, Bhushan Bharat-R65777 wrote:
int kvm_arch_vcpu_runnable(struct kvm_vcpu *v) {
-return !(v->arch.shared->msr & MSR_WE) ||
- !!(v->arch.pending_exceptions) ||
- v->requests;
+bool ret = !(v->arch.shared->msr & MSR_WE) ||
>
On 07/17/2012 11:56 AM, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Wood Scott-B07421
>> Sent: Tuesday, July 17, 2012 10:08 PM
>> To: Bhushan Bharat-R65777
>> Cc: Wood Scott-B07421; Alexander Graf; kvm-...@vger.kernel.org;
>> kvm@vger.kernel.org; bharatb.ya...@gmail.co
On 07/17/2012 12:10 PM, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Wood Scott-B07421
>> Sent: Tuesday, July 17, 2012 10:31 PM
>> To: Bhushan Bharat-R65777
>> Cc: Wood Scott-B07421; Alexander Graf; kvm-...@vger.kernel.org;
>> kvm@vger.kernel.org; bharatb.ya...@gmail.co
On 07/17/2012 11:51 AM, Alexander Graf wrote:
> On 07/17/2012 06:27 PM, Scott Wood wrote:
>> Determining whether we're on final expiration is based only on the
>> previous value of TSR[ENW,WIS] when the timer expires. We look at TCR
>> to determine whether we need to
r expiry, it exit to QEMU
> if TCR.WRC is non ZERO. QEMU can reset/shutdown etc depending upon how
> it is configured.
>
> Signed-off-by: Liu Yu
> Signed-off-by: Scott Wood
> Signed-off-by: Bharat Bhushan
Please put a note before your signoff stating that it's been modifie
CAP(KVM_CAP_PPC_WDT) ioctl.
>>> The kernel timer are used for watchdog emulation and emulates
>>> h/w watchdog state machine. On watchdog timer expiry, it exit to QEMU
>>> if TCR.WRC is non ZERO. QEMU can reset/shutdown etc depending upon how
>>> it is configured.
r expiry, it exit to QEMU
> if TCR.WRC is non ZERO. QEMU can reset/shutdown etc depending upon how
> it is configured.
>
> Signed-off-by: Liu Yu
> Signed-off-by: Scott Wood
> Signed-off-by: Bharat Bhushan
> [bharat.bhus...@freescale.com: reworked patch]
Typically the []
On 07/22/2012 11:10 PM, Bhushan Bharat-R65777 wrote:
>>> @@ -386,13 +387,23 @@ int kvm_arch_vcpu_init(struct kvm_vcpu *vcpu)
>>> #ifdef CONFIG_KVM_EXIT_TIMING
>>> mutex_init(&vcpu->arch.exit_timing_lock);
>>> #endif
>>> -
>>> +#ifdef CONFIG_BOOKE
>>> + spin_lock_init(&vcpu->arch.wdt_lock);
>
On 07/21/2012 03:37 AM, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Wood Scott-B07421
>> Sent: Saturday, July 21, 2012 2:59 AM
>> To: Bhushan Bharat-R65777
>> Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; ag...@suse.de; Bhushan
>> Bharat-
>> R65777
>> Subject: Re:
On 07/23/2012 06:19 AM, Bharat Bhushan wrote:
> IAC/DAC are defined as 32 bit while they are 64 bit wide. So ONE_REG
> interface is added to set/get them.
>
> Signed-off-by: Bharat Bhushan
> ---
> v2:
> - Using copy_to/from_user() apis.
>
> arch/powerpc/include/asm/kvm.h | 12 ++
>
On 07/23/2012 10:43 AM, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Wood Scott-B07421
>> Sent: Monday, July 23, 2012 9:02 PM
>> To: Bhushan Bharat-R65777
>> Cc: Wood Scott-B07421; kvm-...@vger.kernel.org; kvm@vger.kernel.org;
>> ag...@suse.de
>> Subject: Re: [PATCH 2/2
On 07/23/2012 10:48 AM, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Wood Scott-B07421
>> Sent: Monday, July 23, 2012 9:12 PM
>> To: Bhushan Bharat-R65777
>> Cc: kvm-...@vger.kernel.org; ag...@suse.de; kvm@vger.kernel.org; Bhushan
>> Bharat-
>> R65777
>> Subject: Re: [
On 07/23/2012 11:04 AM, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Wood Scott-B07421
>> Sent: Monday, July 23, 2012 9:31 PM
>> To: Bhushan Bharat-R65777
>> Cc: Wood Scott-B07421; kvm-...@vger.kernel.org; kvm@vger.kernel.org;
>> ag...@suse.de
>> Subject: Re: [PATCH 2/2
On 07/24/2012 02:45 AM, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Wood Scott-B07421
>> Sent: Monday, July 23, 2012 10:00 PM
>> To: Bhushan Bharat-R65777
>> Cc: Wood Scott-B07421; kvm-...@vger.kernel.org; kvm@vger.kernel.org;
>> ag...@suse.de
>> Subject: Re: [PATCH 2/
On 07/25/2012 03:37 PM, Marcelo Tosatti wrote:
> On Fri, Jul 20, 2012 at 04:29:08PM -0500, Scott Wood wrote:
>> On 07/20/2012 12:00 AM, Bharat Bhushan wrote:
>>> This patch adds the watchdog emulation in KVM. The watchdog
>>> emulation is enabled by KVM_ENABLE_CAP(KVM_
On 07/26/2012 12:32 AM, Bharat Bhushan wrote:
> _GLOBAL(kvmppc_handlers_start)
> KVM_HANDLER BOOKE_INTERRUPT_CRITICAL SPRN_SPRG_RSCRATCH_CRIT SPRN_CSRR0
> KVM_HANDLER BOOKE_INTERRUPT_MACHINE_CHECK SPRN_SPRG_RSCRATCH_MC SPRN_MCSRR0
> @@ -94,6 +98,7 @@ KVM_HANDLER BOOKE_INTERRUPT_DEBUG SPRN_SPRG_
On 07/26/2012 12:32 AM, Bharat Bhushan wrote:
> This patch adds:
> 1) KVM debug handler added for e500v2.
> 2) Guest debug by qemu gdb stub.
Does it make sense for these to both be in the same patch? If there's
common code used by both, that could be added first.
> Signed-off-by: Liu Yu
> Sig
On 07/30/2012 02:37 AM, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Wood Scott-B07421
>> Sent: Friday, July 27, 2012 7:00 AM
>> To: Bhushan Bharat-R65777
>> Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; ag...@suse.de; Bhushan
>> Bharat-
>> R65777
>> Subject: Re: [
On 07/30/2012 06:11 AM, Bharat Bhushan wrote:
> +1: /* debug interrupt happened in guest */
> + mfspr r4, \scratch
> + mtcrr3
> + mr r3, r4
> + mfspr r4, SPRN_SPRG_THREAD
> + lwz r4, THREAD_KVM_VCPU(r4)
> + stw r3, VCPU_GPR(r4)(r4)
> + stw r5,
for watchdog emulation and emulates
>> h/w watchdog state machine. On watchdog timer expiry, it exit to QEMU
>> if TCR.WRC is non ZERO. QEMU can reset/shutdown etc depending upon how
>> it is configured.
>>
>> Signed-off-by: Liu Yu
>> Signed-off-by: Scott Wood
On 07/31/2012 06:59 PM, Alexander Graf wrote:
> Well, user space always comes in via the ioctl path, which in turn
> does vcpu_load(vcpu), thus should always be running as the vcpu
> context itself.
Right, it's the timers you're racing with.
> It boils down to the original thing I was saying back
On 08/01/2012 12:27 PM, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Alexander Graf [mailto:ag...@suse.de]
>> Sent: Wednesday, August 01, 2012 7:57 AM
>> To: Bhushan Bharat-R65777
>> Cc: qemu-...@nongnu.org List; kvm-...@vger.kernel.org; Bhushan Bharat-R65777;
>> qemu-d
On 08/02/2012 10:56 AM, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Wood Scott-B07421
>> Sent: Wednesday, August 01, 2012 11:31 PM
>> To: Bhushan Bharat-R65777
>> Cc: Alexander Graf; qemu-...@nongnu.org List; kvm-...@vger.kernel.org; qemu-
>> devel qemu-devel; KVM list
On 08/05/2012 04:00 AM, Avi Kivity wrote:
> On 08/04/2012 01:32 AM, Benjamin Herrenschmidt wrote:
>> On Fri, 2012-08-03 at 15:05 -0300, Marcelo Tosatti wrote:
>>
>>> See kvm_arch_process_async_events() call to qemu_system_reset_request()
>>> in target-i386/kvm.c.
>>>
>>> The whole thing is fragile,
On 08/07/2012 05:47 AM, Alexander Graf wrote:
>> diff --git a/arch/powerpc/kvm/booke_interrupts.S
>> b/arch/powerpc/kvm/booke_interrupts.S
>> index 3539805..890673c 100644
>> --- a/arch/powerpc/kvm/booke_interrupts.S
>> +++ b/arch/powerpc/kvm/booke_interrupts.S
>> @@ -73,6 +73,51 @@ _GLOBAL(kvmppc
On 08/07/2012 05:57 AM, Alexander Graf wrote:
> When we map a page that wasn't icache cleared before, do so when first
> mapping it in KVM using the same information bits as the Linux mapping
> logic. That way we are 100% sure that any page we map does not have stale
> entries in the icache.
>
> W
odule.
Reported-by: Geert Uytterhoeven
Signed-off-by: Scott Wood
---
Sending to Alex even though this isn't KVM-specific since the commit it
fixes is still only in his tree (and linux-next).
arch/powerpc/kernel/ppc_ksyms.c |5 +
1 file changed, 5 insertions(+)
diff --git a/ar
On 08/11/2012 08:07 AM, Tabi Timur-B04825 wrote:
> On Sat, Aug 11, 2012 at 2:01 AM, Geert Uytterhoeven
> wrote:
>> On Sat, Aug 11, 2012 at 12:21 AM, Scott Wood wrote:
>>> +EXPORT_SYMBOL(epapr_hypercall_start);
>>
>> EXPORT_SYMBOL_GPL?
>
> We prefer EXPORT
On 08/14/2012 06:04 PM, Alexander Graf wrote:
> From: Bharat Bhushan
>
> IAC/DAC are defined as 32 bit while they are 64 bit wide. So ONE_REG
> interface is added to set/get them.
>
> Signed-off-by: Bharat Bhushan
> Signed-off-by: Alexander Graf
> ---
> arch/powerpc/include/asm/kvm.h |
On 08/14/2012 06:47 PM, Alexander Graf wrote:
>
> On 15.08.2012, at 01:44, Scott Wood wrote:
>
>> On 08/14/2012 06:04 PM, Alexander Graf wrote:
>>> From: Bharat Bhushan
>>>
>>> IAC/DAC are defined as 32 bit while they are 64 bit wide. So ONE_
On 08/14/2012 06:04 PM, Alexander Graf wrote:
> We need a central place to check for pending requests in. Add one that
> only does the timer check we already do in a different place.
>
> Later, this central function can be extended by more checks.
>
> Signed-off-by: Alexander Graf
> ---
> arch/
On 08/14/2012 06:04 PM, Alexander Graf wrote:
> Generic KVM code might want to know whether we are inside guest context
> or outside. It also wants to be able to push us out of guest context.
>
> Add support to the BookE code for the generic vcpu->mode field that describes
> the above states.
>
>
On 08/14/2012 07:13 PM, Alexander Graf wrote:
>
> On 15.08.2012, at 02:10, Scott Wood wrote:
>
>> On 08/14/2012 06:04 PM, Alexander Graf wrote:
>>> We need a central place to check for pending requests in. Add one that
>>> only does the timer check w
On 08/14/2012 07:26 PM, Alexander Graf wrote:
>
> On 15.08.2012, at 02:17, Scott Wood wrote:
>
>> On 08/14/2012 06:04 PM, Alexander Graf wrote:
>>> Generic KVM code might want to know whether we are inside guest context
>>> or outside. It also wants to be abl
On 08/14/2012 06:04 PM, Alexander Graf wrote:
> The e500 target has lived without mmu notifiers ever since it got
> introduced, but fails for the user space check on them with hugetlbfs.
>
> So in order to get that one working, implement mmu notifiers in a
> reasonably dumb fashion and be happy. O
On 08/14/2012 06:04 PM, Alexander Graf wrote:
> When we map a page that wasn't icache cleared before, do so when first
> mapping it in KVM using the same information bits as the Linux mapping
> logic. That way we are 100% sure that any page we map does not have stale
> entries in the icache.
We're
On 08/14/2012 06:04 PM, Alexander Graf wrote:
> + /* Going into guest context! Yay! */
> + vcpu->mode = IN_GUEST_MODE;
> + smp_wmb();
> +
> break;
> }
What is the wmb protecting against here?
-Scott
--
To unsubscribe from this list: send t
On 08/15/2012 04:52 AM, Alexander Graf wrote:
>
> On 15.08.2012, at 03:23, Scott Wood wrote:
>
>> On 08/14/2012 06:04 PM, Alexander Graf wrote:
>>> When we map a page that wasn't icache cleared before, do so when first
>>> mapping it in KVM using the same
On 08/15/2012 12:27 PM, Alexander Graf wrote:
>
> On 15.08.2012, at 19:26, Scott Wood wrote:
>
>> On 08/15/2012 04:52 AM, Alexander Graf wrote:
>>>
>>> On 15.08.2012, at 03:23, Scott Wood wrote:
>>>
>>>> On 08/14/2012 06:04 PM, Alexander G
On 08/15/2012 01:01 PM, Alexander Graf wrote:
>
> On 15.08.2012, at 19:47, Scott Wood wrote:
>
>> On 08/15/2012 12:27 PM, Alexander Graf wrote:
>>>
>>> On 15.08.2012, at 19:26, Scott Wood wrote:
>>>
>>>> On 08/15/2012 04:52 AM, Alexander
On 08/15/2012 01:29 PM, Alexander Graf wrote:
>
> On 15.08.2012, at 20:27, Alexander Graf wrote:
>
>>
>> On 15.08.2012, at 20:16, Scott Wood wrote:
>>
>>> On 08/15/2012 01:01 PM, Alexander Graf wrote:
>>>>
>>>> On 15.08.2012, a
On 08/15/2012 01:51 PM, Alexander Graf wrote:
>
> On 15.08.2012, at 20:33, Scott Wood wrote:
>
>> On 08/15/2012 01:29 PM, Alexander Graf wrote:
>>>
>>> On 15.08.2012, at 20:27, Alexander Graf wrote:
>>>
>>>>
>>>> On 15.08.2
On 08/15/2012 01:58 PM, Alexander Graf wrote:
>
> On 15.08.2012, at 20:56, Scott Wood wrote:
>
>> On 08/15/2012 01:51 PM, Alexander Graf wrote:
>>>
>>> On 15.08.2012, at 20:33, Scott Wood wrote:
>>>
>>>> On 08/15/2012 01:29 PM, Alexander Graf
On 08/15/2012 02:29 PM, Alexander Graf wrote:
>
> On 15.08.2012, at 21:05, Scott Wood wrote:
>
>> On 08/15/2012 01:58 PM, Alexander Graf wrote:
>>>
>>> On 15.08.2012, at 20:56, Scott Wood wrote:
>>>
>>>> On 08/15/2012 01:51 PM, Alexander
On 08/16/2012 03:48 AM, Bhushan Bharat-R65777 wrote:
> diff --git a/arch/powerpc/include/asm/kvm.h
> b/arch/powerpc/include/asm/kvm.h index 3c14202..da71c84 100644
> --- a/arch/powerpc/include/asm/kvm.h
> +++ b/arch/powerpc/include/asm/kvm.h
> @@ -25,6 +25,7 @@
> /* Select
On 08/16/2012 10:12 AM, Bhushan Bharat-R65777 wrote:
>
>
>> -Original Message-
>> From: Wood Scott-B07421
>> Sent: Tuesday, July 31, 2012 3:31 AM
>> To: Bhushan Bharat-R65777
>> Cc: Wood Scott-B07421; kvm-...@vger.kernel.org; kvm@vger.kernel.org;
>> ag...@suse.de
>> Subject: Re: [PATCH 2/
On 08/15/2012 04:29 AM, Alexander Graf wrote:
>
> On 15.08.2012, at 03:17, Scott Wood wrote:
>
>> On 08/14/2012 07:26 PM, Alexander Graf wrote:
>>>
>>> On 15.08.2012, at 02:17, Scott Wood wrote:
>>>
>>>> On 08/14/2012 06:04 PM, Alexander
Avoid a race as described in the code comment.
Also remove a related smp_wmb() from booke's kvmppc_prepare_to_enter().
I can't see any reason for it, and the book3s_pr version doesn't have it.
Signed-off-by: Scott Wood
---
arch/powerpc/kvm/booke.c |1 -
arch/powerpc/kvm/p
We were only allocating half the bytes we need, which was made more
obvious by a recent fix to the memset in clear_tlb1_bitmap().
Signed-off-by: Scott Wood
---
arch/powerpc/kvm/e500_tlb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/e500_tlb.c b/arch
This was found by kmemleak.
Signed-off-by: Scott Wood
---
arch/powerpc/kvm/e500_tlb.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/kvm/e500_tlb.c b/arch/powerpc/kvm/e500_tlb.c
index a27d134..641f978 100644
--- a/arch/powerpc/kvm/e500_tlb.c
+++ b/arch/powerpc/kvm
On 08/29/2011 02:04 PM, Anthony Liguori wrote:
> On 08/29/2011 11:51 AM, Yoder Stuart-B08248 wrote:
>> Instead of config space fixed at 0xf, we would propose
>> a header and multiple 'device info' records at offset 0x0 that would
>> encode everything that user space needs to know about
>> the devic
On 08/29/2011 07:34 AM, Sasha Levin wrote:
> Cc: Avi Kivity
> Cc: Marcelo Tosatti
> Signed-off-by: Sasha Levin
> ---
> Documentation/virtual/kvm/api.txt | 27 +++
> 1 files changed, 27 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/virtual/kvm/api.txt
>
On 08/29/2011 02:51 PM, Alex Williamson wrote:
> On Mon, 2011-08-29 at 16:51 +, Yoder Stuart-B08248 wrote:
>> The device info records following the file header have the following
>> record types each with content encoded in a record specific way:
>>
>> REGION - describes an addressable addres
On 08/29/2011 05:46 PM, Alex Williamson wrote:
> On Mon, 2011-08-29 at 16:58 -0500, Scott Wood wrote:
>> On 08/29/2011 02:51 PM, Alex Williamson wrote:
>>> On Mon, 2011-08-29 at 16:51 +, Yoder Stuart-B08248 wrote:
>>>> The device info records following the
rate subrecord
because it is of variable length. Putting it at the end of DTINDEX
would inhibit DTINDEX's extensibility.
> On Mon, 2011-08-29 at 18:14 -0500, Scott Wood wrote:
>> On 08/29/2011 05:46 PM, Alex Williamson wrote:
>>> I could imagine a platform device described by ACPI
On 09/01/2011 03:00 PM, Michael S. Tsirkin wrote:
> That's a very rich interface, and easy to get wrong.
> AFAIK the only reason vfio uses read/write for PCI was to avoid inventing
> a custom interface. But if you do, it looks like a set of ioctls would
> be much easier? You can even fit the existi
Signed-off-by: Scott Wood
---
arch/powerpc/kvm/booke.c |4 ++--
arch/powerpc/kvm/e500.c |3 ---
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index ee45fa0..d967faf 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch
On 09/02/2011 10:57 AM, Michael S. Tsirkin wrote:
> On Thu, Sep 01, 2011 at 03:26:01PM -0500, Scott Wood wrote:
>> On 09/01/2011 03:00 PM, Michael S. Tsirkin wrote:
>>> That's a very rich interface, and easy to get wrong.
>>> AFAIK the only reason vfio uses
On 09/02/2011 10:12 AM, Alexander Graf wrote:
>
> Am 02.09.2011 um 01:08 schrieb Scott Wood :
>
>> Signed-off-by: Scott Wood
>
> Patch description missing.
It's not missing, it's just brief. :-)
I suppose you could add "The hardcoded behavior prevents
On 09/02/2011 02:23 PM, Alexander Graf wrote:
>
> On 02.09.2011, at 20:14, Scott Wood wrote:
>
>> On 09/02/2011 10:12 AM, Alexander Graf wrote:
>>>
>>> Am 02.09.2011 um 01:08 schrieb Scott Wood :
>>>
>>>> Signed-off-by: Scott Wood
>>&
The hardcoded behavior prevents proper SMP support.
QEMU shall specify the vcpu's PIR as the vcpu id.
Signed-off-by: Scott Wood
---
v2: More detailed commit message.
arch/powerpc/kvm/booke.c |4 ++--
arch/powerpc/kvm/e500.c |3 ---
2 files changed, 2 insertions(+), 5 dele
On 09/19/2011 10:16 AM, Alex Williamson wrote:
> On Fri, 2011-09-09 at 08:11 -0500, Stuart Yoder wrote:
>> 2. Header
>>
>> The header is located at offset 0x0 in the device fd
>> and has the following format:
>>
>> struct devfd_header {
>> __u32 magic;
>> __u32 version;
>>
On 09/19/2011 04:07 PM, Alex Williamson wrote:
> On Mon, 2011-09-19 at 14:37 -0500, Scott Wood wrote:
>>> A DTPATH as a record, an INTERRUPT as a sub-record, etc.
>>
>> Same as any other unrecognized (sub)record type, you ignore it -- but
>> the kernel should no
On 09/19/2011 06:35 PM, Alexander Graf wrote:
> + /*
> + * e500 doesn't implement the lowest tsize bit,
> + * or 1K pages.
> + */
> + tsize = max(BOOK3E_PAGESZ_4K, tsize & ~1);
> +
> +
On 09/24/2011 02:47 AM, Alexander Graf wrote:
>
> On 22.09.2011, at 08:50, Liu Yu-B13201 wrote:
>
>>
>>
>>> -Original Message-
>>> From: kvm-ppc-ow...@vger.kernel.org
>>> [mailto:kvm-ppc-ow...@vger.kernel.org] On Behalf Of Alexander Graf
>>> Sent: Tuesday, September 20, 2011 7:36 AM
>>>
On 09/24/2011 02:44 AM, Alexander Graf wrote:
> On 20.09.2011, at 19:54, Scott Wood wrote:
>> On 09/19/2011 06:35 PM, Alexander Graf wrote:
>>> + asm (PPC_CNTLZL "%0,%1" : "=r" (lz) : "r" (psize));
>>> +
On 09/26/2011 01:34 PM, Alex Williamson wrote:
> The other obvious possibility is a pure ioctl interface. To match what
> this proposal is trying to describe, plus the runtime interfaces, we'd
> need something like:
>
> /* :0 - PCI devices, :1 - Devices path device, 63:2 - reserved */
> #define V
On 09/26/2011 02:57 PM, Stuart Yoder wrote:
> On Mon, Sep 26, 2011 at 2:51 AM, David Gibson
>> Um, not to put too fine a point on it, this is madness.
>>
>> Yes, it's very flexible and can thereby cover a very wide range of
>> cases. But it's much, much too complex. Userspace has to parse a
>> co
On 09/26/2011 07:45 PM, Alex Williamson wrote:
> On Mon, 2011-09-26 at 18:59 -0500, Scott Wood wrote:
>> On 09/26/2011 01:34 PM, Alex Williamson wrote:
>>> /* Reset the device */
>>> #define VFIO_DEVICE_RESET _IO(, ,)
>>
>> What generi
On 09/28/2011 09:45 AM, Jan Kiszka wrote:
> On 2011-09-28 16:26, Alexander Graf wrote:
>>
>> On 28.09.2011, at 16:23, Jan Kiszka wrote:
>>
>>> Alex,
>>>
>>> we have this diff in qemu-kvm:
>>>
>>> diff --git a/exec.c b/exec.c
>>> index c1e045d..f188549 100644
>>> --- a/exec.c
>>> +++ b/exec.c
>>> @@
On 09/28/2011 04:02 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2011-09-28 at 12:27 -0500, Scott Wood wrote:
>
>> Why would it need to be synchronous? Even if it's asynchronous emulated
>> DMA, we don't want it sitting around only in a data cache that
>&g
tsize = min(__ilog2(psize) - 10, tsize);
Any reason for __ilog2() rather than ilog2()? Shouldn't make a
difference, just curious about avoiding the public interface.
Either way,
Acked-by: Scott Wood
-Scott
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/05/2011 01:55 PM, Alexander Graf wrote:
>
> On 05.10.2011, at 18:06, Scott Wood wrote:
>
>> Any reason for __ilog2() rather than ilog2()? Shouldn't make a
>> difference, just curious about avoiding the public interface.
>
> I grep'ed through the kerne
On 10/31/2011 07:50 AM, Avi Kivity wrote:
> On 10/31/2011 09:53 AM, Alexander Graf wrote:
>> +/* sesel is index into the set, not the whole array */
>> +static void write_stlbe(struct kvmppc_vcpu_e500 *vcpu_e500,
>> +struct tlbe *gtlbe,
>> +struct tlbe *stlbe
On 10/31/2011 08:24 AM, Avi Kivity wrote:
> On 10/31/2011 09:53 AM, Alexander Graf wrote:
>> From: Scott Wood
>>
>> This implements a shared-memory API for giving host userspace access to
>> the guest's TLB.
>>
>>
>> diff --git a/Documentation/v
On 11/01/2011 03:58 AM, Avi Kivity wrote:
> On 10/31/2011 10:12 PM, Scott Wood wrote:
>>>> +4.59 KVM_DIRTY_TLB
>>>> +
>>>> +Capability: KVM_CAP_SW_TLB
>>>> +Architectures: ppc
>>>> +Type: vcpu ioctl
>>>> +Par
Currently we check prior to returning from a lightweight exit,
but not prior to initial entry.
book3s already does a similar test.
Signed-off-by: Scott Wood
---
arch/powerpc/kvm/booke.c | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/kvm/booke.c b
hen I sent that...)
This supersedes the first three patches of "KVM: PPC: booke: paravirt and
timer" from 8/26.
Scott Wood (6):
KVM: PPC: Rename deliver_interrupts to prepare_to_enter
KVM: PPC: Move prepare_to_enter call site into subarch code
KVM: PPC: booke: Check for MSR[WE] in prep
This function also updates paravirt int_pending, so rename it
to be more obvious that this is a collection of checks run prior
to (re)entering a guest.
Signed-off-by: Scott Wood
---
arch/powerpc/include/asm/kvm_ppc.h |2 +-
arch/powerpc/kvm/book3s.c |2 +-
arch/powerpc/kvm
this sort (plus it has several additional call sites), so
I'm deferring the book3s fix to someone more familiar with that code.
book3s behavior should be unchanged by this patch.
Signed-off-by: Scott Wood
---
arch/powerpc/kvm/book3s_hv.c |2 ++
arch/powerpc/kvm/book3s_pr.c |2 ++
a
Also fix wrteei 1 paravirt to check for a pending interrupt.
Signed-off-by: Scott Wood
---
arch/powerpc/kernel/kvm.c | 92 +-
arch/powerpc/kernel/kvm_emul.S | 96 ++-
2 files changed, 154 insertions(+), 34
egs ioctls, but I do not see any
non-booke emulation. I also do not see any syncing with real registers
(in PR-mode) including the user-readable SPRG3. This patch should not
make that situation any worse.
Signed-off-by: Scott Wood
---
arch/powerpc/include/asm/kvm_e500.h |8 --
arch/powerpc/i
This prevents us from inappropriately blocking in a KVM_SET_REGS
ioctl -- the MSR[WE] will take effect when the guest is next entered.
It also causes SRR1[WE] to be set when we enter the guest's interrupt
handler, which is what e500 hardware is documented to do.
Signed-off-by: Scott
int_pending was only being lowered if a bit in pending_exceptions
was cleared during exception delivery -- but for interrupts, we clear
it during IACK/TSR emulation. This caused paravirt for enabling
MSR[EE] to be ineffective.
Signed-off-by: Scott Wood
---
arch/powerpc/kvm/booke.c |6
On Fri, Nov 11, 2011 at 03:09:17PM +0100, Alexander Graf wrote:
> On 11/08/2011 11:11 PM, Scott Wood wrote:
> >Currently we check prior to returning from a lightweight exit,
> >but not prior to initial entry.
> >
> >book3s already does a similar test.
>
On 11/11/2011 09:35 AM, Alexander Graf wrote:
> On 11/11/2011 04:32 PM, Scott Wood wrote:
>> On Fri, Nov 11, 2011 at 03:09:17PM +0100, Alexander Graf wrote:
>>> On 11/08/2011 11:11 PM, Scott Wood wrote:
>>>> Currently we check prior to returning from a lightweig
On 11/03/2011 03:12 PM, Alex Williamson wrote:
> +Many modern system now provide DMA and interrupt remapping facilities
> +to help ensure I/O devices behave within the boundaries they've been
> +allotted. This includes x86 hardware with AMD-Vi and Intel VT-d as
> +well as POWER systems with Partit
On 11/14/2011 07:13 AM, Alexander Graf wrote:
> On 11/09/2011 01:23 AM, Scott Wood wrote:
>> +/* Check pending exceptions and deliver one, if possible. */
>> +void kvmppc_core_prepare_to_enter(struct kvm_vcpu *vcpu)
>> +{
>> +
On 11/14/2011 12:01 PM, Alexander Graf wrote:
>
> On 14.11.2011, at 18:22, Scott Wood wrote:
>
>> kvmppc_core_check_exceptions can clear MSR_WE, so we need to check after
>> that. We can't enable interrupts after kvmppc_core_check_exceptions (or
>> rather, if we
On 11/14/2011 02:54 PM, Alex Williamson wrote:
> On Fri, 2011-11-11 at 18:14 -0600, Scott Wood wrote:
>> What are the semantics of "desired and/or returned dma address"?
>
> I believe the original intention was that a user could leave dmaaddr
> clear and let the
On 11/15/2011 12:34 AM, David Gibson wrote:
> I think we need to pin exactly what "MAP_ANY" means down better. Now,
> VFIO is pretty much a lost cause if you can't map any normal process
> memory page into the IOMMU, so I think the only thing that is really
> covered is IOVAs. But saying "can map
On 11/15/2011 03:40 PM, Aaron Fabbri wrote:
>
>
>
> On 11/15/11 12:10 PM, "Scott Wood" wrote:
>
>> On 11/15/2011 12:34 AM, David Gibson wrote:
>
>>>> +static int allow_unsafe_intrs;
>>>> +module_param(allow_unsafe
On 11/11/2011 04:10 PM, Alex Williamson wrote:
>
> Thanks Konrad! Comments inline.
>
> On Fri, 2011-11-11 at 12:51 -0500, Konrad Rzeszutek Wilk wrote:
>> On Thu, Nov 03, 2011 at 02:12:24PM -0600, Alex Williamson wrote:
>>> +When supported, as indicated by the device flags, reset the device.
>>>
On Thu, Nov 17, 2011 at 01:22:17PM -0700, Alex Williamson wrote:
> On Wed, 2011-11-16 at 11:52 -0500, Konrad Rzeszutek Wilk wrote:
> > On Fri, Nov 11, 2011 at 03:10:56PM -0700, Alex Williamson wrote:
> > What would be the return value if somebody tried to unmask an edge one?
> > Should that be docu
.
Decrementers (and FITs, once implemented) are delivered as
level-triggered interrupts -- dequeued when the TSR bit is cleared, not
on delivery.
Signed-off-by: Liu Yu
[scottw...@freescale.com: significant changes]
Signed-off-by: Scott Wood
---
v2 updates:
- Use the KVM request mechanism to serialize the (de
On Fri, Nov 18, 2011 at 01:32:56PM -0700, Alex Williamson wrote:
> Hmm, that might be cleaner than eliminating the size with just using
> _IO(). So we might have something like:
>
> #define VFIO_IOMMU_MAP_DMA _IOWR(';', 106, struct vfio_dma_map)
> #define VFIO_IOMMU_MAP_DMA_V2
1 - 100 of 731 matches
Mail list logo
