Re: Configuration vs. compat hints

2009-06-14 Thread Markus Armbruster
Avi Kivity writes: > Mark McLoughlin wrote: [...] >>> NB the device tree contains no host configuration information. >>> >> >> So, it wouldn't e.g. include the path to the image file for a block >> device? That would always be specified on the command line? >> > > Or in a different file.

Re: Configuration vs. compat hints

2009-06-15 Thread Markus Armbruster
Avi Kivity writes: > On 06/15/2009 12:08 PM, Mark McLoughlin wrote: >>> This last option makes sense to me: in a real world the user has >>> control over where he places the device on the bus, so why >>> not with qemu? >>> >> >> Yep, most people seem to agree that it makes sense to allow th

Re: [Qemu-devel] Re: Configuration vs. compat hints

2009-06-15 Thread Markus Armbruster
Avi Kivity writes: > (adding cc) > > On 06/15/2009 02:35 PM, Markus Armbruster wrote: >> Not really. QEMU gives just the host bridge a fixed slot[*]. All the >> other slots are available. >> > > qemu needs to export these two bits of information: the fi

Re: Configuration vs. compat hints

2009-06-15 Thread Markus Armbruster
Anthony Liguori writes: > Avi Kivity wrote: >> On 06/15/2009 12:08 PM, Mark McLoughlin wrote: This last option makes sense to me: in a real world the user has control over where he places the device on the bus, so why not with qemu? >>> >>> Yep, most people seem to agree

virtio-blk-pci chokes on some PCI slots

2009-06-16 Thread Markus Armbruster
I'm working on make PCI slots configurable in QEMU. While testing the feature for virtio-blk-pci, I ran into a task hang with Fedora kernel 2.6.27.5-117.fc10. Marcelo tested it with a newer kernel, and will follow up with details. Instead of the full QEMU patch I'm working on, the appended littl

Re: virtio-blk-pci chokes on some PCI slots

2009-06-17 Thread Markus Armbruster
Marcelo Tosatti writes: > On Tue, Jun 16, 2009 at 06:47:45PM +0200, Markus Armbruster wrote: >> I'm working on make PCI slots configurable in QEMU. While testing the >> feature for virtio-blk-pci, I ran into a task hang with Fedora kernel >> 2.6.27.5-117.fc10. Marc

Re: virtio-blk-pci chokes on some PCI slots

2009-06-18 Thread Markus Armbruster
Markus Armbruster writes: > Even better: I can reproduce it with an unpatched upstream QEMU > (qemu.git commit cfde4bd9) like this: > > $ qemu foo.qcow2 -net nic -net nic -net nic -drive file=bar.img,if=virtio > > virtio-blk-pci ends up in slot 6. And: $ qemu foo.qc

Re: Device assignment hotplug broken

2009-06-30 Thread Markus Armbruster
. > > When the device assignment can come back? 4 day passed and no message from > Markus Armbruster till now. I'm having difficulties testing my patch. If it works for you, please let me know. Once I'm satisfied it works, I'll post it properly. diff --git a/hw/devic

Re: Device assignment hotplug broken

2009-07-01 Thread Markus Armbruster
Sheng Yang writes: > On Tuesday 30 June 2009 20:28:08 Markus Armbruster wrote: >> Sheng Yang writes: >> > On Friday 26 June 2009 01:24:03 Avi Kivity wrote: >> >> The impact of the hotplug changes on device assignment were too >> >> difficult for me to

[PATCH] Fix up device assignment hotplug and re-enable it

2009-07-01 Thread Markus Armbruster
Disabled in merge commit a3b371477e3. Signed-off-by: Markus Armbruster --- hw/device-assignment.c | 11 +-- hw/pci.c |2 +- hw/pci.h |1 + 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-assignment.c

[PATCH] Fix up ipf.c for recent merges

2009-07-01 Thread Markus Armbruster
Commit 42f0a928 merged support for addr=... in option argument of -net nic, but failed to update ipf_init1(). Commit 7a8f3ed9 merged support for addr=... in option argument of -drive if=virtio, but failed to update ipf_init1(). Untested. Signed-off-by: Markus Armbruster --- hw/ipf.c |7

Re: [Qemu-devel] Planning for the 0.11.0 release

2009-07-09 Thread Markus Armbruster
Anthony Liguori writes: > Mark McLoughlin wrote: >> Hi Anthony, >> >> On Mon, 2009-06-22 at 18:57 -0500, Anthony Liguori wrote: >> >>> Hi, >>> >>> It's getting to be about the time to start thinking about the >>> 0.11.0 release. 0.10.0 was released on March 2nd so following with >>> the 6 mon

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-16 Thread Markus Armbruster
Anthony Liguori writes: > Blue Swirl wrote: >> Then how about something like: >> -drive name=hda,if=ide,cache=off,file_is_arg -filearg foo.img >> -drive name=vda,if=virtio,cache=writeback,file_comes_next -patharg foo.img >> -drive name=sdb,if=scsi,unit=1,fnarg -fnarg boo.img >> > > The ex

Re: [Qemu-devel] KVM call agenda for June 21

2011-06-21 Thread Markus Armbruster
Avi Kivity writes: > On 06/21/2011 04:50 PM, Anthony Liguori wrote: >> On 06/21/2011 06:28 AM, Avi Kivity wrote: >>> On 06/20/2011 10:42 AM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. >>> >>> >>> https://bugzilla.redhat.com/show_bug.cgi?id=68967

Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)

2011-07-04 Thread Markus Armbruster
Typo in subject: "unsed". The warning is spelled "unused-but-set-variable", the option "-Wunused-but-set-variable". Raghavendra D Prabhu writes: > In a few cases, variable attributed 'unused' has been added, in other cases > unused variable has been either removed or commented out. > > Signed-o

Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)

2011-07-05 Thread Markus Armbruster
Peter Maydell writes: > On 5 July 2011 07:15, Markus Armbruster wrote: >>> +    int fd, __attribute__((unused)) ret; >>> >>>      snprintf(reset_file, sizeof(reset_file), >>>               "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/reset", &g

Re: [PATCH 1/3] qemu: Add strtosz_suffix_unit function

2011-07-08 Thread Markus Armbruster
Joerg Roedel writes: > This function does the same as the strtosz_suffix function > except that it allows to specify the unit to which the > k/M/B/T suffixes apply. This function will be used later to > parse the tsc-frequency from the command-line. > > Signed-off-by: Joerg Roedel > --- > cutil

Re: [Qemu-devel] [RFC] New thread for the VM migration

2011-07-18 Thread Markus Armbruster
Juan Quintela writes: [...] > I have think a little bit about hotplug & migration, and haven't arraive > to a nice solution. > > - Disabling hotplug/unplug during migration: easy to do. But it is not > exactly user friendly (we are here). > > - Allowing hotplug during migration. Solutions: >

Re: [Qemu-devel] [PATCH 1/3] scsi: Sanitize command definitions

2011-07-22 Thread Markus Armbruster
Hannes Reinecke writes: > Adding some missing command definitions and update the existing ones. > No functional change. Add: LOCATE_10, UNMAP, VARLENGTH_CDB, WRITE_FILEMARKS_16, EXTENDED_COPY, ATA_PASSTHROUGH, ACCESS_CONTROL_IN, ACCESS_CONTROL_OUT, COMPARE_AND_WRITE, VERIFY_16, SYNCHRONIZE_CACHE

Re: [Qemu-devel] [PATCH 3/3] scsi-disk: Check for supported commands

2011-07-22 Thread Markus Armbruster
Hannes Reinecke writes: > Not every command is support for any device type. This patch adds > a check for rejecting unsupported commands. > > Signed-off-by: Hannes Reinecke Commit message says "patch adds", patch only deletes. Looks like something wrent wrong with 2/3 and 3/3. -- To unsubscrib

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Markus Armbruster
Avi Kivity writes: > On 07/25/2011 01:04 PM, Alexander Graf wrote: >> On 25.07.2011, at 12:02, Avi Kivity wrote: >> >> > On 07/25/2011 12:56 PM, Alexander Graf wrote: >> >> > >> >> > That argument can be used to block any change. You'll get used to >> >> it in time. The question is, is th

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Markus Armbruster
Kevin Wolf writes: > Am 25.07.2011 12:06, schrieb Stefan Hajnoczi: >> On Mon, Jul 25, 2011 at 9:51 AM, Avi Kivity wrote: >>> qemu_malloc() is type-unsafe as it returns a void pointer. Introduce >>> QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. >>> >>> Signed-off-by: Avi Kivity >

Re: [Qemu-devel] [PATCH 5/6] scsi-disk: Remove 'drive_kind'

2011-07-25 Thread Markus Armbruster
Hannes Reinecke writes: > Instead of using its own definitions scsi-disk should > be using the device type of the parent device. > > Signed-off-by: Hannes Reinecke > --- > hw/scsi-defs.h |6 +- > hw/scsi-disk.c | 48 > 2 files changed,

Re: [Qemu-devel] [PATCH 0/6][v2] Check for supported SCSI commands

2011-07-25 Thread Markus Armbruster
Hannes Reinecke writes: > Markus Armbruster pointed out that not every SCSI command is supported > for a given device type. Based on his patch and suggestiongs this series > cleans up the SCSI device type and adds a check for supported commands. I like this series. It conflicts with

Re: [Qemu-devel] [PATCH 5/6] scsi-disk: Remove 'drive_kind'

2011-07-25 Thread Markus Armbruster
Hannes Reinecke writes: > On 07/25/2011 05:59 PM, Markus Armbruster wrote: >> Hannes Reinecke writes: >> >>> Instead of using its own definitions scsi-disk should >>> be using the device type of the parent device. >>> >>> Signed-off-by:

Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-26 Thread Markus Armbruster
Christoph Hellwig writes: > On Fri, Jul 22, 2011 at 04:51:17PM +0200, Hannes Reinecke wrote: >> Not every command is support for any device type. This patch adds >> a check for rejecting unsupported commands. >> >> Signed-off-by: Hannes Reinecke > > This seems to conflic with Markus' series. B

Re: [Qemu-devel] KVM call minutes July 24th

2012-07-30 Thread Markus Armbruster
Juan Quintela writes: > Hi > > Minutes of Today call. > > ahci: agraf > > - how to enable it? > * today is too difficult (alex) > * get it to work as everything else (markus) > And big discussion ensued. Markus & alex will reply with details. > No agreement, and too subtle for me to

Re: [Qemu-devel] [PATCH uq/master] kvmvapic: Disable if there is insufficient memory

2012-08-14 Thread Markus Armbruster
e-kvm -vnc :0 -m 640k Segmentation fault (core dumped) > Reported-by: Markus Armbruster > Signed-off-by: Jan Kiszka Tested-by: Markus Armbruster -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-29 Thread Markus Armbruster
Anthony Liguori writes: > Blue Swirl writes: > >> On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: >>> On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > On 27.08.2012 22:56, Blue Swirl wrote: > []

Re: [Qemu-devel] KVM call agenda for October 25

2011-10-26 Thread Markus Armbruster
Kevin Wolf writes: > Am 25.10.2011 16:06, schrieb Anthony Liguori: >> On 10/25/2011 08:56 AM, Kevin Wolf wrote: >>> Am 25.10.2011 15:05, schrieb Anthony Liguori: I'd be much more open to changing the default mode to cache=none FWIW since the risk of data loss there is much, much l

Re: [Qemu-devel] KVM call agenda for October 25

2011-10-26 Thread Markus Armbruster
Paolo Bonzini writes: > On 10/26/2011 10:48 AM, Markus Armbruster wrote: >> Sector size is a device property. >> >> If the user asks for a 4K sector disk, and the backend can't support >> that, we need to reject the configuration. Just like we reject >> r

Re: [qemu bug] device assignment doesn't work: "error: requires KVM support"

2011-10-26 Thread Markus Armbruster
"Ren, Yongjie" writes: >> -Original Message- >> From: Alex Williamson [mailto:alex.william...@redhat.com] >> Sent: Thursday, October 27, 2011 11:04 AM >> To: Ren, Yongjie >> Cc: KVM General; Avi Kivity >> Subject: Re: [qemu bug] device assignment doesn't work: "error: requires KVM >> supp

Re: [qemu bug] device assignment doesn't work: "error: requires KVM support"

2011-10-27 Thread Markus Armbruster
"Ren, Yongjie" writes: >> -Original Message- >> From: Markus Armbruster [mailto:arm...@redhat.com] >> Sent: Thursday, October 27, 2011 2:50 PM >> To: Ren, Yongjie >> Cc: Alex Williamson; KVM General; Avi Kivity >> Subject: Re: [qemu bug] de

Re: [qemu bug] device assignment doesn't work: "error: requires KVM support"

2011-10-27 Thread Markus Armbruster
"Ren, Yongjie" writes: >> -Original Message- >> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On >> Behalf Of Ren, Yongjie >> Sent: Thursday, October 27, 2011 3:03 PM >> To: Markus Armbruster >> Cc: Alex Williamson; KVM

Re: [RFC/GIT PULL] Linux KVM tool for v3.2

2011-11-09 Thread Markus Armbruster
Pekka Enberg writes: > Hi Anthony, > >> On 11/04/2011 03:38 AM, Pekka Enberg wrote: >>> Hi Linus, >>> >>> Please consider pulling the latest KVM tool tree from: >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux.git >>> kvmtool/for-linus >>> >> >> [snip] >> >>> tools/kvm/virtio/n

Re: [RFC/GIT PULL] Linux KVM tool for v3.2

2011-11-10 Thread Markus Armbruster
Sasha Levin writes: > On Thu, Nov 10, 2011 at 9:57 AM, Markus Armbruster wrote: [...] >> Start with a clean read/write raw image.  Probing declares it raw. >> Guest writes QCOW signature to it, with a backing file of its choice. >> >> Restart with the same image.

Re: [RFC/GIT PULL] Linux KVM tool for v3.2

2011-11-10 Thread Markus Armbruster
Sasha Levin writes: > On Thu, Nov 10, 2011 at 10:57 AM, Markus Armbruster wrote: >> Sasha Levin writes: [...] >>> I'm actually not sure why KVM tool got QCOW support in the first >>> place. You can have anything QCOW provides if you use btrfs (among >>

Re: [RFC/GIT PULL] Linux KVM tool for v3.2

2011-11-10 Thread Markus Armbruster
Pekka Enberg writes: > Hi Anthony, > > On Thu, Nov 10, 2011 at 3:43 PM, Anthony Liguori > wrote: >> It's not just the qcow2 implementation or even the block layer.  This pull >> requests adds a userspace TCP/IP stack to the kernel and yet netdev isn't on >> the CC and there are no Ack's from an

[PATCH] kvm-tpr-opt: Fix instruction_is_ok() for push tpr

2011-11-22 Thread Markus Armbruster
Missing break spotted by Coverity. Signed-off-by: Markus Armbruster --- kvm-tpr-opt.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kvm-tpr-opt.c b/kvm-tpr-opt.c index 4b2bd47..14c4b36 100644 --- a/kvm-tpr-opt.c +++ b/kvm-tpr-opt.c @@ -152,6 +152,7 @@ static int

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Markus Armbruster
Anthony Liguori writes: > On 01/18/2011 10:56 AM, Jan Kiszka wrote: >> >>> The device model topology is 100% a hidden architectural detail. >>> >> This is true for the sysbus, it is obviously not the case for PCI and >> similarly discoverable buses. There we have a guest-explorable topology

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Markus Armbruster
Gerd Hoffmann writes: > On 01/18/11 18:09, Anthony Liguori wrote: >> On 01/18/2011 10:56 AM, Jan Kiszka wrote: >>> The device model topology is 100% a hidden architectural detail. >>> This is true for the sysbus, it is obviously not the case for PCI and >>> similarly discoverable buses. Ther

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Markus Armbruster
Anthony Liguori writes: > On 01/18/2011 09:43 AM, Jan Kiszka wrote: >> On 2011-01-18 16:04, Anthony Liguori wrote: >> >>> On 01/18/2011 08:28 AM, Jan Kiszka wrote: >>> On 2011-01-12 11:31, Jan Kiszka wrote: > Am 12.01.2011 11:22, Avi Kivity wrote: > >

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-21 Thread Markus Armbruster
Gerd Hoffmann writes: > On 01/20/11 20:39, Anthony Liguori wrote: >> On 01/20/2011 02:44 AM, Gerd Hoffmann wrote: >>> Hi, >>> For (2), you cannot use bus=X,addr=Y because it makes assumptions about the PCI topology which may change in newer -M pc's. >>> >>> Why should the PCI topology f

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-21 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> By the way, we don't have a QEMUState but instead use globals. > > /me wants to underline this. > > IMO it is absolutely pointless to worry about ways to pass around > kvm_state. There never ever will be a serious need for that. > > We can stick with the curren

Re: [Qemu-devel] [PATCHv8 12/16] Add bootindex parameter to net/block/fd device

2011-01-28 Thread Markus Armbruster
Gleb Natapov writes: > If bootindex is specified on command line a string that describes device > in firmware readable way is added into sorted list. Later this list will > be passed into firmware to control boot order. > > Signed-off-by: Gleb Natapov Out of curiosity: what about qdev "scsi-gen

Re: [Qemu-devel] [PATCHv8 12/16] Add bootindex parameter to net/block/fd device

2011-01-28 Thread Markus Armbruster
Gleb Natapov writes: > On Fri, Jan 28, 2011 at 02:29:50PM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > If bootindex is specified on command line a string that describes device >> > in firmware readable way is added into sorted list. Later t

Re: [Qemu-devel] [PATCHv8 12/16] Add bootindex parameter to net/block/fd device

2011-02-02 Thread Markus Armbruster
Gleb Natapov writes: > If bootindex is specified on command line a string that describes device > in firmware readable way is added into sorted list. Later this list will > be passed into firmware to control boot order. > > Signed-off-by: Gleb Natapov Just noticed something that slipped through

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-08 Thread Markus Armbruster
Chris Wright writes: [...] > - qdev/vmstate both examples of partially completed work that need more > attention As far as qdev's concerned, I can see two kinds of to-dos: * Further develop qdev so that more of the machine init code can becomes qdev declarations. Specific ideas welcome.

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Markus Armbruster
Anthony Liguori writes: > On 02/08/2011 11:13 AM, Markus Armbruster wrote: >> Chris Wright writes: >> >> [...] >> >>> - qdev/vmstate both examples of partially completed work that need more >>>attention >>> >&g

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Markus Armbruster
Peter Maydell writes: > On 8 February 2011 17:13, Markus Armbruster wrote: >> As far as qdev's concerned, I can see two kinds of to-dos: >> >> * Further develop qdev so that more of the machine init code can becomes >>  qdev declarations.  Specific ideas

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Markus Armbruster
Aurelien Jarno writes: > On Tue, Feb 08, 2011 at 06:13:53PM +0100, Markus Armbruster wrote: >> Chris Wright writes: >> >> [...] >> > - qdev/vmstate both examples of partially completed work that need more >> > attention >> >> As far

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Markus Armbruster
Peter Maydell writes: > On 9 February 2011 08:11, Markus Armbruster wrote: >> Peter Maydell writes: >>> Markus Armbruster wrote: >>>> I've said this before: at some point in time (sooner rather than >>>> later, if you ask me), we need to sh

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Markus Armbruster
Anthony Liguori writes: > On 02/09/2011 02:01 AM, Markus Armbruster wrote: >> Anthony Liguori writes: [...] >>> We need to unify the property model. We have QemuOpts, qdev >>> properties, and QObject which basically reinvents variant typing three >>> diffe

Re: [Qemu-devel] KVM call agenda for Feb 15

2011-02-15 Thread Markus Armbruster
Anthony Liguori writes: > On 02/14/2011 11:56 AM, Chris Wright wrote: >> Please send in any agenda items you are interested in covering. >> > > - QAPI and QMP events > - qdev future Do we need a qdev tree and a maintainer for it? > > I don't really have a coherent plan for the second on

Re: [Qemu-devel] Re: [PATCH V6 1/4 resend] nmi: convert cpu_index to cpu-index

2011-02-23 Thread Markus Armbruster
Luiz Capitulino writes: > On Mon, 21 Feb 2011 09:37:57 +0800 > Lai Jiangshan wrote: > >> Hi, Luiz Capitulino >> >> Any problem? > > Sorry for the delay. Looks good in general to me know, there's only one > small problem and it's the error message: > > (qemu) nmi 100 > Parameter 'cpu-index'

Re: [Qemu-devel] [PATCH V6 3/4] qmp, nmi: convert do_inject_nmi() to QObject

2011-02-24 Thread Markus Armbruster
Anthony Liguori writes: > On 01/27/2011 02:20 AM, Lai Jiangshan wrote: >> Make we can inject NMI via qemu-monitor-protocol. >> We use "inject-nmi" for the qmp command name, the meaning is clearer. >> >> Signed-off-by: Lai Jiangshan >> --- >> diff --git a/hmp-commands.hx b/hmp-commands.hx >> inde

Re: [Qemu-devel] [PATCH V6 3/4] qmp, nmi: convert do_inject_nmi() to QObject

2011-02-24 Thread Markus Armbruster
Anthony Liguori writes: > On 02/24/2011 02:33 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >> >>> On 01/27/2011 02:20 AM, Lai Jiangshan wrote: >>> >>>> Make we can inject NMI via qemu-monitor-protocol. >>>&g

Re: [Qemu-devel] [PATCH V6 3/4] qmp, nmi: convert do_inject_nmi() to QObject

2011-02-25 Thread Markus Armbruster
Anthony Liguori writes: > On 02/24/2011 10:20 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >> >>> On 02/24/2011 02:33 AM, Markus Armbruster wrote: >>> >>>> Anthony Liguori writes: [...] >>>>> Please de

Re: [Qemu-devel] [PATCH V6 3/4] qmp, nmi: convert do_inject_nmi() to QObject

2011-02-27 Thread Markus Armbruster
Anthony Liguori writes: > On 02/25/2011 03:54 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >> >>> On 02/24/2011 10:20 AM, Markus Armbruster wrote: >>> >>>> Anthony Liguori writes: >>>> >>

Re: USB EHCI patch for 0.14.0?

2011-03-11 Thread Markus Armbruster
erik.r...@rdsoftware.de writes: > Hi David, > > I did a second iteration and it looked way better, maybe my first attempts > were somehow buggy. > > First - please review your DPRINTF in the usb-ehci.c, there is a variable > "dev" undefined in line 504/505 when enabling the debugging defines at th

Re: USB EHCI patch for 0.14.0?

2011-03-11 Thread Markus Armbruster
David Ahern writes: > On 03/11/11 08:39, Markus Armbruster wrote: >> erik.r...@rdsoftware.de writes: >> >>> Hi David, >>> >>> I did a second iteration and it looked way better, maybe my first attempts >>> were somehow buggy. >>> >&g

Re: USB EHCI patch for 0.14.0?

2011-03-11 Thread Markus Armbruster
Erik Rull writes: > Markus Armbruster wrote: >> erik.r...@rdsoftware.de writes: >> >>> Hi David, >>> >>> I did a second iteration and it looked way better, maybe my first attempts >>> were somehow buggy. >>> >>> First - pleas

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-04 Thread Markus Armbruster
[Note cc: Anthony] "Daniel P. Berrange" writes: > On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote: >> From: Lai Jiangshan >> Date: Mon, 7 Mar 2011 17:05:15 +0800 >> Subject: [PATCH 2/2] qemu,qmp: add inject-nmi qmp command >> >> inject-nmi command injects an NMI on all CPUs of gu

Re: [ANNOUNCE] Native Linux KVM tool

2011-04-06 Thread Markus Armbruster
Anthony Liguori writes: > On 04/03/2011 05:11 AM, Avi Kivity wrote: >> On 04/03/2011 12:59 PM, Pekka Enberg wrote: >>> Hi Avi, >>> >>> On Sun, Apr 3, 2011 at 11:23 AM, Avi Kivity wrote: >>> >> Note that this is a development prototype for the time being: >>> there's no >>> >> networking suppor

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-11 Thread Markus Armbruster
Avi Kivity writes: > On 04/08/2011 12:41 AM, Anthony Liguori wrote: >> >> And it's a good thing to have, but exposing this as the only API to >> do something as simple as generating a guest crash dump is not the >> friendliest thing in the world to do to users. > > nmi is a fine name for somethin

Re: [Qemu-devel] KVM call minutes for November 29

2011-11-29 Thread Markus Armbruster
Avi Kivity writes: > On 11/29/2011 05:51 PM, Juan Quintela wrote: >> How to do high level stuff? >> - python? >> > > One of the disadvantages of the various scripting languages is the lack > of static type checking, which makes it harder to do full sweeps of the > source for API changes, relying

KVM call agenda for Tuesday 24

2012-01-23 Thread Markus Armbruster
Please send in any agenda items you are interested in covering. Cheers, Markus -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Qemu-devel] KVM call agenda for Tuesday 24

2012-01-24 Thread Markus Armbruster
Anthony Liguori writes: > On 01/23/2012 11:38 AM, Markus Armbruster wrote: >> Please send in any agenda items you are interested in covering. > > I don't have anything pressing. I vote to cancel the call. Call's cancelled. -- To unsubscribe from this list: send the

Re: [PATCH] fixup e432cef9 (aio help text): end sentences with periods

2012-01-24 Thread Markus Armbruster
Laszlo Ersek writes: > (Please keep me CC'd on any followup; I'm not subscribed. Thanks.) Patch is fine, but it needs to go to . -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/

Re: QEMU-KVM 'Random' Virtual MAC Address.

2012-05-01 Thread Markus Armbruster
Veruca Salt writes: > Hello. > When creating an NIC in qemu, I have found that the default address on XP > virtual machines is the same for two VM's on different physical boxes. > Before we go off building an assignment programme to retrofit VM's upgraded > to the fit we're planning, will diffe

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Thu, May 24, 2012 at 05:53:21PM -0300, Luiz Capitulino wrote: >> On Fri, 25 May 2012 01:59:06 +0800 >> zwu.ker...@gmail.com wrote: >> >> > From: Zhi Yong Wu >> > >> > The patchset implements network hub stead of vlan. The main work was done >> > by stefan, and i r

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, May 25, 2012 at 12:18 PM, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >>> On Thu, May 24, 2012 at 05:53:21PM -0300, Luiz Capitulino wrote: >>>> On Fri, 25 May 2012 01:59:06 +0800 >>>> zwu.ker..

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-29 Thread Markus Armbruster
Luiz Capitulino writes: > On Mon, 28 May 2012 12:17:04 +0100 > Stefan Hajnoczi wrote: > >> What we need to decide is whether it's okay to drop QEMU "VLANs" >> completely and change dump command-line syntax? > > I'd vote for dropping it. > >> I think vlan-hub doesn't hurt anyone because the code

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-06-04 Thread Markus Armbruster
Anthony Liguori writes: > On 05/29/2012 04:14 PM, Markus Armbruster wrote: >> Luiz Capitulino writes: >> >>> On Mon, 28 May 2012 12:17:04 +0100 >>> Stefan Hajnoczi wrote: >>> >>>> What we need to decide is whether it's okay to dro

Re: [Qemu-devel] live migration between qemu-kvm 1.0 and 0.15

2012-04-02 Thread Markus Armbruster
Anthony Liguori writes: > So, since we're approaching 1.1, we should really discuss release > criteria for 1.1 with respect to live migration. I'd prefer to avoid > surprises in this release. > > My expectation is that migration works from: > > qemu-1.0 -M 1.0 =>qemu-1.1 -M 1.1 > qemu-1.

KVM call minutes April 3

2012-04-03 Thread Markus Armbruster
I'm afraid my notes are rather rough... * 1.1 soft freeze apr 15th (less than two weeks) hard freeze may 1 three months cycle for 1.2 stable machine types only every few releases? "pc-next" * Maintainers, got distracted and my notes make no sense, sorry * MSI injection to KVM irqchips f

Re: KVM call agenda for April, Tuesday 10

2012-04-10 Thread Markus Armbruster
As there are no topics, call is cancelled. Sorry for the late notice. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-05 Thread Markus Armbruster
Gleb Natapov writes: > On Thu, Nov 04, 2010 at 03:22:50PM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Thu, Nov 04, 2010 at 09:46:57AM +0100, Markus Armbruster wrote: >> >> > But why order of device creation is important? It sho

Re: [Qemu-devel] [PATCHv2 1/8] Introduce deriver_name field to DeviceInfo structure.

2010-11-05 Thread Markus Armbruster
Gleb Natapov writes: > On Thu, Nov 04, 2010 at 03:58:03PM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Thu, Nov 04, 2010 at 10:20:18AM +0100, Markus Armbruster wrote: >> >> Gleb Natapov writes: >> >> >> >&

Re: [Qemu-devel] [PATCHv2 1/8] Introduce deriver_name field to DeviceInfo structure.

2010-11-05 Thread Markus Armbruster
Gleb Natapov writes: > On Fri, Nov 05, 2010 at 03:14:20PM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Thu, Nov 04, 2010 at 03:58:03PM +0100, Markus Armbruster wrote: >> >> Gleb Natapov writes: >> >> >> >> &

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-05 Thread Markus Armbruster
Gleb Natapov writes: > On Fri, Nov 05, 2010 at 03:04:05PM +0100, Markus Armbruster wrote: [...] >> >> >> There has been quite some discussion on "canonical path" on the list, >> >> >> but no consensus. Ironically, one of the places where we g

Re: [Qemu-devel] [PATCHv2 1/8] Introduce deriver_name field to DeviceInfo structure.

2010-11-06 Thread Markus Armbruster
Gleb Natapov writes: > On Fri, Nov 05, 2010 at 05:24:01PM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Fri, Nov 05, 2010 at 03:14:20PM +0100, Markus Armbruster wrote: >> >> Gleb Natapov writes: >> >> >> >> &

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-06 Thread Markus Armbruster
Gleb Natapov writes: > On Fri, Nov 05, 2010 at 05:31:38PM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Fri, Nov 05, 2010 at 03:04:05PM +0100, Markus Armbruster wrote: >> [...] >> >> >> >> There has been quite some d

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-06 Thread Markus Armbruster
Gleb Natapov writes: > On Sat, Nov 06, 2010 at 10:25:31AM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Fri, Nov 05, 2010 at 05:31:38PM +0100, Markus Armbruster wrote: >> >> Gleb Natapov writes: >> >> >> >> &

Re: [Qemu-devel] [PATCHv2 1/8] Introduce deriver_name field to DeviceInfo structure.

2010-11-06 Thread Markus Armbruster
Gleb Natapov writes: > On Sat, Nov 06, 2010 at 10:01:25AM +0100, Markus Armbruster wrote: > [skip] >> > Why should Seabios match against three (or even more) different type of >> > devices to detect ata interface? Why require Seabios changes when this >> > c

Re: New @ Proxmox: -device, vhost... Docs, notes?

2010-11-15 Thread Markus Armbruster
linux_...@proinbox.com writes: > Hi Everyone, > > I'm impressed with all the activity I see here since joining the list > this year. > It helps to reinforce that I chose the right technology. Thanks. > > > > The -device method & vhost=on option recently became available to us at > the ProxmoxVE pr

Re: [PATCH] device-assignment: Register as un-migratable

2010-11-16 Thread Markus Armbruster
Jan Kiszka writes: > Am 15.11.2010 23:25, Alex Williamson wrote: >> On Mon, 2010-11-15 at 23:04 +0100, Jan Kiszka wrote: >>> Am 15.11.2010 21:25, Alex Williamson wrote: On Mon, 2010-11-15 at 21:05 +0100, Jan Kiszka wrote: > Am 15.11.2010 20:41, Alex Williamson wrote: >> Use register_

Re: [PATCH v2 0/5] Extra capabilities for device assignment

2010-12-09 Thread Markus Armbruster
Avi Kivity writes: > On 12/06/2010 06:43 PM, Alex Williamson wrote: >> On Mon, 2010-12-06 at 18:34 +0200, Avi Kivity wrote: >> > On 12/06/2010 06:21 PM, Alex Williamson wrote: >> > > v2: >> > >- Reimplement 2/5 to remove more cruft >> > > >> > > v1: >> > > >> > > Now that we've got

Re: [PATCH] pci: Fix PCI capabilities collision error value

2010-12-09 Thread Markus Armbruster
Alex Williamson writes: > Signed-off-by: Alex Williamson > --- > > hw/pci.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 288d6fd..0962416 100644 > --- a/hw/pci.c > +++ b/hw/pci.c > @@ -1856,7 +1856,7 @@ int pci_add_capability(PCIDevi

Re: [PATCH v2 2/2] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-10 Thread Markus Armbruster
Lai Jiangshan writes: > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). > > changed from v1 > Add document. > Add error handling when the cpu index is invalid. > > Signed-off-by: Lai Jiangshan > --- > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 23024ba..f8

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Markus Armbruster
Lai Jiangshan writes: > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). > > changed from v1 > Add document. > Add error handling when the cpu index is invalid. > > changed from v2 > use QERR_INVALID_PARAMETER_VALUE as Markus suggest. > > Signed-off-by: Lai Jiangshan

[PATCH] qemu-kvm: Switch to upstream -enable-kvm semantics

2010-12-15 Thread Markus Armbruster
Switch to upstream semantics: KVM off by default, -enable-kvm switches it on, and when it can't, it's fatal. Having to enable KVM explicitly is annoying, but the proper place to address that is upstream. Signed-off-by: Markus Armbruster --- vl.c | 10 +- 1 files changed

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 15 Dec 2010 11:49:23 +0100 > Markus Armbruster wrote: > >> Lai Jiangshan writes: >> >> > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). >> > >> > changed from v1 >> > Ad

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 15 Dec 2010 19:18:32 +0200 > Avi Kivity wrote: > >> On 12/15/2010 07:09 PM, Luiz Capitulino wrote: >> > On Wed, 15 Dec 2010 17:49:27 +0800 >> > Lai Jiangshan wrote: >> > >> > > >> > > Convert do_inject_nmi() to QObject, QError, we need to use it(via >> > > li

Re: [PATCH] qemu-kvm: Switch to upstream -enable-kvm semantics

2010-12-15 Thread Markus Armbruster
Anthony Liguori writes: > On 12/15/2010 09:50 AM, Markus Armbruster wrote: >> We currently enable KVM by default, and when it's not available, we >> print a message and fall back to TCG. Option -enable-kvm is ignored. >> Option -no-kvm suppresses KVM. >> >&

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 15 Dec 2010 18:45:09 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Wed, 15 Dec 2010 19:18:32 +0200 >> > Avi Kivity wrote: [...] >> >> I'd like to see cpu-index made optional;

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 16 Dec 2010 11:03:38 +0200 > Avi Kivity wrote: > >> On 12/15/2010 08:00 PM, Luiz Capitulino wrote: >> > > > >> > > > Looks like a GUI feature to me, >> > > >> > > Really? Can't see how you can build "NMI to all CPUs" from "NMI this >> > > CPU". Or am I mi

Re: [Qemu-devel] [PATCH 2/3] nmi: make cpu-index argument optional

2010-12-20 Thread Markus Armbruster
Lai Jiangshan writes: > When the argument "cpu-index" is not given, > then "nmi" command will inject NMI on all CPUs. > > This simulate the nmi button on physical machine. > > Signed-off-by: Lai Jiangshan > --- > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 8de7aa3..d8fe4c0 100644 > -

Re: [Qemu-devel] [PATCH 1/3] nmi: convert cpu_index to cpu-index

2010-12-20 Thread Markus Armbruster
Lai Jiangshan writes: > "cpu-index" is better name. > > Signed-off-by: Lai Jiangshan > --- > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 4befbe2..8de7aa3 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -721,7 +721,7 @@ ETEXI > #if defined(TARGET_I386) > { >

Re: [Qemu-devel] [PATCH V4 3/3] qmp, nmi: convert do_inject_nmi() to QObject, QError

2010-12-20 Thread Markus Armbruster
Lai Jiangshan writes: > Make we can inject NMI via qemu-monitor-protocol. > We use "inject-nmi" for the qmp command name, the meaning is clearer. > When cpu-index is found invalid in runtime, it will report > QERR_INVALID_PARAMETER_VALUE. This patch does two separate things: 1. Fix do_inject_nm

  1   2   3   >