Re: [Qemu-devel] [PATCHv5 1/5] qemu/msi: fix segfault in msix_save

2009-07-09 Thread Luiz Capitulino
On Sun, 5 Jul 2009 15:58:23 +0300 "Michael S. Tsirkin" wrote: > This fixes segfault reported by Kevin Wolf, > and simplifies the code in msix_save. > > Reported-by: Kevin Wolf > Signed-off-by: Michael S. Tsirkin Any reason on why this wasn't applied yet? Spent some time bisecting this just

Re: [PATCH] virt.kvm: Handle migrate errors using QMP monitor properly

2012-08-22 Thread Luiz Capitulino
On Tue, 21 Aug 2012 12:02:11 -0300 Lucas Meneghel Rodrigues wrote: > When using QMP monitor as the sole monitor on KVM autotest > (something that we sadly did not exercise on our test farms), > starting qemu with -S and then issuing 'cont' will cause > errors, since the error treatment with QMP m

Re: [PATCH] virt.kvm_monitor: Future proof migration handling on QMP monitor

2012-08-22 Thread Luiz Capitulino
the GenericError > class. So let's also handle this exception class. > > CC: Luiz Capitulino > Signed-off-by: Lucas Meneghel Rodrigues > --- > client/virt/kvm_monitor.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/client/virt/kvm_monito

Re: [Qemu-devel] KVM call agenda for October 25

2011-10-24 Thread Luiz Capitulino
On Mon, 24 Oct 2011 13:02:05 +0100 Peter Maydell wrote: > On 24 October 2011 12:35, Paolo Bonzini wrote: > > On 10/24/2011 01:04 PM, Juan Quintela wrote: > >> Please send in any agenda items you are interested in covering. > > > > - What's left to merge for 1.0. > > Things on my list, FWIW: >

Re: [PATCH V5 2/4] nmi: make cpu-index argument optional

2011-01-19 Thread Luiz Capitulino
Sorry for the long delay on this one, in general looks good, I have just a few small comments. On Mon, 10 Jan 2011 17:27:51 +0800 Lai Jiangshan wrote: > When the argument "cpu-index" is not given, > then "nmi" command will inject NMI on all CPUs. Please, state that we're changing the human mon

Re: [PATCH V5 3/4] qmp,nmi: convert do_inject_nmi() to QObject

2011-01-19 Thread Luiz Capitulino
On Mon, 10 Jan 2011 17:28:14 +0800 Lai Jiangshan wrote: > Make we can inject NMI via qemu-monitor-protocol. > We use "inject-nmi" for the qmp command name, the meaning is clearer. > > Signed-off-by: Lai Jiangshan > --- > diff --git a/hmp-commands.hx b/hmp-commands.hx > index a49fcd4..4db413d 1

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-25 Thread Luiz Capitulino
On Mon, 24 Jan 2011 16:06:34 -0600 Anthony Liguori wrote: > On 01/24/2011 07:25 AM, Chris Wright wrote: > > Please send in any agenda items you are interested in covering. > > > > - coroutines for the block layer > - glib everywhere - Let's start planning our next release in advance, here's

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-25 Thread Luiz Capitulino
On Tue, 25 Jan 2011 11:57:27 -0200 Luiz Capitulino wrote: > On Mon, 24 Jan 2011 16:06:34 -0600 > Anthony Liguori wrote: > > > On 01/24/2011 07:25 AM, Chris Wright wrote: > > > Please send in any agenda items you are interested in covering. > > > > >

Google Summer of Code 2011

2011-01-28 Thread Luiz Capitulino
Hi there, GSoC 2011 has been announced[1]. As we were pretty successful last year, I think we should participate again. I've already created a wiki page: http://wiki.qemu.org/Google_Summer_of_Code_2011 We should now populate it with projects and people willing to be mentors should say so (or ju

Re: Google Summer of Code 2011

2011-01-31 Thread Luiz Capitulino
On Sun, 30 Jan 2011 16:06:20 +0100 Alexander Graf wrote: > > On 28.01.2011, at 21:10, Luiz Capitulino wrote: > > > Hi there, > > > > GSoC 2011 has been announced[1]. As we were pretty successful last year, > > I think we should participate again.

Re: [Qemu-devel] Re: KVM call agenda for Feb 1

2011-02-01 Thread Luiz Capitulino
On Mon, 31 Jan 2011 15:39:22 -0600 Anthony Liguori wrote: > On 01/31/2011 12:10 PM, Jan Kiszka wrote: > > On 2011-01-31 11:02, Juan Quintela wrote: > > > >> Please send in any agenda items you are interested incovering. > >> > >> > > o KVM upstream merge: status, plans, coordination >

Re: [Qemu-devel] Re: KVM call agenda for Feb 1

2011-02-01 Thread Luiz Capitulino
On Tue, 1 Feb 2011 10:53:21 -0200 Luiz Capitulino wrote: > On Mon, 31 Jan 2011 15:39:22 -0600 > Anthony Liguori wrote: > > > On 01/31/2011 12:10 PM, Jan Kiszka wrote: > > > On 2011-01-31 11:02, Juan Quintela wrote: > > > > > >> Please send in a

Re: [PATCH V6 1/4] nmi: convert cpu_index to cpu-index

2011-02-01 Thread Luiz Capitulino
On Thu, 27 Jan 2011 16:20:27 +0800 Lai Jiangshan wrote: > "cpu-index" which uses hyphen is better name. > > Signed-off-by: Lai Jiangshan It looks ok from a quick pass, but I can't apply it on current master, what commit HEAD did you? Btw, please, do include the patch 0/0 with a general descr

Re: [PATCH V6 1/4] nmi: convert cpu_index to cpu-index

2011-02-09 Thread Luiz Capitulino
On Wed, 09 Feb 2011 14:46:32 +0800 Lai Jiangshan wrote: > On 02/01/2011 09:29 PM, Luiz Capitulino wrote: > > On Thu, 27 Jan 2011 16:20:27 +0800 > > Lai Jiangshan wrote: > > > >> "cpu-index" which uses hyphen is better name. > >> > >>

Re: [Qemu-devel] KVM Agenda for Feb 22

2011-02-22 Thread Luiz Capitulino
On Mon, 21 Feb 2011 14:13:04 -0600 Anthony Liguori wrote: > On 02/21/2011 11:12 AM, Juan Quintela wrote: > > please send in any agenda items you are interested in covering. > > > > - 0.14.0 release is out, thanks to everyone that participated! Let's > discuss what worked well, what could

Re: [PATCH V6 1/4 resend] nmi: convert cpu_index to cpu-index

2011-02-23 Thread Luiz Capitulino
On Mon, 21 Feb 2011 09:37:57 +0800 Lai Jiangshan wrote: > Hi, Luiz Capitulino > > Any problem? Sorry for the delay. Looks good in general to me know, there's only one small problem and it's the error message: (qemu) nmi 100 Parameter 'cpu-index' expects a

Re: [Qemu-devel] [PATCH V6 3/4] qmp, nmi: convert do_inject_nmi() to QObject

2011-02-23 Thread Luiz Capitulino
On Wed, 23 Feb 2011 13:25:38 -0600 Anthony Liguori wrote: > On 01/27/2011 02:20 AM, Lai Jiangshan wrote: > > Make we can inject NMI via qemu-monitor-protocol. > > We use "inject-nmi" for the qmp command name, the meaning is clearer. > > > > Signed-off-by: Lai Jiangshan > > --- > > diff --git a/h

Re: [Qemu-devel] KVM call agenda for Mars 21th

2011-03-22 Thread Luiz Capitulino
On Mon, 21 Mar 2011 13:58:35 +0100 Juan Quintela wrote: > > Please, send in any agenda items you are interested in covening. > > - Merge patches speed. I just "feel", that patches are not being > handled fast enough, so ... I looked how much patches have been > integrated since Mars 1st:

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-04 Thread Luiz Capitulino
On Mon, 04 Apr 2011 14:19:58 +0200 Markus Armbruster wrote: > [Note cc: Anthony] > > "Daniel P. Berrange" writes: > > > On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote: > >> From: Lai Jiangshan > >> Date: Mon, 7 Mar 2011 17:05:15 +0800 > >> Subject: [PATCH 2/2] qemu,qmp: add inj

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-04 Thread Luiz Capitulino
On Mon, 04 Apr 2011 08:09:29 -0500 Anthony Liguori wrote: > On 04/04/2011 07:19 AM, Markus Armbruster wrote: > > [Note cc: Anthony] > > > > "Daniel P. Berrange" writes: > > > >> On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote: > >>> From: Lai Jiangshan > >>> Date: Mon, 7 Mar 2011 1

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-06 Thread Luiz Capitulino
On Mon, 04 Apr 2011 08:05:48 -0500 Anthony Liguori wrote: > On 04/04/2011 07:54 AM, Avi Kivity wrote: > > On 04/04/2011 01:59 PM, Daniel P. Berrange wrote: > >> Interesting that with HMP you need to specify a single CPU index, but > >> with QMP it is injecting to all CPUs at once. Is there any co

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-06 Thread Luiz Capitulino
On Wed, 06 Apr 2011 13:03:37 -0500 Anthony Liguori wrote: > On 04/06/2011 12:47 PM, Luiz Capitulino wrote: > > On Mon, 04 Apr 2011 08:05:48 -0500 > > Anthony Liguori wrote: > > > >> On 04/04/2011 07:54 AM, Avi Kivity wrote: > >>> On 04/

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-06 Thread Luiz Capitulino
On Wed, 06 Apr 2011 20:17:47 +0200 Jan Kiszka wrote: > On 2011-04-06 20:08, Luiz Capitulino wrote: > > On Wed, 06 Apr 2011 13:03:37 -0500 > > Anthony Liguori wrote: > > > >> On 04/06/2011 12:47 PM, Luiz Capitulino wrote: > >>> On Mon, 04 Apr 2011 0

Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-08 Thread Luiz Capitulino
Hi there, Summary: - PXE boot in qemu.git (HEAD f124a41) is quite slow, more than 5 minutes. Got the problem with e1000, virtio and rtl8139. However, pcnet *works* (it's as fast as qemu-kvm.git) - PXE boot in qemu-kvm.git (HEAD df85c051) is fast, less than a minute. Tried with e1000,

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-08 Thread Luiz Capitulino
On Tue, 08 May 2012 07:14:11 -0500 Anthony Liguori wrote: > On 05/07/2012 06:47 AM, Juan Quintela wrote: > > > > Hi > > > > Please send in any agenda items you are interested in covering. > > I've got a conflict at 9am as it turns out so I won't be able to attend. Does this mean the call is can

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-24 Thread Luiz Capitulino
On Fri, 25 May 2012 01:59:06 +0800 zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > > The patchset implements network hub stead of vlan. The main work was done by > stefan, and i rebased it to latest QEMU upstream, did some testings and am > responsible for pushing it to QEMU upstream. Hones

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 08:47:18 +0800 Zhi Yong Wu wrote: > On Fri, May 25, 2012 at 4:53 AM, Luiz Capitulino > wrote: > > On Fri, 25 May 2012 01:59:06 +0800 > > zwu.ker...@gmail.com wrote: > > > >> From: Zhi Yong Wu > >> > >> The patchset impl

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 13:01:37 +0100 Stefan Hajnoczi wrote: > I agree it would be nice to drop entirely but I don't feel happy doing > that to users who might have QEMU buried in scripts somewhere. One > day they upgrade packages and suddenly their stuff doesn't work > anymore. This is very simil

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 14:59:25 +0200 Paolo Bonzini wrote: > Il 25/05/2012 14:53, Luiz Capitulino ha scritto: > >> > I agree it would be nice to drop entirely but I don't feel happy doing > >> > that to users who might have QEMU buried in scripts somewhere. One >

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 15:14:39 +0200 Paolo Bonzini wrote: > Il 25/05/2012 15:07, Luiz Capitulino ha scritto: > > On Fri, 25 May 2012 14:59:25 +0200 > > Paolo Bonzini wrote: > > > >> Il 25/05/2012 14:53, Luiz Capitulino ha scritto: > >>>>> I agr

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 15:19:28 +0200 Paolo Bonzini wrote: > Il 25/05/2012 15:18, Luiz Capitulino ha scritto: > >> > > >> > Still not sure what you mean... > > I meant it's a similar case. kqemu was a special case and maintenance > > burden. > > W

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 15:37:15 +0200 Paolo Bonzini wrote: > Il 25/05/2012 15:30, Luiz Capitulino ha scritto: > > On Fri, 25 May 2012 15:19:28 +0200 > > Paolo Bonzini wrote: > > > >> Il 25/05/2012 15:18, Luiz Capitulino ha scritto: > >>>>> >

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-25 Thread Luiz Capitulino
On Fri, 25 May 2012 15:47:28 +0200 Paolo Bonzini wrote: > Il 25/05/2012 15:43, Luiz Capitulino ha scritto: > >> Yeah, VDE probably includes something like an hub. But then we could > >> drop even "-net socket", "-net udp", "-net dump", and on

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-28 Thread Luiz Capitulino
On Mon, 28 May 2012 12:17:04 +0100 Stefan Hajnoczi wrote: > What we need to decide is whether it's okay to drop QEMU "VLANs" > completely and change dump command-line syntax? I'd vote for dropping it. > I think vlan-hub doesn't hurt anyone because the code has been isolated > and we keep backwa

Re: [Qemu-devel] [PATCH 1/3] start vm after reseting it

2012-05-30 Thread Luiz Capitulino
On Mon, 21 May 2012 14:49:32 +0800 Wen Congyang wrote: > The guest should run after reseting it, but it does not > run if its old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. > > Signed-off-by: Wen Congyang > --- > vl.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) >

Re: [Qemu-devel] [PATCH 3/3] deal with guest panicked event

2012-05-30 Thread Luiz Capitulino
On Mon, 21 May 2012 14:50:51 +0800 Wen Congyang wrote: > When the guest is panicked, it will write 0x1 to the port 0x505. So if > qemu reads 0x1 from this port, we can do the folloing three things > according to the parameter -onpanic: > 1. emit QEVENT_GUEST_PANICKED only > 2. emit QEVENT_GUEST_P

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-06-04 Thread Luiz Capitulino
On Mon, 04 Jun 2012 12:56:41 +0800 Anthony Liguori wrote: > On 05/25/2012 08:53 PM, Luiz Capitulino wrote: > > On Fri, 25 May 2012 13:01:37 +0100 > > Stefan Hajnoczi wrote: > > > >> I agree it would be nice to drop entirely but I don't feel happy doing >

Re: [Qemu-devel] [PATCH 3/3] deal with guest panicked event

2012-06-12 Thread Luiz Capitulino
On Tue, 12 Jun 2012 14:55:37 +0800 Wen Congyang wrote: > >> +static void panicked_perform_action(void) > >> +{ > >> +switch(panicked_action) { > >> +case PANICKED_REPORT: > >> +panicked_mon_event("report"); > >> +break; > >> + > >> +case PANICKED_PAUSE: > >> +p

Re: [Qemu-devel] [PATCH 3/3] deal with guest panicked event

2012-06-12 Thread Luiz Capitulino
On Tue, 12 Jun 2012 13:40:45 +0100 "Daniel P. Berrange" wrote: > On Tue, Jun 12, 2012 at 09:35:04AM -0300, Luiz Capitulino wrote: > > On Tue, 12 Jun 2012 14:55:37 +0800 > > Wen Congyang wrote: > > > > > >> +static void panicked_perform

Re: [Qemu-devel] [PATCH]qemu: deal with guest paniced event

2012-03-01 Thread Luiz Capitulino
On Mon, 27 Feb 2012 11:05:58 +0800 Wen Congyang wrote: > When the host knows the guest is paniced, it will set > exit_reason to KVM_EXIT_GUEST_PANIC. So if qemu receive > this exit_reason, we can send a event to tell management > application that the guest is paniced. > > Signed-off-by: Wen Cong

Re: [Qemu-devel] Can VMX provide real mode support?

2012-03-23 Thread Luiz Capitulino
On Wed, 21 Mar 2012 15:48:43 +0200 Avi Kivity wrote: > On 03/21/2012 03:40 PM, Jan Kiszka wrote: > > On 2012-03-21 13:38, GaoYi wrote: > > > Hi Jan, > > > > > > Since the newest Intel-VT supports the guest OS under the real mode, > > > which was already supported in AMD-V, can the VMX in th

Re: [Qemu-devel] KVM call agenda for Nov 23

2010-11-23 Thread Luiz Capitulino
On Mon, 22 Nov 2010 17:00:41 -0600 Anthony Liguori wrote: > On 11/22/2010 03:45 PM, Chris Wright wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > > > >> Please send in any agenda items you are interested in covering. > >> > > usb-ccid > > > > - vcpu hard limits - 0.14 (re

Re: [PATCH 2/6] qemu,qmp: convert do_inject_nmi() to QObject

2010-12-09 Thread Luiz Capitulino
On Thu, 09 Dec 2010 14:59:00 +0800 Lai Jiangshan wrote: > > Convert do_inject_nmi() to QObject, we need to use it(via libvirt). Patches 0/6 and 1/6 are missing. Also, I see that you're converting two unrelated commands in the same series. Please, split into two series. > It is trivial, as it

Re: [PATCH 6/6] qemu,qmp: Convert do_sendkey() to QObject,QError

2010-12-09 Thread Luiz Capitulino
On Thu, 09 Dec 2010 14:59:40 +0800 Lai Jiangshan wrote: > > Convert do_sendkey() to QObject,QError, we need to use it.(via libvirt) > > It is a trivial conversion, carefully converted the error reports. Trivial conversion doesn't seem to lead to a good interface for qmp, because sendkey carrie

Re: [PATCH v2 1/2] QError: new QERR_INVALID_CPU_INDEX

2010-12-10 Thread Luiz Capitulino
On Fri, 10 Dec 2010 14:36:01 +0800 Lai Jiangshan wrote: > > Signed-off-by: Lai Jiangshan As Markus said, we report this as an invalid parameter in do_cpu(), we can do the same for inject-nmi. > --- > diff --git a/qerror.c b/qerror.c > index ac2cdaf..f59fb58 100644 > --- a/qerror.c > +++ b/qe

Re: [PATCH v2 2/2] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-10 Thread Luiz Capitulino
On Fri, 10 Dec 2010 14:36:08 +0800 Lai Jiangshan wrote: > +SQMP > +inject_nmi > +-- > + > +Inject an NMI on the given CPU (x86 only). > + > +Arguments: > + > +- "cpu_index": the index of the CPU to be injected NMI (json-int) > + > +Example: > + > +-> { "execute": "inject_nmi", "arguments"

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 17:49:27 +0800 Lai Jiangshan wrote: > > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). > > changed from v1 > Add document. > Add error handling when the cpu index is invalid. > > changed from v2 > use QERR_INVALID_PARAMETER_VALUE as Markus sugge

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 11:49:23 +0100 Markus Armbruster wrote: > Lai Jiangshan writes: > > > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). > > > > changed from v1 > > Add document. > > Add error handling when the cpu index is invalid. > > > > changed from v2 > > use Q

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 19:18:32 +0200 Avi Kivity wrote: > On 12/15/2010 07:09 PM, Luiz Capitulino wrote: > > On Wed, 15 Dec 2010 17:49:27 +0800 > > Lai Jiangshan wrote: > > > > > > > > Convert do_inject_nmi() to QObject, QError, we need to use it(via >

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 18:39:07 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 15 Dec 2010 11:49:23 +0100 > > Markus Armbruster wrote: > > > >> Lai Jiangshan writes: > >> > >> > Convert do_inject_nmi() to

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 18:45:09 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 15 Dec 2010 19:18:32 +0200 > > Avi Kivity wrote: > > > >> On 12/15/2010 07:09 PM, Luiz Capitulino wrote: > >> > On Wed, 15 Dec 20

Re: KVM Test report, kernel d335b15... qemu cb1983b8...

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 10:32:12 +0200 Avi Kivity wrote: > On 12/15/2010 08:05 AM, Hao, Xudong wrote: > > Hi, all, > > This is KVM test result against kvm.git > > d335b156f9fafd177d0606cf845d9a2df2dc5431, and qemu-kvm.git > > cb1983b8809d0e06a97384a40bad1194a32fc814. > > > > Currently qemu-kvm buil

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 11:03:38 +0200 Avi Kivity wrote: > On 12/15/2010 08:00 PM, Luiz Capitulino wrote: > > > > > > > > Looks like a GUI feature to me, > > > > > > Really? Can't see how you can build "NMI to all CPUs" from "NMI

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 12:51:14 +0200 Avi Kivity wrote: > On 12/16/2010 12:48 PM, Luiz Capitulino wrote: > > Ok, I didn't know that, but I had another idea: the command could accept > > either a single cpu index or a list: > > > > > >{ "execu

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 14:50:08 +0200 Avi Kivity wrote: > On 12/16/2010 01:47 PM, Markus Armbruster wrote: > > > > > > This has the feature of injecting the nmi in just some cpus, although I'm > > > not sure this is going to be desired/useful. > > > > Use case for NMI-ing a subset of the CPUs? > >

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 15:11:50 +0200 Avi Kivity wrote: > On 12/16/2010 03:09 PM, Luiz Capitulino wrote: > > On Thu, 16 Dec 2010 14:50:08 +0200 > > Avi Kivity wrote: > > > > > On 12/16/2010 01:47 PM, Markus Armbruster wrote: > > > > > > > >

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-17 Thread Luiz Capitulino
On Fri, 17 Dec 2010 14:20:15 +0800 Lai Jiangshan wrote: > On 12/16/2010 09:17 PM, Luiz Capitulino wrote: > > On Thu, 16 Dec 2010 15:11:50 +0200 > > Avi Kivity wrote: > >> > >> Why have an argument at all? Always nmi to all cpus. > > > > I

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2011-01-03 Thread Luiz Capitulino
On Mon, 20 Dec 2010 14:09:05 +0800 Lai Jiangshan wrote: > On 12/17/2010 11:25 PM, Avi Kivity wrote: > > On 12/17/2010 01:22 PM, Luiz Capitulino wrote: > >> > > >> > I think Avi's suggest is better, and I will use > >> > "inject-nm

Re: [Qemu-devel] [PATCH 1/3] nmi: convert cpu_index to cpu-index

2011-01-03 Thread Luiz Capitulino
On Mon, 20 Dec 2010 18:00:34 +0100 Markus Armbruster wrote: > Lai Jiangshan writes: > > > "cpu-index" is better name. > > > > Signed-off-by: Lai Jiangshan > > --- > > diff --git a/hmp-commands.hx b/hmp-commands.hx > > index 4befbe2..8de7aa3 100644 > > --- a/hmp-commands.hx > > +++ b/hmp-comma

Re: [PATCH v2 2/2] qemu,qmp: convert do_inject_nmi() to QObject, QError

2011-01-03 Thread Luiz Capitulino
On Mon, 20 Dec 2010 08:47:46 -0200 Marcelo Tosatti wrote: > On Fri, Dec 10, 2010 at 09:20:26AM -0200, Luiz Capitulino wrote: > > On Fri, 10 Dec 2010 14:36:08 +0800 > > Lai Jiangshan wrote: > > > > > +SQMP > > > +inject_nmi > > > +-- &g

Re: [PATCH] KVM test: qmp_basic: Go through available monitors to find a qmp one

2011-01-11 Thread Luiz Capitulino
t; error the test with a more descriptive message > > Also, clarify the exception thrown when the monitor is not responsive > after the test. > > Signed-off-by: Qingtang Zhou > Signed-off-by: Lucas Meneghel Rodrigues Makes sense: Acked-by: Luiz Capitulino > --- > c

Re: Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Luiz Capitulino
On Sat, 9 Apr 2011 13:34:43 +0300 Blue Swirl wrote: > On Sat, Apr 9, 2011 at 2:25 AM, Luiz Capitulino > wrote: > > Hi there, > > > > Summary: > > > >  - PXE boot in qemu.git (HEAD f124a41) is quite slow, more than 5 minutes. > > Got > >   the

Re: Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Luiz Capitulino
On Fri, 08 Apr 2011 19:50:57 -0500 Anthony Liguori wrote: > On 04/08/2011 06:25 PM, Luiz Capitulino wrote: > > Hi there, > > > > Summary: > > > > - PXE boot in qemu.git (HEAD f124a41) is quite slow, more than 5 minutes. > > Got > > the pr

Re: Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Luiz Capitulino
On Mon, 11 Apr 2011 13:00:32 -0600 Alex Williamson wrote: > On Mon, 2011-04-11 at 15:35 -0300, Luiz Capitulino wrote: > > On Fri, 08 Apr 2011 19:50:57 -0500 > > Anthony Liguori wrote: > > > > > On 04/08/2011 06:25 PM, Luiz Capitulino wrote: > > &

Re: Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-11 Thread Luiz Capitulino
On Mon, 11 Apr 2011 22:04:52 +0200 Jan Kiszka wrote: > On 2011-04-11 21:15, Luiz Capitulino wrote: > > On Mon, 11 Apr 2011 13:00:32 -0600 > > Alex Williamson wrote: > > > >> On Mon, 2011-04-11 at 15:35 -0300, Luiz Capitulino wrote: > >>> On Fri, 08 Apr

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-13 Thread Luiz Capitulino
On Tue, 12 Apr 2011 21:31:18 +0300 Blue Swirl wrote: > On Tue, Apr 12, 2011 at 10:52 AM, Avi Kivity wrote: > > On 04/11/2011 08:15 PM, Blue Swirl wrote: > >> > >> On Mon, Apr 11, 2011 at 10:01 AM, Markus Armbruster > >>  wrote: > >> >  Avi Kivity  writes: > >> > > >> >>  On 04/08/2011 12:41 AM,

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-25 Thread Luiz Capitulino
On Wed, 20 Apr 2011 09:53:56 +0800 Lai Jiangshan wrote: > On 04/04/2011 09:09 PM, Anthony Liguori wrote: > > On 04/04/2011 07:19 AM, Markus Armbruster wrote: > >> [Note cc: Anthony] > >> > >> "Daniel P. Berrange" writes: > >> > >>> On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote: >

Re: [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command

2011-04-26 Thread Luiz Capitulino
On Thu, 21 Apr 2011 11:23:54 +0800 Lai Jiangshan wrote: > > Hi, Anthony Liguori > > Any suggestion? > > Although all command line interfaces will be converted to to use QMP > interfaces in 0.16, > I hope inject-nmi come into QAPI earlier, 0.15. I don't know what Anthony thinks about adding n

Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command

2011-04-27 Thread Luiz Capitulino
On Wed, 27 Apr 2011 09:54:34 +0800 Lai Jiangshan wrote: > On 04/26/2011 09:29 PM, Anthony Liguori wrote: > > On 04/26/2011 08:26 AM, Luiz Capitulino wrote: > >> On Thu, 21 Apr 2011 11:23:54 +0800 > >> Lai Jiangshan wrote: > >> > >>> >

Re: [PATCH -v3] Monitor command: x-gpa2hva, translate guest physical address to host virtual address

2011-04-29 Thread Luiz Capitulino
On Fri, 29 Apr 2011 08:30:25 +0800 Huang Ying wrote: > On 04/28/2011 10:04 PM, Marcelo Tosatti wrote: > > On Thu, Apr 28, 2011 at 08:00:19AM -0500, Anthony Liguori wrote: > >> On 04/27/2011 06:06 PM, Marcelo Tosatti wrote: > >>> On Fri, Nov 19, 2010 at 04:17:35PM +0800, Huang Ying wrote: > O

Re: [PATCH 0/2 V9] hmp,qmp: add inject-nmi

2011-04-29 Thread Luiz Capitulino
On Thu, 28 Apr 2011 11:35:20 +0800 Lai Jiangshan wrote: > > > Adds new QERR_UNSUPPORTED, converts "nmi" to "inject-nmi" and > make it supports qmp. Lai, unfortunately this series still have some issues (like changing the HMP command name). I think V7 was the best submission so far, so I decide

Re: [Qemu-devel] KVM call minutes for 2013-04-23

2013-04-24 Thread Luiz Capitulino
On Tue, 23 Apr 2013 10:06:41 -0600 Eric Blake wrote: > > we can change "drive_mirror" to use a new command to see if there > > are the new features. > > drive-mirror changed in 1.4 to add optional buf-size parameter; right > now, libvirt is forced to limit itself to 1.3 interface (no buf-siz

Re: [Qemu-devel] KVM call minutes for 2013-04-23

2013-04-24 Thread Luiz Capitulino
On Wed, 24 Apr 2013 10:03:21 +0200 Stefan Hajnoczi wrote: > On Tue, Apr 23, 2013 at 10:06:41AM -0600, Eric Blake wrote: > > On 04/23/2013 08:45 AM, Juan Quintela wrote: > > > we can change "drive_mirror" to use a new command to see if there > > > are the new features. > > > > drive-mirror ch

[RFC v2] virtio-balloon: automatic ballooning support

2013-05-09 Thread Luiz Capitulino
this to be dynamically enabled by mngt Signed-off-by: Luiz Capitulino --- o You can find my test script here: http://repo.or.cz/w/qemu/qmp-unstable.git/blob/refs/heads/balloon/auto-ballooning/memcg/rfc:/scripts/autob-test o You can find the guest driver counterpart code at: http://re

[RFC v2 0/2] virtio_balloon: auto-ballooning support

2013-05-09 Thread Luiz Capitulino
rue 5. Balloon the guest memory down, say from 1G to 256MB 6. Generate some pressure in the guest, say a kernel build with -j16 Any feedback is appreciated! Luiz Capitulino (2): virtio_balloon: move balloon_lock mutex to callers virtio_balloon: auto-ballooning support drivers/virtio/v

[RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-09 Thread Luiz Capitulino
4 3649 1079847 1616367 4543 953289 1635379 5642 913237 1514000 Auto-ballooning enabled: RUN TIME(s) SWAP IN SWAP OUT 1629 901 12537 2624 981 18506 3626 573 9085 4631 2250 42534 5627 1610 20808 Signed-of

[RFC 1/2] virtio_balloon: move balloon_lock mutex to callers

2013-05-09 Thread Luiz Capitulino
semantics. Signed-off-by: Luiz Capitulino --- drivers/virtio/virtio_balloon.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index bd3ae32..9d5fe2b 100644 --- a/drivers/virtio/virtio_balloon.c +++ b

Re: [RFC 1/2] virtio_balloon: move balloon_lock mutex to callers

2013-05-10 Thread Luiz Capitulino
On Thu, 9 May 2013 18:03:09 -0300 Rafael Aquini wrote: > On Thu, May 09, 2013 at 10:53:48AM -0400, Luiz Capitulino wrote: > > This commit moves the balloon_lock mutex out of the fill_balloon() > > and leak_balloon() functions to their callers. > > > > The reason for t

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-10 Thread Luiz Capitulino
On Thu, 9 May 2013 18:15:19 -0300 Rafael Aquini wrote: > On Thu, May 09, 2013 at 10:53:49AM -0400, Luiz Capitulino wrote: > > Automatic ballooning consists of dynamically adjusting the guest's > > balloon according to memory pressure in the host and in the guest. > >

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-10 Thread Luiz Capitulino
On Fri, 10 May 2013 09:20:46 -0400 Luiz Capitulino wrote: > On Thu, 9 May 2013 18:15:19 -0300 > Rafael Aquini wrote: > > > On Thu, May 09, 2013 at 10:53:49AM -0400, Luiz Capitulino wrote: > > > Automatic ballooning consists of dynamically adjusting the guest's >

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-13 Thread Luiz Capitulino
On Sun, 12 May 2013 21:49:34 +0300 "Michael S. Tsirkin" wrote: > On Sun, May 12, 2013 at 12:36:09PM -0400, Rik van Riel wrote: > > On 05/12/2013 10:30 AM, Michael S. Tsirkin wrote: > > >On Thu, May 09, 2013 at 10:53:49AM -0400, Luiz Capitulino wrote: > >

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-13 Thread Luiz Capitulino
On Mon, 13 May 2013 11:34:41 -0300 Rafael Aquini wrote: > You're right, and the host's member is used to communicate the configured size > to guest's balloon device, however, by not changing it when the shrinker > causes > the balloon to deflate will make the balloon thread to be woken up again

Re: [RFC 2/2] virtio_balloon: auto-ballooning support

2013-05-13 Thread Luiz Capitulino
On Mon, 13 May 2013 22:02:50 +0300 "Michael S. Tsirkin" wrote: > On Mon, May 13, 2013 at 02:25:11PM -0400, Luiz Capitulino wrote: > > On Mon, 13 May 2013 11:34:41 -0300 > > Rafael Aquini wrote: > > > > > You're right, and the host's member

Re: [RFC v2 0/2] virtio_balloon: auto-ballooning support

2013-05-16 Thread Luiz Capitulino
On Thu, 16 May 2013 16:56:34 -0400 Sasha Levin wrote: > On 05/09/2013 10:53 AM, Luiz Capitulino wrote: > > Hi, > > > > This series is a respin of automatic ballooning support I started > > working on last year. Patch 2/2 contains all relevant technical > > det

Re: [PATCH uq/master] fix double free the memslot in kvm_set_phys_mem

2013-05-31 Thread Luiz Capitulino
On Fri, 31 May 2013 16:52:18 +0800 Xiao Guangrong wrote: > Luiz Capitulino reported that guest refused to boot and qemu > complained with: > kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument > > It is caused by commit 235e8982ad that did double free for t

PATCH] virtio-spec: small English/punctuation corrections

2013-05-31 Thread Luiz Capitulino
1. s/These are devices are/These devices are 2. s/Thefirst/The first 3. s/, Guest should/. Guest should Signed-off-by: Luiz Capitulino --- virtio-spec.lyx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/virtio-spec.lyx b/virtio-spec.lyx index 6e188d0..7e4ce71 100644

[PATCH] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-05 Thread Luiz Capitulino
The balloon_page_dequeue() function can return NULL. If it does for the first page being freed, then leak_balloon() will create a scatter list with len=0. Which in turn seems to generate an invalid virtio request. Signed-off-by: Luiz Capitulino --- PS: I didn't get this in practice. I fou

Re: [PATCH] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-05 Thread Luiz Capitulino
On Wed, 5 Jun 2013 18:24:49 -0300 Rafael Aquini wrote: > On Wed, Jun 05, 2013 at 05:10:31PM -0400, Luiz Capitulino wrote: > > The balloon_page_dequeue() function can return NULL. If it does for > > the first page being freed, then leak_balloon() will create a > > scatter l

[PATCH v2] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-05 Thread Luiz Capitulino
such an invalid virtio request will cause errors in QEMU and fill_balloon() also performs the same check implemented by this commit. Signed-off-by: Luiz Capitulino Acked-by: Rafael Aquini --- o v2 - Improve changelog drivers/virtio/virtio_balloon.c | 3 ++- 1 file changed, 2 insertions(

Re: [PATCH v2] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-06 Thread Luiz Capitulino
On Thu, 6 Jun 2013 11:13:58 -0300 Rafael Aquini wrote: > On Wed, Jun 05, 2013 at 09:18:37PM -0400, Luiz Capitulino wrote: > > The balloon_page_dequeue() function can return NULL. If it does for > > the first page being freed, then leak_balloon() will create a > > scatter l

Re: [PATCH v2] virtio_balloon: leak_balloon(): only tell host if we got pages deflated

2013-06-17 Thread Luiz Capitulino
On Wed, 5 Jun 2013 21:18:37 -0400 Luiz Capitulino wrote: > The balloon_page_dequeue() function can return NULL. If it does for > the first page being freed, then leak_balloon() will create a > scatter list with len=0. Which in turn seems to generate an invalid > virtio request. >

Re: [Qemu-devel] x86-64 apic panic on shutdown on 1.4.93.

2013-06-27 Thread Luiz Capitulino
On Wed, 26 Jun 2013 00:52:31 -0500 Rob Landley wrote: > I intermittently get this from current kernels running under currentish > qemu-git. Look familiar to anybody? Which kernel do you run in the host? Is the guest doing anything special? > > reboot: machine restart > general protection fau

[PATCH] virtio_balloon: update_balloon_size(): update correct field

2013-12-04 Thread Luiz Capitulino
According to the virtio spec, the device configuration field that should be updated after an inflation or deflation operation is the 'actual' field, not the 'num_pages' one. Commit 855e0c5288177bcb193f6f6316952d2490478e1c swapped them in update_balloon_size(). Fix it.

[RFC PATCH 0/4] virtio_balloon: add pressure notification via a new virtqueue

2014-01-16 Thread Luiz Capitulino
, it's added here for the convenience of someone who wants to try automatic ballooning. Patch 2/4 is a hack to make in-kernel vmpressure work for something not related to cgroups, I'll improve it in later versions. Glauber Costa (1): vmpressure: in-kernel notifications Luiz cap

[RFC PATCH 2/4] vmpressure in-kernel: hack

2014-01-16 Thread Luiz Capitulino
From: Luiz capitulino 1. Allow drivers to register private data 2. Allow drivers to pass css=NULL 3. Pass level to the callback Signed-off-by: Luiz capitulino --- include/linux/vmpressure.h | 3 ++- mm/vmpressure.c| 13 + 2 files changed, 11 insertions(+), 5 deletions

[RFC PATCH 1/4] vmpressure: in-kernel notifications

2014-01-16 Thread Luiz Capitulino
Pekka Enberg Reviewed-by: Greg Thelen Cc: Dave Chinner Cc: John Stultz Cc: Andrew Morton Cc: Joonsoo Kim Cc: Michal Hocko Cc: Kamezawa Hiroyuki Cc: Johannes Weiner Signed-off-by: Luiz capitulino --- include/linux/vmpressure.h | 5 + mm/vmpressure.c

[RFC PATCH 3/4] virtio_balloon: add pressure notification via a new virtqueue

2014-01-16 Thread Luiz Capitulino
From: Luiz capitulino This commit adds support to a new virtqueue called message virtqueue. The message virtqueue can be used by guests to notify the host about important memory-related state changes in the guest. Currently, the only implemented notification is the "guest is under pressure

[RFC PATCH 4/4] virtio_balloon: skip inflation if guest is under pressure

2014-01-16 Thread Luiz Capitulino
From: Luiz capitulino This is necessary for automatic ballooning. If the guest gets under pressure while there's an on-going inflation operation, we want the guest to do the following: 1. Stop on-going inflation 2. Notify the host we're under pressure 3. Wait for host's ack

[RFC PATCH] balloon: add automatic ballooning support

2014-01-16 Thread Luiz Capitulino
both, which I guess means automatic balloon is not regressing this - vm-up did swap a bit, not sure if this is a problem Now the code, and I think I deserve a coffee after having wrote all this stuff... Signed-off-by: Luiz capitulino --- hw/virtio/virtio-balloon.c | 180 +

Re: [RFC PATCH 3/4] virtio_balloon: add pressure notification via a new virtqueue

2014-01-16 Thread Luiz Capitulino
On Fri, 17 Jan 2014 09:10:47 +1030 Rusty Russell wrote: > Luiz Capitulino writes: > > From: Luiz capitulino > > > > This commit adds support to a new virtqueue called message virtqueue. > > OK, this needs a lot of thought (especially since reworking the virtio &g

  1   2   >