Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-02 Thread John Fastabend
On 2/1/2012 11:24 PM, Michael S. Tsirkin wrote: > On Sun, Nov 20, 2011 at 08:30:24AM -0800, Roopa Prabhu wrote: >> >> >> >> On 11/17/11 4:15 PM, "Ben Hutchings" wrote: >> >>> Sorry to come to this rather late. >>> >>> On Tue, 2011-11-08 at 23:55 -0800, Roopa Prabhu wrote: >>> [...] v2 -> v3 >

Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-02 Thread John Fastabend
On 2/2/2012 12:50 AM, Michael S. Tsirkin wrote: > On Thu, Feb 02, 2012 at 12:46:57AM -0800, John Fastabend wrote: >> On 2/1/2012 11:24 PM, Michael S. Tsirkin wrote: >>> On Sun, Nov 20, 2011 at 08:30:24AM -0800, Roopa Prabhu wrote: >>>> >>>> >>>

Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-02 Thread John Fastabend
On 2/2/2012 10:07 AM, Roopa Prabhu wrote: > > > > On 2/2/12 12:46 AM, "John Fastabend" wrote: > >> On 2/1/2012 11:24 PM, Michael S. Tsirkin wrote: >>> On Sun, Nov 20, 2011 at 08:30:24AM -0800, Roopa Prabhu wrote: >>>> >&g

Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-02 Thread John Fastabend
On 2/2/2012 12:38 PM, Ben Hutchings wrote: > On Thu, 2012-02-02 at 00:46 -0800, John Fastabend wrote: > [...] >> OK finally got to read through this. And its not clear to me why we need >> these per VF/PF filter netdevice ops and netlink extensions if we can >> get the s

Re: [net-next RFC V4 PATCH 0/4] Multiqueue virtio-net

2012-06-25 Thread John Fastabend
On 6/25/2012 3:07 AM, Michael S. Tsirkin wrote: On Mon, Jun 25, 2012 at 05:16:48PM +0800, Jason Wang wrote: Hello All: This series is an update version of multiqueue virtio-net driver based on Krishna Kumar's work to let virtio-net use multiple rx/tx queues to do the packets reception and trans

Re: [net-next-2.6 PATCH 0/6 v4] macvlan: MAC Address filtering support for passthru mode

2012-02-08 Thread John Fastabend
On 2/5/2012 8:54 AM, Roopa Prabhu wrote: > > > > On 2/3/12 7:32 AM, "Roopa Prabhu" wrote: > >> >> >> >> On 2/2/12 10:58 AM, "John Fastabend" wrote: > .. > >>> Are you sure they will be good to have? I'm not so

[RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-08 Thread John Fastabend
t the bridge case. http://lists.openwall.net/netdev/2011/11/08/135 Signed-off-by: John Fastabend --- include/linux/netdev_features.h |2 ++ net/bridge/br_fdb.c | 34 ++ 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/include/linux/net

[RFC PATCH v0 2/2] ixgbe: add NETIF_F_HW_FDB to supported flags

2012-02-08 Thread John Fastabend
Signed-off-by: John Fastabend --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 35 + 1 files changed, 24 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index ecc46ce..66261

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-09 Thread John Fastabend
On 2/8/2012 8:36 PM, Stephen Hemminger wrote: > On Wed, 08 Feb 2012 19:22:06 -0800 > John Fastabend wrote: > >> Propagate software FDB table into hardware uc, mc lists when >> the NETIF_F_HW_FDB is set. >> >> This resolves the case below where an embedded sw

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-09 Thread John Fastabend
On 2/9/2012 9:40 AM, Stephen Hemminger wrote: > On Thu, 09 Feb 2012 09:36:47 -0800 > John Fastabend wrote: > >> But the device features makes it easy for user space to learn that the device >> supports this sort of offload. Now if all SR-IOV devices support this then it &g

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-09 Thread John Fastabend
On 2/9/2012 10:14 AM, Sridhar Samudrala wrote: > On Wed, 2012-02-08 at 19:22 -0800, John Fastabend wrote: >> Propagate software FDB table into hardware uc, mc lists when >> the NETIF_F_HW_FDB is set. >> >> This resolves the case below where an embedded switch is used &g

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-09 Thread John Fastabend
On 2/9/2012 4:39 PM, Sridhar Samudrala wrote: > On Thu, 2012-02-09 at 12:30 -0800, John Fastabend wrote: >> On 2/9/2012 10:14 AM, Sridhar Samudrala wrote: >>> On Wed, 2012-02-08 at 19:22 -0800, John Fastabend wrote: >>>> Propagate software FDB table into hardw

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-09 Thread John Fastabend
On 2/9/2012 1:11 PM, jamal wrote: > On Thu, 2012-02-09 at 09:52 -0800, John Fastabend wrote: > >>>> By netlink_notifier do you mean adding a notifier_block and using >>>> atomic_notifier_call_chain() >>>> probably in rtnl_notify()? Then drivers could r

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-09 Thread John Fastabend
On 2/9/2012 6:14 PM, John Fastabend wrote: > On 2/9/2012 1:11 PM, jamal wrote: >> On Thu, 2012-02-09 at 09:52 -0800, John Fastabend wrote: >> >>>>> By netlink_notifier do you mean adding a notifier_block and using >>>>> atomic_notifier_call_chain()

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-13 Thread John Fastabend
your embedded switch > could do ACLs, IPv4 forwarding etc. And the kernel bloats. > I am always bigoted to move all policy control to user space instead of > bloating in the kernel. > > > On Thu, 2012-02-09 at 20:14 -0800, John Fastabend wrote: > >>> >>> Hi Jam

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-14 Thread John Fastabend
On 2/14/2012 5:18 AM, jamal wrote: > On Mon, 2012-02-13 at 07:13 -0800, John Fastabend wrote: > >> The use case here is multiple VFs but the same solution should work with >> multiple PFs as well. FDB controls should be independent of how the ports >> are exposed VF

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-14 Thread John Fastabend
On 2/14/2012 11:05 AM, Stephen Hemminger wrote: > On Tue, 14 Feb 2012 10:57:04 -0800 > John Fastabend wrote: > >> On 2/14/2012 5:18 AM, jamal wrote: >>> On Mon, 2012-02-13 at 07:13 -0800, John Fastabend wrote: >>> >>>> The use case here is multip

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-15 Thread John Fastabend
On 2/15/2012 6:10 AM, Jamal Hadi Salim wrote: > On Tue, 2012-02-14 at 10:57 -0800, John Fastabend wrote: > >> Roopa was likely on the right track here, >> >> http://patchwork.ozlabs.org/patch/123064/ > > Doesnt seem related to the bridging stuff - the modeling looks

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-17 Thread John Fastabend
On 2/17/2012 6:28 AM, jamal wrote: > On Wed, 2012-02-15 at 17:26 -0800, John Fastabend wrote: >> On 2/15/2012 6:10 AM, Jamal Hadi Salim wrote: >>> On Tue, 2012-02-14 at 10:57 -0800, John Fastabend wrote: >>> >>>> Roopa was likely on the right track here, >

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-28 Thread John Fastabend
On 2/18/2012 4:41 AM, jamal wrote: > On Fri, 2012-02-17 at 09:10 -0800, John Fastabend wrote: > >> Yes I agree that is the goal. >> >>> One last comment: >>> With synchronization there are other challenges when the entry in the >>> hardware conflicts w

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-28 Thread John Fastabend
On 2/28/2012 8:40 PM, John Fastabend wrote: > On 2/18/2012 4:41 AM, jamal wrote: >> On Fri, 2012-02-17 at 09:10 -0800, John Fastabend wrote: >> >>> Yes I agree that is the goal. >>> >>>> One last comment: >>>> With synchronization there

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-29 Thread John Fastabend
On 2/29/2012 5:56 AM, Jamal Hadi Salim wrote: > On Tue, 2012-02-28 at 20:40 -0800, John Fastabend wrote: > >> OK back to this. The last piece is where to put these messages... >> we could take PF_ROUTE:RTM_*NEIGH >> >> PF_ROUTE:RTM_NEWNEIGH - Add a

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-29 Thread John Fastabend
On 2/29/2012 9:52 AM, Stephen Hemminger wrote: > On Wed, 29 Feb 2012 09:25:56 -0800 > John Fastabend wrote: > >> On 2/29/2012 5:56 AM, Jamal Hadi Salim wrote: >>> On Tue, 2012-02-28 at 20:40 -0800, John Fastabend wrote: >>> >>>> OK back to this.

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-03-01 Thread John Fastabend
On 3/1/2012 6:14 AM, Michael S. Tsirkin wrote: > On Wed, Feb 29, 2012 at 09:25:56AM -0800, John Fastabend wrote: >> Agreed. I think adding some ndo_ops for bridging offloads here would >> work. For example the DSA infrastructure and/or macvlan devices might >> need thi

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-03-01 Thread John Fastabend
On 3/1/2012 5:36 AM, Jamal Hadi Salim wrote: > On Wed, 2012-02-29 at 10:19 -0800, John Fastabend wrote: > >>> >>> I want to see a unified API so that user space control applications (RSTP, >>> TRILL?) >>> can use one set of netlink calls for both s

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-03-05 Thread John Fastabend
On 3/5/2012 8:53 AM, Lennert Buytenhek wrote: > On Tue, Feb 28, 2012 at 08:40:06PM -0800, John Fastabend wrote: > >> Also if there are embedded switches with learning capabilities they >> might want to trigger events to user space. In this case having >> a protocol typ

[RFC PATCH v1 0/4] net: bridge: FDB management

2012-03-09 Thread John Fastabend
eedback is appreciated! --- John Fastabend (4): ixgbe: enable FDB netdevice ops net: add fdb generic dump routine net: addr_list: add exclusive dev_uc_add net: add generic PF_BRIDGE:RTM_XXX FDB hooks drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 59 include/linux/n

[RFC PATCH v1 2/4] net: addr_list: add exclusive dev_uc_add

2012-03-09 Thread John Fastabend
lists. Signed-off-by: John Fastabend --- include/linux/netdevice.h |1 + net/core/dev_addr_lists.c | 19 +++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 3963992..7e4a86f 100644 --- a/include

[RFC PATCH v1 3/4] net: add fdb generic dump routine

2012-03-09 Thread John Fastabend
This adds a generic dump routine drivers can call. It should be sufficient to handle any bridging model that uses the unicast address list. This should be most SR-IOV enabled NICs. Signed-off-by: John Fastabend --- net/core/rtnetlink.c | 56

[RFC PATCH v1 4/4] ixgbe: enable FDB netdevice ops

2012-03-09 Thread John Fastabend
Enable FDB ops on ixgbe when in SR-IOV mode. Signed-off-by: John Fastabend --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 59 + 1 files changed, 59 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet

[RFC PATCH v1 1/4] net: add generic PF_BRIDGE:RTM_ FDB hooks

2012-03-09 Thread John Fastabend
published as an RFC here and will be renamed 'bridge' http://patchwork.ozlabs.org/patch/117664/ Signed-off-by: John Fastabend --- include/linux/neighbour.h |3 + include/linux/netdevice.h | 26 include/linux/rtnetlink.h |4 + net/bridge/br_device.c|3 + n

Re: [RFC PATCH v1 4/4] ixgbe: enable FDB netdevice ops

2012-03-09 Thread John Fastabend
On 3/9/2012 7:48 PM, Stephen Hemminger wrote: > >> Enable FDB ops on ixgbe when in SR-IOV mode. >> >> Signed-off-by: John Fastabend > > Will all this break anything on the vf client? What if the vf is running > a bridge. No shouldn't break anything. Actuall

[net-next PATCH v0 0/5] Series short description

2012-03-19 Thread John Fastabend
always any comments/feedback appreciated! --- John Fastabend (5): ixgbe: allow RAR table to be updated in promisc mode ixgbe: enable FDB netdevice ops net: add fdb generic dump routine net: addr_list: add exclusive dev_uc_add net: add generic PF_BRIDGE:RTM_XXX

[net-next PATCH v0 2/5] net: addr_list: add exclusive dev_uc_add

2012-03-19 Thread John Fastabend
lists. Signed-off-by: John Fastabend --- include/linux/netdevice.h |1 + net/core/dev_addr_lists.c | 19 +++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 4208901..5e43cec 100644 --- a/include

[net-next PATCH v0 3/5] net: add fdb generic dump routine

2012-03-19 Thread John Fastabend
This adds a generic dump routine drivers can call. It should be sufficient to handle any bridging model that uses the unicast address list. This should be most SR-IOV enabled NICs. Signed-off-by: John Fastabend --- net/core/rtnetlink.c | 56

[net-next PATCH v0 4/5] ixgbe: enable FDB netdevice ops

2012-03-19 Thread John Fastabend
Enable FDB ops on ixgbe when in SR-IOV mode. Signed-off-by: John Fastabend --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 59 + 1 files changed, 59 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet

[net-next PATCH v0 5/5] ixgbe: allow RAR table to be updated in promisc mode

2012-03-19 Thread John Fastabend
This allows RAR table updates while in promiscuous. With SR-IOV enabled it is valuable to allow the RAR table to be updated even when in promisc mode to configure forwarding Signed-off-by: John Fastabend --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 21 +++-- 1 files

[net-next PATCH v0 1/5] net: add generic PF_BRIDGE:RTM_ FDB hooks

2012-03-19 Thread John Fastabend
ere and will be renamed 'bridge' http://patchwork.ozlabs.org/patch/117664/ Thanks to Jamal Hadi Salim, Stephen Hemminger and Ben Hutchings for valuable feedback, suggestions, and review. Signed-off-by: John Fastabend --- include/linux/neighbour.h |3 + include/linux/netdevic

Re: [net-next PATCH v0 0/5] Series short description

2012-03-19 Thread John Fastabend
On 3/19/2012 3:55 PM, Stephen Hemminger wrote: > On Mon, 19 Mar 2012 18:38:08 -0400 (EDT) > David Miller wrote: > >> From: John Fastabend >> Date: Sun, 18 Mar 2012 23:51:45 -0700 >> >>> This series is a follow up to this thread: >>> >>&

Re: [net-next PATCH v0 0/5] Series short description

2012-03-19 Thread John Fastabend
On 3/19/2012 5:35 PM, David Miller wrote: > From: John Fastabend > Date: Mon, 19 Mar 2012 17:27:00 -0700 > >> Dave, its probably fine to push this to 3.5 then. > > Fair enough. Stephen, please let me know if you see any issues though because without these we have no w

Re: [net-next PATCH v0 3/5] net: add fdb generic dump routine

2012-03-26 Thread John Fastabend
On 3/25/2012 6:09 AM, Roopa Prabhu wrote: > > > > On 3/18/12 11:52 PM, "John Fastabend" wrote: > >> This adds a generic dump routine drivers can call. It >> should be sufficient to handle any bridging model that >> uses the unicast address list.

Re: [RFC PATCH 0/2] make mac programming for virtio net more robust

2013-01-11 Thread John Fastabend
On 1/10/2013 11:46 PM, Michael S. Tsirkin wrote: On Fri, Jan 11, 2013 at 12:53:07PM +1030, Rusty Russell wrote: "Michael S. Tsirkin" writes: On Thu, Jan 10, 2013 at 10:45:39PM +0800, ak...@redhat.com wrote: From: Amos Kong Currenly mac is programmed byte by byte. This means that we have an