Re: [PATCH -tip -v10 5/7] x86: add pt_regs register and stack access APIs

2009-07-05 Thread Frederic Weisbecker
rom v9: > -Fix a typo in a comment. > > Signed-off-by: Masami Hiramatsu > Cc: Christoph Hellwig > Cc: Steven Rostedt > Cc: Ananth N Mavinakayanahalli > Cc: Ingo Molnar > Cc: Frederic Weisbecker > Cc: Roland McGrath > Cc: Srikar Dronamraju > Cc: linux-a...@vger.kern

Re: [PATCH -tip -v10 6/7] tracing: ftrace dynamic ftrace_event_call support

2009-07-05 Thread Frederic Weisbecker
use these > functions may be shared among several ftrace_event_calls. > > Signed-off-by: Masami Hiramatsu > Cc: Steven Rostedt > Cc: Ingo Molnar > Cc: Tom Zanussi > Cc: Frederic Weisbecker Looks good too. Acked-by: Frederic Weisbecker > --- > &g

Re: [PATCH -tip -v10 7/7] tracing: add kprobe-based event tracer

2009-07-07 Thread Frederic Weisbecker
TCHARG +|- offs address. > > See Documentation/trace/kprobes.txt for details. > > Changes from v9: > - Select CONFIG_GENERIC_TRACER when CONFIG_KPROBE_TRACER=y. > > Signed-off-by: Masami Hiramatsu > Acked-by: Ananth N Mavinakayanahalli > Cc:

Re: [PATCH -tip -v10 7/7] tracing: add kprobe-based event tracer

2009-07-07 Thread Frederic Weisbecker
On Tue, Jul 07, 2009 at 03:55:28PM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: > >> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h > >> index 206cb7d..65945eb 100644 > >> --- a/kernel/trace/trace.h > >> +++ b/kernel/trace/trace.h

Re: [PATCH -tip -v10 7/7] tracing: add kprobe-based event tracer

2009-07-07 Thread Frederic Weisbecker
On Tue, Jul 07, 2009 at 04:42:32PM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: > > On Tue, Jul 07, 2009 at 03:55:28PM -0400, Masami Hiramatsu wrote: > >> Frederic Weisbecker wrote: > >>>> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h >

Re: [PATCH -tip -v10 7/7] tracing: add kprobe-based event tracer

2009-07-07 Thread Frederic Weisbecker
On Tue, Jul 07, 2009 at 05:31:25PM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: > > On Tue, Jul 07, 2009 at 04:42:32PM -0400, Masami Hiramatsu wrote: > >> Frederic Weisbecker wrote: > >>> On Tue, Jul 07, 2009 at 03:55:28PM -0400, Masami Hiramatsu wro

Re: [PATCH 1/3] perf: add context field to perf_event

2011-06-29 Thread Frederic Weisbecker
On Wed, Jun 29, 2011 at 06:42:35PM +0300, Avi Kivity wrote: > The perf_event overflow handler does not receive any caller-derived > argument, so many callers need to resort to looking up the perf_event > in their local data structure. This is ugly and doesn't scale if a > single callback services

Re: [PATCH 1/3] perf: add context field to perf_event

2011-07-04 Thread Frederic Weisbecker
On Wed, Jun 29, 2011 at 05:27:25PM +0100, Will Deacon wrote: > Hi Frederic, > > Thanks for including me on CC. > > On Wed, Jun 29, 2011 at 05:08:45PM +0100, Frederic Weisbecker wrote: > > On Wed, Jun 29, 2011 at 06:42:35PM +0300, Avi Kivity wrote: > > > The perf_e

Re: [PATCH 1/3] perf: add context field to perf_event

2011-07-04 Thread Frederic Weisbecker
On Mon, Jul 04, 2011 at 05:10:20PM +0300, Avi Kivity wrote: > On 07/04/2011 04:58 PM, Frederic Weisbecker wrote: > >Another thing I would like to do in the even longer term is to not use perf > >anymore > >for ptrace breakpoints, because that involves a heavy dependency a

Re: [PATCH 1/3] perf: add context field to perf_event

2011-07-05 Thread Frederic Weisbecker
On Tue, Jul 05, 2011 at 03:30:26PM +0100, Will Deacon wrote: > Hi Frederic, > > On Mon, Jul 04, 2011 at 02:58:24PM +0100, Frederic Weisbecker wrote: > > On Wed, Jun 29, 2011 at 05:27:25PM +0100, Will Deacon wrote: > > > Hi Frederic, > > > > > > Thanks f

Re: [PATCH 2/6] rcu: Allow rcu_user_enter()/exit() to nest

2012-07-09 Thread Frederic Weisbecker
On Sun, Jul 08, 2012 at 06:54:18PM +0300, Avi Kivity wrote: > On 07/06/2012 03:00 PM, Frederic Weisbecker wrote: > > Allow calls to rcu_user_enter() even if we are already > > in userspace (as seen by RCU) and allow calls to rcu_user_exit() > > even if we are already in the

Re: [PATCH 6/9] perf: expose perf capability to other modules.

2011-11-02 Thread Frederic Weisbecker
On Tue, Nov 01, 2011 at 10:20:04AM -0600, David Ahern wrote: > > > On 11/01/2011 10:13 AM, Gleb Natapov wrote: > > On Tue, Nov 01, 2011 at 09:49:19AM -0600, David Ahern wrote: > >> On 10/30/2011 10:53 AM, Gleb Natapov wrote: > >>> KVM needs to know perf capability to decide which PMU it can expos

Re: [PATCH 6/9] perf: expose perf capability to other modules.

2011-11-10 Thread Frederic Weisbecker
On Mon, Nov 07, 2011 at 02:45:17PM +, Will Deacon wrote: > Hi Frederic, > > On Wed, Nov 02, 2011 at 07:42:04AM +, Frederic Weisbecker wrote: > > On Tue, Nov 01, 2011 at 10:20:04AM -0600, David Ahern wrote: > > > Right. Originally it could be enabled/disabled

Re: [PATCH 6/9] perf: expose perf capability to other modules.

2011-11-15 Thread Frederic Weisbecker
On Thu, Nov 10, 2011 at 06:12:23AM -0600, Jason Wessel wrote: > On 11/10/2011 02:58 AM, Frederic Weisbecker wrote: > > On Mon, Nov 07, 2011 at 02:45:17PM +, Will Deacon wrote: > >> Hi Frederic, > >> > >> On Wed, Nov 02, 2011 at 07:42:04AM +, Frederic We

Re: [PATCH 0/4] Alter steal-time reporting in the guest

2013-02-18 Thread Frederic Weisbecker
2013/2/5 Michael Wolf : > In the case of where you have a system that is running in a > capped or overcommitted environment the user may see steal time > being reported in accounting tools such as top or vmstat. This can > cause confusion for the end user. Sorry, I'm no expert in this area. But I

Re: [PATCH 0/4] Alter steal-time reporting in the guest

2013-03-06 Thread Frederic Weisbecker
2013/2/19 Marcelo Tosatti : > On Mon, Feb 18, 2013 at 05:43:47PM +0100, Frederic Weisbecker wrote: >> 2013/2/5 Michael Wolf : >> > In the case of where you have a system that is running in a >> > capped or overcommitted environment the user may see steal time >&g

Re: [PATCH 0/4] Alter steal-time reporting in the guest

2013-03-06 Thread Frederic Weisbecker
2013/3/5 Michael Wolf : > Sorry for the delay in the response. I did not see the email > right away. > > On Mon, 2013-02-18 at 22:11 -0300, Marcelo Tosatti wrote: >> On Mon, Feb 18, 2013 at 05:43:47PM +0100, Frederic Weisbecker wrote: >> > 2013/2/5 Michael Wolf : >

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-24 Thread Frederic Weisbecker
2013/3/21 Gleb Natapov : > Isn't is simpler for kernel/context_tracking.c to define empty > __guest_enter()/__guest_exit() if !CONFIG_KVM. That doesn't look right. Off-cases are usually handled from the headers, right? So that we avoid iffdeffery ugliness in core code. -- To unsubscribe from this

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-05-15 Thread Frederic Weisbecker
On Mon, Mar 25, 2013 at 02:14:20PM -0700, Kevin Hilman wrote: > Gleb Natapov writes: > > > On Sun, Mar 24, 2013 at 02:44:26PM +0100, Frederic Weisbecker wrote: > >> 2013/3/21 Gleb Natapov : > >> > Isn't is simpler for kernel/context_tracking.c to define emp

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-05-16 Thread Frederic Weisbecker
On Thu, May 16, 2013 at 12:52:03AM +0200, Frederic Weisbecker wrote: > On Mon, Mar 25, 2013 at 02:14:20PM -0700, Kevin Hilman wrote: > > Gleb Natapov writes: > > > > > On Sun, Mar 24, 2013 at 02:44:26PM +0100, Frederic Weisbecker wrote: > > >> 2013/3/21 Gleb

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-05-17 Thread Frederic Weisbecker
On Fri, May 17, 2013 at 07:09:42AM -0700, Kevin Hilman wrote: > Frederic Weisbecker writes: > > > On Thu, May 16, 2013 at 12:52:03AM +0200, Frederic Weisbecker wrote: > >> On Mon, Mar 25, 2013 at 02:14:20PM -0700, Kevin Hilman wrote: > >> > Gleb Natapov writes

Re: [PATCH -tip v14 03/12] kprobes: checks probe address is instruction boudary on x86

2009-08-18 Thread Frederic Weisbecker
-off-by: Masami Hiramatsu > Acked-by: Ananth N Mavinakayanahalli > Cc: Avi Kivity > Cc: Andi Kleen > Cc: Christoph Hellwig > Cc: Frank Ch. Eigler > Cc: Frederic Weisbecker > Cc: H. Peter Anvin > Cc: Ingo Molnar > Cc: Jason Baron > Cc: Jim Keniston > C

Re: [PATCH -tip v14 03/12] kprobes: checks probe address is instruction boudary on x86

2009-08-18 Thread Frederic Weisbecker
On Tue, Aug 18, 2009 at 07:17:39PM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: > >> + while (addr < paddr) { > >> + kernel_insn_init(&insn, (void *)addr); > >> + insn_get_opcode(&insn); > >> + > >&g

Re: [PATCH -tip v14 03/12] kprobes: checks probe address is instruction boudary on x86

2009-08-18 Thread Frederic Weisbecker
On Tue, Aug 18, 2009 at 08:19:33PM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: > > On Tue, Aug 18, 2009 at 07:17:39PM -0400, Masami Hiramatsu wrote: > >> Frederic Weisbecker wrote: > >>>> +while (addr < paddr) { > >>>> +

Re: [PATCH -tip v14 07/12] tracing: Introduce TRACE_FIELD_ZERO() macro

2009-08-18 Thread Frederic Weisbecker
tsu > Cc: Ananth N Mavinakayanahalli > Cc: Avi Kivity > Cc: Andi Kleen > Cc: Christoph Hellwig > Cc: Frank Ch. Eigler > Cc: Frederic Weisbecker > Cc: H. Peter Anvin > Cc: Ingo Molnar > Cc: Jason Baron > Cc: Jim Keniston > Cc: K.Prasad > Cc: Lai Jiangs

Re: [PATCH -tip v14 08/12] tracing: add kprobe-based event tracer

2009-08-18 Thread Frederic Weisbecker
Hiramatsu > Acked-by: Ananth N Mavinakayanahalli > Cc: Avi Kivity > Cc: Andi Kleen > Cc: Christoph Hellwig > Cc: Frank Ch. Eigler > Cc: Frederic Weisbecker > Cc: H. Peter Anvin > Cc: Ingo Molnar > Cc: Jason Baron > Cc: Jim Keniston > Cc: K.Prasad > Cc:

Re: [PATCH -tip v14 07/12] tracing: Introduce TRACE_FIELD_ZERO() macro

2009-08-19 Thread Frederic Weisbecker
On Tue, Aug 18, 2009 at 10:20:11PM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: > > On Thu, Aug 13, 2009 at 04:35:01PM -0400, Masami Hiramatsu wrote: > >> Use TRACE_FIELD_ZERO(type, item) instead of TRACE_FIELD_ZERO_CHAR(item). > >> This also includ

Re: [PATCH -tip v14 01/12] x86: instruction decoder API

2009-08-19 Thread Frederic Weisbecker
On Thu, Aug 13, 2009 at 04:34:13PM -0400, Masami Hiramatsu wrote: > Add x86 instruction decoder to arch-specific libraries. This decoder > can decode x86 instructions used in kernel into prefix, opcode, modrm, > sib, displacement and immediates. This can also show the length of > instructions. > >

Re: [PATCH -tip v14 01/12] x86: instruction decoder API

2009-08-19 Thread Frederic Weisbecker
On Thu, Aug 20, 2009 at 01:42:31AM +0200, Frederic Weisbecker wrote: > On Thu, Aug 13, 2009 at 04:34:13PM -0400, Masami Hiramatsu wrote: > > Add x86 instruction decoder to arch-specific libraries. This decoder > > can decode x86 instructions used in kernel into prefix, opcode,

Re: [PATCH -tip v14 01/12] x86: instruction decoder API

2009-08-20 Thread Frederic Weisbecker
On Thu, Aug 20, 2009 at 10:42:05AM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: >> On Thu, Aug 13, 2009 at 04:34:13PM -0400, Masami Hiramatsu wrote: >>> Add x86 instruction decoder to arch-specific libraries. This decoder >>> can decode x86 instructions

Re: [PATCH -tip v14 01/12] x86: instruction decoder API

2009-08-20 Thread Frederic Weisbecker
On Thu, Aug 20, 2009 at 11:03:40AM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: >> On Thu, Aug 20, 2009 at 01:42:31AM +0200, Frederic Weisbecker wrote: >>> On Thu, Aug 13, 2009 at 04:34:13PM -0400, Masami Hiramatsu wrote: >>>> Add x86 instruction deco

Re: [PATCH -tip v14 01/12] x86: instruction decoder API

2009-08-20 Thread Frederic Weisbecker
On Thu, Aug 20, 2009 at 12:16:05PM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: >> On Thu, Aug 20, 2009 at 11:03:40AM -0400, Masami Hiramatsu wrote: >>> Frederic Weisbecker wrote: >>>> On Thu, Aug 20, 2009 at 01:42:31AM +0200, Frederic Weisbecker wrote:

Re: [TOOL] kprobestest : Kprobe stress test tool

2009-08-20 Thread Frederic Weisbecker
On Thu, Aug 13, 2009 at 04:57:20PM -0400, Masami Hiramatsu wrote: > This script tests kprobes to probe on all symbols in the kernel and finds > symbols which must be blacklisted. > > > Usage > - > kprobestest [-s SYMLIST] [-b BLACKLIST] [-w WHITELIST] > Run stress test. If SYMLIST file i

Re: [PATCH -tip v14 01/12] x86: instruction decoder API

2009-08-20 Thread Frederic Weisbecker
On Thu, Aug 20, 2009 at 03:01:25PM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: >> On Thu, Aug 20, 2009 at 12:16:05PM -0400, Masami Hiramatsu wrote: >>> Frederic Weisbecker wrote: >>>> On Thu, Aug 20, 2009 at 11:03:40AM -0400, Masami Hiramatsu wrote: &

Re: [PATCH tracing/kprobes 1/4] x86: Fix x86 instruction decoder selftest to check only .text

2009-08-23 Thread Frederic Weisbecker
On Fri, Aug 21, 2009 at 03:43:07PM -0400, Masami Hiramatsu wrote: > Fix x86 instruction decoder selftest to check only .text because other > sections (e.g. .notes) will have random bytes which don't need to be checked. Applied these 4 patches in git://git.kernel.org/pub/scm/linux/kernel/git/fred

Re: [TOOL] c2kpe: C expression to kprobe event format converter

2009-08-30 Thread Frederic Weisbecker
On Thu, Aug 13, 2009 at 04:59:19PM -0400, Masami Hiramatsu wrote: > This program converts probe point in C expression to kprobe event > format for kprobe-based event tracer. This helps to define kprobes > events by C source line number or function name, and local variable > name. Currently, this su

Re: [TOOL] c2kpe: C expression to kprobe event format converter

2009-08-31 Thread Frederic Weisbecker
On Mon, Aug 31, 2009 at 12:14:34AM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: > > On Thu, Aug 13, 2009 at 04:59:19PM -0400, Masami Hiramatsu wrote: > >> This program converts probe point in C expression to kprobe event > >> format for kprobe-based

Re: kvm guest: hrtimer: interrupt too slow

2009-10-07 Thread Frederic Weisbecker
(Adding Thomas in Cc) On Sat, Oct 03, 2009 at 08:12:05PM -0300, Marcelo Tosatti wrote: > Michael, > > Can you please give the patch below a try please? (without acpi_pm timer > or priority adjustments for the guest). > > On Tue, Sep 29, 2009 at 05:12:17PM +0400, Michael Tokarev wrote: > > Hell

Re: kvm guest: hrtimer: interrupt too slow

2009-10-09 Thread Frederic Weisbecker
On Sat, Oct 10, 2009 at 01:22:16AM +0400, Michael Tokarev wrote: > Marcelo Tosatti wrote: > [snip] > >> Would be useful to collect sar (sar -B -b -u) output every one second >> in both host/guest. You already mentioned load was low, but this should >> give more details. > > Here we go: http://www.

Re: kvm guest: hrtimer: interrupt too slow

2009-10-10 Thread Frederic Weisbecker
On Sat, Oct 10, 2009 at 01:18:16PM +0400, Michael Tokarev wrote: > Michael Tokarev wrote: >> Frederic Weisbecker wrote: > [] >>>>> Was there swapping going on? >>>> Not as far as I can see, and sar output agrees. >>> >>> But I can read th

Re: [PATCH -tip 2/6 V4] x86: add arch-dep register and stack access API to ptrace

2009-04-02 Thread Frederic Weisbecker
t; - get_stack_nth(struct pt_regs *reg, unsigned nth) >Get Nth entry of the stack. (N >= 0) > > - get_argument_nth(struct pt_regs *reg, unsigned nth) >Get Nth argument at function call. (N >= 0) > > Signed-off-by: Masami Hiramatsu > Cc: Steven Rostedt > Cc: Ananth N

Re: [PATCH -tip v5 4/7] tracing: add kprobe-based event tracer

2009-05-11 Thread Frederic Weisbecker
On Sat, May 09, 2009 at 01:33:53PM -0400, Masami Hiramatsu wrote: > Frédéric Weisbecker wrote: > > Hi, > > > > 2009/5/9 Masami Hiramatsu : > [...] > >> + > >> +/* event recording functions */ > >> +static void kprobe_trace_record(unsigned long ip, struct trace_probe *tp, > >> +

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-18 Thread Frederic Weisbecker
On Thu, Mar 18, 2010 at 12:32:51PM +0200, Avi Kivity wrote: > By "serious developer" I mean > > - someone who is interested in contributing, not in getting their name > into the kernel commits list > - someone who is willing to read the wiki page and find out where the > repository and mailin

Re: ftrace/perf_event leak

2010-09-01 Thread Frederic Weisbecker
On Wed, Sep 01, 2010 at 01:02:57PM +0200, Peter Zijlstra wrote: > On Wed, 2010-09-01 at 13:38 +0300, Avi Kivity wrote: > > On 09/01/2010 12:38 PM, Li Zefan wrote: > > > > > > Then try this: > > > > Tested-by: Avi Kivity > > > > Thanks, queued as: > > --- > Subject: perf, trace: Fix module leak

Re: [RFC/PATCH 1/1] s390/kvm: Fix BUG in include/linux/kvm_host.h:745

2013-01-08 Thread Frederic Weisbecker
that no preemption happens during kvm_guest_enter. > We can enable preemption again after the call to > rcu_virt_note_context_switch returns. > > Please note that we continue to run s390 guests with interrupts > enabled. > > CC: Frederic Weisbecker > CC: Gleb Natapov > Signed-off-

Re: [PATCH v2 0/5] rcu,nohz,kvm: use RCU extended quiescent state when running KVM guest

2015-02-06 Thread Frederic Weisbecker
On Thu, Feb 05, 2015 at 03:23:47PM -0500, r...@redhat.com wrote: > When running a KVM guest on a system with NOHZ_FULL enabled I just need to clarify the motivation first, does the above situation really happen? Ok some distros enable NOHZ_FULL to let the user stop the tick in userspace. So most o

Re: [PATCH 1/5] rcu,nohz: add state parameter to context_tracking_user_enter/exit

2015-02-06 Thread Frederic Weisbecker
On Thu, Feb 05, 2015 at 03:23:48PM -0500, r...@redhat.com wrote: > From: Rik van Riel > > Add the expected ctx_state as a parameter to context_tracking_user_enter > and context_tracking_user_exit, allowing the same functions to not just > track kernel <> user space switching, but also kernel <> g

Re: [PATCH 4/5] kvm,rcu,nohz: use RCU extended quiescent state when running KVM guest

2015-02-06 Thread Frederic Weisbecker
On Thu, Feb 05, 2015 at 03:23:51PM -0500, r...@redhat.com wrote: > From: Rik van Riel > > The host kernel is not doing anything while the CPU is executing > a KVM guest VCPU, so it can be marked as being in an extended > quiescent state, identical to that used when running user space > code. > >

Re: [PATCH v2 0/5] rcu,nohz,kvm: use RCU extended quiescent state when running KVM guest

2015-02-06 Thread Frederic Weisbecker
On Fri, Feb 06, 2015 at 09:56:43AM -0500, Rik van Riel wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/06/2015 08:46 AM, Frederic Weisbecker wrote: > > On Thu, Feb 05, 2015 at 03:23:47PM -0500, r...@redhat.com wrote: > >> When running a KVM guest

Re: [PATCH v2 0/5] rcu,nohz,kvm: use RCU extended quiescent state when running KVM guest

2015-02-06 Thread Frederic Weisbecker
On Fri, Feb 06, 2015 at 02:50:44PM +0100, Paolo Bonzini wrote: > > > On 06/02/2015 14:46, Frederic Weisbecker wrote: > > > When running a KVM guest on a system with NOHZ_FULL enabled > > > > I just need to clarify the motivation first, does the above situation >

Re: [PATCH v2 0/5] rcu,nohz,kvm: use RCU extended quiescent state when running KVM guest

2015-02-06 Thread Frederic Weisbecker
On Fri, Feb 06, 2015 at 04:00:27PM +0100, Christian Borntraeger wrote: > Am 05.02.2015 um 21:23 schrieb r...@redhat.com: > > When running a KVM guest on a system with NOHZ_FULL enabled, and the > > KVM guest running with idle=poll mode, we still get wakeups of the > > rcuos/N threads. > > > > This

Re: [PATCH 1/5] rcu,nohz: add state parameter to context_tracking_user_enter/exit

2015-02-06 Thread Frederic Weisbecker
On Fri, Feb 06, 2015 at 01:20:21PM -0500, Rik van Riel wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/06/2015 12:22 PM, Frederic Weisbecker wrote: > > On Thu, Feb 05, 2015 at 03:23:48PM -0500, r...@redhat.com wrote: > >> From: Rik van Riel

Re: [PATCH 1/5] rcu,nohz: add state parameter to context_tracking_user_enter/exit

2015-02-06 Thread Frederic Weisbecker
On Fri, Feb 06, 2015 at 01:51:56PM -0500, Rik van Riel wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/06/2015 01:23 PM, Frederic Weisbecker wrote: > > On Fri, Feb 06, 2015 at 01:20:21PM -0500, Rik van Riel wrote: On > > 02/06/2015 12:22 PM, Frederic Wei

Re: [PATCH 4/5] kvm,rcu,nohz: use RCU extended quiescent state when running KVM guest

2015-02-06 Thread Frederic Weisbecker
On Thu, Feb 05, 2015 at 03:23:51PM -0500, r...@redhat.com wrote: > From: Rik van Riel > > The host kernel is not doing anything while the CPU is executing > a KVM guest VCPU, so it can be marked as being in an extended > quiescent state, identical to that used when running user space > code. > >

Re: [PATCH 1/5] rcu,nohz: add state parameter to context_tracking_user_enter/exit

2015-02-07 Thread Frederic Weisbecker
; > > > > On 02/06/2015 06:15 PM, Frederic Weisbecker wrote: > > > > > > > Just a few things then: > > > > > > > > 1) In this case rename context_tracking_user_enter/exit() to > > > > context_tracking_enter() and context_tracking_ex

Re: [PATCH -v3 0/6] rcu,nohz,kvm: use RCU extended quiescent state when running KVM guest

2015-02-09 Thread Frederic Weisbecker
On Mon, Feb 09, 2015 at 08:22:59PM -0500, Rik van Riel wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/09/2015 08:15 PM, Will Deacon wrote: > > Hi Rik, > > > > On Mon, Feb 09, 2015 at 04:04:38PM +, r...@redhat.com wrote: > >> Apologies to Catalin and Will for not fixing up

Re: [PATCH 1/6] rcu,nohz: add context_tracking_user_enter/exit wrapper functions

2015-02-10 Thread Frederic Weisbecker
On Tue, Feb 10, 2015 at 09:41:45AM -0500, r...@redhat.com wrote: > From: Rik van Riel > > These wrapper functions allow architecture code (eg. ARM) to keep > calling context_tracking_user_enter & context_tracking_user_exit > the same way it always has, without error prone tricks like duplicate >

Re: [PATCH 1/6] rcu,nohz: add context_tracking_user_enter/exit wrapper functions

2015-02-10 Thread Frederic Weisbecker
On Tue, Feb 10, 2015 at 09:25:26AM -0800, Paul E. McKenney wrote: > On Tue, Feb 10, 2015 at 11:48:37AM -0500, Rik van Riel wrote: > > On 02/10/2015 10:28 AM, Frederic Weisbecker wrote: > > > On Tue, Feb 10, 2015 at 09:41:45AM -0500, r...@redhat.com wrote: > &g

Re: [PATCH -v5 6/5] context_tracking: fix exception_enter when already in IN_KERNEL

2015-02-12 Thread Frederic Weisbecker
On Wed, Feb 11, 2015 at 02:43:19PM -0500, Rik van Riel wrote: > If exception_enter happens when already in IN_KERNEL state, the > code still calls context_tracking_exit, which ends up in > rcu_eqs_exit_common, which explodes with a WARN_ON when it is > called in a situation where dynticks are not e

Re: [PATCH -v5 6/5] context_tracking: fix exception_enter when already in IN_KERNEL

2015-02-12 Thread Frederic Weisbecker
On Thu, Feb 12, 2015 at 10:47:10AM -0500, Rik van Riel wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/12/2015 10:42 AM, Frederic Weisbecker wrote: > > On Wed, Feb 11, 2015 at 02:43:19PM -0500, Rik van Riel wrote: > >> If exception_enter happens when

Re: [PATCH -v5 0/5] rcu,nohz,kvm: use RCU extended quiescent state when running KVM guest

2015-02-12 Thread Frederic Weisbecker
; > Thanks to Christian Borntraeger, Paul McKenney, Paulo Bonzini, > Frederic Weisbecker, and Will Deacon for reviewing and improving > earlier versions of this patch series. > So the patchset look good, thanks everyone. I'm applying the series and will see anything explode. I&#