Re: [PATCH v3 2/9] KVM-HDR Add constant to represent KVM MSRs enabled bit

2011-06-29 Thread Eric B Munson
; CC: Rik van Riel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson My mail provider seems to have dropped patch 1 of the series so I can't reply directly to it, please add my Tested-by there as well. Tested-by: Eric

Re: [PATCH v3 3/9] KVM-HDR: KVM Steal time implementation

2011-06-29 Thread Eric B Munson
rt the kernel part but not the > hypervisor, or the other way around. > > Signed-off-by: Glauber Costa > CC: Rik van Riel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson Tested-by: Eric B Munson signature.asc Description: Digital signature

Re: [PATCH v3 4/9] KVM-HV: KVM Steal time implementation

2011-06-29 Thread Eric B Munson
o people who wants to backport the kernel > part but not the hypervisor, or the other way around. > > Signed-off-by: Glauber Costa > CC: Rik van Riel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson Tested

Re: [PATCH v3 5/9] KVM-HV: use schedstats to calculate steal time

2011-06-29 Thread Eric B Munson
iel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson > CC: Marcelo Tosatti Tested-by: Eric B Munson signature.asc Description: Digital signature

Re: [PATCH v3 6/9] KVM-GST: Add a pv_ops stub for steal time

2011-06-29 Thread Eric B Munson
tra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson Tested-by: Eric B Munson signature.asc Description: Digital signature

Re: [PATCH v3 7/9] KVM-GST: KVM Steal time accounting

2011-06-29 Thread Eric B Munson
t; CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson Tested-by: Eric B Munson signature.asc Description: Digital signature

Re: [PATCH v3 8/9] KVM-GST: adjust scheduler cpu power

2011-06-29 Thread Eric B Munson
; would wrongly think that all cpus have the same ability to run processes, > lowering the overall throughput. > > Signed-off-by: Glauber Costa > CC: Rik van Riel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson

Re: [PATCH v3 9/9] KVM-GST: KVM Steal time registration

2011-06-29 Thread Eric B Munson
Riel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson Tested-by: Eric B Munson signature.asc Description: Digital signature

Re: [PATCH v3 2/9] KVM-HDR Add constant to represent KVM MSRs enabled bit

2011-06-30 Thread Eric B Munson
On Thu, 30 Jun 2011, Avi Kivity wrote: > On 06/30/2011 12:56 AM, Eric B Munson wrote: > >My mail provider seems to have dropped patch 1 of the series so I can't reply > >directly to it, please add my Tested-by there as well. > > How did you test it then? > I buil

Re: [PATCH v3 2/9] KVM-HDR Add constant to represent KVM MSRs enabled bit

2011-06-30 Thread Eric B Munson
On Thu, 30 Jun 2011, Glauber Costa wrote: > On 06/30/2011 09:59 AM, Eric B Munson wrote: > >On Thu, 30 Jun 2011, Avi Kivity wrote: > > > >>On 06/30/2011 12:56 AM, Eric B Munson wrote: > >>>My mail provider seems to have dropped patch 1 of the series so I c

Re: [PATCH v5 3/9] KVM-HDR: KVM Steal time implementation

2011-07-05 Thread Eric B Munson
rt the kernel part but not the > hypervisor, or the other way around. > > Signed-off-by: Glauber Costa > CC: Rik van Riel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson Tested-by: Eric B Munson signature.asc Description: Digital signature

Re: [PATCH v5 2/9] KVM-HDR Add constant to represent KVM MSRs enabled bit

2011-07-05 Thread Eric B Munson
; CC: Rik van Riel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson Tested-by: Eric B Munson signature.asc Description: Digital signature

Re: [PATCH v5 4/9] KVM-HV: KVM Steal time implementation

2011-07-05 Thread Eric B Munson
itzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson Tested-by: Eric B Munson signature.asc Description: Digital signature

Re: [PATCH v5 5/9] KVM-GST: Add a pv_ops stub for steal time

2011-07-05 Thread Eric B Munson
e code to be easily bypassed when not > in use. > > Signed-off-by: Glauber Costa > CC: Rik van Riel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson Tested-by: Eric B Munson signature.asc Description: Digital signature

Re: [PATCH v5 6/9] add jump labels for ia64 paravirt

2011-07-05 Thread Eric B Munson
Costa > CC: Isaku Yamahata > CC: Eddie Dong > CC: Rik van Riel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson Tested-by: Eric B Munson signature.asc Description: Digital signature

Re: [PATCH v5 7/9] KVM-GST: KVM Steal time accounting

2011-07-05 Thread Eric B Munson
uber Costa > CC: Rik van Riel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson Tested-by: Eric B Munson signature.asc Description: Digital signature

Re: [PATCH v5 8/9] KVM-GST: adjust scheduler cpu power

2011-07-05 Thread Eric B Munson
steal_time_rq. This is because otherwise, information about time > accounted in update_process_tick() would never reach us in update_rq_clock(). > > Signed-off-by: Glauber Costa > CC: Rik van Riel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Ant

Re: [PATCH v5 9/9] KVM-GST: KVM Steal time registration

2011-07-05 Thread Eric B Munson
d to survive cpu offlining/onlining. > > Signed-off-by: Glauber Costa > CC: Rik van Riel > CC: Jeremy Fitzhardinge > CC: Peter Zijlstra > CC: Avi Kivity > CC: Anthony Liguori > CC: Eric B Munson Tested-by: Eric B Munson signature.asc Description: Digital signature

Re: [PATCH v5 1/9] introduce kvm_read_guest_cached

2011-07-05 Thread Eric B Munson
: Glauber Costa Tested-by: Eric B Munson signature.asc Description: Digital signature

[RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped by host

2011-08-03 Thread Eric B Munson
cleared and the soft lockup message is skipped. This currently breaks the build for non-x86 architectures but part of what I am looking for here is how to go about adding the function stubs for everything else. Eric B Munson (3): Add flag to indicate that a vm was stopped by the host Add

[RFC PATCH 1/3] Add flag to indicate that a vm was stopped by the host

2011-08-03 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. Signed-off-by: Eric B Munson --- arch/x86/include/asm/pvclock-abi.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/include/asm/pvclock-abi.h b/arch/x86/include

[RFC PATCH 2/3] Add functions to check if the host has stopped the vm

2011-08-03 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson --- arch/x86/include/asm/pvclock.h |3 +++ arch/x86/kernel/kvmclock.c | 12

[RFC PATCH 3/3] Add check for suspended vm in softlockup detector

2011-08-03 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. Signed-off-by: Eric B Munson --- kernel/watchdog.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions

Re: KVM: x86: fix pvclock guest stopped flag reporting (v2)

2012-08-07 Thread Eric B Munson
On 2012-08-03 14:57, Marcelo Tosatti wrote: kvm_guest_time_update unconditionally clears hv_clock.flags field, so the notification never reaches the guest. Fix it by allowing PVCLOCK_GUEST_STOPPED to passthrough. Signed-off-by: Marcelo Tosatti Reviewed-by: Eric B Munson -- To unsubscribe

[PATCH 3/4] Add generic stubs for kvm stop check functions

2011-08-29 Thread Eric B Munson
This function is called from the watchdog code when a soft lockup is detected. If this is an arch that does not support pvclock, this function is used. Signed-off-by: Eric B Munson --- include/asm-generic/pvclock.h | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) create

[PATCH 2/4] Add functions to check if the host has stopped the vm

2011-08-29 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson --- arch/x86/include/asm/pvclock.h |2 ++ arch/x86/kernel/kvmclock.c | 14

[PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-08-29 Thread Eric B Munson
warning. Eric B Munson (4): Add flag to indicate that a vm was stopped by the host Add functions to check if the host has stopped the vm Add generic stubs for kvm stop check functions Add check for suspended vm in softlockup detector arch/x86/include/asm/pvclock-abi.h |1 + arch/x86

[PATCH 4/4] Add check for suspended vm in softlockup detector

2011-08-29 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. Signed-off-by: Eric B Munson --- kernel/watchdog.c | 12 1 files changed, 12 insertions(+), 0 deletions

[PATCH 1/4] Add flag to indicate that a vm was stopped by the host

2011-08-29 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. Signed-off-by: Eric B Munson --- arch/x86/include/asm/pvclock-abi.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/include/asm/pvclock-abi.h b/arch/x86/include

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-08-30 Thread Eric B Munson
On Tue, Aug 30, 2011 at 06:26, Marcelo Tosatti wrote: > On Mon, Aug 29, 2011 at 05:27:11PM -0600, Eric B Munson wrote: >> Currently, when qemu stops a guest kernel that guest will issue a soft lockup >> message when it resumes.  This set provides the ability for qemu to >>

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-09-13 Thread Eric B Munson
On Fri, 09 Sep 2011, Marcelo Tosatti wrote: > On Thu, Sep 01, 2011 at 02:27:49PM -0600, emun...@mgebm.net wrote: > > On Thu, 01 Sep 2011 14:24:12 -0500, Anthony Liguori wrote: > > >On 08/30/2011 07:26 AM, Marcelo Tosatti wrote: > > >>On Mon, Aug 29, 2011 at 05:27:1

Re: [PATCH 0/4] Avoid soft lockup message when KVM is stopped by host

2011-09-20 Thread Eric B Munson
On Thu, 15 Sep 2011, Marcelo Tosatti wrote: > On Tue, Sep 13, 2011 at 04:49:55PM -0400, Eric B Munson wrote: > > On Fri, 09 Sep 2011, Marcelo Tosatti wrote: > > > > > On Thu, Sep 01, 2011 at 02:27:49PM -0600, emun...@mgebm.net wrote: > > > > On Thu, 01 Sep

[PATCH] Fix include dependency for mmu_notifier

2011-10-10 Thread Eric B Munson
The kvm_host struct can include an mmu_notifier struct but mmu_notifier.h is not included directly. Signed-off-by: Eric B Munson --- include/linux/kvm_host.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index

Re: [PATCH] Fix include dependency for mmu_notifier

2011-10-11 Thread Eric B Munson
On Tue, 11 Oct 2011, Avi Kivity wrote: > On 10/10/2011 05:46 PM, Eric B Munson wrote: > >The kvm_host struct can include an mmu_notifier struct but mmu_notifier.h is > >not included directly. > > Thanks, applied. Is there a .config which causes this? > > -- > er

[PATCH 0/6] Avoid soft lockup message when KVM is stopped by host

2011-10-25 Thread Eric B Munson
the guest behind by the amount of time of the pause. This forces a guest to have ntp running in order to keep the wall clock accurate. Eric B Munson (6): Add flag to indicate that a vm was stopped by the host Add functions to check if the host has stopped the vm Add ioctl for

[PATCH 1/6] Add flag to indicate that a vm was stopped by the host

2011-10-25 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. Signed-off-by: Eric B Munson --- arch/x86/include/asm/pvclock-abi.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/include/asm/pvclock-abi.h b/arch/x86/include

[PATCH 3/6] Add ioctl for KVM_GUEST_STOPPED

2011-10-25 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson --- arch/x86/include/asm/pvclock.h |3 +++ arch/x86/kernel/kvmclock.c | 12 arch/x86/kvm/x86.c |5

[PATCH 4/6] Add generic stubs for kvm stop check functions

2011-10-25 Thread Eric B Munson
Signed-off-by: Eric B Munson --- include/asm-generic/pvclock.h | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) create mode 100644 include/asm-generic/pvclock.h diff --git a/include/asm-generic/pvclock.h b/include/asm-generic/pvclock.h new file mode 100644 index

[PATCH 2/6] Add functions to check if the host has stopped the vm

2011-10-25 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson --- arch/x86/include/asm/pvclock.h |2 ++ arch/x86/kernel/kvmclock.c | 19

[PATCH 6/6] Add age out of guest paused flag

2011-10-25 Thread Eric B Munson
flag. The time out will be specified by the hypervisor in the ioctl call. Signed-off-by: Eric B Munson --- arch/x86/include/asm/pvclock.h |2 ++ arch/x86/kernel/kvmclock.c | 24 arch/x86/kvm/x86.c |9 + include/linux/kvm.h|

[PATCH 5/6] Add check for suspended vm in softlockup detector

2011-10-25 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. Signed-off-by: Eric B Munson --- kernel/watchdog.c |9 + 1 files changed, 9 insertions(+), 0 deletions

Re: [PATCH 3/6] Add ioctl for KVM_GUEST_STOPPED

2011-10-28 Thread Eric B Munson
On Thu, 27 Oct 2011, Marcelo Tosatti wrote: > On Tue, Oct 25, 2011 at 03:26:16PM -0400, Eric B Munson wrote: > > Now that we have a flag that will tell the guest it was suspended, create an > > interface for that communication using a KVM ioctl. > > > > S

Re: [PATCH 6/6] Add age out of guest paused flag

2011-10-28 Thread Eric B Munson
Thanks for the review. On Fri, 28 Oct 2011, Marcelo Tosatti wrote: > On Tue, Oct 25, 2011 at 03:26:19PM -0400, Eric B Munson wrote: > > The KVM_GUEST_PAUSED flag will prevent a guest from compaining about a soft > > lockup but it can mask real soft lockups if the flag isn&#x

[PATCH 1/6 V2] Add flag to indicate that a vm was stopped by the host

2011-10-31 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. Signed-off-by: Eric B Munson --- arch/x86/include/asm/pvclock-abi.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/include/asm/pvclock-abi.h b/arch/x86/include

[PATCH 3/6 V2] Add ioctl for KVM_GUEST_STOPPED

2011-10-31 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson --- Changes from V1: Add kvm_set_host_stopped to arch/x86/jvm/x86.c instead of kvmclock.c Rename KVM_PAUSE_GUEST to KVM_GUEST_PAUSED

[PATCH 6/6 V2] Add age out of guest paused flag

2011-10-31 Thread Eric B Munson
flag. The time out will be specified by the hypervisor in the ioctl call. Signed-off-by: Eric B Munson --- Cahnges from V1: Add host functions for flag management to arch/x86/kvm/x86.c instead of kvmclock.c arch/x86/include/asm/pvclock.h |2 ++ arch/x86/kvm/x86.c |

[PATCH 4/6 V2] Add generic stubs for kvm stop check functions

2011-10-31 Thread Eric B Munson
Signed-off-by: Eric B Munson --- include/asm-generic/pvclock.h | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) create mode 100644 include/asm-generic/pvclock.h diff --git a/include/asm-generic/pvclock.h b/include/asm-generic/pvclock.h new file mode 100644 index

[PATCH 5/6 V2] Add check for suspended vm in softlockup detector

2011-10-31 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. Signed-off-by: Eric B Munson --- kernel/watchdog.c |9 + 1 files changed, 9 insertions(+), 0 deletions

[PATCH 0/6 V2] Avoid soft lockup message when KVM is stopped by host

2011-10-31 Thread Eric B Munson
was attempted to solve this in Qemu, but the side effects of saving and restoring the clock and tsc for each vcpu put the wall clock of the guest behind by the amount of time of the pause. This forces a guest to have ntp running in order to keep the wall clock accurate. Eric B Munson (6): Add

[PATCH 2/6 V2] Add functions to check if the host has stopped the vm

2011-10-31 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson --- arch/x86/include/asm/pvclock.h |2 ++ arch/x86/kernel/kvmclock.c | 19

Re: [PATCH 6/6 V2] Add age out of guest paused flag

2011-11-01 Thread Eric B Munson
On Tue, 01 Nov 2011, Anthony Liguori wrote: > On 10/31/2011 03:07 PM, Eric B Munson wrote: > >The KVM_GUEST_PAUSED flag will prevent a guest from compaining about a soft > >lockup but it can mask real soft lockups if the flag isn't cleared when it is > >no longer releva

Re: [PATCH 2/6 V2] Add functions to check if the host has stopped the vm

2011-11-01 Thread Eric B Munson
On Tue, 01 Nov 2011, Anthony Liguori wrote: > On 10/31/2011 03:07 PM, Eric B Munson wrote: > >When a host stops or suspends a VM it will set a flag to show this. The > >watchdog will use these functions to determine if a softlockup is real, or > >the > >result of a

Re: [PATCH 6/6 V2] Add age out of guest paused flag

2011-11-01 Thread Eric B Munson
On Tue, 01 Nov 2011, Anthony Liguori wrote: > On 11/01/2011 02:51 PM, Eric B Munson wrote: > >On Tue, 01 Nov 2011, Anthony Liguori wrote: > > > >>On 10/31/2011 03:07 PM, Eric B Munson wrote: > >>>The KVM_GUEST_PAUSED flag will prevent a guest from compaining

Re: [PATCH 3/6 V2] Add ioctl for KVM_GUEST_STOPPED

2011-11-01 Thread Eric B Munson
On Tue, 01 Nov 2011, Anthony Liguori wrote: > On 10/31/2011 03:07 PM, Eric B Munson wrote: > >Now that we have a flag that will tell the guest it was suspended, create an > >interface for that communication using a KVM ioctl. > > > >Signed-off-by: Eric B Munson > >

[PATCH 1/6 V3] Add flag to indicate that a vm was stopped by the host

2011-11-04 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 2/6 V3] Add functions to check if the host has stopped the vm

2011-11-04 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc

[PATCH 4/6 V3] Add generic stubs for kvm stop check functions

2011-11-04 Thread Eric B Munson
Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: jeremy.fitzhardi...@citrix.com Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker

[PATCH 0/6 V3] Avoid soft lockup message when KVM is stopped by host

2011-11-04 Thread Eric B Munson
...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (6): Add flag to indicate that a vm was stopped by the host Add functions to check if the host has stopped the vm Add ioctl for KVM_GUEST_STOPPED Add generic stubs for kvm stop check functions Add check for

[PATCH 6/6 V3] Add age out of guest paused flag

2011-11-04 Thread Eric B Munson
flag. The time out will be specified by the hypervisor in the ioctl call. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: jeremy.fitzhardi...@citrix.com Cc: kvm@vger.kernel.o

[PATCH 5/6 V3] Add check for suspended vm in softlockup detector

2011-11-04 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc

[PATCH 1/5 V4] Add flag to indicate that a vm was stopped by the host

2011-11-29 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 3/5 V4] Add ioctl for KVM_GUEST_STOPPED

2011-11-29 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc

[PATCH 5/5 V4] Add check for suspended vm in softlockup detector

2011-11-29 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH] Guest stop notification

2011-11-29 Thread Eric B Munson
-off-by: Eric B Munson Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: a...@redhat.com Cc: kvm@vger.kernel.org Cc: linux-ker...@vger.kernel.org --- target-i386/kvm.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/target-i386/kvm.c b

[PATCH 4/5 V4] Add generic stubs for kvm stop check functions

2011-11-29 Thread Eric B Munson
Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: jeremy.fitzhardi...@citrix.com Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker

[PATCH 0/5 V4] Avoid soft lockup message when KVM is stopped by host

2011-11-29 Thread Eric B Munson
om Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: jeremy.fitzhardi...@citrix.com Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (5): Add flag to indicate that a vm was stopped by the host Add functions to check if the

[PATCH 2/5 V4] Add functions to check if the host has stopped the vm

2011-11-29 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc

Re: [PATCH] Guest stop notification

2011-12-01 Thread Eric B Munson
On Thu, 01 Dec 2011, Jan Kiszka wrote: > On 2011-11-29 22:36, Eric B Munson wrote: > > Often when a guest is stopped from the qemu console, it will report spurious > > soft lockup warnings on resume. There are kernel patches being discussed > > that > > will give t

Re: [PATCH] Guest stop notification

2011-12-01 Thread Eric B Munson
On Thu, 01 Dec 2011, Jan Kiszka wrote: > On 2011-11-29 22:36, Eric B Munson wrote: > > Often when a guest is stopped from the qemu console, it will report spurious > > soft lockup warnings on resume. There are kernel patches being discussed > > that > > will give t

[PATCH V2] Guest stop notification

2011-12-01 Thread Eric B Munson
patch uses the qemu Notifier system to tell the guest it is about to be stopped. Signed-off-by: Eric B Munson Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Jan Kiszka Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: linux-ker...@vger.kernel.org Cc: kvm@vger.kernel.org --- target-i386/kvm.c |1

Re: [PATCH] Guest stop notification

2011-12-01 Thread Eric B Munson
On Thu, 01 Dec 2011, Marcelo Tosatti wrote: > On Thu, Dec 01, 2011 at 06:36:17PM +0100, Jan Kiszka wrote: > > On 2011-12-01 18:22, Eric B Munson wrote: > > > On Thu, 01 Dec 2011, Jan Kiszka wrote: > > > > > >> On 2011-11-29 22:36, Eric B Munson wrote: >

[PATCH V3] Guest stop notification

2011-12-02 Thread Eric B Munson
-off-by: Eric B Munson Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Jan Kiszka Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: kvm@vger.kernel.org --- Changes from V2: Move ioctl into hw/kvmclock.c so as other arches can use it as it is implemented Changes from V1: Remove unnecessary

Re: [PATCH V3] Guest stop notification

2011-12-02 Thread Eric B Munson
On Fri, 02 Dec 2011, Jan Kiszka wrote: > On 2011-12-02 20:19, Eric B Munson wrote: > > Often when a guest is stopped from the qemu console, it will report spurious > > soft lockup warnings on resume. There are kernel patches being discussed > > that > > will give t

Re: [PATCH V3] Guest stop notification

2011-12-05 Thread Eric B Munson
On Sat, 03 Dec 2011, Jan Kiszka wrote: > On 2011-12-02 22:27, Eric B Munson wrote: > > On Fri, 02 Dec 2011, Jan Kiszka wrote: > > > >> On 2011-12-02 20:19, Eric B Munson wrote: > >>> Often when a guest is stopped from the qemu console, it will report > >

Re: [PATCH 3/5 V4] Add ioctl for KVM_GUEST_STOPPED

2011-12-05 Thread Eric B Munson
On Sat, 03 Dec 2011, Sasha Levin wrote: > On Tue, 2011-11-29 at 16:35 -0500, Eric B Munson wrote: > > > > Now that we have a flag that will tell the guest it was suspended, > > create an interface for that communication using a KVM ioctl. > > > > Signed-off-b

[PATCH V4] Guest stop notification

2011-12-05 Thread Eric B Munson
patch uses the qemu Notifier system to tell the guest it is about to be stopped. Signed-off-by: Eric B Munson Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Jan Kiszka Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: kvm@vger.kernel.org --- Changes from V3: Collapse new state change notification

[PATCH 1/5 V5] Add flag to indicate that a vm was stopped by the host

2011-12-05 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-05 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc

[PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-05 Thread Eric B Munson
nux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (5): Add flag to indicate that a vm was stopped by the host Add functions to check if the host has stopped the vm Add ioctl for KVMCLOCK_GUEST_STOPPED Add generic stubs for kvm stop check functions Add chec

[PATCH 5/5 V5] Add check for suspended vm in softlockup detector

2011-12-05 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 4/5 V5] Add generic stubs for kvm stop check functions

2011-12-05 Thread Eric B Munson
Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: jeremy.fitzhardi...@citrix.com Cc: levinsasha...@gmail.com Cc: Jan Kiszka Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org

[PATCH 3/5 V5] Add ioctl for KVMCLOCK_GUEST_STOPPED

2011-12-05 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-08 Thread Eric B Munson
On Wed, 07 Dec 2011, Avi Kivity wrote: > On 12/05/2011 10:18 PM, Eric B Munson wrote: > > Changes from V4: > > Rename KVM_GUEST_PAUSED to KVMCLOCK_GUEST_PAUSED > > Add description of KVMCLOCK_GUEST_PAUSED ioctl to api.txt > > > > Changes from V3: > > Incl

Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-08 Thread Eric B Munson
On Wed, 07 Dec 2011, Avi Kivity wrote: > On 12/05/2011 10:19 PM, Eric B Munson wrote: > > When a host stops or suspends a VM it will set a flag to show this. The > > watchdog will use these functions to determine if a softlockup is real, or > > the > > result of a su

Re: [PATCH 3/5 V5] Add ioctl for KVMCLOCK_GUEST_STOPPED

2011-12-08 Thread Eric B Munson
On Wed, 07 Dec 2011, Avi Kivity wrote: > On 12/05/2011 10:19 PM, Eric B Munson wrote: > > Now that we have a flag that will tell the guest it was suspended, create an > > interface for that communication using a KVM ioctl. > > > > @@ -3295,6 +3295,10 @@ long kvm_arch_v

Re: [PATCH 4/5 V5] Add generic stubs for kvm stop check functions

2011-12-08 Thread Eric B Munson
On Wed, 07 Dec 2011, Avi Kivity wrote: > On 12/05/2011 10:19 PM, Eric B Munson wrote: > > > > diff --git a/include/asm-generic/kvm_para.h b/include/asm-generic/kvm_para.h > > new file mode 100644 > > index 000..177e1eb > > --- /dev/null > > +++ b/inc

[PATCH 1/4 V6] Add flag to indicate that a vm was stopped by the host

2011-12-08 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 4/4] Add check for suspended vm in softlockup detector

2011-12-08 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 3/4] Add ioctl for KVMCLOCK_GUEST_STOPPED

2011-12-08 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc

[PATCH 2/4] Add functions to check if the host has stopped the vm

2011-12-08 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc

[PATCH 0/4 V6] Avoid soft lockup message when KVM is stopped by host

2011-12-08 Thread Eric B Munson
rg Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (4): Add flag to indicate that a vm was stopped by the host Add functions to check if the host has stopped the vm Add ioctl for KVMCLOCK_GUEST_STOPPED Add check for suspended vm in softl

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-14 Thread Eric B Munson
On Wed, 14 Dec 2011, Avi Kivity wrote: > On 12/14/2011 02:16 PM, Marcelo Tosatti wrote: > > > Having this controlled from userspace means it doesn't work for SIGSTOP > > > or for long scheduling delays. What about doing this automatically > > > based on preempt notifiers? > > > > Long scheduling

Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-14 Thread Eric B Munson
On Wed, 14 Dec 2011, Avi Kivity wrote: > On 12/14/2011 02:11 PM, Marcelo Tosatti wrote: > > On Thu, Dec 08, 2011 at 10:23:10AM -0500, Eric B Munson wrote: > > > On Wed, 07 Dec 2011, Avi Kivity wrote: > > > > > > > On 12/05/2011 10:19 PM, Eric B Munso

Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-14 Thread Eric B Munson
On Wed, 14 Dec 2011, Avi Kivity wrote: > On 12/14/2011 07:11 PM, Eric B Munson wrote: > > > > > > > > > > If I understand (please correct me if this is wrong) because this is > > > > > only > > > > > called from the watchdo

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-14 Thread Eric B Munson
On Wed, 14 Dec 2011, Avi Kivity wrote: > On 12/08/2011 05:19 PM, Eric B Munson wrote: > > > error compiling committee.c: too many arguments to function > > > > > My concern for preempt notifiers is masking real soft lockup warnings. If > > the > > flag is

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-15 Thread Eric B Munson
On Thu, 15 Dec 2011, Avi Kivity wrote: > On 12/14/2011 07:58 PM, Eric B Munson wrote: > > > I don't think you should see a guest softlockup if the host is > > > overloaded. Nor should you see it due to a long live migration pause, > > > or STOP/CONT. You sho

[PATCH 2/4 V7] Add functions to check if the host has stopped the vm

2011-12-15 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc

[PATCH 1/4 V7] Add flag to indicate that a vm was stopped by the host

2011-12-15 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 0/4 V7] Avoid soft lockup message when KVM is stopped by host

2011-12-15 Thread Eric B Munson
hardi...@citrix.com Cc: levinsasha...@gmail.com Cc: Jan Kiszka Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (4): Add flag to indicate that a vm was stopped by the host Add functions to check if the host has stopped the vm

[PATCH 4/4 V7] Add check for suspended vm in softlockup detector

2011-12-15 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

  1   2   >