On Thu, Jul 28, 2011 at 12:31:51PM +0300, Pekka Enberg wrote:
> On Thu, Jul 28, 2011 at 12:01 PM, Sasha Levin wrote:
> > PCI BAR probing is done in four steps:
> >
> > 1. Read address (and flags).
> > 2. Mask BAR.
> > 3. Read BAR again - Now the expected result is the size of the BAR.
> > 4. M
On Thu, Jul 28, 2011 at 12:01:54PM +0300, Sasha Levin wrote:
...
>
> struct mmio_mapping {
> struct rb_int_node node;
> - void(*kvm_mmio_callback_fn)(u64 addr, u8 *data, u32
> len, u8 is_write);
> + void(*kvm_mmio_callback_fn)(u64 addr,
On Thu, Jul 28, 2011 at 12:01:52PM +0300, Sasha Levin wrote:
> Map GSIs manually when starting the guest.
> This will allow us mapping new GSIs for MSIX in the future.
>
> Signed-off-by: Sasha Levin
> ---
Other than a few nits the series looks good to me, thanks Sasha!
--
To unsubscribe from thi
On Thu, Aug 16, 2012 at 10:01:58AM +0300, Pekka Enberg wrote:
> Hello,
> [0.248962] Pid: 0, comm: swapper/0 Not tainted 3.6.0-rc1+ #24
> [penberg@tux ~]$ cat perf-kvmtool-issue
> Hello,
>
> Has anyone seen this? It's kvmtool/next with 3.6.0-rc1. Looks like we
> are doing uncore_init() on virtu
On Thu, Aug 16, 2012 at 11:07:43AM +0400, Cyrill Gorcunov wrote:
> On Thu, Aug 16, 2012 at 10:01:58AM +0300, Pekka Enberg wrote:
> > Hello,
> > [0.248962] Pid: 0, comm: swapper/0 Not tainted 3.6.0-rc1+ #24
> > [penberg@tux ~]$ cat perf-kvmtool-issue
> > Hello,
&g
On Thu, Aug 16, 2012 at 10:41:53AM +0300, Pekka Enberg wrote:
> On 08/16/2012 03:19 PM, Peter Zijlstra wrote:
> >> On Thu, 2012-08-16 at 10:01 +0300, Pekka Enberg wrote:
> >>> Has anyone seen this? It's kvmtool/next with 3.6.0-rc1. Looks like we
> >>> are doing uncore_init() on virtualized CPU whic
On Thu, Aug 16, 2012 at 11:45:52AM +0300, Avi Kivity wrote:
> >> On Thu, Aug 16, 2012 at 10:38 AM, Yan, Zheng
> >> wrote:
> >> > The Intel uncore doc does not specify how to check if uncore exist.
> >> > How about disabling uncore on virtualized CPU?
> >>
> >> (CC'ing Avi.)
> >
> > Why not simpl
On Thu, Aug 30, 2012 at 09:36:37AM +0200, Sasha Levin wrote:
> + char *new_env[] = { "TERM=linux", "DISPLAY=192.168.33.1:0",
> + "HOME=/virt/home", NULL };
> +
> + mkdir("/virt/home", 0755);
Please add check for mkdir error code. Frankly, this is a bad habbit
to
On Thu, Aug 30, 2012 at 10:16:54AM +0200, Ingo Molnar wrote:
>
> * Pekka Enberg wrote:
>
> > On Thu, Aug 30, 2012 at 10:36 AM, Sasha Levin
> > wrote:
> > > Build with -flto set, which should enable link-time-optimizations.
> > >
> > > I'm not sure if it provides a significant performance incre
On Thu, Aug 30, 2012 at 10:33:21AM +0200, Sasha Levin wrote:
> >>>
> >>> Ingo, any objections to this?
> >>
> >> No objections if you can live with a 2x-4x increase in build
> >> time - at worst it might cause funnies with the BIOS linker
> >> script and such.
> >
> > Maybe we could enable it vi
On Tue, Sep 06, 2011 at 02:23:54AM +0300, Sasha Levin wrote:
> This patch allows to run previously created guestfs by simply specifying it
> with the '-d' parameter.
>
> This allows running guestfs which were created before using:
>
> kvm setup -n [name]
>
> Signed-off-by: Sasha Levin
> -
On Wed, Nov 09, 2011 at 05:49:53PM +0200, Sasha Levin wrote:
> On Wed, 2011-11-09 at 17:42 +0200, Richard Weinberger wrote:
> > On Wed, 09 Nov 2011 16:49:51 +0200, Sasha Levin
> > wrote:
> > > We'll do kvm_clock as well if you compile it in the kernel.
> >
> > CONFIG_HIGH_RES_TIMERS is on both ho
On Wed, Nov 09, 2011 at 08:00:06PM +0400, Cyrill Gorcunov wrote:
...
> >
> > You'll need CONFIG_KVM_CLOCK.
> >
> > I'm not actually sure how close our implementation is to having tsc
> > working so far, Cyrill knows more about that than me.
> >
kvm: Drop "notsc" no longer needed kernel option
"notsc" option has been used to avoid APIC calibration
problem at early days when we didn't support APIC at all.
Now with KVM APIC emulation used there is no longer need
for this option. Drop it.
Reported-by: Richard Weinberger
On Mon, Nov 28, 2011 at 07:54:27PM +0200, Sasha Levin wrote:
>
> +/*
> + * Each buffer in the virtqueues is actually a chain of descriptors. This
> + * function returns the next descriptor in the chain, or vq->vring.num if
> we're
> + * at the end.
> + */
> +static unsigned next_desc(struct vri
On Friday, April 1, 2011, Carsten Otte wrote:
> On 31.03.2011 23:47, Alexander Graf wrote:
>
> Did you take a look at kuli?
>
> Right. If you want to take kuli as a start, and GPL is acceptable for you ;-).
> If kuli seems right, I suggest to go ahead and make an upstream git
> repository for it.
On 04/03/2011 12:53 PM, Pekka Enberg wrote:
> Hi,
>
> On Sun, Apr 3, 2011 at 11:24 AM, Avi Kivity wrote:
>> On 04/03/2011 09:21 AM, Ingo Molnar wrote:
>>>
>>> * Anthony Liguori wrote:
>>>
On 03/31/2011 12:30 PM, Pekka Enberg wrote:
> Hi all,
>
> We’re proud to announce
On Fri, Apr 8, 2011 at 9:14 AM, Pekka Enberg wrote:
> Hi Anthony,
>
> On Fri, Apr 8, 2011 at 5:14 AM, Anthony Liguori wrote:
>> If someone was going to seriously go about doing something like this, a
>> better approach would be to start with QEMU and remove anything non-x86 and
>> all of the UI/c
On Fri, Apr 8, 2011 at 1:11 PM, Jan Kiszka wrote:
> On 2011-04-08 10:27, Pekka Enberg wrote:
>> Hi Jan,
>>
>> On Fri, 2011-04-08 at 09:39 +0200, Jan Kiszka wrote:
>>> I agree that it's easy to change 2kSomething LOC for this. But if you
>>> now wait too long designing in essential features like SM
On Friday, April 8, 2011, Alexander Graf wrote:
>
> On 08.04.2011, at 12:42, Jan Kiszka wrote:
>
>> On 2011-04-08 11:32, Cyrill Gorcunov wrote:
>>> It seems there is a misunderstanding. KVM-tool is quite far from been KVM
>>> replacement (if ever). And what we&#x
On 04/09/2011 03:59 PM, Ingo Molnar wrote:
>
> * Pekka Enberg wrote:
>
>> In preparation for threaded execution model, this patch introduces a KVM VCPU
>> data structure 'struct kvm_cpu'.
>>
>> Cc: Asias He
>> Cc: Cyrill Gorcunov
&
On 04/09/2011 04:27 PM, Ingo Molnar wrote:
...
>>
>> Ugh, Pekka, was the memory properly mmaped? Setup bios called multiple
>> times in every thread?
>
> Why should mmap() be called in every thread?
>
> Thanks,
>
> Ingo
I thought it being called for some reason.
I'm not updated to this th
On 04/09/2011 04:34 PM, Pekka Enberg wrote:
> On Sat, 9 Apr 2011, Cyrill Gorcunov wrote:
>> I thought it being called for some reason.
>> I'm not updated to this threaded model yet.
>
> None of the fancy stuff is merged. It's likely just because of struct layout
On 04/10/2011 11:09 AM, Pekka Enberg wrote:
> On Sun, Apr 10, 2011 at 9:50 AM, Asias He wrote:
>> This patch makes Ctrl+a escape key. Ctrl+a+x will terminate kvm tools.
>>
>> It works for both serial and virtio console.
>> If you want to input Ctrl+a to guest, type Ctrl+a twice.
>>
>> Signed-off-b
On Tue, Nov 29, 2011 at 03:01:59PM +0200, Pekka Enberg wrote:
> >>
> >>Hi Sasha, where the rmb() then? Or maybe you wanted plain barrier() here?
> >
> >On the kernel side.
> >Theres a mb there which happens there during the kick.
>
> I guess we need to improve the comment in next_desc()?
>
Kerne
On Mon, Dec 05, 2011 at 11:22:11AM +0200, Sasha Levin wrote:
>
> +static int kvm_custom_stage2(void)
> +{
> + char tmp[PATH_MAX], dst[PATH_MAX], *src;
> + const char *rootfs;
> + int r;
> +
> + src = realpath("guest/init_stage2", NULL);
> + if (src == NULL)
> + ret
On Tue, Dec 06, 2011 at 12:25:29PM +0200, Pekka Enberg wrote:
> On Tue, Dec 6, 2011 at 5:42 AM, Matt Evans wrote:
> > vesa, pci-shmem and virtio-pci devices need to set up config space with
> > little-endian conversions (as config space is LE). The pci_config_address
> > bitfield also needs to be
On Tue, Dec 06, 2011 at 01:41:56PM +0200, Pekka Enberg wrote:
> On Tue, Dec 6, 2011 at 12:28 PM, Cyrill Gorcunov wrote:
> > On Tue, Dec 06, 2011 at 12:25:29PM +0200, Pekka Enberg wrote:
> >> On Tue, Dec 6, 2011 at 5:42 AM, Matt Evans wrote:
> >> > vesa, pci-shmem
On Tue, Dec 06, 2011 at 12:29:48PM +0200, Pekka Enberg wrote:
...
>
> Otherwise looks OK to me. Cyrill?
>
It might be not seen from patch (or my local kvm repo
is not yet updated well) but I somehow miss who will be
reading initrd in case of loading flat image? If noone,
then what's the point to
On Tue, Dec 06, 2011 at 01:58:24PM +0200, Pekka Enberg wrote:
> On Tue, 2011-12-06 at 15:47 +0400, Cyrill Gorcunov wrote:
> > On Tue, Dec 06, 2011 at 01:41:56PM +0200, Pekka Enberg wrote:
> > > On Tue, Dec 6, 2011 at 12:28 PM, Cyrill Gorcunov
> > > wrote:
> >
On Tue, Dec 06, 2011 at 03:29:00PM +0200, Pekka Enberg wrote:
> >
> >Hehe, this is because it should be rtaher defined as
> >
> >union pci_config_address {
> >struct {
> > #if __BYTE_ORDER == __LITTLE_ENDIAN
> > unsignedzeros : 2;
> > unsignedregister_number : 6;
> > #
On Wed, Dec 07, 2011 at 11:42:27AM +1100, Matt Evans wrote:
> Hi Cyrill,
>
> On 06/12/11 23:04, Cyrill Gorcunov wrote:
> > On Tue, Dec 06, 2011 at 12:29:48PM +0200, Pekka Enberg wrote:
> > ...
> >>
> >> Otherwise looks OK to me. Cyrill?
> >>
>
On Wed, Dec 07, 2011 at 12:21:52PM +0200, Gleb Natapov wrote:
> On Tue, Dec 06, 2011 at 10:42:55PM +0200, Sasha Levin wrote:
> > +static void handle_nmi(int fd, u32 type, u32 len, u8 *msg)
> > +{
> > + u32 vcpu = *(u32 *)msg;
> > +
> > + ioctl(kvm_cpus[vcpu]->vcpu_fd, KVM_NMI);
>
> You need to
On Wed, Dec 07, 2011 at 12:33:05PM +0200, Gleb Natapov wrote:
> On Wed, Dec 07, 2011 at 02:31:11PM +0400, Cyrill Gorcunov wrote:
> > On Wed, Dec 07, 2011 at 12:21:52PM +0200, Gleb Natapov wrote:
> > > On Tue, Dec 06, 2011 at 10:42:55PM +0200, Sasha Levin wrote:
> > > &g
On Wed, Dec 07, 2011 at 12:41:50PM +0200, Gleb Natapov wrote:
> >
> > Yup, but while we support linux kernels only it should be fine. Still
> > of course on long term we need a check.
> >
> Tomorrow someone will send a patch to change how Linux behaves and
> slightly older kvmtool will not be abl
On Fri, Dec 16, 2011 at 10:40:06AM +0200, Sasha Levin wrote:
> Signed-off-by: Sasha Levin
> ---
Thanks, Sasha!
Cyrill
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/maj
‘__xchg_wrong_size’ [-Werror=missing-prototypes]
| ../../arch/x86/include/asm/cmpxchg.h: In function ‘__xchg_wrong_size’:
| ../../arch/x86/include/asm/cmpxchg.h:12:2: error: expected declaration
specifiers before ‘__compiletime_error’
Signed-off-by: Cyrill Gorcunov
---
Not sure if it'
The kernel already has pr_err helper lets do the same.
Signed-off-by: Cyrill Gorcunov
---
tools/kvm/builtin-stat.c |2 +-
tools/kvm/disk/core.c |2 +-
tools/kvm/include/kvm/util.h |2 +-
tools/kvm/kvm.c|2 +-
tools/kvm/util/parse-options.c | 16
Index is u8 value so array size should be 256.
Signed-off-by: Cyrill Gorcunov
---
tools/kvm/ui/sdl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.git/tools/kvm/ui/sdl.c
===
--- linux-2.6.git.orig/tools
If some of subsequent calls fails we better to return error
code instead of dying with a message. This is a first step
in getting rid of number of die() calls we have in code.
Signed-off-by: Cyrill Gorcunov
---
tools/kvm/builtin-run.c |5 -
tools/kvm/include/kvm/kvm.h
BUILD_BUG_ON is unable to catch errors on expression which
can't be evaluated at compile time.
Signed-off-by: Cyrill Gorcunov
---
tools/kvm/x86/bios.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6.git/tools/kvm/x86/b
On Mon, Dec 19, 2011 at 09:13:28AM +0200, Pekka Enberg wrote:
> >
> >-BUILD_BUG_ON(i > E820_X_MAX);
> >+assert(i <= E820_X_MAX);
>
> We should use BUG_ON() like tools/perf does.
>
We dont have it yet. So I'll introduce this helper later,
but note that we will have to cover _all_ assert()
UG_ON() like tools/perf does.
>
> On Mon, Dec 19, 2011 at 9:57 AM, Cyrill Gorcunov wrote:
> > We dont have it yet. So I'll introduce this helper later,
> > but note that we will have to cover _all_ assert() calls then,
> > so it's better to make in a separate patc
On Mon, Dec 19, 2011 at 11:40:09AM +0100, Ingo Molnar wrote:
>
> GDB will catch that signal.
>
Yeah, good point! Pekka, drop this patch please, I'll make new one at evening.
Cyrill
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vg
On Mon, Dec 19, 2011 at 11:50:31AM +0100, Ingo Molnar wrote:
...
>
> The tool-specific BUG() implementation can be added as a delta
> on top of that. It's in fact better to keep those two steps
> separate.
>
OK, will do on top.
Cyrill
--
To unsubscribe from this list: send the line "u
Raise SIGABRT in case if run-time crtitical
problem found.
Proposed-by: Ingo Molnar
Signed-off-by: Cyrill Gorcunov
---
Ingo, you meant something like below?
tools/kvm/include/kvm/util.h | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
Index: linux-2.6.git/tools/kvm
Signed-off-by: Cyrill Gorcunov
---
tools/kvm/Makefile |2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.git/tools/kvm/Makefile
===
--- linux-2.6.git.orig/tools/kvm/Makefile
+++ linux-2.6.git/tools/kvm/Makefile
@@ -327,6
On Wed, Feb 01, 2012 at 09:05:34AM +0200, Pekka Enberg wrote:
> On Tue, 31 Jan 2012, Sasha Levin wrote:
> >Might happen when hardware virtualization is not supported.
> >
> >Reported-by: Ingo Molnar
> >Signed-off-by: Sasha Levin
> >---
> >tools/kvm/builtin-run.c |4
> >1 files changed, 4
On Wed, Feb 01, 2012 at 09:26:00AM +0200, Pekka Enberg wrote:
> On Wed, 1 Feb 2012, Cyrill Gorcunov wrote:
> >I suspect we need something like
> >---
> >tools/kvm/builtin-run.c |5 +
> >tools/kvm/kvm.c |2 +-
> >2 files changed, 6 insertions(+),
On error mmap returns MAP_FAILED so we
need a proper test here.
Signed-off-by: Cyrill Gorcunov
---
tools/kvm/hw/pci-shmem.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: linux-2.6.git/tools/kvm/hw/pci-shmem.c
On Fri, Feb 03, 2012 at 11:15:41PM +0400, Cyrill Gorcunov wrote:
> On error mmap returns MAP_FAILED so we
> need a proper test here.
>
Pekka, pick this one instead -- a caller is expecting null/not-null
only.
Cyrill
---
kvm tools: Fix test for mmap failure
On error mma
64 symbols should be more than enough.
Signed-off-by: Cyrill Gorcunov
---
I hope I didn't miss anything?
tools/kvm/kvm.c |2 +-
tools/kvm/powerpc/include/kvm/kvm-arch.h |2 +-
tools/kvm/x86/include/kvm/kvm-arch.h |2 +-
3 files changed, 3 insertio
On Sat, Feb 04, 2012 at 02:15:36PM +0200, Pekka Enberg wrote:
> On Fri, 3 Feb 2012, Cyrill Gorcunov wrote:
> >If guest name is used (which is default case) the kvm might end
> >up carrying the pointer to name which is allocated on stack.
> >
> >kvm_cmd_run_init
On Sat, Feb 04, 2012 at 04:20:05PM +0400, Cyrill Gorcunov wrote:
> On Sat, Feb 04, 2012 at 02:15:36PM +0200, Pekka Enberg wrote:
> > On Fri, 3 Feb 2012, Cyrill Gorcunov wrote:
> > >If guest name is used (which is default case) the kvm might end
> > >up carrying t
On Sat, Feb 04, 2012 at 02:57:23PM +0200, Pekka Enberg wrote:
> On Sat, 4 Feb 2012, Cyrill Gorcunov wrote:
> >Index: linux-2.6.git/tools/kvm/kvm.c
> >===
> >--- linux-2.6.git.orig/tools/kvm/kvm.c
> >+++ li
' not found. Please make sure your kernel has CONFIG_KVM
enabled and that the KVM modules are loaded.
| Segmentation fault (core dumped)
| [cyrill@moon kvm]$
Signed-off-by: Cyrill Gorcunov
---
tools/kvm/builtin-run.c |4
tools/kvm/kvm.c | 11 ---
2 files c
On Sat, Feb 04, 2012 at 07:38:41PM +0200, Pekka Enberg wrote:
> On Sat, 4 Feb 2012, Cyrill Gorcunov wrote:
> >In case if there error happened in kvm__init and we have
> >no files opened -- we should not try to close them.
> >
> >Also once kvm failed to init the
On Sat, Feb 04, 2012 at 07:54:38PM +0200, Pekka Enberg wrote:
> On Sat, 4 Feb 2012, Cyrill Gorcunov wrote:
> >Index: linux-2.6.git/tools/kvm/kvm.c
> >===
> >--- linux-2.6.git.orig/tools/kvm/kvm.c
> >+++ li
Otherwise I'm getting the following compile
problem on my Fedora machine. The helper is
rather taken from linux kernel.
| [cyrill@moon kvm]$ make tags
| x86/include/kvm/barrier.h:11:25: fatal error: asm/barrier.h: No such file or
directory compilation terminated.
Signed-off-by: C
On Mon, Jun 04, 2012 at 11:40:53PM +0800, Asias He wrote:
>
> +static void *virtio_blk_thread(void *dev)
> +{
> + struct blk_dev *bdev = dev;
> + u64 data;
> +
> + while (1) {
> + read(bdev->io_efd, &data, sizeof(u64));
> + virtio_blk_do_io(bdev->kvm, &bdev->vq
On Tue, Jun 05, 2012 at 08:47:17AM +0800, Asias He wrote:
> > I must admit I don't understand this code ;) The data get read into
> > stack variable forever?
>
> The data we read itself is not interesting at all. virtio_blk_thread()
> sleeps on the eventfd bdev->io_efd until notify_vq() writes som
From: Cyrill Gorcunov
Use str[n|l] functions to make sure destination is
not overflowed.
Seems socket path generation should be moved into
a separate helper, but it's for another patch.
Signed-off-by: Cyrill Gorcunov
---
tools/kvm/include/kvm/strbuf.h |1 +
tools/kvm/
On Fri, Jun 15, 2012 at 01:34:16PM +0200, Sasha Levin wrote:
> We need to set the HYPERVISOR flag to let the kernel know we're running
> under a hypervisor.
>
> This makes the kernel enable all sorts of para-virtualization options
> such as kvm-clock.
>
> Signed-off-by: Sasha Levin
OK, looks go
On Wed, Jun 20, 2012 at 10:23:06AM +0300, Pekka Enberg wrote:
> On Fri, 15 Jun 2012, Cyrill Gorcunov wrote:
>
> > On Fri, Jun 15, 2012 at 01:34:16PM +0200, Sasha Levin wrote:
> > > We need to set the HYPERVISOR flag to let the kernel know we're running
> > > un
On Sat, Feb 04, 2012 at 10:02:19PM +0400, Cyrill Gorcunov wrote:
>
> Strictly speaking, kvm__init need more serious rewrite together with
> kvm__arch_init/kvm_ipc__start/kvm_ipc__register_handler ret. vals tests,
> i'll do this a bit late.
>
Sorry for delay, was busy. Anyway
On Mon, Feb 06, 2012 at 12:22:04PM +0200, Pekka Enberg wrote:
> Hi Michael,
>
> On Mon, 6 Feb 2012, Michael Ellerman wrote:
> >Signed-off-by: Michael Ellerman
> >---
> >tools/kvm/builtin-run.c |5 +
> >1 files changed, 5 insertions(+), 0 deletions(-)
> >
> >diff --git a/tools/kvm/builtin-r
On Thu, Feb 09, 2012 at 03:01:26PM +0200, Pekka Enberg wrote:
> On Thu, Feb 9, 2012 at 7:40 AM, Yang Bai wrote:
> > Since the different issues have been handled in the
> > internal of kvm__init, it can only return NULL if error
> > happened.
> >
> > Signed-off-by: Yang Bai
>
> Sorry, I don't und
On Mon, Feb 13, 2012 at 08:14:22PM +0800, Yang Bai wrote:
> Hi all,
>
> As I know, native tool does not support loading BIOS so it does not
> support Windows. Is this supporting now?
> If not, I may try to implement it.
>
Nope yet. There was a plan to implement seabios support,
but nothing is do
On Tue, Feb 14, 2012 at 01:10:59PM +0200, Pekka Enberg wrote:
> On Tue, Feb 14, 2012 at 1:03 PM, Yang Bai wrote:
> > Since on X86, bios is always at the end of the address space, so I
> > have some thought about how to implement the seabios support for kvm
> > tool.
> >
> > 1. using kvm__register_
On Tue, Feb 14, 2012 at 09:20:18PM +0800, Yang Bai wrote:
> And will seabios replace the present bios implement or co-exsit?
Ideally we should get rid of our minibios completely and only have
seabios here instead.
Cyrill
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
On Tue, Feb 14, 2012 at 05:35:47PM +0200, Pekka Enberg wrote:
> On Tue, Feb 14, 2012 at 09:20:18PM +0800, Yang Bai wrote:
> >> And will seabios replace the present bios implement or co-exsit?
>
> On Tue, Feb 14, 2012 at 3:32 PM, Cyrill Gorcunov wrote:
> > Ideally
On Tue, Feb 14, 2012 at 11:07:08PM -0500, Kevin O'Connor wrote:
...
> > hardware. Maybe we could poke someone from KVM camp for a hint?
>
> SeaBIOS has two ways to be deployed - first is to copy the image to
> the top of the first 1MB (eg, 0xe-0xf) and jump to
> 0xf000:0xfff0 in 16bit mode
On Fri, Feb 24, 2012 at 05:05:29PM +0200, Pekka Enberg wrote:
> This patch adds a "--bios" command line option to "vm run". You can use this
> to
> try to boot with SeaBIOS, for example:
>
> ./vm run --bios=/usr/share/seabios/bios.bin \
>--disk $HOME/images/debian_lenny_amd64_standard.q
om --dangerous
>
> Cc: Asias He
> Cc: Cyrill Gorcunov
> Cc: Ingo Molnar
> Cc: Sasha Levin
> Signed-off-by: Pekka Enberg
> ---
> tools/kvm/builtin-run.c | 29 ++---
> 1 files changed, 26 insertions(+), 3 deletions(-)
>
> diff --git a/
On Thu, Mar 08, 2012 at 05:11:16PM +0200, Pekka Enberg wrote:
> On Thu, Mar 8, 2012 at 4:32 PM, Daniele Carollo
> wrote:
> > for an university study, I'm doing some network test between two vm
> > using native linux kvm tool and connected via tap/virtio/vhost.
> > When I run my script (several co
On Thu, Mar 08, 2012 at 04:31:17PM +0100, Daniele Carollo wrote:
> > > I don't really use the tap interface so lets CC Asias. Which guest
> > > kernel are you using, btw?
> > >
> >
> > Yup, Asias was using it, if my memory doesn't betray me. Also both -- host
> > and guest kernel versions might be
On Thu, Apr 12, 2012 at 09:39:59PM +0800, 'Asias He wrote:
> +static bool is_mounted(struct stat *st)
> +{
> + struct stat st_buf;
> + struct mntent *mnt;
> + FILE *f;
> +
> + f = setmntent("/proc/mounts", "r");
> + if (!f)
> + return false;
> +
> + while ((mnt =
On 04/11/2011 11:07 PM, Gleb Natapov wrote:
> On Mon, Apr 11, 2011 at 10:01:30PM +0300, Pekka Enberg wrote:
>> On Sun, 2011-04-10 at 16:58 +0300, Gleb Natapov wrote:
>>> On Sun, Apr 10, 2011 at 09:49:31PM +0800, Amos Kong wrote:
System halted.
[note: guest hung ...]
>>> Isn't tha
If user pases own options we need an extra space otherwise
options get joined.
Signed-off-by: Cyrill Gorcunov
---
tools/kvm/kvm-run.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.git/tools/kvm/kvm-run.c
On Fri, Apr 29, 2011 at 11:53 AM, Sasha Levin wrote:
> On Fri, 2011-04-29 at 15:13 +0800, Asias He wrote:
>> On 04/29/2011 02:52 PM, Pekka Enberg wrote:
>> > Please make that IRQ latency fix a separate patch. Don't we need to do
>> > it for TX path as well, btw?
>> >
>>
>> No. We only need it in R
wrote:
> On Fri, Apr 29, 2011 at 1:02 PM, Cyrill Gorcunov wrote:
>> So, if I understand all the things correct -- making virtio devices to
>> belong separated irqs
>> issued some race conditions on read\write operations between host and
>> guest and adding
>&g
On 05/03/2011 11:59 PM, Ingo Molnar wrote:
...
>>>
>>> Hm, how can duplicate definitions happen? Only one place should define them
>>> -
>>> otherwise we might end up with incompatible definitions ...
>>
>> We has ALIGN defined in include/kvm/bios.h within our code.
>
> Well, but then the right
On 05/04/2011 12:10 AM, Cyrill Gorcunov wrote:
> On 05/03/2011 11:59 PM, Ingo Molnar wrote:
> ...
>>>>
>>>> Hm, how can duplicate definitions happen? Only one place should define
>>>> them -
>>>> otherwise we might end up with incompatible d
On 05/04/2011 12:28 AM, Sasha Levin wrote:
> Drops align from bios.h, fixes related code to use
> instead.
>
> Signed-off-by: Sasha Levin
> ---
...
Looks good to me, thanks Sasha. (I suspect it still builds and run, right? :)
--
Thanks,
Cyrill
--
To unsubscribe from this list: send the line
On 05/04/2011 06:44 PM, Sasha Levin wrote:
...
>>
>> There should really be a helper function for these initializations - and a
>> loop
>> that creates VIRTIO_BLK_MAX_DEV of them, right?
>>
>> Also, the IRQs used by kvm should be enumerated in an include file in a
>> single
>> place, with range
Please review, I hope I didn't miss anything. Testing is appereciated
and comments as well.
Thanks,
Cyrill
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
It's better than have them sprinkled in.c files. Note
that pin for ring device is changed so it no longer shared
with block device (it is done in a sake of simplicity).
Also comment style if a bit tuned up in virtio-pci.h
just to be consistent.
Reported-by: Ingo Molnar
Signed-off-by: C
This also requires to tune up mptable code. Note the srcbusirq
need to follow specification convention, so we merge device
number and pin into one field inside mptable_set_default_int_src
helper.
Signed-off-by: Cyrill Gorcunov
---
tools/kvm/include/kvm/virtio-pci-dev.h | 16 +--
tools/kvm
On 05/05/2011 11:06 PM, Cyrill Gorcunov wrote:
> It's better than have them sprinkled in.c files. Note
> that pin for ring device is changed so it no longer shared
> with block device (it is done in a sake of simplicity).
>
> Also comment style if a bit tune
On 05/05/2011 11:06 PM, Cyrill Gorcunov wrote:
> It's better than have them sprinkled in.c files. Note
> that pin for ring device is changed so it no longer shared
> with block device (it is done in a sake of simplicity).
>
> Also comment style if a bit tuned up in virti
On 05/06/2011 12:14 AM, Pekka Enberg wrote:
> On Thu, 5 May 2011, Cyrill Gorcunov wrote:
>> This also requires to tune up mptable code. Note the srcbusirq
>> need to follow specification convention, so we merge device
>> number and pin into one field inside mptable_set_defa
On 05/06/2011 12:16 AM, Pekka Enberg wrote:
> On Fri, 6 May 2011, Cyrill Gorcunov wrote:
>>> This seems to break virtio drivers on my box.
>>>
>>
>> Crap, thanks Pekka, I'll recheck. Drop this series for a while then.
>
> I merged the first pa
On 05/06/2011 11:29 AM, Pekka Enberg wrote:
> On Fri, May 6, 2011 at 10:26 AM, Sasha Levin wrote:
>> virtio-blk needs a block of 4 IRQs (currently - staticly defined).
>> Giving the initial IRQ of 15 causes breakage when adding more
>> than one device.
>>
>> Signed-off-by: Sasha Levin
>
> Can we
On 05/06/2011 11:36 AM, Sasha Levin wrote:
> On Fri, 2011-05-06 at 10:29 +0300, Pekka Enberg wrote:
>> On Fri, May 6, 2011 at 10:26 AM, Sasha Levin wrote:
>>> virtio-blk needs a block of 4 IRQs (currently - staticly defined).
>>> Giving the initial IRQ of 15 causes breakage when adding more
>>> th
On 05/06/2011 12:04 PM, Pekka Enberg wrote:
> On Fri, May 6, 2011 at 11:01 AM, Sasha Levin wrote:
>> On Fri, 2011-05-06 at 10:43 +0300, Pekka Enberg wrote:
>>> On Fri, May 6, 2011 at 10:36 AM, Sasha Levin
>>> wrote:
afaik, we need to have same IRQ pins for devices which may have
differ
On 05/06/2011 12:10 PM, Pekka Enberg wrote:
> On Fri, May 6, 2011 at 11:08 AM, Cyrill Gorcunov wrote:
>> Yes, that is what we do, and it seems to be the "right" way how sane bios
>> should behave, same time (i might be wrong since I didn't checked this
>> part
Only 4 pins are allowed for every PCI compilant device. Mutlifunctional
devices can use up to all INTA#,B#,C#,D# pins, for our sindle function
devices pin INTA# is enough.
Signed-off-by: Cyrill Gorcunov
---
tools/kvm/irq.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
Index
Please review.
Thanks,
Cyrill
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The kernel expects srcbusirq follows MP specification and consists
a tuple of PCI device number with pin encoded. Make it so, otherwise
the kernel reports kind of "buggy MP table" found.
Signed-off-by: Cyrill Gorcunov
---
tools/kvm/mptable.c | 10 +++---
1 file changed, 7 insert
On 05/07/2011 06:55 PM, Cyrill Gorcunov wrote:
> The kernel expects srcbusirq follows MP specification and consists
> a tuple of PCI device number with pin encoded. Make it so, otherwise
> the kernel reports kind of "buggy MP table" found.
>
> Signed-off-by: Cyrill Gor
1 - 100 of 150 matches
Mail list logo
