Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Blue Swirl
On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: > As we have thread-local cpu_single_env now and KVM uses exactly one > thread per VCPU, we can drop the cpu_single_env updates from the loop > and initialize this variable only once during setup. I don't think this is correct. Maybe you missed the

Re: [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Blue Swirl
On Sat, Feb 11, 2012 at 10:06, Jan Kiszka wrote: > On 2012-02-11 11:02, Blue Swirl wrote: >> On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: >>> As we have thread-local cpu_single_env now and KVM uses exactly one >>> thread per VCPU, we can drop the cpu_single_env up

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Blue Swirl
On Sat, Feb 11, 2012 at 12:43, Jan Kiszka wrote: > On 2012-02-11 12:49, Andreas Färber wrote: >> Am 11.02.2012 12:25, schrieb Blue Swirl: >>> I think using cpu_single_env is an indication of a problem, like poor >>> code, layering violation or poor API (vmport). Wha

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Blue Swirl
On Sat, Feb 11, 2012 at 14:00, Jan Kiszka wrote: > On 2012-02-11 14:54, Blue Swirl wrote: >> On Sat, Feb 11, 2012 at 12:43, Jan Kiszka wrote: >>> On 2012-02-11 12:49, Andreas Färber wrote: >>>> Am 11.02.2012 12:25, schrieb Blue Swirl: >>>>> I thi

Re: [Qemu-devel] [PATCH v2 2/8] Allow to use pause_all_vcpus from VCPU context

2012-02-11 Thread Blue Swirl
On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: > In order to perform critical manipulations on the VM state in the > context of a VCPU, specifically code patching, stopping and resuming of > all VCPUs may be necessary. resume_all_vcpus is already compatible, now > enable pause_all_vcpus for this

Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once

2012-02-11 Thread Blue Swirl
On Sat, Feb 11, 2012 at 14:18, Jan Kiszka wrote: > On 2012-02-11 15:11, Blue Swirl wrote: >> On Sat, Feb 11, 2012 at 14:00, Jan Kiszka wrote: >>> On 2012-02-11 14:54, Blue Swirl wrote: >>>> On Sat, Feb 11, 2012 at 12:43, Jan Kiszka wrote: >>>>&

Re: [Qemu-devel] [PATCH v2 3/8] target-i386: Add infrastructure for reporting TPR MMIO accesses

2012-02-11 Thread Blue Swirl
On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: > This will allow the APIC core to file a TPR access report. Depending on > the accelerator and kernel irqchip mode, it will either be delivered > right away or queued for later reporting. > > In TCG mode, we can restart the triggering instruction a

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-11 Thread Blue Swirl
On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: > This enables acceleration for MMIO-based TPR registers accesses of > 32-bit Windows guest systems. It is mostly useful with KVM enabled, > either on older Intel CPUs (without flexpriority feature, can also be > manually disabled for testing) or an

Re: [Qemu-devel] [PATCH v2 5/8] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-13 Thread Blue Swirl
On Mon, Feb 13, 2012 at 10:16, Jan Kiszka wrote: > On 2012-02-11 16:25, Blue Swirl wrote: >> On Fri, Feb 10, 2012 at 18:31, Jan Kiszka wrote: >>> This enables acceleration for MMIO-based TPR registers accesses of >>> 32-bit Windows guest systems. It is mostly useful w

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Blue Swirl
On Mon, Mar 5, 2012 at 15:17, Avi Kivity wrote: > On 03/05/2012 05:15 PM, Anthony Liguori wrote: >>> The other alternative is to s/target_phys_addr_t/uint64_t/ in the memory >>> API.  I think 32-on-32 is quite rare these days, so it wouldn't be much >>> of a performance issue. >> >> >> I think thi

Re: [PATCHv3 00/14] boot order specification

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > This is current sate of the patch series for people to comment on. > I am using open firmware naming scheme to specify device path names. > > Names look like this on pci machine: > /p...@i0cf8/i...@1,1/dr...@1/d...@0 > /p...@i0cf8/i...@1/f...@

Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus.

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 6:21 PM, Michael S. Tsirkin wrote: > On Wed, Nov 10, 2010 at 08:02:12PM +0200, Gleb Natapov wrote: >> On Wed, Nov 10, 2010 at 07:34:12PM +0200, Michael S. Tsirkin wrote: >> > On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: >> > > >> > > Signed-off-by: Gleb Nat

Re: [PATCHv3 11/14] Add bootindex parameter to net/block/fd device

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > If bootindex is specified on command line a string that describes device > in firmware readable way is added into sorted list. Later this list will > be passed into firmware to control boot order. > > Signed-off-by: Gleb Natapov > --- >  bloc

Re: [PATCHv3 04/14] Add get_fw_dev_path callback to ISA bus in qdev.

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > Use device ioports to create unique device path. > > Signed-off-by: Gleb Natapov > --- >  hw/isa-bus.c |   15 +++ >  1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/hw/isa-bus.c b/hw/isa-bus.c > index c0ac7e9..7

Re: [PATCHv3 10/14] Add get_dev_path callback for usb bus.

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/usb-bus.c |   35 +++ >  1 files changed, 35 insertions(+), 0 deletions(-) > > diff --git a/hw/usb-bus.c b/hw/usb-bus.c > index 256b881..6292282 100644 > --- a/hw/usb-bu

Re: [PATCHv3 14/14] Pass boot device list to firmware.

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.h |    1 + >  hw/pc.c     |   19 +++ >  sysemu.h    |    1 + >  vl.c        |   40 >  4 files changed, 61 insertions(+), 0 deletions(-)

Re: [PATCHv3 14/14] Pass boot device list to firmware.

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.h |    1 + >  hw/pc.c     |   19 +++ >  sysemu.h    |    1 + >  vl.c        |   40 >  4 files changed, 61 insertions(+), 0 deletions(-)

Re: [PATCHv3 14/14] Pass boot device list to firmware.

2010-11-10 Thread Blue Swirl
2010/11/10 Gleb Natapov : > On Wed, Nov 10, 2010 at 07:11:54PM +0000, Blue Swirl wrote: >> On Wed, Nov 10, 2010 at 5:14 PM, Gleb Natapov wrote: >> > >> > Signed-off-by: Gleb Natapov >> > --- >> >  hw/fw_cfg.h |    1 + >> >  hw/pc.c  

Re: [PATCHv3 00/14] boot order specification

2010-11-11 Thread Blue Swirl
On Thu, Nov 11, 2010 at 10:21 AM, Gerd Hoffmann wrote: > On 11/10/10 18:14, Gleb Natapov wrote: >> >> This is current sate of the patch series for people to comment on. >> I am using open firmware naming scheme to specify device path names. >> >> Names look like this on pci machine: >> /p...@i0cf8

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.c |   14 ++ >  hw/fw_cfg.h |    4 +++- >  sysemu.h    |    1 + >  vl.c        |   51 +++ >  4 files changed, 69 insertions(+), 1 dele

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 8:54 PM, Michael S. Tsirkin wrote: > On Sun, Nov 14, 2010 at 08:49:59PM +0000, Blue Swirl wrote: >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: >> > >> > Signed-off-by: Gleb Natapov >> > --- >> >  hw/fw_cfg.c |

Re: [PATCHv4 13/15] Add bootindex for option roms.

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > Extend -option-rom command to have additional parameter ,bootindex=. This patch is broken: CCarm-softmmu/palm.o /src/qemu/hw/palm.c: In function 'palmte_init': /src/qemu/hw/palm.c:237: error: incompatible type for argument 1 of 'get_ima

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.c |   14 ++ >  hw/fw_cfg.h |    4 +++- >  sysemu.h    |    1 + >  vl.c        |   51 +++ >  4 files changed, 69 insertions(+), 1 dele

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-15 Thread Blue Swirl
2010/11/15 Gleb Natapov : > On Sun, Nov 14, 2010 at 10:50:13PM +0000, Blue Swirl wrote: >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: >> > >> > Signed-off-by: Gleb Natapov >> > --- >> >  hw/fw_cfg.c |   14 ++ >>

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-16 Thread Blue Swirl
On Tue, Nov 16, 2010 at 7:22 AM, Gleb Natapov wrote: > On Mon, Nov 15, 2010 at 09:52:19PM -0500, Kevin O'Connor wrote: >> On Mon, Nov 15, 2010 at 03:36:25PM +0200, Gleb Natapov wrote: >> > On Mon, Nov 15, 2010 at 08:26:35AM -0500, Kevin O'Connor wrote: >> > > On Mon, Nov 15, 2010 at 09:40:08AM +02

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-16 Thread Blue Swirl
2010/11/16 Gleb Natapov : > On Mon, Nov 15, 2010 at 08:29:24PM +0000, Blue Swirl wrote: >> 2010/11/15 Gleb Natapov : >> > On Sun, Nov 14, 2010 at 10:50:13PM +, Blue Swirl wrote: >> >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: >> >

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-17 Thread Blue Swirl
2010/11/16 Gleb Natapov : > On Tue, Nov 16, 2010 at 06:30:19PM +0000, Blue Swirl wrote: >> >> Perhaps the FW path should use device class names if no name is specified. >> > What do you mean by "device class name". We can do something like this: >> > if (

Re: [PATCHv6 00/16] boot order specification

2010-11-23 Thread Blue Swirl
On Tue, Nov 23, 2010 at 4:12 PM, Anthony Liguori wrote: > On 11/23/2010 09:31 AM, Gleb Natapov wrote: >> >> Anthony, Blue >> >> No comments on this patch series for almost a week. Can it be applied? >> > > Does that mean everyone's happy or have folks not gotten around to review > it? > > IOW, las

Re: [Qemu-devel] [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-11-23 Thread Blue Swirl
On Tue, Nov 23, 2010 at 4:49 PM, Anthony Liguori wrote: > qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT.  Instead of teaching > them to respond to these signals (which cannot be trapped), use SIGUSR1 to > approximate the behavior of SIGSTOP/SIGCONT. > > The purpose of this is to implemen

Re: [Qemu-devel] [PATCH 00/21] Kemari for KVM 0.2

2010-11-26 Thread Blue Swirl
On Thu, Nov 25, 2010 at 6:06 AM, Yoshiaki Tamura wrote: > Hi, > > This patch series is a revised version of Kemari for KVM, which > applied comments for the previous post and KVM Forum 2010.  The > current code is based on qemu.git > f711df67d611e4762966a249742a5f7499e19f99. > > For general inform

Re: [Qemu-devel] [PATCH 00/21] Kemari for KVM 0.2

2010-11-27 Thread Blue Swirl
On Sat, Nov 27, 2010 at 8:53 AM, Yoshiaki Tamura wrote: > 2010/11/27 Stefan Hajnoczi : >> On Sat, Nov 27, 2010 at 4:29 AM, Yoshiaki Tamura >> wrote: >>> 2010/11/27 Blue Swirl : >>>> On Thu, Nov 25, 2010 at 6:06 AM, Yoshiaki Tamura >>>> wrote: >

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Blue Swirl
On Sun, Nov 28, 2010 at 7:54 AM, Gleb Natapov wrote: > On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: >> On 11/23/2010 06:12 PM, Anthony Liguori wrote: >> >On 11/23/2010 09:31 AM, Gleb Natapov wrote: >> >>Anthony, Blue >> >> >> >>No comments on this patch series for almost a week. Can

Re: [PATCHv6 00/16] boot order specification

2010-11-28 Thread Blue Swirl
On Sun, Nov 28, 2010 at 1:19 PM, Gleb Natapov wrote: > On Sun, Nov 28, 2010 at 03:13:52PM +0200, Michael S. Tsirkin wrote: >> On Sun, Nov 28, 2010 at 09:54:04AM +0200, Gleb Natapov wrote: >> > On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: >> > > On 11/23/2010 06:12 PM, Anthony Liguor

Re: [PATCHv8 00/16] boot order specification

2010-12-11 Thread Blue Swirl
Thanks, applied all. On Wed, Dec 8, 2010 at 11:34 AM, Gleb Natapov wrote: > Forget to save a couple of buffers before sending version 7 :( > > Anthony, Blue can this be applied now? > > Gleb Natapov (16): >  Introduce fw_name field to DeviceInfo structure. >  Introduce new BusInfo callback get_fw

Re: [Qemu-devel] [RESEND PATCH v3 1/2] Minimal RAM API support

2010-12-13 Thread Blue Swirl
On Mon, Dec 13, 2010 at 8:47 PM, Alex Williamson wrote: > This adds a minimum chunk of Anthony's RAM API support so that we > can identify actual VM RAM versus all the other things that make > use of qemu_ram_alloc. > > Signed-off-by: Alex Williamson > --- > >  Makefile.objs |    1 + >  cpu-commo

Re: [Qemu-devel] possible regression in qemu-kvm 0.13.0 (memtest)

2010-12-28 Thread Blue Swirl
On Mon, Dec 27, 2010 at 3:47 AM, Stefan Hajnoczi wrote: > On Sat, Dec 25, 2010 at 7:02 PM, Peter Lieven wrote: >> this was the outcome of my bisect session: >> >> 956a3e6bb7386de48b642d4fee11f7f86a2fcf9a is first bad commit >> commit 956a3e6bb7386de48b642d4fee11f7f86a2

Re: FIXED: Re: [Qemu-devel] possible regression in qemu-kvm 0.13.0 (memtest)

2011-01-06 Thread Blue Swirl
On Thu, Jan 6, 2011 at 4:41 PM, Serge E. Hallyn wrote: > Thanks, Stefan.  That patch actually doesn't compile for me, because > it leaves references in hw/pckbd.c to both ioport92_write and > ioport92_read, which it deletes from there.  Should ioport92_read > just be renamed to outport_read instea

Re: [Qemu-devel] [PATCH uq/master 1/2] Add qemu_ram_remap

2011-01-13 Thread Blue Swirl
On Thu, Jan 13, 2011 at 8:34 AM, Huang Ying wrote: > qemu_ram_remap() unmaps the specified RAM pages, then re-maps these > pages again.  This is used by KVM HWPoison support to clear HWPoisoned > page tables across guest rebooting, so that a new page may be > allocated later to recover the memory

Re: [Qemu-devel] [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-01-13 Thread Blue Swirl
On Thu, Jan 13, 2011 at 5:15 PM, Yoshiaki Tamura wrote: > Introduce qemu_savevm_state_{begin,commit} to send the memory and > device info together, while avoiding cancelling memory state tracking. > > Signed-off-by: Yoshiaki Tamura > --- >  savevm.c |   88 > +

Re: [Qemu-devel] [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2011-01-13 Thread Blue Swirl
On Thu, Jan 13, 2011 at 5:15 PM, Yoshiaki Tamura wrote: > When -k option is set to migrate command, it will turn on ft_mode to > start FT migration mode (Kemari). > > Signed-off-by: Yoshiaki Tamura > --- >  hmp-commands.hx |    7 --- >  migration.c     |    3 +++ >  qmp-commands.hx |    7 +++

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-11 Thread Blue Swirl
On Mon, Apr 11, 2011 at 10:01 AM, Markus Armbruster wrote: > Avi Kivity writes: > >> On 04/08/2011 12:41 AM, Anthony Liguori wrote: >>> >>> And it's a good thing to have, but exposing this as the only API to >>> do something as simple as generating a guest crash dump is not the >>> friendliest th

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-12 Thread Blue Swirl
On Tue, Apr 12, 2011 at 10:52 AM, Avi Kivity wrote: > On 04/11/2011 08:15 PM, Blue Swirl wrote: >> >> On Mon, Apr 11, 2011 at 10:01 AM, Markus Armbruster >>  wrote: >> >  Avi Kivity  writes: >> > >> >>  On 04/08/2011 12:41 AM, Anthony Liguori

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-13 Thread Blue Swirl
On Wed, Apr 13, 2011 at 4:08 PM, Luiz Capitulino wrote: > On Tue, 12 Apr 2011 21:31:18 +0300 > Blue Swirl wrote: > >> On Tue, Apr 12, 2011 at 10:52 AM, Avi Kivity wrote: >> > On 04/11/2011 08:15 PM, Blue Swirl wrote: >> >> >> >> On Mon, Apr 11,

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-15 Thread Blue Swirl
On Thu, Apr 14, 2011 at 12:55 PM, Daniel P. Berrange wrote: > On Wed, Apr 13, 2011 at 10:56:21PM +0300, Blue Swirl wrote: >> On Wed, Apr 13, 2011 at 4:08 PM, Luiz Capitulino >> wrote: >> > On Tue, 12 Apr 2011 21:31:18 +0300 >> > Blue Swirl wrote: >> &

Re: [Qemu-devel] [PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only)

2011-04-28 Thread Blue Swirl
On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell wrote: > 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain > entry addresses of functions that are utilized by update_irq() to > detect coalesced interrupts. apic code loads these pointers during > initialization. I'm not so happ

Re: [Qemu-devel] [PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only)

2011-04-29 Thread Blue Swirl
On Fri, Apr 29, 2011 at 12:45 PM, Ulrich Obergfell wrote: > >> On 2011-04-28 20:51, Blue Swirl wrote: >>> On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell wrote: >>>> 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain >

Re: [Qemu-devel] [RFC v1] Add declarations for hierarchical memory region API

2011-05-20 Thread Blue Swirl
On Thu, May 19, 2011 at 5:12 PM, Avi Kivity wrote: > The memory API separates the attributes of a memory region (its size, how > reads or writes are handled, dirty logging, and coalescing) from where it > is mapped and whether it is enabled.  This allows a device to configure > a memory region onc

Re: [Qemu-devel] [RFC v1] Add declarations for hierarchical memory region API

2011-05-20 Thread Blue Swirl
On Fri, May 20, 2011 at 5:46 PM, Anthony Liguori wrote: > On 05/20/2011 09:40 AM, Richard Henderson wrote: >> >> On 05/20/2011 07:31 AM, Anthony Liguori wrote: >>> >>> But is this a characteristic of devices or is this a characteristic of >>> the chipset/CPU? >> >> Chipset. > > So if the chipset o

Re: [Qemu-devel] [RFC v1] Add declarations for hierarchical memory region API

2011-05-22 Thread Blue Swirl
On Sun, May 22, 2011 at 9:45 AM, Avi Kivity wrote: > On 05/20/2011 08:59 PM, Blue Swirl wrote: >> >> On Thu, May 19, 2011 at 5:12 PM, Avi Kivity  wrote: >> >  The memory API separates the attributes of a memory region (its size, >> > how >> >  reads

Re: [Qemu-devel] [RFC v1] Add declarations for hierarchical memory region API

2011-05-22 Thread Blue Swirl
On Sun, May 22, 2011 at 2:36 PM, Avi Kivity wrote: > On 05/22/2011 12:32 PM, Blue Swirl wrote: >> >> >>  >    +void memory_region_add_coalescing(MemoryRegion *mr, >> >>  >    +                    

Re: [Qemu-devel] [RFC v1] Add declarations for hierarchical memory region API

2011-05-22 Thread Blue Swirl
On Sun, May 22, 2011 at 3:18 PM, Avi Kivity wrote: > On 05/22/2011 03:06 PM, Blue Swirl wrote: >> >> On Sun, May 22, 2011 at 2:36 PM, Avi Kivity  wrote: >> >  On 05/22/2011 12:32 PM, Blue Swirl wrote: >> >> >> >>  >>    >

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-06-04 Thread Blue Swirl
On Wed, Jun 1, 2011 at 2:30 AM, Anthony Liguori wrote: > On 05/31/2011 02:24 PM, Vivek Goyal wrote: >> >> On Tue, May 31, 2011 at 01:39:47PM -0500, Anthony Liguori wrote: >>> >>> On 05/31/2011 12:59 PM, Vivek Goyal wrote: >> >> Ok, so we seem to be talking of two requirements. >> >> - A consistent

Re: [Qemu-devel] [PATCH V2 11/20] tap: support enabling or disabling a queue

2013-01-25 Thread Blue Swirl
On Fri, Jan 25, 2013 at 10:35 AM, Jason Wang wrote: > This patch introduce a new bit - enabled in TAPState which tracks whether a > specific queue/fd is enabled. The tap/fd is enabled during initialization and > could be enabled/disabled by tap_enalbe() and tap_disable() which calls > platform >

Re: [Qemu-devel] [PATCH V2 11/20] tap: support enabling or disabling a queue

2013-01-29 Thread Blue Swirl
On Tue, Jan 29, 2013 at 1:50 PM, Jason Wang wrote: > On 01/26/2013 03:13 AM, Blue Swirl wrote: >> On Fri, Jan 25, 2013 at 10:35 AM, Jason Wang wrote: >>> This patch introduce a new bit - enabled in TAPState which tracks whether a >>> specific queue/fd is enabled. T

Re: [PATCH v3 2/3] VFIO-AER: Vfio-pci driver changes for supporting AER

2013-02-03 Thread Blue Swirl
On Sun, Feb 3, 2013 at 2:10 PM, Pandarathil, Vijaymohan R wrote: > - New VFIO_SET_IRQ ioctl option to pass the eventfd that is signaled > when > an error occurs in the vfio_pci_device > > - Register pci_error_handler for the vfio_pci driver > > - When the device

Re: [PATCH v3 3/3] QEMU-AER: Qemu changes to support AER for VFIO-PCI devices

2013-02-03 Thread Blue Swirl
On Sun, Feb 3, 2013 at 2:10 PM, Pandarathil, Vijaymohan R wrote: > - Create eventfd per vfio device assigned to a guest and register an > event handler > > - This fd is passed to the vfio_pci driver through the SET_IRQ ioctl > > - When the device encounters an err

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Blue Swirl
On Wed, Sep 5, 2012 at 3:41 PM, Anthony Liguori wrote: > Avi Kivity writes: > >> On 09/05/2012 12:00 AM, Anthony Liguori wrote: Why? The way this is being submitted I don't see why we should treat Jan's patch any different from a patch by IBM or Samsung where we've asked folks

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Blue Swirl
On Tue, Sep 4, 2012 at 9:28 PM, Michael S. Tsirkin wrote: > On Tue, Sep 04, 2012 at 07:27:32PM +0000, Blue Swirl wrote: >> On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity wrote: >> > On 09/03/2012 10:32 PM, Blue Swirl wrote: >> >> On Mon, Sep 3, 2012 at 4:14 PM, Avi

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Blue Swirl
On Wed, Sep 5, 2012 at 7:22 PM, Anthony Liguori wrote: > Blue Swirl writes: > >> On Wed, Sep 5, 2012 at 3:41 PM, Anthony Liguori >> wrote: >>> Avi Kivity writes: >>> >>>> On 09/05/2012 12:00 AM, Anthony Liguori wrote: >>>>>&

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Blue Swirl
On Wed, Sep 5, 2012 at 7:24 PM, Eric Blake wrote: > On 09/05/2012 01:04 PM, Blue Swirl wrote: >>> I don't mind GPLv2+, if people want to share code from QEMU in GPLv3 >>> projects, GPLv2+ enables that. >> >> The advantage of 100% GPLv2+ (or other GPLv3 c

Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Blue Swirl
On Thu, Sep 6, 2012 at 3:42 AM, Alexander Graf wrote: > > On 05.09.2012, at 15:38, Blue Swirl wrote: > >> On Wed, Sep 5, 2012 at 7:22 PM, Anthony Liguori >> wrote: >>> Blue Swirl writes: >>> >>>> On Wed, Sep 5, 2012 at 3:41 PM, Ant

Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Blue Swirl
On Thu, Sep 6, 2012 at 4:06 PM, Andreas Färber wrote: > Am 06.09.2012 10:44, schrieb Jan Kiszka: >> On 2012-08-30 20:30, Jan Kiszka wrote: >>> This adds PCI device assignment for i386 targets using the classic KVM >>> interfaces. This version is 100% identical to what is being maintained >>> in qe

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Blue Swirl
On Thu, Sep 6, 2012 at 8:44 AM, Avi Kivity wrote: > On 09/05/2012 10:04 PM, Blue Swirl wrote: >> >> Reinventing a disassembler for ever growing x86 assembly is >> no fun. > > We can try linking to a disassembler library. I use udis86 to > disassemble instructi

Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Blue Swirl
On Sat, Sep 8, 2012 at 9:28 AM, Alexander Graf wrote: > > > On 08.09.2012, at 10:06, Blue Swirl wrote: > >> On Thu, Sep 6, 2012 at 8:44 AM, Avi Kivity wrote: >>> On 09/05/2012 10:04 PM, Blue Swirl wrote: >>>> >>>> Reinventing a disass

Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Blue Swirl
On Sat, Sep 8, 2012 at 12:13 PM, Alexander Graf wrote: > > > On 08.09.2012, at 12:16, Blue Swirl wrote: > >> On Sat, Sep 8, 2012 at 9:28 AM, Alexander Graf wrote: >>> >>> >>> On 08.09.2012, at 10:06, Blue Swirl wrote: >>> >>>>

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 9:51 AM, Gerd Hoffmann wrote: > This patch adds a mmio bar to the qemu standard vga which allows to > access the standard vga registers and bochs dispi interface registers > via mmio. > > Cc: Benjamin Herrenschmidt > Signed-off-by: Gerd Hoffmann > --- > hw/vga-pci.c |

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-22 Thread Blue Swirl
On Thu, Sep 20, 2012 at 5:43 AM, Gerd Hoffmann wrote: > Hi, > >>> +vbe_ioport_write_index(&d->vga, 0, index); >>> +return vbe_ioport_read_data(&d->vga, 0); >> >> These functions are only available with CONFIG_BOCHS_VBE #defined, so >> this code should be conditional as well. >> >> But bu

Re: [Qemu-devel] [PATCH v5 00/17] Allow changing of Hypervisor CPUIDs.

2012-09-22 Thread Blue Swirl
On Sat, Sep 22, 2012 at 12:13 AM, Don Slutz wrote: > Also known as Paravirtualization CPUIDs. > > This is primarily done so that the guest will think it is running > under vmware when hypervisor-vendor=vmware is specified as a > property of a cpu. Please use checkpatch.pl to check for missing bra

Re: [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis wrote: > Example: > "-dimm id=dimm0,size=512M,node=0,populated=off" There should not be a need to introduce a new top level option, instead you should just use -device, like -device dimm,base=0,id=dimm0,size=512M,node=0,populated=off That wou

Re: [RFC PATCH v3 07/19] acpi_piix4: Implement memory device hotplug registers

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis wrote: > A 32-byte register is used to present up to 256 hotplug-able memory devices > to BIOS and OSPM. Hot-add and hot-remove functions trigger an ACPI hotplug > event through these. Only reads are allowed from these registers. > > An ACPI ho

Re: [RFC PATCH v3 08/19] pc: calculate dimm physical addresses and adjust memory map

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis wrote: > Dimm physical address offsets are calculated automatically and memory map is > adjusted accordingly. If a DIMM can fit before the PCI_HOLE_START (currently > 0xe000), it will be added normally, otherwise its physical address will b

Re: [RFC PATCH v3 00/19] ACPI memory hotplug

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis wrote: > This is v3 of the ACPI memory hotplug functionality. Only x86_64 target is > supported > for now. > > Overview: > > Dimm device layout is modeled with a new qemu command line > > "-dimm id=name,size=sz,node=pxm,populated=on|off" > > T

Re: [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-09-29 Thread Blue Swirl
On Mon, Sep 24, 2012 at 10:42 AM, Vasilis Liaskovitis wrote: > On Sat, Sep 22, 2012 at 01:46:57PM +0000, Blue Swirl wrote: >> On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis >> wrote: >> > Example: >> > "-dimm id=dimm0,size=512M,node=0,populated=of

Re: [RFC PATCH v3 08/19] pc: calculate dimm physical addresses and adjust memory map

2012-09-29 Thread Blue Swirl
On Mon, Sep 24, 2012 at 3:27 PM, Vasilis Liaskovitis wrote: > On Sat, Sep 22, 2012 at 02:15:28PM +0000, Blue Swirl wrote: >> > + >> > +/* Function to configure memory offsets of hotpluggable dimms */ >> > + >> > +target_phys_addr_

Re: [PATCH] kvm: Set default accelerator to "kvm" if the host supports it

2012-10-03 Thread Blue Swirl
On Mon, Oct 1, 2012 at 4:20 PM, Anthony Liguori wrote: > Jan Kiszka writes: > >> If we built a target for a host that supports KVM in principle, set the >> default accelerator to KVM as well. This also means the start of QEMU >> will fail to start if KVM support turns out to be unavailable at >>

Re: [PATCH v6 3/4] vfio: vfio-pci device assignment driver

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 5:11 PM, Alex Williamson wrote: > On Fri, 2012-10-05 at 16:54 +0000, Blue Swirl wrote: >> On Wed, Sep 26, 2012 at 5:19 PM, Alex Williamson >> wrote: >> > + >> > +typedef struct QEMU_PACKED VFIOIRQSetFD { >> > +struct

Re: [PATCH v6 3/4] vfio: vfio-pci device assignment driver

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 5:33 PM, Alex Williamson wrote: > On Fri, 2012-10-05 at 17:22 +0000, Blue Swirl wrote: >> On Fri, Oct 5, 2012 at 5:11 PM, Alex Williamson >> wrote: >> > On Fri, 2012-10-05 at 16:54 +, Blue Swirl wrote: >> >> On Wed, Sep 26, 2012 at 5

Re: [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-10-13 Thread Blue Swirl
On Tue, Oct 9, 2012 at 5:04 PM, Vasilis Liaskovitis wrote: > Hi, > > sorry for the delayed answer. > > On Sat, Sep 29, 2012 at 11:13:04AM +0000, Blue Swirl wrote: >> > >> > The "-dimm" option is supposed to specify the dimm/memory layout, and not &g

Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture

2012-10-13 Thread Blue Swirl
On Wed, Oct 10, 2012 at 3:07 PM, Peter Maydell wrote: > From: Christoffer Dall > > Add basic support for KVM on ARM architecture. > > Signed-off-by: Christoffer Dall > [PMM: Minor tweaks and code cleanup, switch to ONE_REG] > Signed-off-by: Peter Maydell > --- > hw/arm_pic.c | 28

Re: [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-10-19 Thread Blue Swirl
On Thu, Oct 18, 2012 at 12:33 PM, Avi Kivity wrote: > On 10/18/2012 11:27 AM, Vasilis Liaskovitis wrote: >> On Wed, Oct 17, 2012 at 12:03:51PM +0200, Avi Kivity wrote: >>> On 10/17/2012 11:19 AM, Vasilis Liaskovitis wrote: >>> >> >>> >> I don't think so, but probably there's a limit of DIMMs that

[PATCH 2/5] kvm: avoid using cpu_single_env

2012-10-28 Thread Blue Swirl
Pass around CPUState instead of using global cpu_single_env. Signed-off-by: Blue Swirl --- target-i386/kvm.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 3aa62b2..3329d5e 100644 --- a/target-i386/kvm.c

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm/pci-assign: 64 bits bar emulation

2012-11-03 Thread Blue Swirl
On Fri, Nov 2, 2012 at 5:38 AM, Xudong Hao wrote: > Enable 64 bits bar emulation. > > Signed-off-by: Xudong Hao > --- > hw/kvm/pci-assign.c | 18 -- > 1 files changed, 12 insertions(+), 6 deletions(-) > > diff --git a/hw/kvm/pci-assign.c b/hw/kvm/pci-assign.c > index 05b93d9..f

Re: [Qemu-devel] Release plan for 0.12.0

2009-09-30 Thread Blue Swirl
On Wed, Sep 30, 2009 at 6:59 PM, Carl-Daniel Hailfinger wrote: > On 30.09.2009 15:07, Anthony Liguori wrote: >> Carl-Daniel Hailfinger wrote: >>> However, to run coreboot on Qemu with the same init sequence as on >>> simplified real hardware, we need Cache-as-RAM (CAR) support. [...] >> >> Do we r

Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()

2010-05-11 Thread Blue Swirl
On 5/10/10, Alex Williamson wrote: > If the init function of a device fails, as might happen with device > assignment, we never undo the work done by do_pci_register_device(). > This not only causes a bit of a memory leak, but also leaves a bogus > pointer in the bus devices array that can caus

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-20 Thread Blue Swirl
On Wed, May 19, 2010 at 7:22 PM, Christian Brunner wrote: > The attached patch is a block driver for the distributed file system > Ceph (http://ceph.newdream.net/). This driver uses librados (which > is part of the Ceph server) for direct access to the Ceph object > store and is running entirely i

Re: [PATCH] pc: fix segfault introduced by 3d53f5c36ff6

2010-05-20 Thread Blue Swirl
Good catch. Thanks, applied. On Thu, May 20, 2010 at 6:14 AM, Eduard - Gabriel Munteanu wrote: > Commit 3d53f5c36ff6 introduced a segfault by erroneously making fw_cfg a > 'void **' and passing it around in different ways. > > Signed-off-by: Eduard - Gabriel Munteanu > --- >  hw/pc.c |    4 ++-

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-23 Thread Blue Swirl
On Thu, May 20, 2010 at 11:02 PM, Yehuda Sadeh Weinraub wrote: > On Thu, May 20, 2010 at 1:31 PM, Blue Swirl wrote: >> On Wed, May 19, 2010 at 7:22 PM, Christian Brunner wrote: >>> The attached patch is a block driver for the distributed file system >>> Ceph (http:

Re: [Qemu-devel] Re: [RFC PATCH] AMD IOMMU emulation

2010-05-24 Thread Blue Swirl
On Mon, May 24, 2010 at 3:40 PM, Joerg Roedel wrote: > Hi Eduard, > > On Thu, May 20, 2010 at 04:50:07PM +0300, Eduard - Gabriel Munteanu wrote: >> +  --enable-amd-iommu-emul) amd_iommu="yes" >> +  ;; > > A compile-time option is a good idea. > >> +/* MMIO registers */ >> +#define MMIO_DEVICE_TABL

Re: [Qemu-devel] Re: [RFC PATCH] AMD IOMMU emulation

2010-05-25 Thread Blue Swirl
On Tue, May 25, 2010 at 8:39 AM, Joerg Roedel wrote: > On Mon, May 24, 2010 at 08:10:16PM +0000, Blue Swirl wrote: >> On Mon, May 24, 2010 at 3:40 PM, Joerg Roedel wrote: >> >> + >> >> +#define MMIO_SIZE               0x2028 >> > >> > Thi

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-25 Thread Blue Swirl
On Mon, May 24, 2010 at 2:17 AM, Yehuda Sadeh Weinraub wrote: > On Sun, May 23, 2010 at 12:59 AM, Blue Swirl wrote: >> On Thu, May 20, 2010 at 11:02 PM, Yehuda Sadeh Weinraub >> wrote: >>> On Thu, May 20, 2010 at 1:31 PM, Blue Swirl wrote: >>>> On Wed

Re: [Qemu-devel] [PATCH v6 5/6] Inter-VM shared memory PCI device

2010-06-05 Thread Blue Swirl
On Fri, Jun 4, 2010 at 9:45 PM, Cam Macdonell wrote: > Support an inter-vm shared memory device that maps a shared-memory object as a > PCI device in the guest.  This patch also supports interrupts between guest by > communicating over a unix domain socket.  This patch applies to the qemu-kvm > re

Re: [Qemu-devel] [PATCH v6 5/6] Inter-VM shared memory PCI device

2010-06-09 Thread Blue Swirl
On Mon, Jun 7, 2010 at 4:41 PM, Cam Macdonell wrote: > On Sat, Jun 5, 2010 at 3:44 AM, Blue Swirl wrote: >> On Fri, Jun 4, 2010 at 9:45 PM, Cam Macdonell wrote: >>> Support an inter-vm shared memory device that maps a shared-memory object >>> as a >>> PCI d

Re: [Qemu-devel] [PATCH 10/10] TCP based live migration

2008-09-10 Thread Blue Swirl
On 9/9/08, Anthony Liguori <[EMAIL PROTECTED]> wrote: > This patch introduces a tcp protocol for live migration. It can be used as > follows: > > qemu-system-x86_64 -hda ~/images/linux-test.img -monitor stdio > > (qemu) migrate tcp:localhost:1025 > > On the same system: > > qemu-system-x86

Re: [Qemu-devel] [PATCH 8/10] Introduce a buffered QEMUFile wrapper

2008-09-12 Thread Blue Swirl
On 9/9/08, Anthony Liguori <[EMAIL PROTECTED]> wrote: > This patch introduces a buffered QEMUFile wrapper. This allows QEMUFile's to > be > rate limited. It also allows makes it easier to implement a QEMUFile that is > asynchronous. > > The only real non-obvious part of the API is the "frozen

Re: [Qemu-devel] [PATCH 1/10] Refactor QEMUFile for live migration

2008-09-12 Thread Blue Swirl
On 9/9/08, Anthony Liguori <[EMAIL PROTECTED]> wrote: > To support live migration, we override QEMUFile so that instead of writing to > disk, the save/restore state happens over a network connection. > > This patch makes QEMUFile read/write operations function pointers so that we > can override

Re: [Qemu-devel] [PATCH 3/10] Add bdrv_flush_all()

2008-09-12 Thread Blue Swirl
On 9/9/08, Anthony Liguori <[EMAIL PROTECTED]> wrote: > This patch adds a bdrv_flush_all() function. It's necessary to ensure that > all > IO operations have been flushed to disk before completely a live migration. > > N.B. we don't actually use this now. We really should flush the block > dr

Re: [Qemu-devel] [PATCH] Refactor AIO to allow multiple AIO implementations

2008-09-16 Thread Blue Swirl
On 9/16/08, Anthony Liguori <[EMAIL PROTECTED]> wrote: > This patch refactors the AIO layer to allow multiple AIO implementations. > It's > only possible because of the recent signalfd() patch. > +/* This is a simple lock used to protect the aio_handlers list. > Specifically, > + * it's use

KVM for Sparc?

2008-09-21 Thread Blue Swirl
Hi, Sorry for cross-posting (and because I used the wrong address in the first time for KVM, sorry for the duplicate on Sparclinux). Sparc host support for Qemu is getting close to ready, I can already run a Sparc32 system emulator on OpenBSD/Sparc64 and there is some limited success with rec

Re: KVM for Sparc?

2008-09-23 Thread Blue Swirl
On 9/22/08, David Miller <[EMAIL PROTECTED]> wrote: > From: Anthony Liguori <[EMAIL PROTECTED]> > Date: Mon, 22 Sep 2008 14:34:21 -0500 > > > > Blue Swirl wrote: > > > But I think we could already start early drafting of what KVM support > > >

Re: KVM for Sparc?

2008-09-23 Thread Blue Swirl
On 9/23/08, David Miller <[EMAIL PROTECTED]> wrote: > From: Hollis Blanchard <[EMAIL PROTECTED]> > > Date: Mon, 22 Sep 2008 16:25:51 -0500 > > > > On Mon, 2008-09-22 at 13:26 -0700, David Miller wrote: > > > From: Hollis Blanchard <[EMAIL PROTECTED]> > > > Date: Mon, 22 Sep 2008 15:18:39 -0500 >

<    1   2   3   >