Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Blue Swirl
On 6/12/09, Mark McLoughlin wrote: > On Fri, 2009-06-12 at 12:00 -0500, Anthony Liguori wrote: > > Mark McLoughlin wrote: > > > So, when libvirt creates a guest for the first time, it makes a copy of > > > the device tree and continues to use that even if qemu is upgraded. > > > That's enough

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Blue Swirl
On 6/15/09, Avi Kivity wrote: > On 06/15/2009 09:12 PM, Anthony Liguori wrote: > > > > > 2) Whenever the default machine type changes in a guest-visible way, > introduce a new machine type > > > > s/whenever/qemu stable release/ > > > > - Use explicit versions in name: pc-v1, pc-v2 > > > > pc-q

Re: [Qemu-devel] Planning for the 0.11.0 release

2009-06-23 Thread Blue Swirl
On 6/23/09, Anthony Liguori wrote: > Hi, > > It's getting to be about the time to start thinking about the 0.11.0 > release. 0.10.0 was released on March 2nd so following with the 6 month > release cycle, that would put 0.11.0 at September 2nd. > > Based on the experiences with the stable relea

Re: [Qemu-devel] [PATCH] virtio_serial: A char device for simple guest <-> host communication

2009-06-23 Thread Blue Swirl
On 6/23/09, Amit Shah wrote: > We expose multiple char devices ("ports") for simple communication > between the host userspace and guest. > +struct virtio_serial_config { > + __u32 nr_ports; > + __u16 status; > +} __attribute__((packed)); There is still structure packing. I'd use

Re: [Qemu-devel] [PATCH] virtio-serial: virtio device for simple host <-> guest communication

2009-06-23 Thread Blue Swirl
On 6/23/09, Amit Shah wrote: > This interface presents a char device from which bits can be > sent and read. > +struct virtio_serial_config > +{ > +uint32_t nr_ports; > +uint16_t status; > +} __attribute__((packed)); Obviously this has to match the kernel structure if you go for 16

Re: [Qemu-devel] QEMU bug tracker on Launchpad

2009-06-23 Thread Blue Swirl
On 6/23/09, Anthony Liguori wrote: > Dustin Kirkland was kind enough to setup a bug tracker for QEMU on > Launchpad. I would like to make this the official QEMU bug tracker unless > there is significant objection. The links on code tab do not show which is our tree and there are some Ubuntu tree

Re: [Qemu-devel] [PATCHv3 1/3] qemu/msi: fix segfault in msix_save

2009-07-05 Thread Blue Swirl
On 7/5/09, Michael S. Tsirkin wrote: > This fixes segfault reported by Kevin Wolf, > and simplifies the code in msix_save. > +if (!dev->cap_present & QEMU_PCI_CAP_MSIX) > +return; Dubious: !x & y. You also forgot the braces. -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCHv4 4/5] qemu/msi: missing braces

2009-07-05 Thread Blue Swirl
On 7/5/09, Michael S. Tsirkin wrote: > MSIX present bit is tested incorrectly, and only happens to work because > the bit we are testing is 0x1. Add braces to fix this. > > Reported-by: Blue Swirl > Signed-off-by: Michael S. Tsirkin > --- > hw/msix.c |2 +- &

Re: [PATCHv4 4/5] qemu/msi: missing braces

2009-07-05 Thread Blue Swirl
On 7/5/09, Michael S. Tsirkin wrote: > On Sun, Jul 05, 2009 at 02:48:12PM +0300, Blue Swirl wrote: > > On 7/5/09, Michael S. Tsirkin wrote: > > > MSIX present bit is tested incorrectly, and only happens to work because > > > the bit we are testing is 0

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Blue Swirl
On 7/15/09, Ram Pai wrote: > Problem: It is impossible to feed filenames with the character colon because > qemu interprets such names as a protocol. For example filename scsi:0, is > interpreted as a protocol by name "scsi". > --- a/block/raw-posix.c > +++ b/block/raw-posix.c > +static int

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames

2009-07-15 Thread Blue Swirl
On 7/15/09, Anthony Liguori wrote: > Blue Swirl wrote: > > > I bet this won't compile on win32. > > > > Instead of this (IMHO doomed) escape approach, maybe the filename > > parameter could be specified as the next argument, for example: > > -hda format=

Re: [Qemu-devel] [PATCH] Fix fallouts from Linux header inclusion

2011-06-26 Thread Blue Swirl
Thanks, applied. On Thu, Jun 23, 2011 at 11:05 AM, Jan Kiszka wrote: > From: Jan Kiszka > > This is an all-in-one fix for the smaller and bigger mistakes of the > build system changes for accompanied Linux headers: >  - only enable KVM and vhost on Linux hosts >  - fix powerpc asm header symlink

Re: nested VMX + unrelated qemu bug

2011-07-16 Thread Blue Swirl
On Sat, Jul 16, 2011 at 10:53 AM, Alexander Graf wrote: > > On 14.07.2011, at 17:22, Bernhard M. Wiedemann wrote: > >> Hi, >> >> I tried nested VMX on Xeon E5630 and it worked really well with the Kernel >> from avi's git and 0.14.0 >> (with modprobe kvm-intel nested=1) >> >> >> but in the proces

Re: [Qemu-devel] [RFC v4 11/58] memory: add ioeventfd support

2011-07-20 Thread Blue Swirl
On Sun, Jul 17, 2011 at 2:13 PM, Avi Kivity wrote: > As with the rest of the memory API, the caller associates an eventfd > with an address, and the memory API takes care of registering or > unregistering when the address is made visible or invisible to the > guest. > > Signed-off-by: Avi Kivity

Re: [Qemu-devel] [RFC v5 12/86] memory: add ioeventfd support

2011-07-21 Thread Blue Swirl
On Wed, Jul 20, 2011 at 7:49 PM, Avi Kivity wrote: > As with the rest of the memory API, the caller associates an eventfd > with an address, and the memory API takes care of registering or > unregistering when the address is made visible or invisible to the > guest. > > Signed-off-by: Avi Kivity

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Blue Swirl
On Mon, Jul 25, 2011 at 1:09 PM, Avi Kivity wrote: > On 07/25/2011 01:04 PM, Alexander Graf wrote: >> >> On 25.07.2011, at 12:02, Avi Kivity wrote: >> >> >  On 07/25/2011 12:56 PM, Alexander Graf wrote: >> >>  > >> >>  >   That argument can be used to block any change.  You'll get used to >> >> it

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Blue Swirl
On Mon, Jul 25, 2011 at 3:21 PM, Anthony Liguori wrote: > On 07/25/2011 07:18 AM, Avi Kivity wrote: >> >> On 07/25/2011 03:11 PM, Anthony Liguori wrote: >>> >>> On 07/25/2011 03:51 AM, Avi Kivity wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW()

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Blue Swirl
On Mon, Jul 25, 2011 at 5:51 PM, Paolo Bonzini wrote: > On 07/25/2011 04:23 PM, Blue Swirl wrote: >> >> >  Yes.  We can just make qemu_malloc use g_malloc. >> >> It would be also possible to make g_malloc() use qemu_malloc(). That >> way we could keep the trac

Re: [Qemu-devel] [RFC PATCH v2 09/21] pc: Add dimm paravirt SRAT info

2012-07-12 Thread Blue Swirl
On Wed, Jul 11, 2012 at 10:31 AM, Vasilis Liaskovitis wrote: > The numa_fw_cfg paravirt interface is extended to include SRAT information for > all hotplug-able dimms. There are 3 words for each hotplug-able memory slot, > denoting start address, size and node proximity. The new info is appended

Re: [Qemu-devel] [RFC PATCH v2 06/21] dimm: Implement memory device abstraction

2012-07-12 Thread Blue Swirl
On Wed, Jul 11, 2012 at 10:31 AM, Vasilis Liaskovitis wrote: > Each hotplug-able memory slot is a SysBusDevice. A hot-add operation for a > particular dimm creates a new MemoryRegion of the given physical address > offset, size and node proximity, and attaches it to main system memory as a > sub_r

Re: [Qemu-devel] [RFC PATCH v2 00/21] ACPI memory hotplug

2012-07-12 Thread Blue Swirl
On Wed, Jul 11, 2012 at 10:31 AM, Vasilis Liaskovitis wrote: > This is v2 of the ACPI memory hotplug prototype for x86_64 target. I think the concept of DIMMs (what about SIMMs? SODIMMs? I liked memslot) would be useful for most targets, but hotplugging may be limited to x86 only. It would be nic

Re: [Qemu-devel] [RFC PATCH v2 00/21] ACPI memory hotplug

2012-07-14 Thread Blue Swirl
On Fri, Jul 13, 2012 at 5:49 PM, Vasilis Liaskovitis wrote: > On Thu, Jul 12, 2012 at 08:04:56PM +0000, Blue Swirl wrote: >> On Wed, Jul 11, 2012 at 10:31 AM, Vasilis Liaskovitis >> wrote: >> > This is v2 of the ACPI memory hotplug prototype for x86_64 target. >> &

Re: [Qemu-devel] [PATCH 1/5] scsi-disk: removable hard disks support START/STOP

2012-07-23 Thread Blue Swirl
On Mon, Jul 16, 2012 at 2:25 PM, Paolo Bonzini wrote: > Support for START/STOP UNIT right now is limited to CD-ROMs. This is wrong, > since removable hard disks (in the real world: SD card readers) also support > it in pretty much the same way. I remember vaguely tuning a set of large SCSI hard

Re: [Qemu-devel] [PATCH v4] Fixes related to processing of qemu's -numa option

2012-08-04 Thread Blue Swirl
Thanks, applied. On Tue, Jul 17, 2012 at 4:31 AM, Chegu Vinod wrote: > Changes since v3: >- using bitmap_set() instead of set_bit() in numa_add() routine. >- removed call to bitmak_zero() since bitmap_new() also zeros' the bitmap. >- Rebased to the latest qemu. > > Changes since v2: >

Re: [Qemu-devel] [PATCH 3/5] s390: Add new channel I/O based virtio transport.

2012-08-07 Thread Blue Swirl
On Tue, Aug 7, 2012 at 2:52 PM, Cornelia Huck wrote: > Add a new virtio transport that uses channel commands to perform > virtio operations. > > Add a new machine type s390-ccw that uses this virtio-ccw transport > and make it the default machine for s390. > > Signed-off-by: Cornelia Huck > --- >

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-07 Thread Blue Swirl
On Tue, Aug 7, 2012 at 2:52 PM, Cornelia Huck wrote: > Provide a mechanism for qemu to provide fully virtual subchannels to > the guest. In the KVM case, this relies on the kernel's css support. > The !KVM case is not yet supported. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/Makefile.objs

Re: [Qemu-devel] [PATCH v8 5/6] introduce a new qom device to deal with panicked event

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 2:47 AM, Wen Congyang wrote: > If the target is x86/x86_64, the guest's kernel will write 0x01 to the > port KVM_PV_EVENT_PORT when it is panciked. This patch introduces a new > qom device kvm_pv_ioport to listen this I/O port, and deal with panicked > event according to pan

Re: [Qemu-devel] [PATCH 3/5] s390: Add new channel I/O based virtio transport.

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 8:28 AM, Cornelia Huck wrote: > On Tue, 7 Aug 2012 20:47:22 + > Blue Swirl wrote: > > >> > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c >> > new file mode 100644 >> > index 000..8a90c3a >> > --- /dev/nu

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck wrote: > On Tue, 7 Aug 2012 21:00:59 + > Blue Swirl wrote: > > >> > diff --git a/hw/s390x/css.c b/hw/s390x/css.c >> > new file mode 100644 >> > index 000..7941c44 >> > --- /dev/nu

Re: [PATCH 04/15] memory: MemoryRegion topology must be stable when updating

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > Using mem_map_lock to protect among updaters. So we can get the intact > snapshot of mem topology -- FlatView & radix-tree. > > Signed-off-by: Liu Ping Fan > --- > exec.c |3 +++ > memory.c | 22 +++

Re: [PATCH 08/15] memory: introduce PhysMap to present snapshot of toploygy

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > PhysMap contain the flatview and radix-tree view, they are snapshot > of system topology and should be consistent. With PhysMap, we can > swap the pointer when updating and achieve the atomic. > > Signed-off-by: Liu Ping

Re: [PATCH 09/15] memory: prepare flatview and radix-tree for rcu style access

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote: > From: Liu Ping Fan > > Flatview and radix view are all under the protection of pointer. > And this make sure the change of them seem to be atomic! > > The mr accessed by radix-tree leaf or flatview will be reclaimed > after the prev PhysMap no

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 7:34 PM, Peter Maydell wrote: > On 8 August 2012 20:16, Blue Swirl wrote: >> On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck >> wrote: >>> On Tue, 7 Aug 2012 21:00:59 + >>> Blue Swirl wrote: >>>> Please use more descr

Re: [PATCH 04/15] memory: MemoryRegion topology must be stable when updating

2012-08-09 Thread Blue Swirl
On Thu, Aug 9, 2012 at 7:28 AM, liu ping fan wrote: > On Thu, Aug 9, 2012 at 3:17 AM, Blue Swirl wrote: >> On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote: >>> From: Liu Ping Fan >>> >>> Using mem_map_lock to protect among updaters. So we can get the

Re: [Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection

2012-08-13 Thread Blue Swirl
On Mon, Aug 13, 2012 at 8:35 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This is required to get past the following assert with: > > commit 1523ed9e1d46b0b54540049d491475ccac7e6421 > Author: Jan Kiszka > Date: Thu May 17 10:32:39 2012 -0300 > > virtio/vhost: Add support

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-13 Thread Blue Swirl
On Mon, Aug 13, 2012 at 8:35 AM, Nicholas A. Bellinger wrote: > From: Stefan Hajnoczi > > This patch adds a new type of host device that drives the vhost_scsi > device. The syntax to add vhost-scsi is: > > qemu -vhost-scsi id=vhost-scsi0,wwpn=...,tpgt=123 > > The virtio-scsi emulated device wi

Re: [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2

2012-08-13 Thread Blue Swirl
oifd support I've proposed >>> > for KVM enable an accelerated patch for this through KVM. I'd >>> > like to get this base driver in first and enable the remaining >>> > support in-tree. >>> > >>> > I've split this vers

Re: [Qemu-devel] [PATCH v8 5/6] introduce a new qom device to deal with panicked event

2012-08-25 Thread Blue Swirl
On Wed, Aug 22, 2012 at 7:30 AM, Wen Congyang wrote: > At 08/09/2012 03:01 AM, Blue Swirl Wrote: >> On Wed, Aug 8, 2012 at 2:47 AM, Wen Congyang wrote: >>> If the target is x86/x86_64, the guest's kernel will write 0x01 to the >>> port KVM_PV_EVENT_PORT when it is

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-27 Thread Blue Swirl
On Mon, Aug 27, 2012 at 12:20 PM, Michael S. Tsirkin wrote: > In preparation for adding PV EOI support, disable PV EOI by default for > 1.1 and older machine types, to avoid CPUID changing during migration. > > PV EOI can still be enabled/disabled by specifying it explicitly. > Enable for 1.1

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-27 Thread Blue Swirl
On Mon, Aug 27, 2012 at 7:01 PM, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 06:56:38PM +0000, Blue Swirl wrote: >> > +static uint32_t slow_bar_readb(void *opaque, target_phys_addr_t addr) >> > +{ >> > +AssignedDevRegion *d = opaque; >> > +

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-27 Thread Blue Swirl
On Mon, Aug 27, 2012 at 7:06 PM, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 06:58:29PM +0000, Blue Swirl wrote: >> On Mon, Aug 27, 2012 at 12:20 PM, Michael S. Tsirkin wrote: >> > In preparation for adding PV EOI support, disable PV EOI by default for >> >

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-27 Thread Blue Swirl
On Mon, Aug 27, 2012 at 7:24 PM, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 07:12:27PM +0000, Blue Swirl wrote: >> On Mon, Aug 27, 2012 at 7:06 PM, Michael S. Tsirkin wrote: >> > On Mon, Aug 27, 2012 at 06:58:29PM +, Blue Swirl wrote: >> >> On Mon, Aug

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > On 27.08.2012 22:56, Blue Swirl wrote: > [] >>> +static uint32_t slow_bar_readb(void *opaque, target_phys_addr_t addr) >>> +{ >>> +AssignedDevRegion *d = opaque; >>> +uint8_t *in = d

Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 1:22 PM, Michael S. Tsirkin wrote: > In preparation for adding PV EOI support, disable PV EOI by default for > 1.1 and older machine types, to avoid CPUID changing during migration. > > PV EOI can still be enabled/disabled by specifying it explicitly. > Enable for 1.1 >

Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 5:22 PM, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 05:05:25PM +0000, Blue Swirl wrote: >> > +static bool _kvm_pv_eoi_disabled; >> >> NACK. I find your lack of compliance disturbing. > > Compliance with what? Could you please add

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 05:01:55PM +0000, Blue Swirl wrote: >> On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: >> > On 27.08.2012 22:56, Blue Swirl wrote: >> > [] >> >>> +s

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 7:31 PM, Anthony Liguori wrote: > Blue Swirl writes: > >> On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: >>> On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: >>>> On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-01 Thread Blue Swirl
On Tue, Aug 28, 2012 at 9:51 PM, Anthony Liguori wrote: > Blue Swirl writes: > >> On Tue, Aug 28, 2012 at 7:31 PM, Anthony Liguori >> wrote: >>> Blue Swirl writes: >>> >>>> On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin >>>>

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-03 Thread Blue Swirl
On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity wrote: > On 08/29/2012 11:27 AM, Markus Armbruster wrote: >> >> I don't see a point in making contributors avoid non-problems that might >> conceivably become trivial problems some day. Especially when there's >> no automated help with the avoiding. > >

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-04 Thread Blue Swirl
On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity wrote: > On 09/03/2012 10:32 PM, Blue Swirl wrote: >> On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity wrote: >>> On 08/29/2012 11:27 AM, Markus Armbruster wrote: >>>> >>>> I don't see a point in ma

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around Qemu to test kernels

2011-08-24 Thread Blue Swirl
On Tue, Aug 23, 2011 at 10:16 PM, Alexander Graf wrote: > On LinuxCon I had a nice chat with Linus on what he thinks kvm-tool > would be doing and what he expects from it. Basically he wants a > small and simple tool he and other developers can run to try out and > see if the kernel they just buil

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-08-25 Thread Blue Swirl
On Wed, Aug 24, 2011 at 9:38 PM, Alexander Graf wrote: > On LinuxCon I had a nice chat with Linus on what he thinks kvm-tool > would be doing and what he expects from it. Basically he wants a > small and simple tool he and other developers can run to try out and > see if the kernel they just built

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-19 Thread Blue Swirl
On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori wrote: > On 01/19/2011 07:15 AM, Markus Armbruster wrote: >> >> So they interact with KVM (need kvm_state), and they interact with the >> emulated PCI bus.  Could you elaborate on the fundamental difference >> between the two interactions that makes

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Blue Swirl
On Thu, Jan 20, 2011 at 9:33 AM, Jan Kiszka wrote: > On 2011-01-19 20:32, Blue Swirl wrote: >> On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori >> wrote: >>> On 01/19/2011 07:15 AM, Markus Armbruster wrote: >>>> >>>> So they interact with

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Blue Swirl
On Thu, Jan 20, 2011 at 7:37 PM, Anthony Liguori wrote: > On 01/20/2011 03:33 AM, Jan Kiszka wrote: >> >> On 2011-01-19 20:32, Blue Swirl wrote: >> >>> >>> On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori >>>  wrote: >>>

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-20 Thread Blue Swirl
On Thu, Jan 20, 2011 at 9:22 PM, Jan Kiszka wrote: > On 2011-01-20 20:27, Blue Swirl wrote: >> On Thu, Jan 20, 2011 at 9:33 AM, Jan Kiszka wrote: >>> On 2011-01-19 20:32, Blue Swirl wrote: >>>> On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori >>>> w

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-21 Thread Blue Swirl
On Fri, Jan 21, 2011 at 8:46 AM, Gerd Hoffmann wrote: >  Hi, > >> By the way, we don't have a QEMUState but instead use globals. > > /me wants to underline this. > > IMO it is absolutely pointless to worry about ways to pass around kvm_state. >  There never ever will be a serious need for that. >

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-21 Thread Blue Swirl
On Fri, Jan 21, 2011 at 5:21 PM, Jan Kiszka wrote: > On 2011-01-21 17:37, Blue Swirl wrote: >> On Fri, Jan 21, 2011 at 8:46 AM, Gerd Hoffmann wrote: >>>  Hi, >>> >>>> By the way, we don't have a QEMUState but instead use globals. >>> >>

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-21 Thread Blue Swirl
On Fri, Jan 21, 2011 at 6:17 PM, Jan Kiszka wrote: > On 2011-01-21 19:04, Blue Swirl wrote: >> On Fri, Jan 21, 2011 at 5:21 PM, Jan Kiszka wrote: >>> On 2011-01-21 17:37, Blue Swirl wrote: >>>> On Fri, Jan 21, 2011 at 8:46 AM, Gerd Hoffmann wrote: >>>&g

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-24 Thread Blue Swirl
On Mon, Jan 24, 2011 at 2:08 PM, Jan Kiszka wrote: > On 2011-01-21 19:49, Blue Swirl wrote: >>>> I'd add fourth possible class: >>>>  - device, CPU and machine configuration, like nographic, >>>> win2k_install_hack, no_hpet, smp_cpus etc. Maybe also &

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 2:55 PM, Jan Kiszka wrote: > The registers of real IOAPICs can be relocated during runtime (via > chipset registers). We don't support this yet, but qemu-kvm carries the > current base address in its version 2 vmstate. > > To align both implementations for migratability, add

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 5:18 PM, Jan Kiszka wrote: > On 2011-02-03 18:03, Blue Swirl wrote: >> On Thu, Feb 3, 2011 at 2:55 PM, Jan Kiszka wrote: >>> The registers of real IOAPICs can be relocated during runtime (via >>> chipset registers). We don't support th

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 5:43 PM, Jan Kiszka wrote: > On 2011-02-03 18:36, Blue Swirl wrote: >> On Thu, Feb 3, 2011 at 5:18 PM, Jan Kiszka wrote: >>> On 2011-02-03 18:03, Blue Swirl wrote: >>>> On Thu, Feb 3, 2011 at 2:55 PM, Jan Kiszka wrote: >>>>> T

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 6:01 PM, Jan Kiszka wrote: > On 2011-02-03 18:54, Blue Swirl wrote: >> On Thu, Feb 3, 2011 at 5:43 PM, Jan Kiszka wrote: >>> On 2011-02-03 18:36, Blue Swirl wrote: >>>> On Thu, Feb 3, 2011 at 5:18 PM, Jan Kiszka wrote: >>>&

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 7:06 PM, Jan Kiszka wrote: > On 2011-02-03 20:01, Blue Swirl wrote: >> On Thu, Feb 3, 2011 at 6:01 PM, Jan Kiszka wrote: >>> On 2011-02-03 18:54, Blue Swirl wrote: >>>> On Thu, Feb 3, 2011 at 5:43 PM, Jan Kiszka wrote: >>>&

Re: [Qemu-devel] [0.14?][PATCH 3/4] ioapic: Prepare for base address relocation

2011-02-03 Thread Blue Swirl
On Thu, Feb 3, 2011 at 7:25 PM, Jan Kiszka wrote: > On 2011-02-03 20:11, Blue Swirl wrote: >> On Thu, Feb 3, 2011 at 7:06 PM, Jan Kiszka wrote: >>> On 2011-02-03 20:01, Blue Swirl wrote: >>>> On Thu, Feb 3, 2011 at 6:01 PM, Jan Kiszka wrote: >>>&

Re: [PATCH 01/13] Generic DMA memory access interface

2011-02-05 Thread Blue Swirl
On Thu, Feb 3, 2011 at 11:32 PM, Eduard - Gabriel Munteanu wrote: > This introduces replacements for memory access functions like > cpu_physical_memory_read(). The new interface can handle address > translation and access checking through an IOMMU. > > Signed-off-by: Eduard - Gabriel Munteanu > -

Re: [PATCH 00/13] AMD IOMMU emulation patchset (reworked cc/to)

2011-02-05 Thread Blue Swirl
On Thu, Feb 3, 2011 at 11:32 PM, Eduard - Gabriel Munteanu wrote: > Hi again, > > Sorry for the mess, I forgot to cc Michael and this should go through his > tree. > I'm also cc-ing the SeaBIOS people. > > malc already ack-ed the audio bits. Please use scripts/checkpatch.pl to check for whitespa

Re: [Qemu-devel] [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state

2011-02-07 Thread Blue Swirl
On Mon, Feb 7, 2011 at 1:19 PM, Jan Kiszka wrote: > If kvmclock is used, which implies the kernel supports it, register a > kvmclock device with the sysbus. Its main purpose is to save and restore > the kernel state on migration, but this will also allow to visualize it > one day. > > Signed-off-b

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Blue Swirl
On Wed, Feb 9, 2011 at 12:43 PM, Anthony Liguori wrote: > On 02/08/2011 01:30 PM, Aurelien Jarno wrote: >> >> On Tue, Feb 08, 2011 at 06:13:53PM +0100, Markus Armbruster wrote: >> >>> >>> Chris Wright  writes: >>> >>> [...] >>> - qdev/vmstate both examples of partially completed work tha

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Blue Swirl
On Wed, Feb 9, 2011 at 4:44 PM, Anthony Liguori wrote: > On 02/09/2011 06:28 AM, Markus Armbruster wrote: >>> >>> Except that construction of a device requires initialization from an >>> array of variants (which is then type checked).  The way we store the >>> variants is lossy because we convert

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-09 Thread Blue Swirl
On Wed, Feb 9, 2011 at 9:59 PM, Anthony Liguori wrote: > On 02/09/2011 06:48 PM, Blue Swirl wrote: >>> >>> ISASerialState dev; >>> >>> isa_serial_init(&dev, 0, 0x274, 0x07, NULL, NULL); >>> >> >> Do you mean that there should be

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-11 Thread Blue Swirl
On Thu, Feb 10, 2011 at 9:47 AM, Anthony Liguori wrote: > On 02/09/2011 09:15 PM, Blue Swirl wrote: >> >> On Wed, Feb 9, 2011 at 9:59 PM, Anthony Liguori >>  wrote: >> >>> >>> On 02/09/2011 06:48 PM, Blue Swirl wrote: >>> >>>>>

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-11 Thread Blue Swirl
On Thu, Feb 10, 2011 at 6:05 PM, Anthony Liguori wrote: > On 02/10/2011 03:20 PM, Gleb Natapov wrote: >> >> Jugging by how well all previous conversion went we will end up with one >> more way of creating devices. One legacy, another qdev and your new one. >> And what is the problem with qdev agai

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-13 Thread Blue Swirl
On Sun, Feb 13, 2011 at 5:31 PM, Anthony Liguori wrote: > On 02/11/2011 12:14 PM, Blue Swirl wrote: >> >> On Thu, Feb 10, 2011 at 6:05 PM, Anthony Liguori >>  wrote: >> >>> >>> On 02/10/2011 03:20 PM, Gleb Natapov wrote: >>> >>>>

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-13 Thread Blue Swirl
On Sun, Feb 13, 2011 at 9:57 PM, Anthony Liguori wrote: > On 02/13/2011 01:37 PM, Blue Swirl wrote: >> >> On Sun, Feb 13, 2011 at 5:31 PM, Anthony Liguori >>  wrote: >> >>> >>> qdev doesn't expose any state today.  qdev properties are >>>

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-14 Thread Blue Swirl
On Mon, Feb 14, 2011 at 12:42 AM, Anthony Liguori wrote: > On 02/13/2011 03:00 PM, Blue Swirl wrote: >> >> On Sun, Feb 13, 2011 at 9:57 PM, Anthony Liguori >>  wrote: >> >>> >>> On 02/13/2011 01:37 PM, Blue Swirl wrote: >>> >>>>

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-14 Thread Blue Swirl
On Mon, Feb 14, 2011 at 10:53 PM, Anthony Liguori wrote: > On 02/14/2011 11:31 AM, Blue Swirl wrote: >> >> I don't understand. The caller just does >> if (isa_serial_init()) { >>   error(); >> } >> or >> if (serial_init()) { >>   err

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-15 Thread Blue Swirl
On Mon, Feb 14, 2011 at 11:47 PM, Anthony Liguori wrote: > On 02/14/2011 03:25 PM, Blue Swirl wrote: >> >> I'd still like to have the inline wrapper over the factory interface, >> probably with similar signature to isa_serial_new. Then there would be >> two funct

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-07 Thread Blue Swirl
On Thu, Apr 7, 2011 at 9:51 PM, Gleb Natapov wrote: > On Thu, Apr 07, 2011 at 01:32:50PM -0500, Anthony Liguori wrote: >> On 04/07/2011 01:10 PM, Peter Maydell wrote: >> >On 6 April 2011 20:34, Anthony Liguori  wrote: >> >>http://publib.boulder.ibm.com/infocenter/lnxinfo/v3r0m0/index.jsp?topic=/li

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-08 Thread Blue Swirl
On Fri, Apr 8, 2011 at 9:04 AM, Gleb Natapov wrote: > On Thu, Apr 07, 2011 at 04:41:03PM -0500, Anthony Liguori wrote: >> On 04/07/2011 02:17 PM, Gleb Natapov wrote: >> >On Thu, Apr 07, 2011 at 10:04:00PM +0300, Blue Swirl wrote: >> >>On Thu, Apr 7, 2011 a

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-08 Thread Blue Swirl
On Fri, Apr 8, 2011 at 10:32 PM, Anthony Liguori wrote: > On 04/08/2011 02:17 PM, Blue Swirl wrote: >> >> On Fri, Apr 8, 2011 at 9:04 AM, Gleb Natapov  wrote: >>> >>> On Thu, Apr 07, 2011 at 04:41:03PM -0500, Anthony Liguori wrote: >>>> &g

Re: Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-09 Thread Blue Swirl
On Sat, Apr 9, 2011 at 2:25 AM, Luiz Capitulino wrote: > Hi there, > > Summary: > >  - PXE boot in qemu.git (HEAD f124a41) is quite slow, more than 5 minutes. Got >   the problem with e1000, virtio and rtl8139. However, pcnet *works* (it's >   as fast as qemu-kvm.git) > >  - PXE boot in qemu-kvm.g

Re: [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259

2011-12-04 Thread Blue Swirl
On Sun, Dec 4, 2011 at 16:35, Avi Kivity wrote: > On 12/04/2011 05:19 PM, Jan Kiszka wrote: >> > >> > In the sense that kernel-apic is just an accelerated apic.  From the >> > guest point of view, there's no difference, and that should be reflected >> > in the device model. >> >> That was my goal

Re: [PATCH v4 12/15] kvm: x86: Add user space part for in-kernel APIC

2011-12-08 Thread Blue Swirl
On Thu, Dec 8, 2011 at 11:52, Jan Kiszka wrote: > This introduces the alternative APIC backend which makes use of KVM's > in-kernel device model. External NMI injection via LINT1 is emulated by > checking the current state of the in-kernel APIC, only injecting a NMI > into the VCPU if LINT1 is unm

Re: [PATCH v4 00/15] uq/master: Introduce basic irqchip support

2011-12-08 Thread Blue Swirl
On Thu, Dec 8, 2011 at 11:52, Jan Kiszka wrote: > Changes in v4: > - rebased of current uq/master > - fixed stupid bugs that broke bisectability and user space irqchip mode > - integrated NMI-over-LINT1 injection logic I had comments to one patch, others look fine. Overall, string based subtype

Re: [PATCH v4 12/15] kvm: x86: Add user space part for in-kernel APIC

2011-12-10 Thread Blue Swirl
On Fri, Dec 9, 2011 at 07:52, Jan Kiszka wrote: > On 2011-12-09 08:45, Jan Kiszka wrote: >> On 2011-12-08 22:16, Blue Swirl wrote: >>> On Thu, Dec 8, 2011 at 11:52, Jan Kiszka wrote: >>>> This introduces the alternative APIC backend which makes use of KVM's &g

Re: [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode

2011-12-10 Thread Blue Swirl
On Sat, Dec 10, 2011 at 12:28, Jan Kiszka wrote: > From: Jan Kiszka > > When the HPET enters legacy mode, the IRQ output of the PIT is > suppressed and replaced by the HPET timer 0. But the current code to > emulate this was broken in many ways. It reset the PIT state after > re-enabling, it work

Re: [PATCH 0/2] pit/hpet: Fix legacy mode switching

2011-12-10 Thread Blue Swirl
On Sat, Dec 10, 2011 at 12:28, Jan Kiszka wrote: > This is a small preparatory series to allow the introduction of the KVM > in-kernel PIT. Of course, it is also a fix for the various bugs in the > related PIT/HPET code. See patches for details. > > Jan Kiszka (2): >  hpet: Save/restore cached RTC

Re: [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode

2011-12-10 Thread Blue Swirl
On Sat, Dec 10, 2011 at 15:51, Jan Kiszka wrote: > On 2011-12-10 16:49, Blue Swirl wrote: >>> >>> +ISADevice *pit_init(int base, qemu_irq irq) >> >> Please retain this function in pc.h, or even better, introduce i8254.h. > > No concerns about i8254.h, but th

Re: [PATCH v4 12/15] kvm: x86: Add user space part for in-kernel APIC

2011-12-10 Thread Blue Swirl
On Sat, Dec 10, 2011 at 15:58, Jan Kiszka wrote: > On 2011-12-10 16:40, Blue Swirl wrote: >> On Fri, Dec 9, 2011 at 07:52, Jan Kiszka wrote: >>> On 2011-12-09 08:45, Jan Kiszka wrote: >>>> On 2011-12-08 22:16, Blue Swirl wrote: >>>>> On Thu, Dec 8,

Re: [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode

2011-12-10 Thread Blue Swirl
On Sat, Dec 10, 2011 at 16:03, Jan Kiszka wrote: > On 2011-12-10 16:54, Blue Swirl wrote: >> On Sat, Dec 10, 2011 at 15:51, Jan Kiszka wrote: >>> On 2011-12-10 16:49, Blue Swirl wrote: >>>>> >>>>> +ISADevice *pit_init(int base, qemu_irq irq) >&g

Re: [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode

2011-12-10 Thread Blue Swirl
On Sat, Dec 10, 2011 at 16:29, Jan Kiszka wrote: > On 2011-12-10 17:26, Blue Swirl wrote: >> On Sat, Dec 10, 2011 at 16:03, Jan Kiszka wrote: >>> On 2011-12-10 16:54, Blue Swirl wrote: >>>> On Sat, Dec 10, 2011 at 15:51, Jan Kiszka wrote: >>>&

Re: [PATCH qom-next 00/59] QOM CPUState, part 4: CPU_COMMON

2012-05-23 Thread Blue Swirl
ling!) from: > git://github.com/afaerber/qemu-cpu.git qom-cpu-common.v1 > https://github.com/afaerber/qemu-cpu/commits/qom-cpu-common.v1 > > Regards, > Andreas > > Cc: Anthony Liguori > Cc: Paolo Bonzini > Cc: Igor Mammedov > > Cc: Richard Henderson > Cc: Peter

Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary

2012-06-17 Thread Blue Swirl
On Sun, Jun 17, 2012 at 11:51 AM, Avi Kivity wrote: > On 06/17/2012 02:47 PM, Jan Kiszka wrote: I think this should rather go into generic code. >>> >>> To be honest, I put this in kvm-specific code because vl.c doesn't have >>> TARGET_PAGE_ALIGN.  Maybe we should have machine->page_size

Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary

2012-06-17 Thread Blue Swirl
On Sun, Jun 17, 2012 at 12:54 PM, Avi Kivity wrote: > On 06/17/2012 03:43 PM, Blue Swirl wrote: >> On Sun, Jun 17, 2012 at 11:51 AM, Avi Kivity wrote: >>> On 06/17/2012 02:47 PM, Jan Kiszka wrote: >>>>>> >>>>>> I think this should rather go i

Re: [Qemu-devel] plan for device assignment upstream

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 9:43 AM, Avi Kivity wrote: > On 07/02/2012 12:30 PM, Jan Kiszka wrote: >> On 2012-07-02 11:18, Michael S. Tsirkin wrote: >>> I've been thinking hard about Jan's patches for device >>> assignment. Basically while I thought it makes sense >>> to make all devices: assignment an

Re: [PATCH 1/6] file_ram_alloc(): coding style fixes

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 6:06 PM, Eduardo Habkost wrote: > Cc: Blue Swirl > Signed-off-by: Eduardo Habkost Acked-by: Blue Swirl > --- > exec.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/exec.c b/exec.c > index 8244d54..c8bfd

Re: [PATCH 2/6] file_ram_alloc(): use g_strdup_printf() instead of asprintf()

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 6:06 PM, Eduardo Habkost wrote: > Cc: Blue Swirl > Signed-off-by: Eduardo Habkost Acked-by: Blue Swirl > --- > exec.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/exec.c b/exec.c > index c8bfd27

Re: [Qemu-devel] plan for device assignment upstream

2012-07-05 Thread Blue Swirl
On Wed, Jul 4, 2012 at 8:05 AM, Avi Kivity wrote: > On 07/03/2012 10:06 PM, Blue Swirl wrote: >> On Mon, Jul 2, 2012 at 9:43 AM, Avi Kivity wrote: >>> On 07/02/2012 12:30 PM, Jan Kiszka wrote: >>>> On 2012-07-02 11:18, Michael S. Tsirkin wrote: >>>>>

  1   2   3   >