On Wed, Aug 22, 2012 at 12:49 AM, Feng Tang wrote:
> Hi Fengguang,
>
>
> On Wed, 22 Aug 2012 10:50:08 +0800
> Fengguang Wu wrote:
>
>> Feng,
>>
>> > I think it's pci_get_subsys() triggered this assert:
>> >
>> > /*
>> > * Oi! Can't be having __GFP_FS allocations with IRQs disable
On Tue, Sep 13, 2011 at 10:55 PM, Amos Kong wrote:
> 'slot->funcs' is initialized in acpiphp_glue.c:register_slot() before
> hotpluging device, and only one entry(func 0) is added to it,
> no new entry will be added to the list when hotpluging devices to the slot.
> When we release the whole devic
On Sun, May 6, 2012 at 8:11 AM, Xudong Hao wrote:
> LTR: Save Max snoop/no-snoop Latency Value in pci_save_pcie_state, and
> restore them in pci_restore_pcie_state.
>
> Signed-off-by: Xudong Hao
>
> ---
> drivers/pci/pci.c | 12
> 1 files changed, 12 insertions(+), 0 deletions(-)
r_write_config_dword(struct pci_dev *dev, int where, u32
> val);
If you repost this, can you remove the externs when you move these
declarations? I know the file's currently a random mix, but we might
as well make a tiny improvement.
Looks fine to me otherwise, and if you don't h
On Fri, May 11, 2012 at 4:56 PM, Alex Williamson
wrote:
> In a PCIe environment, transactions aren't always required to
> reach the root bus before being re-routed. Peer-to-peer DMA
> may actually not be seen by the IOMMU in these cases. For
> IOMMU groups, we want to provide IOMMU drivers a way
On Mon, May 14, 2012 at 4:49 PM, Alex Williamson
wrote:
> On Mon, 2012-05-14 at 16:02 -0600, Bjorn Helgaas wrote:
>> On Fri, May 11, 2012 at 4:56 PM, Alex Williamson
>> wrote:
>> > In a PCIe environment, transactions aren't always required to
>> > reach the
> I tried to work through some examples to develop some intuition about this:
Sorry, gmail inserted line breaks that ruined this picture. Here's a
URL for it:
http://www.asciiflow.com/#3736558963405980039
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message
On Tue, May 8, 2012 at 3:09 AM, Hao, Xudong wrote:
>> -Original Message-
>> From: Bjorn Helgaas [mailto:bhelg...@google.com]
>> > }
>> >
>>
>> This doesn't make any sense to me. "pos" is the offset of the PCI
>> E
On Sun, May 13, 2012 at 8:48 PM, Xudong Hao wrote:
> Enable LTR(Latency tolerance reporting) and OBFF(optimized buffer flush/fill)
> in
> pci_enable_device(), so that they are enabled before the device is used by
> driver.
Please split this into two patches (one for LTR and another for OBFF)
s
On Fri, May 25, 2012 at 8:02 AM, Jan Kiszka wrote:
> According to Alexey, the T310 does not properly support INTx masking as
> it fails to keep the PCI_STATUS_INTERRUPT bit updated once the interrupt
> is masked. Mark this adapter as broken so that pci_intx_mask_supported
> won't report it as comp
On Fri, Jun 8, 2012 at 1:01 AM, Xudong Hao wrote:
> The series of patches enable LTR and OBFF before device is used by driver, and
> introduce a couple of functions to save/restore LTR latency value.
>
> Patch 1/4 introduce new function pci_obff_supported() as pci_ltr_support().
>
> Patch 2/4 enab
On Fri, Jun 8, 2012 at 2:01 AM, Xudong Hao wrote:
> LTR: Save Max snoop/no-snoop Latency Value in pci_save_pcie_state, and restore
> them in pci_restore_pcie_state.
>
> Signed-off-by: Xudong Hao
> ---
> drivers/pci/pci.c | 71
> ---
> drivers/
On Thu, Jun 7, 2012 at 2:30 AM, Jan Kiszka wrote:
> From: Jan Kiszka
>
> According to
>
> http://thread.gmane.org/gmane.comp.emulators.kvm.devel/91388
>
> the T310 does not properly support INTx masking as it fails to keep the
> PCI_STATUS_INTERRUPT bit updated once the interrupt is masked. Mark
On Thu, Jun 7, 2012 at 11:01 AM, Alex Williamson
wrote:
> Passes pci_intx_mask_supported test but continues to send interrupts
> as discovered through VFIO-based device assignment.
>
> http://www.spinics.net/lists/kvm/msg73738.html
>
> Signed-off-by: Alex Williamson
> Tested-by: Andreas Hartmann
On Thu, Mar 1, 2012 at 10:18 AM, wrote:
> From b4cf24d5987475862de799c78773f13f25ed2af8 Mon Sep 17 00:00:00 2001
> From: Tadeusz Struk
> Date: Tue, 17 Jan 2012 16:45:46 +
> Subject: [PATCH] Added functionality that allows dynamically add and remove
> device specific reset functions
The sub
Thanks!
You didn't fix the subject line :) It should contain "PCI: ". Thanks
for including the "v2" inside "[PATCH]". That helps keep things
straight.
On Fri, Mar 2, 2012 at 4:55 AM, wrote:
> Hi,
> Reworked according to comments.
All the text here becomes part of the changelog, so you don't
On Fri, Mar 2, 2012 at 10:06 AM, Tadeusz Struk wrote:
> On 02/03/12 16:29, Bjorn Helgaas wrote:
>> Where do you plan to add calls to pci_dev_specific_reset_add()? In
>> drivers?
>
> Yes, I'm working on a driver for a device with SRIOV capability.
> I'll call it
On Mon, Mar 5, 2012 at 3:00 AM, Tadeusz Struk wrote:
>
> ---
> drivers/pci/pci.h | 1 +
> drivers/pci/quirks.c | 33 +++--
> include/linux/pci.h | 1 +
> 3 files changed, 29 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.
On Wed, Apr 4, 2012 at 9:30 AM, Tadeusz Struk wrote:
> Hi Bjorn,
> Did you have chance to look at this one?
Yep. It needs a changelog. "Fixed warning" is inadequate. It needs
an explanation of what the VF connection is. It would also be nice if
you fixed the function comment, which is unintel
On Thu, May 30, 2013 at 12:40:19PM -0600, Alex Williamson wrote:
> PCIe ACS (Access Control Services) is the PCIe 2.0+ feature that
> allows us to control whether transactions are allowed to be redirected
> in various subnodes of a PCIe topology. For instance, if two
> endpoints are below a root p
On Tue, Jun 18, 2013 at 12:20 PM, Alex Williamson
wrote:
> On Tue, 2013-06-18 at 11:28 -0600, Bjorn Helgaas wrote:
>> On Thu, May 30, 2013 at 12:40:19PM -0600, Alex Williamson wrote:
>> > PCIe ACS (Access Control Services) is the PCIe 2.0+ feature that
>> > a
On Tue, Jun 18, 2013 at 5:03 PM, Don Dutile wrote:
> On 06/18/2013 06:22 PM, Alex Williamson wrote:
>>
>> On Tue, 2013-06-18 at 15:31 -0600, Bjorn Helgaas wrote:
>>>
>>> On Tue, Jun 18, 2013 at 12:20 PM, Alex Williamson
>>> wrote:
>>>>
>&
On Wed, Jun 19, 2013 at 6:43 AM, Don Dutile wrote:
> On 06/18/2013 10:52 PM, Bjorn Helgaas wrote:
>>
>> On Tue, Jun 18, 2013 at 5:03 PM, Don Dutile wrote:
>>>
>>> On 06/18/2013 06:22 PM, Alex Williamson wrote:
>>>>
>>>>
&g
On Wed, Jul 11, 2012 at 11:18 PM, Alex Williamson
wrote:
> We've confirmed that peer-to-peer between these devices is
> not possible. We can therefore claim that they support a
> subset of ACS.
>
> Signed-off-by: Alex Williamson
> Cc: Joerg Roedel
> ---
>
> Two things about this patch make me a
[fix Joerg's email address]
On Tue, Jun 25, 2013 at 10:15 PM, Bjorn Helgaas wrote:
> On Wed, Jul 11, 2012 at 11:18 PM, Alex Williamson
> wrote:
>> We've confirmed that peer-to-peer between these devices is
>> not possible. We can therefore claim that the
On Tue, Jul 16, 2013 at 8:21 PM, Myron Stowe wrote:
> Linux Plumbers has approved an ACPI/PM, PCI microconference. The
> overview page is here:
>
> http://wiki.linuxplumbersconf.org/2013:pci_subsystem
>
> We would like to start receiving volunteers for presenting topics of
> interest. There is a
[+cc linux-pci]
On Fri, Aug 2, 2013 at 3:28 PM, Benjamin Herrenschmidt
wrote:
> Right. Another use case is, I know of devices that need a fundamental
> reset (PERST) after applying a FW update.
This is a tangent from the real discussion here, but the question of
resetting a device after a firmw
[+cc Al, linux-fsdevel for fdget/fdput usage]
On Wed, Aug 14, 2013 at 2:10 PM, Alex Williamson
wrote:
> The current VFIO_DEVICE_RESET interface only maps to PCI use cases
> where we can isolate the reset to the individual PCI function. This
> means the device must support FLR (PCIe or AF), PM re
On Mon, Aug 19, 2013 at 12:41 PM, Alex Williamson
wrote:
> On Wed, 2013-08-14 at 17:06 -0600, Alex Williamson wrote:
>> On Wed, 2013-08-14 at 16:42 -0600, Bjorn Helgaas wrote:
>> > On Wed, Aug 14, 2013 at 2:10 PM, Alex Williamson
>> > wrote:
>> > > +s
On Mon, May 19, 2014 at 01:01:07PM +1000, Gavin Shan wrote:
> The patch exports 2 MSI message relevant functions, which will be
> used by VFIO PCI driver. The VFIO PCI driver would be built as
> a module.
>
> Signed-off-by: Gavin Shan
Acked-by: Bjorn Helgaas
I think Alex will m
On Fri, Aug 08, 2014 at 01:36:03PM +0800, Ethan Zhao wrote:
> This patch set introduces three PCI device flag operation helper functions
> when set pci device PF/VF to assigned or deassigned status also check it.
> and patch 2,3,4 apply these helper functions to KVM,XEN and PCI.
>
> v2: simplify u
On Fri, Sep 05, 2014 at 11:15:22AM -0600, Bjorn Helgaas wrote:
> On Fri, Aug 08, 2014 at 01:36:03PM +0800, Ethan Zhao wrote:
> > This patch set introduces three PCI device flag operation helper functions
> > when set pci device PF/VF to assigned or deassigned status also check it
On Tue, Sep 09, 2014 at 10:21:24AM +0800, Ethan Zhao wrote:
> This patch set introduces three PCI device flag operation helper functions
> when set pci device PF/VF to assigned or deassigned status also check it.
> and patch 2,3,4 apply these helper functions to KVM,XEN and PCI.
>
> v2: simplify u
[+ Alex, linux-pci, kvm]
On Thu, Oct 2, 2014 at 4:11 AM, wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=85441
>
> Bug ID: 85441
>Summary: [vfio] [lockdep] Deadlock when attempting to unbind
> device from a running VM
>Product: Drivers
Hi Antonios,
On Mon, Oct 27, 2014 at 12:07 PM, Antonios Motakis
wrote:
> The virqfd functionality that is used by VFIO_PCI to implement interrupt
> masking and unmasking via an eventfd, is generic enough and can be reused
> by another driver. Move it to a separate file in order to allow the code
On Mon, Oct 27, 2014 at 12:08 PM, Antonios Motakis
wrote:
> The virqfd_enable and virqfd_disable functions are now global. Add the
> vfio_ prefix to those functions.
Wouldn't it be better to change the name *before* making them global?
Bjorn
--
To unsubscribe from this list: send the line "unsub
On Mon, Dec 16, 2013 at 3:16 PM, Alex Williamson
wrote:
> PCI resets will attempt to take the device_lock for any device to be
> reset. This is a problem if that lock is already held, for instance
> in the device remove path. It's not sufficient to simply kill the
> user process or skip the rese
On Tue, Jan 14, 2014 at 8:45 PM, Alex Williamson
wrote:
> PCI resets will attempt to take the device_lock for any device to be
> reset. This is a problem if that lock is already held, for instance
> in the device remove path. It's not sufficient to simply kill the
> user process or skip the rese
On Fri, Jan 17, 2014 at 9:02 AM, Alexander Gordeev wrote:
> This series is against "next" branch in Bjorn's repo:
> git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
>
> Changes from v1 to v2:
> - added a regression fix "ahci: Fix broken fallback to single
> MSI mode" as patch 1/
On Sat, Jan 18, 2014 at 12:15 AM, Alexander Gordeev wrote:
> On Fri, Jan 17, 2014 at 02:00:32PM -0700, Bjorn Helgaas wrote:
>> > As the release is supposedly this weekend, do you prefer
>> > the patches to go to your tree or to individual trees after
>> > the releas
On Fri, Jan 17, 2014 at 05:02:21PM +0100, Alexander Gordeev wrote:
> As result deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() and pci_enable_msix_range()
On Sat, Jan 18, 2014 at 09:59:40AM -0500, Tejun Heo wrote:
> On Sat, Jan 18, 2014 at 07:38:55AM -0700, Bjorn Helgaas wrote:
> > On Sat, Jan 18, 2014 at 12:15 AM, Alexander Gordeev
> > wrote:
> > > On Fri, Jan 17, 2014 at 02:00:32PM -0700, Bjorn Helgaas wrote:
&g
fix it and make it eligible for calling forom atomic context.
Do the same change for the pci_get_class() as suggested by Bjorn Helgaas
[bhelgaas: changelog, clear pci_device_id on stack with memset()]
Bisected-by: Fengguang Wu
Signed-off-by: Feng Tang
Signed-o
[+ linux-pci, Yinghai]
On Thu, Nov 8, 2012 at 8:59 PM, Jason Gao wrote:
>> The BIOS in your machine doesn't support SR-IOV. You'll need to ask the
>> manufacturer for a BIOS upgrade, if in fact one is available. Sometimes
>> they're not.
>
> very thanks Greg,my server Dell R710 with latest BI
[+cc kvm list]
On Wed, Mar 19, 2014 at 7:32 PM, Ming Lei wrote:
> On Thu, Mar 20, 2014 at 12:45 AM, Bjorn Helgaas wrote:
>> On Tue, Mar 18, 2014 at 10:52 PM, Ming Lei wrote:
>>> Hi,
>>>
>>> Looks Sasha fixed the problem in lkvm tool[1].
>>>
>&
On Fri, Mar 21, 2014 at 2:25 PM, Sasha Levin wrote:
> On 03/21/2014 04:07 PM, Bjorn Helgaas wrote:
>>
>> I think I figured out what the problem is. In virtio_pci__init(), we
>> allocate some address space with pci_get_io_space_block(), save its
>> address in vpc
Coverity complains that "byte" is used uninitialized in
drivers/vfio/pci/vfio_pci_config.c in vfio_ext_cap_len():
1139sts = byte & PCI_TPH_CAP_ST_MASK;
1140sts >>= PCI_TPH_CAP_ST_SHIFT;
1141return PCI_TPH_BASE_SIZEOF + round_u
On Thu, Apr 3, 2014 at 9:53 AM, Bjorn Helgaas wrote:
> Coverity complains that "byte" is used uninitialized in
> drivers/vfio/pci/vfio_pci_config.c in vfio_ext_cap_len():
>
> 1139sts = byte & PCI_TPH_CAP_ST_MASK;
> 1140
On Tue, May 20, 2014 at 08:53:21AM -0600, Alex Williamson wrote:
> The driver_override field allows us to specify the driver for a device
> rather than relying on the driver to provide a positive match of the
> device. This shortcuts the existing process of looking up the vendor
> and device ID, a
On Tue, May 20, 2014 at 08:53:21AM -0600, Alex Williamson wrote:
> The driver_override field allows us to specify the driver for a device
> rather than relying on the driver to provide a positive match of the
> device. This shortcuts the existing process of looking up the vendor
> and device ID, a
On Mon, May 19, 2014 at 01:01:10PM +1000, Gavin Shan wrote:
> The MSIx vector table lives in device memory, which may be cleared as
> part of a backdoor device reset. This is the case on the IBM IPR HBA
> when the BIST is run on the device. When assigned to a QEMU guest,
> the guest driver does a p
On Sat, May 31, 2014 at 5:42 AM, Gavin Shan wrote:
> On Fri, May 30, 2014 at 04:12:32PM -0600, Bjorn Helgaas wrote:
>>On Mon, May 19, 2014 at 01:01:10PM +1000, Gavin Shan wrote:
>>> The MSIx vector table lives in device memory, which may be cleared as
>>> part of a bac
On Wednesday 22 October 2008 02:40:41 am Yu Zhao wrote:
> This patch moves all definitions of the PCI resource names to an 'enum',
> and also replaces some hard-coded resource variables with symbol
> names. This change eases introduction of device specific resources.
Thanks for removing a bunch of
On Wednesday 22 October 2008 02:45:31 am Yu Zhao wrote:
> Document the new PCI[x86] boot parameters.
>
> Cc: Alex Chiang <[EMAIL PROTECTED]>
> Cc: Grant Grundler <[EMAIL PROTECTED]>
> Cc: Greg KH <[EMAIL PROTECTED]>
> Cc: Ingo Molnar <[EMAIL PROTECTED]>
> Cc: Jesse Barnes <[EMAIL PROTECTED]>
> Cc:
On Wednesday 22 October 2008 02:43:24 am Yu Zhao wrote:
> This patch adds boot option to align MMIO resource for a device.
> The alignment is a bigger value between the PAGE_SIZE and the
> resource size.
It looks like this forces alignment on PAGE_SIZE, not "a bigger
value between the PAGE_SIZE an
On Wednesday 22 October 2008 02:43:03 am Yu Zhao wrote:
> This patch adds boot options so user can reassign device resources
> of all devices under a bus.
>
> The boot options can be used as:
> pci=assign-mmio=:01,assign-pio=:02
> '[:]bb' is the domain and bus number.
I think th
On Wednesday 22 October 2008 08:44:24 am Yu Zhao wrote:
> Bjorn Helgaas wrote:
> > On Wednesday 22 October 2008 02:40:41 am Yu Zhao wrote:
> >> This patch moves all definitions of the PCI resource names to an 'enum',
> >> and also replaces some hard-coded reso
On Mon, Nov 26, 2012 at 11:46 PM, Gleb Natapov wrote:
> On Mon, Nov 26, 2012 at 09:46:12PM -0200, Marcelo Tosatti wrote:
>> On Tue, Nov 20, 2012 at 02:09:46PM +, Pandarathil, Vijaymohan R wrote:
>> >
>> >
>> > > -Original Message-
>> > > From: Stefan Hajnoczi [mailto:stefa...@gmail.com
[+cc Konrad, Boris, David, xen-devel, Alex, kvm]
On Wed, Jan 28, 2015 at 09:52:17AM +0800, Yijing Wang wrote:
> Sometimes, a pci bridge device BAR was not assigned
> properly. After we call pci_bus_assign_resources(), the
> resource of the BAR would be reseted. So if we try to
> enable msix for th
On Wed, Jan 28, 2015 at 3:05 PM, Boris Ostrovsky
wrote:
> On 01/28/2015 01:13 PM, Bjorn Helgaas wrote:
>>
>>
>> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
>> index fd60806..c3e7dfc 100644
>> --- a/drivers/pci/msi.c
>> +++ b/drivers/pci/msi.c
>&
On Thu, Jan 29, 2015 at 7:15 AM, Jan Beulich wrote:
On 29.01.15 at 04:54, wrote:
>> --- a/drivers/pci/msi.c
>> +++ b/drivers/pci/msi.c
>> @@ -694,11 +694,16 @@ static void __iomem *msix_map_region(struct pci_dev
>> *dev, unsigned nr_entries)
>> {
>> resource_size_t phys_addr;
>>
cache
The PCI core sets resource flags to zero when it can't assign space for the
resource (see reset_resource()). There are also some cases where it sets
the IORESOURCE_UNSET flag, e.g., pci_reassigndev_resource_alignment(),
pci_assign_resource(), etc. So we must check for both cas
On Wed, Mar 04, 2015 at 01:02:43PM -0700, Alex Williamson wrote:
> This copies the same support from pci-stub for exactly the same
> purpose, enabling a set of PCI IDs to be automatically added to the
> driver's dynamic ID table at module load time. The code here is
> pretty simple and both vfio-p
On Wed, Mar 11, 2015 at 3:14 PM, Alex Williamson
wrote:
> On Fri, 2015-03-06 at 16:11 -0600, Bjorn Helgaas wrote:
>> On Wed, Mar 04, 2015 at 01:02:43PM -0700, Alex Williamson wrote:
>> > This copies the same support from pci-stub for exactly the same
>> > purpose, enab
64 matches
Mail list logo
