Re: hpet missing in qemu-kvm's acpi table

2009-06-05 Thread Beth Kon
Jan Kiszka wrote: Hi, does qemu-kvm's bios intentionally refrain from reporting hpet support via acpi or is this a bug? It works nicely with upstream (tcg & kvm mode). Jan Hi Jan. HPET is not in qemu-kvm yet because there are some issues unique to qemu-kvm regarding disabling of the in-ker

[PATCH 1/2] Clean up MADT Table Creation (v2)

2009-06-09 Thread Beth Kon
it. After that, I'd be willing to submit incremental rewrite patches for acpi_bios_init to qemu, starting with MADT and RSDT. Signed-off-by: Beth Kon diff --git a/kvm/bios/rombios32.c b/kvm/bios/rombios32.c index 369cbef..cdae363 100755 --- a/kvm/bios/rombios32.c +++ b/kvm/bios/rombios32.c

[PATCH 2/2] Clean up RSDT Table Creation (v2)

2009-06-09 Thread Beth Kon
table_offset_entry entries so I could add the check for overflow - || (nb_rsdt_entries > MAX_RSDT_ENTRIES) This is not ideal. An ideal fix would require a rewrite of the rsdt build code, which I can do later and submit to qemu. Signed-off-by: Beth Kon diff --git a/kvm/bios/rombios32.c b/kvm/b

qemu-kvm broken after ./configure --disable-kvm

2009-06-11 Thread Beth Kon
Building latest git with ./configure --disable-kvm breaks with errors in pcspk.c -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/5] BIOS changes for configuring irq0->inti2 override (v4)

2009-06-11 Thread Beth Kon
These patches resolve the irq0->inti2 override issue, and get the hpet working on kvm. Override and HPET changes are sent as a series because HPET depends on the override. Win2k8 expects the HPET interrupt on inti2, regardless of whether an override exists in the BIOS. And the HPET spec states tha

[PATCH 3/5] BIOS changes for KVM HPET (v5)

2009-06-11 Thread Beth Kon
Signed-off-by: Beth Kon --- kvm/bios/acpi-dsdt.dsl |2 -- kvm/bios/rombios32.c | 11 +++ 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/kvm/bios/acpi-dsdt.dsl b/kvm/bios/acpi-dsdt.dsl index db57307..71d0a5e 100755 --- a/kvm/bios/acpi-dsdt.dsl +++ b/kvm/bios

[PATCH 5/5] HPET interaction with in-kernel PIT

2009-06-11 Thread Beth Kon
Signed-off-by: Beth Kon --- arch/x86/include/asm/kvm.h |1 + arch/x86/kvm/i8254.c | 24 +++- arch/x86/kvm/i8254.h |3 ++- arch/x86/kvm/x86.c |5 - 4 files changed, 26 insertions(+), 7 deletions(-) diff --git a/arch/x86/include/asm

[PATCH 2/5] Userspace changes for configuring irq0->inti2 override (v4)

2009-06-11 Thread Beth Kon
Signed-off-by: Beth Kon --- hw/ioapic.c|6 +++--- hw/pc.c|2 ++ qemu-kvm-x86.c |6 +- qemu-kvm.h |2 ++ sysemu.h |1 + vl.c | 11 +-- 6 files changed, 22 insertions(+), 6 deletions(-) diff --git a/hw/ioapic.c b/hw/ioapic.c index

[PATCH 4/5] Userspace changes for KVM HPET (v4)

2009-06-11 Thread Beth Kon
restarted accordingly. Signed-off-by: Beth Kon --- hw/hpet.c | 15 +++ hw/i8254.c| 43 ++- hw/i8254.h|2 ++ hw/pc.h |4 ++-- kvm/include/x86/asm/kvm.h |1 + qemu-kvm.c

Re: [PATCH 1/5] BIOS changes for configuring irq0->inti2 override (v4)

2009-06-11 Thread Beth Kon
Sebastian Herbszt wrote: Beth Kon wrote: These patches resolve the irq0->inti2 override issue, and get the hpet working on kvm. Override and HPET changes are sent as a series because HPET depends on the override. Win2k8 expects the HPET interrupt on inti2, regardless of whether an overr

Re: [PATCH 1/5] BIOS changes for configuring irq0->inti2 override (v4)

2009-06-11 Thread Beth Kon
Beth Kon wrote: Sebastian Herbszt wrote: Beth Kon wrote: These patches resolve the irq0->inti2 override issue, and get the hpet working on kvm. Override and HPET changes are sent as a series because HPET depends on the override. Win2k8 expects the HPET interrupt on inti2, regardless

[PATCH 1/5] Userspace changes for configuring irq0->inti2 override (v6)

2009-06-11 Thread Beth Kon
least during crash and shutdown (in Linux), so this needs to be handled properly. Changes from v4: - Modify mp_table entry count depending on whether irq_override is enabled. Signed-off-by: Beth Kon --- kvm/bios/rombios32.c | 67 ++ 1 files

[PATCH 2/5] Userspace changes for configuring irq0->inti2 override (v6)

2009-06-11 Thread Beth Kon
Signed-off-by: Beth Kon --- hw/ioapic.c|6 +++--- hw/pc.c|2 ++ qemu-kvm-x86.c |6 +- qemu-kvm.h |2 ++ sysemu.h |1 + vl.c | 11 +-- 6 files changed, 22 insertions(+), 6 deletions(-) diff --git a/hw/ioapic.c b/hw/ioapic.c index

[PATCH 3/5] BIOS changes for KVM HPET (v6)

2009-06-11 Thread Beth Kon
Signed-off-by: Beth Kon --- kvm/bios/acpi-dsdt.dsl |2 -- kvm/bios/rombios32.c | 11 +++ 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/kvm/bios/acpi-dsdt.dsl b/kvm/bios/acpi-dsdt.dsl index db57307..71d0a5e 100755 --- a/kvm/bios/acpi-dsdt.dsl +++ b/kvm/bios/acpi

[PATCH 4/5] Userspace changes for KVM HPET (v6)

2009-06-11 Thread Beth Kon
restarted accordingly. Signed-off-by: Beth Kon --- diff --git a/hw/hpet.c b/hw/hpet.c index 29db325..043b92b 100644 --- a/hw/hpet.c +++ b/hw/hpet.c @@ -206,6 +206,9 @@ static int hpet_load(QEMUFile *f, void *opaque, int version_id) qemu_get_timer(f, s->timer[i].qemu_ti

[PATCH 5/5] HPET interaction with in-kernel PIT (v6)

2009-06-11 Thread Beth Kon
Signed-off-by: Beth Kon --- arch/x86/include/asm/kvm.h |1 + arch/x86/kvm/i8254.c | 24 +++- arch/x86/kvm/i8254.h |3 ++- arch/x86/kvm/x86.c |5 - 4 files changed, 26 insertions(+), 7 deletions(-) diff --git a/arch/x86/include/asm

ioctl number overlap?

2009-06-15 Thread Beth Kon
kvm.h has #define KVM_SET_GUEST_DEBUG _IOW(KVMIO, 0x9b, struct kvm_guest_debug) and #define KVM_IA64_VCPU_SET_STACK _IOW(KVMIO, 0x9b, void *) Seems that these could conflict? -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.

[PATCH 2/2][RFC] Kernel changes for HPET legacy mode (v7)

2009-06-18 Thread Beth Kon
the timer, but then restores the actual value, again maintaining "current" state of the pit for possible later reenablement. changes from v6: - Added ioctl interface for legacy mode in order not to break the abi. Signed-off-by: Beth Kon diff --git a/arch/x86/include/asm/kvm.h b/

[PATCH 0/2][RFC] Completing HPET in KVM (v7)

2009-06-18 Thread Beth Kon
There is a problem in the latest git with savevm (it aborts). So I've been unable to test savevm with these patches, but am submitting them RFC. Everything else has been tested, including compatibility testing between old/new kernel/userspace combinations. -- To unsubscribe from this list: send

[PATCH 1/2][RFC] Userspace changes for KVM HPET (v7)

2009-06-18 Thread Beth Kon
. - sprinkled in some #ifdef TARGET_I386 Signed-off-by: Beth Kon diff --git a/hw/hpet.c b/hw/hpet.c index 29db325..2f5255f 100644 --- a/hw/hpet.c +++ b/hw/hpet.c @@ -206,6 +206,9 @@ static int hpet_load(QEMUFile *f, void *opaque, int version_id) qemu_get_timer(f, s->time

Re: [PATCH 2/2][RFC] Kernel changes for HPET legacy mode (v7)

2009-06-19 Thread Beth Kon
Jan Kiszka wrote: Beth Kon wrote: When kvm is in hpet_legacy_mode, the hpet is providing the timer interrupt and the pit should not be. So in legacy mode, the pit timer is destroyed, but the *state* of the pit is maintained. So if kvm or the guest tries to modify the state of the pit, this

Re: [PATCH 2/2][RFC] Kernel changes for HPET legacy mode (v7)

2009-06-22 Thread Beth Kon
Avi Kivity wrote: On 06/22/2009 12:14 PM, Jan Kiszka wrote: Hmm, stead of introducing a new pair of singe-purpose IOCTLs, why not add KVM_GET/SET_PIT2 which exchanges an extended kvm_pit_state2. And that struct should also include some flags field and enough padding to be potentially extended ye

[PATCH 1/5] BIOS changes for irq0->inti2 override (v8)

2009-06-30 Thread Beth Kon
no-acpi case). Signed-off-by: Beth Kon Signed-off-by: Avi Kivity --- kvm/bios/rombios32.c | 67 ++ 1 files changed, 51 insertions(+), 16 deletions(-) diff --git a/kvm/bios/rombios32.c b/kvm/bios/rombios32.c index 0369111..9e5370e 100755 --

[PATCH 2/5] Userspace changes for irq0->inti2 override support (v8)

2009-06-30 Thread Beth Kon
Select irq0->irq2 override based on kernel gsi routing availability If the kernel does not support gsi routing, we cannot do the irq0->irq2 override, so disable it in that case. Signed-off-by: Beth Kon Signed-off-by: Avi Kivity --- hw/ioapic.c|6 +++--- h

[PATCH 3/5] BIOS changes for qemu-kvm hpet support (v8)

2009-06-30 Thread Beth Kon
Advertise HPET in ACPI HPET table Signed-off-by: Beth Kon Signed-off-by: Avi Kivity --- kvm/bios/acpi-dsdt.dsl |2 -- kvm/bios/rombios32.c | 11 +++ 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/kvm/bios/acpi-dsdt.dsl b/kvm/bios/acpi-dsdt.dsl

[PATCH 5/5] Kernel changes for HPET legacy support(v8)

2009-06-30 Thread Beth Kon
e for legacy mode in order not to break the abi. Signed-off-by: Beth Kon --- arch/x86/include/asm/kvm.h |8 ++ arch/x86/kvm/i8254.c | 22 ++--- arch/x86/kvm/i8254.h |3 +- arch/x86/kvm/x86.c | 55 +++-

[PATCH 4/5] Userspace changes for qemu-kvm HPET support(v8)

2009-06-30 Thread Beth Kon
pit_load_count to allow state info to be copied before returning if legacy mode is enabled. - sprinkled in some #ifdef TARGET_I386 Signed-off-by: Beth Kon --- hw/hpet.c | 16 +++-- hw/i8254-kvm.c| 26 ++- hw/i8254.c| 77

[PATCH 1/5] BIOS changes for irq0->inti2 override (v9)

2009-07-07 Thread Beth Kon
no-acpi case). Changes from v8 - Incorporated Gleb's comments to patch 1/5 and 4/5. In 1/5, removed a "return" per Gleb's comment. See 4/5 for v8->v9 change description. Signed-off-by: Beth Kon

[PATCH 3/5] BIOS changes for qemu-kvm hpet support (v9)

2009-07-07 Thread Beth Kon
Advertise HPET in ACPI HPET table Signed-off-by: Beth Kon Signed-off-by: Avi Kivity --- kvm/bios/acpi-dsdt.dsl |2 -- kvm/bios/rombios32.c | 11 +++ 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/kvm/bios/acpi-dsdt.dsl b/kvm/bios/acpi-dsdt.dsl

[PATCH 4/5] Userspace changes for qemu-kvm HPET support(v9)

2009-07-07 Thread Beth Kon
pit2 ioctl Changes from v6: - added ioctl interface for setting hpet legacy mode in kernel pit - moved check for hpet_legacy_mode in pit_load_count to allow state info to be copied before returning if legacy mode is enabled. - sprinkled in some #ifdef TARGET_I386 Signed-off-by: Beth Kon

[PATCH 2/5] Userspace changes for irq0->inti2 override support (v9)

2009-07-07 Thread Beth Kon
Select irq0->irq2 override based on kernel gsi routing availability If the kernel does not support gsi routing, we cannot do the irq0->irq2 override, so disable it in that case. Signed-off-by: Beth Kon Signed-off-by: Avi Kivity --- hw/ioapic.c|6 +++--- h

[PATCH 5/5] Kernel changes for HPET legacy support(v9)

2009-07-07 Thread Beth Kon
e for legacy mode in order not to break the abi. Signed-off-by: Beth Kon --- arch/x86/include/asm/kvm.h |8 ++ arch/x86/kvm/i8254.c | 22 ++--- arch/x86/kvm/i8254.h |3 +- arch/x86/kvm/x86.c | 55 +++-

[RFC][PATCH]Problems with hpet on kvm

2008-08-19 Thread Beth Kon
In hpet.c update_irq: if (timer->tn == 0) irq=timer->state->irqs[0]; must be changed to if (timer->tn == 0) irq=timer->state->irqs[2]; to get win2k8 to boot. Any ideas? Beth Kon IBM Linux Technology Center ****** si

Need help with windows debug tools - HPET problems on win2k864

2008-09-12 Thread Beth Kon
I ran into trouble trying to get the hpet working with win2k864. It hangs very early on (black screen with "Windows is loading Files" at the bottom). My guess is there are problems with our acpi/bios changes, since they introduce some ACPI 2.0 structures and QEMU/KVM supports ACPI 1.0. We may not h

[Fwd: Re: Need help with windows debug tools - HPET problems on win2k864]

2008-09-12 Thread Beth Kon
Oops... meant to copy the list too... -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] --- Begin Message --- On Fri, 2008-09-12 at 20:40 +0200, Sebastian Herbszt wrote: > Beth Kon wrote: > > >I ran into trouble trying to get the hpet

Re: Need help with windows debug tools - HPET problems on win2k864

2008-09-14 Thread Beth Kon
On Sat, 2008-09-13 at 07:50 +0300, Avi Kivity wrote: > Beth Kon wrote: > > I ran into trouble trying to get the hpet working with win2k864. It > > hangs very early on (black screen with "Windows is loading Files" at the > > bottom). My guess is there are prob

[PATCH 1/2] Add HPET emulation to qemu (v3)

2008-10-17 Thread Beth Kon
't found a straightforward way to test on Windows and would appreciate any pointers to existing approaches. The second patch in this series contains the needed bochs bios changes. Signed-off-by: Beth Kon <[EMAIL PROTECTED]> --- Makefile.target |2 +- hw

[PATCH 2/2] Add HPET emulation to qemu (v3)

2008-10-17 Thread Beth Kon
-- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] This patch contains the bochs bios changes needed to support the qemu hpet. --- bios/acpi-dsdt.dsl | 18 ++ bios/rombios32.c | 46 -

Re: [Qemu-devel] [PATCH 1/2] Add HPET emulation to qemu (v3)

2008-10-20 Thread Beth Kon
On Fri, 2008-10-17 at 16:49 +0100, Jamie Lokier wrote: > Beth Kon wrote: > > Clock drift on Linux is in the range of .017% - .019%, loaded and unloaded. > > I > > haven't found a straightforward way to test on Windows and would appreciate > > any pointers to existi

Re: [PATCH 1/2] Add HPET emulation to qemu (v3)

2008-10-27 Thread Beth Kon
On Tue, 2008-10-21 at 10:21 -0500, Anthony Liguori wrote: > Beth Kon wrote: Thanks for the feedback, Anthony. I'll only respond where I have specific comments. Otherwise, I agree to your suggestions and will make the changes. > > +if(timer_enabled(timer) && hpe

Re: [Qemu-devel] [PATCH 1/2] Add HPET emulation to qemu (v3)

2008-10-30 Thread Beth Kon
On Mon, 2008-10-27 at 12:49 +0200, Dor Laor wrote: > Beth Kon wrote: > > On Fri, 2008-10-17 at 16:49 +0100, Jamie Lokier wrote: > > > > > Beth Kon wrote: > > > > > > > Clock drift on Linux is in the range of .017% - .019%, loaded and

[PATCH 2/2] Finish HPET implementation for KVM

2009-04-09 Thread Beth Kon
Signed-off-by: Beth Kon diff --git a/bios/acpi-dsdt.dsl b/bios/acpi-dsdt.dsl index 06ab25d..84697db 100755 --- a/bios/acpi-dsdt.dsl +++ b/bios/acpi-dsdt.dsl @@ -307,6 +307,24 @@ DefinitionBlock ( ,, , AddressRangeMemory, TypeStatic) }) } +Device

[PATCH 1/2] Make BIOS irq0->inti2 override configurable from userspace

2009-04-09 Thread Beth Kon
seeing RHEL5 guests complain of invalid checksum with these patches, but later he couldn't reproduce it, and I'm not seeing it now. While all guests still need to be fully tested, everything appears to be in order. I've tested on win2k864, win2k832, RHEL5.3 32 bit, and ubuntu 8.10 64

[PATCH 1/4] BIOS changes for configuring irq0->inti2 override

2009-05-04 Thread Beth Kon
uests still need to be fully tested, everything appears to be in order. I've tested on win2k864, win2k832, RHEL5.3 32 bit, and ubuntu 8.10 64 bit. Signed-off-by: Beth Kon diff --git a/kvm/bios/rombios32.c b/kvm/bios/rombios32.c index 8684987..ddfa828 100755 --- a/kvm/bios/rombios32.c

[PATCH 2/4] Userspace changes for configuring irq0->inti2 override

2009-05-04 Thread Beth Kon
Signed-off-by: Beth Kon diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index e1b19d7..bb74f38 100644 --- a/hw/fw_cfg.c +++ b/hw/fw_cfg.c @@ -279,6 +279,7 @@ void *fw_cfg_init(uint32_t ctl_port, uint32_t data_port, fw_cfg_add_bytes(s, FW_CFG_UUID, qemu_uuid, 16); fw_cfg_add_i16(s

[PATCH 3/4] BIOS changes for KVM HPET

2009-05-04 Thread Beth Kon
Signed-off-by: Beth Kon diff --git a/kvm/bios/acpi-dsdt.dsl b/kvm/bios/acpi-dsdt.dsl index c756fed..0e142be 100755 --- a/kvm/bios/acpi-dsdt.dsl +++ b/kvm/bios/acpi-dsdt.dsl @@ -308,7 +308,6 @@ DefinitionBlock ( }) } #ifdef BX_QEMU -#ifdef HPET_WORKS_IN_KVM Device

[PATCH 4/4] Userspace changes for KVM HPET

2009-05-04 Thread Beth Kon
Signed-off-by: Beth Kon diff --git a/hw/hpet.c b/hw/hpet.c index c7945ec..47c9f89 100644 --- a/hw/hpet.c +++ b/hw/hpet.c @@ -30,6 +30,7 @@ #include "console.h" #include "qemu-timer.h" #include "hpet_emul.h" +#include "qemu-kvm.h" //#define HPET_

Re: [PATCH 1/4] BIOS changes for configuring irq0->inti2 override

2009-05-05 Thread Beth Kon
Beth Kon wrote: These patches resolve the irq0->inti2 override issue, and get the hpet working on kvm. I've found a problem with these patches. I'll resubmit shortly. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord.

Re: [PATCH 1/4] BIOS changes for configuring irq0->inti2 override

2009-05-06 Thread Beth Kon
Sebastian Herbszt wrote: Beth Kon wrote: @@ -477,6 +480,7 @@ void wrmsr_smp(uint32_t index, uint64_t val) #define QEMU_CFG_SIGNATURE 0x00 #define QEMU_CFG_ID 0x01 #define QEMU_CFG_UUID 0x02 +#define QEMU_CFG_IRQ0_OVERRIDE 0x0e Small thing to consider before you resubmit: In his

[PATCH 1/4] BIOS changes for configuring irq0->inti2 override (v2)

2009-05-07 Thread Beth Kon
later he couldn't reproduce it, and I'm not seeing it now. While all guests still need to be fully tested, everything appears to be in order. I've tested on win2k864, win2k832, RHEL5.3 32 bit, and ubuntu 8.10 64 bit. Signed-off-by: Beth Kon diff --git a/kvm/bios/rombios32.c b/kv

[PATCH 3/4] BIOS changes for KVM HPET (v2)

2009-05-07 Thread Beth Kon
th BX_QEMU undefined. It doesn't seem to be a problem. Signed-off-by: Beth Kon diff --git a/kvm/bios/acpi-dsdt.dsl b/kvm/bios/acpi-dsdt.dsl index c756fed..0e142be 100755 --- a/kvm/bios/acpi-dsdt.dsl +++ b/kvm/bios/acpi-dsdt.dsl @@ -308,7 +308,6 @@ DefinitionBlock ( }) }

[PATCH 4/4] Userspace changes for KVM HPET (v2)

2009-05-07 Thread Beth Kon
Signed-off-by: Beth Kon diff --git a/hw/hpet.c b/hw/hpet.c index c7945ec..47c9f89 100644 --- a/hw/hpet.c +++ b/hw/hpet.c @@ -30,6 +30,7 @@ #include "console.h" #include "qemu-timer.h" #include "hpet_emul.h" +#include "qemu-kvm.h" //#define HPET_

[PATCH 2/4] Userspace changes for configuring irq0->inti2 override (v2)

2009-05-07 Thread Beth Kon
Signed-off-by: Beth Kon diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index e1b19d7..bb74f38 100644 --- a/hw/fw_cfg.c +++ b/hw/fw_cfg.c @@ -279,6 +279,7 @@ void *fw_cfg_init(uint32_t ctl_port, uint32_t data_port, fw_cfg_add_bytes(s, FW_CFG_UUID, qemu_uuid, 16); fw_cfg_add_i16(s

Re: [PATCH 1/4] BIOS changes for configuring irq0->inti2 override(v2)

2009-05-07 Thread Beth Kon
Avi Kivity wrote: Beth Kon wrote: These patches resolve the irq0->inti2 override issue, and get the hpet working on kvm. They are dependent on Jes Sorensen's recent 0006-qemu-kvm-irq-routing.patch. Override and HPET changes are sent as a series because HPET depends on the override

[PATCH 4/4] Userspace changes for KVM HPET (v3)

2009-05-11 Thread Beth Kon
Signed-off-by: Beth Kon diff --git a/hw/hpet.c b/hw/hpet.c index c7945ec..100abf5 100644 --- a/hw/hpet.c +++ b/hw/hpet.c @@ -30,6 +30,7 @@ #include "console.h" #include "qemu-timer.h" #include "hpet_emul.h" +#include "qemu-kvm.h" //#define HPET_

[PATCH 2/4] Userspace changes for configuring irq0->inti2 override (v3)

2009-05-11 Thread Beth Kon
Signed-off-by: Beth Kon diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index e1b19d7..bb74f38 100644 --- a/hw/fw_cfg.c +++ b/hw/fw_cfg.c @@ -279,6 +279,7 @@ void *fw_cfg_init(uint32_t ctl_port, uint32_t data_port, fw_cfg_add_bytes(s, FW_CFG_UUID, qemu_uuid, 16); fw_cfg_add_i16(s

[PATCH 3/4] BIOS changes for KVM HPET (v3)

2009-05-11 Thread Beth Kon
Signed-off-by: Beth Kon diff --git a/kvm/bios/acpi-dsdt.dsl b/kvm/bios/acpi-dsdt.dsl index c756fed..0e142be 100755 --- a/kvm/bios/acpi-dsdt.dsl +++ b/kvm/bios/acpi-dsdt.dsl @@ -308,7 +308,6 @@ DefinitionBlock ( }) } #ifdef BX_QEMU -#ifdef HPET_WORKS_IN_KVM Device

[PATCH 1/4] BIOS changes for configuring irq0->inti2 override (v3)

2009-05-11 Thread Beth Kon
uests still need to be fully tested, everything appears to be in order. I've tested on win2k864, win2k832, RHEL5.3 32 bit, and ubuntu 8.10 64 bit. Changes from v2: - rebased on latest kvm - fixed build problems with --disable-kvm (kvm_kpit_enable/disable) Signed-off-by: Beth Kon diff --g

Re: [PATCH 2/4] Userspace changes for configuring irq0->inti2override (v3)

2009-05-12 Thread Beth Kon
Gleb Natapov wrote: On Tue, May 12, 2009 at 01:22:06PM +0300, Avi Kivity wrote: Gleb Natapov wrote: for (i = 0; i < 24; ++i) { -r = kvm_add_irq_route(kvm_context, i, KVM_IRQCHIP_IOAPIC, i); +if (i == 0) { +r = kvm_add_irq_route(kvm_contex

Re: [PATCH 2/4] Userspace changes for configuring irq0->inti2override (v3)

2009-05-12 Thread Beth Kon
Gleb Natapov wrote: On Mon, May 11, 2009 at 01:29:44PM -0400, Beth Kon wrote: Signed-off-by: Beth Kon diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index e1b19d7..bb74f38 100644 --- a/hw/fw_cfg.c +++ b/hw/fw_cfg.c @@ -279,6 +279,7 @@ void *fw_cfg_init(uint32_t ctl_port, uint32_t data_port

Re: [PATCH 1/4] BIOS changes for configuring irq0->inti2 override(v3)

2009-05-12 Thread Beth Kon
Gleb Natapov wrote: On Mon, May 11, 2009 at 01:29:43PM -0400, Beth Kon wrote: Signed-off-by: Beth Kon diff --git a/kvm/bios/rombios32.c b/kvm/bios/rombios32.c index cbd5f15..53359b8 100755 --- a/kvm/bios/rombios32.c +++ b/kvm/bios/rombios32.c @@ -444,6 +444,9 @@ uint32_t cpuid_features

Re: [PATCH 4/4] Userspace changes for KVM HPET (v3)

2009-05-12 Thread Beth Kon
Avi Kivity wrote: Beth Kon wrote: Signed-off-by: Beth Kon diff --git a/hw/hpet.c b/hw/hpet.c index c7945ec..100abf5 100644 --- a/hw/hpet.c +++ b/hw/hpet.c @@ -30,6 +30,7 @@ #include "console.h" #include "qemu-timer.h" #include "hpet_emul.h" +#include "

Re: [PATCH 4/4] Userspace changes for KVM HPET (v3)

2009-05-12 Thread Beth Kon
Beth Kon wrote: Avi Kivity wrote: Beth Kon wrote: Signed-off-by: Beth Kon diff --git a/hw/hpet.c b/hw/hpet.c index c7945ec..100abf5 100644 --- a/hw/hpet.c +++ b/hw/hpet.c @@ -30,6 +30,7 @@ #include "console.h" #include "qemu-timer.h" #include "hpet_emul

Re: [PATCH] bios: Fix MADT corruption and RSDT size when using -acpitable

2009-05-14 Thread Beth Kon
Anthony Liguori wrote: Vincent Minet wrote: External ACPI tables are counted twice for the RSDT size and the load address for the first external table is in the MADT (interrupt override entries are overwritten). Signed-off-by: Vincent Minet Beth, I think you had a patch attempting to add

Re: [PATCH] bios: Fix MADT corruption and RSDT size when using -acpitable

2009-05-15 Thread Beth Kon
Marcelo Tosatti wrote: Beth, On Thu, May 14, 2009 at 12:20:29PM -0400, Beth Kon wrote: Anthony Liguori wrote: Vincent Minet wrote: External ACPI tables are counted twice for the RSDT size and the load address for the first external table is in the MADT (interrupt override

Subject:[PATCH 1/2] Clean up MADT Table Creation

2009-05-15 Thread Beth Kon
l the layout in one section, then fill things in afterwards. It also corrects a problem where the madt table was memset to 0 before the final size of the table had been determined. Signed-off-by: Beth Kon diff --git a/kvm/bios/rombios32.c b/kvm/bios/rombios32.c index cbd5f15..7f62e4f 100755 --- a/kvm

Subject:[PATCH 1/2] Clean up MADT Table Creation

2009-05-15 Thread Beth Kon
This patch is also based on the patch by Vincent Minet. It corrects the size calculation of the RSDT, and checks for overflow of MAX_RSDT_ENTRIES, assuming that the external table entry count is contained within MAX_RSDT_ENTRIES. Signed-off-by: Beth Kon diff --git a/kvm/bios/rombios32.c b/kvm

Re: Subject:[PATCH 1/2] Clean up MADT Table Creation

2009-05-15 Thread Beth Kon
Beth Kon wrote: This patch is also based on the patch by Vincent Minet. It corrects the size calculation of the RSDT, and checks for overflow of MAX_RSDT_ENTRIES, assuming that the external table entry count is contained within MAX_RSDT_ENTRIES. Signed-off-by: Beth Kon This should have

[PATCH 1/2] Clean up MADT Table Creation

2009-05-15 Thread Beth Kon
ayout in one section, then fill things in afterwards. It also corrects a problem where the madt table was memset to 0 before the final size of the table had been determined. Signed-off-by: Beth Kon diff --git a/kvm/bios/rombios32.c b/kvm/bios/rombios32.c index cbd5f15..7f62e4f 100755 --- a/kvm

[PATCH 2/2] Clean up RSDT Table Creation

2009-05-15 Thread Beth Kon
This patch is also based on the patch by Vincent Minet. It corrects the size calculation of the RSDT, and checks for overflow of MAX_RSDT_ENTRIES, assuming that the external table entry count is contained within MAX_RSDT_ENTRIES. Signed-off-by: Beth Kon diff --git a/kvm/bios/rombios32.c b/kvm

qemu-kvm.git regression in configure

2009-05-19 Thread Beth Kon
Latest qemu-kvm.git fails with ./configure, and reverting 22d239bcee126742df46938ee8ddc7c6b9209e23 corrects it. Beth Kon -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: qemu-kvm.git regression in configure

2009-05-19 Thread Beth Kon
Avi Kivity wrote: Beth Kon wrote: Latest qemu-kvm.git fails with ./configure, and reverting 22d239bcee126742df46938ee8ddc7c6b9209e23 corrects it. Works for me. What error do you get? ./configure: 1364: Syntax error: "(" unexpected (expecting "fi") -- To unsubscribe

Re: [PATCH 1/2] Clean up MADT Table Creation

2009-05-20 Thread Beth Kon
Avi Kivity wrote: Beth Kon wrote: This patch is based on the recent patch from Vincent Minet. I split Vincent's changes into 2 patches (to separate MADT and RSDT table cleanup, as suggested by Marcelo) and added a bit to them. And to give credit where it is due, this cleanup is also re

No longer working on HPET

2010-02-02 Thread Beth Kon
I have decided to take a job outside of IBM and so will not be involved with HPET any longer. Working on KVM has been great fun... top-notch people and a top-notch technology. Wishing KVM and you all the best! -- Regards, Beth Kon -- To unsubscribe from this list: send the line "unsubs

Re: The HPET issue on Linux

2010-01-06 Thread Beth Kon
st: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards, Beth Kon -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majo

Re: The HPET issue on Linux

2010-01-06 Thread Beth Kon
Beth Kon wrote: Dor Laor wrote: On 01/06/2010 12:09 PM, Gleb Natapov wrote: On Wed, Jan 06, 2010 at 05:48:52PM +0800, Sheng Yang wrote: Hi Beth I still found the emulated HPET would result in some boot failure. For example, on my 2.6.30, with HPET enabled, the kernel would fail check_timer

KVM userspace build fails with 2.6.28-rc7 kernel installed

2008-12-05 Thread Beth Kon
I pulled the latest: kvm (commit 3c260758b41000986c3c064b17a9771286e98d1e) kvm-userspace (commit 6892f63c18a526c7b54bbde2f59287787eabe1f8) and built and installed the 2.6.28-rc7 x86_64 kernel from kvm pull, then tried to build kvm-userspace and the build failed: make -C /lib/modules/2.6.28-rc7

[PATCH] hpet config mask fix

2009-01-14 Thread Beth Kon
I discovered a bug in the hpet code that caused Windows to boot without hpet. The config mask I was using was preventing the guest from placing the hpet into 32 bit mode. diff --git a/qemu/hw/hpet.c b/qemu/hw/hpet.c index 5c1aca2..7df2d05 100644 --- a/qemu/hw/hpet.c +++ b/qemu/hw/hpet.c @@ -388

[RFC][PATCH 2/2] Finish hpet implementation for KVM

2009-01-22 Thread Beth Kon
- add hpet to BIOS - add disable/enable of kernel pit when hpet enters/leaves legacy mode Signed-off-by: Beth Kon diff --git a/bios/acpi-dsdt.dsl b/bios/acpi-dsdt.dsl index d67616d..9981a1f 100755 --- a/bios/acpi-dsdt.dsl +++ b/bios/acpi-dsdt.dsl @@ -233,6 +233,24 @@ DefinitionBlock

[RFC][PATCH 1/2] Make irq0->inti2 override in BIOS configurable from userspace

2009-01-22 Thread Beth Kon
it appears to have nothing to do with hpet or irq routing. Needs more looking into. Signed-off-by: Beth Kon --- bios/Makefile|2 +- bios/rombios32.c | 40 qemu/hw/apic.c |5 ++--- qemu/hw/fw_cfg.c |1 + qemu/hw/fw_cfg.h |1 + qemu

ata exception messages

2008-06-03 Thread Beth Kon
I'm running an Ubuntu 7.10 guest on a kvm git build (commit 3125ffd6edb9384b3e418fc08fea99e7e1548a96) and am seeing repeated messages like: [3393.124685] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen [3393.127599] ata1.00: cmd ca/00:30:af:c1:48/00:00:00:00:00/e0 tag 0 cdb 0x0 da

Re: ata exception messages

2008-06-04 Thread Beth Kon
On Tue, 2008-06-03 at 10:49 -0400, Beth Kon wrote: > I'm running an Ubuntu 7.10 guest on a kvm git build (commit > 3125ffd6edb9384b3e418fc08fea99e7e1548a96) and am seeing repeated > messages like: > > [3393.124685] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 >

Re: ata exception messages

2008-06-04 Thread Beth Kon
On Wed, 2008-06-04 at 15:38 +0300, Avi Kivity wrote: > Beth Kon wrote: > > On Tue, 2008-06-03 at 10:49 -0400, Beth Kon wrote: > > > >> I'm running an Ubuntu 7.10 guest on a kvm git build (commit > >> 3125ffd6edb9384b3e418fc08fea99e7e1548a96) and

[RFC][PATCH] Add HPET emulation to qemu

2008-07-09 Thread Beth Kon
ndling the disabling of 8254 and RTC timer interrupts when operating in legacy mode. The HPET spec says "in this case the 8254/RTC timer will not cause any interrupts". I'm not sure if I should disable the RTC/8254 in some more general way, or just disable interrupts. Comments appreciated.

[PATCH] Add HPET support to BIOS

2008-07-09 Thread Beth Kon
This patch, written by Ryan Harper, adds HPET support to BIOS. Signed-off-by: Beth Kon <[EMAIL PROTECTED]> diff --git a/bios/Makefile b/bios/Makefile index 48022ea..3e73fb5 100644 --- a/bios/Makefile +++ b/bios/Makefile @@ -40,7 +40,7 @@ LIBS = -lm RANLIB = ranlib BCC = bcc -GCC = gc

Re: [Qemu-devel] [RFC][PATCH] Add HPET emulation to qemu

2008-07-10 Thread Beth Kon
On Thu, 2008-07-10 at 10:18 +0100, Samuel Thibault wrote: > Cool! > Does it now happen that qemu no longer wakes up every 10ms? If not, > please try to make sure it happens, that would eventually fix that power > leak :) > > Samuel > I will look into CONFIG_NO_HZ operation next. Haven't tried th

Re: [RFC][PATCH] Add HPET emulation to qemu

2008-07-22 Thread Beth Kon
On Sat, 2008-07-12 at 17:42 +0200, Alexander Graf wrote: > Hi Beth, > > On Jul 10, 2008, at 5:48 AM, Beth Kon wrote: > > > This patch, based on an earlier patch by Alexander Graf, adds HPET > > emulation to qemu. I am sending out a separate patch to kvm with the &

[RFC][PATCH] Add HPET emulation to qemu (v2)

2008-08-01 Thread Beth Kon
g when idle, so maybe the HPET won't provide any improvement here. But in any case, I didn't see the 10ms wakeup cycle with CONFIG_NO_HZ. If anyone can shed any light on this, I could look into it more if need be. Signed-off-by: Beth Kon <[EMAIL PROTECTED]> *** Makefile.target

[RFC][PATCH] Add HPET emulation to qemu (v2)

2008-08-01 Thread Beth Kon
g when idle, so maybe the HPET won't provide any improvement here. But in any case, I didn't see the 10ms wakeup cycle with CONFIG_NO_HZ. If anyone can shed any light on this, I could look into it more if need be. Signed-off-by: Beth Kon <[EMAIL PROTECTED]> *** Makefile.target

[RFC][PATCH] Add HPET emulation to qemu (v2)

2008-08-02 Thread Beth Kon
g when idle, so maybe the HPET won't provide any improvement here. But in any case, I didn't see the 10ms wakeup cycle with CONFIG_NO_HZ. If anyone can shed any light on this, I could look into it more if need be. Signed-off-by: Beth Kon <[EMAIL PROTECTED]> *** Makefile.target

Re: [Qemu-devel] [RFC][PATCH] Add HPET emulation to qemu (v2)

2008-08-12 Thread Beth Kon
On Sat, 2008-08-02 at 18:21 +0100, Samuel Thibault wrote: > Anthony Liguori, le Sat 02 Aug 2008 09:46:30 -0500, a écrit : > > Samuel Thibault wrote: > > >Beth Kon, le Sat 02 Aug 2008 06:05:14 -0500, a écrit : > > > > > >>I was trying to reproduce the wakeup