[PATCH net] vhost_net: fix wrong iter offset when setting number of buffers

2015-02-15 Thread Jason Wang
In commit ba7438aed924 ("vhost: don't bother copying iovecs in handle_rx(), kill memcpy_toiovecend()"), we advance iov iter fixup sizeof(struct virtio_net_hdr) bytes and fill the number of buffers after doing the socket recvmsg(). This work well but was broken after commit 6e03f896b52c ("Merge git:

Re: arm: warning at virt/kvm/arm/vgic.c:1468

2015-02-15 Thread Jan Kiszka
On 2015-02-13 07:53, Alex Bennée wrote: > > Alex Bennée writes: > >> Christoffer Dall writes: > >>> On Sun, Feb 08, 2015 at 08:48:09AM +0100, Jan Kiszka wrote: > BTW, KVM tracing support on ARM seems like it requires some care. E.g.: kvm_exit does not report an exit reason. The in-k

Re: [PATCH resend v5 6/6] KVM: nVMX: Enable nested posted interrupt processing

2015-02-15 Thread Wincy Van
On Sun, Feb 15, 2015 at 2:27 PM, Yong Wang wrote: > On Tue, Feb 03, 2015 at 11:58:17PM +0800, Wincy Van wrote: >> If vcpu has a interrupt in vmx non-root mode, we will >> kick that vcpu to inject interrupt timely. With posted >> interrupt processing, the kick intr is not needed, and >> interrupts

Re: arm: warning at virt/kvm/arm/vgic.c:1468

2015-02-15 Thread Marc Zyngier
On Sun, Feb 15 2015 at 8:53:30 am GMT, Jan Kiszka wrote: > On 2015-02-13 07:53, Alex Bennée wrote: >> >> Alex Bennée writes: >> >>> Christoffer Dall writes: >> On Sun, Feb 08, 2015 at 08:48:09AM +0100, Jan Kiszka wrote: >> > BTW, KVM tracing support on ARM seems like it requires so

Re: arm: warning at virt/kvm/arm/vgic.c:1468

2015-02-15 Thread Jan Kiszka
On 2015-02-15 14:37, Marc Zyngier wrote: > On Sun, Feb 15 2015 at 8:53:30 am GMT, Jan Kiszka wrote: >> I'm now throwing trace_printk at my broken KVM. Already found out that I >> get ARM_EXCEPTION_IRQ every few 10 µs. Not seeing any irq_* traces, >> though. Weird. > > This very much looks like a

Re: arm: warning at virt/kvm/arm/vgic.c:1468

2015-02-15 Thread Marc Zyngier
On Sun, Feb 15 2015 at 2:40:40 pm GMT, Jan Kiszka wrote: > On 2015-02-15 14:37, Marc Zyngier wrote: >> On Sun, Feb 15 2015 at 8:53:30 am GMT, Jan Kiszka wrote: >>> I'm now throwing trace_printk at my broken KVM. Already found out that I >>> get ARM_EXCEPTION_IRQ every few 10 µs. Not seeing any

Re: arm: warning at virt/kvm/arm/vgic.c:1468

2015-02-15 Thread Jan Kiszka
On 2015-02-15 15:59, Marc Zyngier wrote: > On Sun, Feb 15 2015 at 2:40:40 pm GMT, Jan Kiszka wrote: >> On 2015-02-15 14:37, Marc Zyngier wrote: >>> On Sun, Feb 15 2015 at 8:53:30 am GMT, Jan Kiszka >>> wrote: I'm now throwing trace_printk at my broken KVM. Already found out that I ge

Re: arm: warning at virt/kvm/arm/vgic.c:1468

2015-02-15 Thread Marc Zyngier
On Sun, Feb 15 2015 at 3:07:50 pm GMT, Jan Kiszka wrote: > On 2015-02-15 15:59, Marc Zyngier wrote: >> On Sun, Feb 15 2015 at 2:40:40 pm GMT, Jan Kiszka wrote: >>> On 2015-02-15 14:37, Marc Zyngier wrote: On Sun, Feb 15 2015 at 8:53:30 am GMT, Jan Kiszka wrote: > I'm now throwing

Re: [RFC PATCH 0/6] ARM64: KVM: PMU infrastructure support

2015-02-15 Thread Christoffer Dall
Hi Anup, On Mon, Jan 12, 2015 at 09:49:13AM +0530, Anup Patel wrote: > On Mon, Jan 12, 2015 at 12:41 AM, Christoffer Dall > wrote: > > On Tue, Dec 30, 2014 at 11:19:13AM +0530, Anup Patel wrote: > >> (dropping previous conversation for easy reading) > >> > >> Hi Marc/Christoffer, > >> > >> I trie

Re: arm: warning at virt/kvm/arm/vgic.c:1468

2015-02-15 Thread Jan Kiszka
On 2015-02-15 16:30, Marc Zyngier wrote: > On Sun, Feb 15 2015 at 3:07:50 pm GMT, Jan Kiszka wrote: >> On 2015-02-15 15:59, Marc Zyngier wrote: >>> On Sun, Feb 15 2015 at 2:40:40 pm GMT, Jan Kiszka >>> wrote: On 2015-02-15 14:37, Marc Zyngier wrote: > On Sun, Feb 15 2015 at 8:53:30 am

Re: arm: warning at virt/kvm/arm/vgic.c:1468

2015-02-15 Thread Christoffer Dall
On Sun, Feb 15, 2015 at 04:35:14PM +0100, Jan Kiszka wrote: > On 2015-02-15 16:30, Marc Zyngier wrote: > > On Sun, Feb 15 2015 at 3:07:50 pm GMT, Jan Kiszka > > wrote: > >> On 2015-02-15 15:59, Marc Zyngier wrote: > >>> On Sun, Feb 15 2015 at 2:40:40 pm GMT, Jan Kiszka > >>> wrote: > On

Re: [PATCH V4] x86 spinlock: Fix memory corruption on completing completions

2015-02-15 Thread Oleg Nesterov
On 02/15, Raghavendra K T wrote: > > On 02/13/2015 09:02 PM, Oleg Nesterov wrote: > >>> @@ -772,7 +773,8 @@ __visible void kvm_lock_spinning(struct arch_spinlock >>> *lock, __ticket_t want) >>> * check again make sure it didn't become free while >>> * we weren't looking. >>> */ >>>

Re: arm: warning at virt/kvm/arm/vgic.c:1468

2015-02-15 Thread Jan Kiszka
On 2015-02-15 16:59, Christoffer Dall wrote: > On Sun, Feb 15, 2015 at 04:35:14PM +0100, Jan Kiszka wrote: >> On 2015-02-15 16:30, Marc Zyngier wrote: >>> On Sun, Feb 15 2015 at 3:07:50 pm GMT, Jan Kiszka >>> wrote: On 2015-02-15 15:59, Marc Zyngier wrote: > On Sun, Feb 15 2015 at 2:40

Re: [PATCH net] vhost_net: fix wrong iter offset when setting number of buffers

2015-02-15 Thread David Miller
From: Jason Wang Date: Sun, 15 Feb 2015 16:35:17 +0800 > In commit ba7438aed924 ("vhost: don't bother copying iovecs in > handle_rx(), kill memcpy_toiovecend()"), we advance iov iter fixup > sizeof(struct virtio_net_hdr) bytes and fill the number of buffers > after doing the socket recvmsg(). Thi

Re: [PATCH V5] x86 spinlock: Fix memory corruption on completing completions

2015-02-15 Thread Oleg Nesterov
Well, I regret I mentioned the lack of barrier after enter_slowpath ;) On 02/15, Raghavendra K T wrote: > > @@ -46,7 +46,8 @@ static __always_inline bool static_key_false(struct > static_key *key); > > static inline void __ticket_enter_slowpath(arch_spinlock_t *lock) > { > - set_bit(0, (vol

Re: [PATCH V5] x86 spinlock: Fix memory corruption on completing completions

2015-02-15 Thread Raghavendra K T
* Raghavendra K T [2015-02-15 11:25:44]: Resending the V5 with smp_mb__after_atomic() change without bumping up revision ---8<--- >From 0b9ecde30e3bf5b5b24009fd2ac5fc7ac4b81158 Mon Sep 17 00:00:00 2001 From: Raghavendra K T Date: Fri, 6 Feb 2015 16:44:11 +0530 Subject: [PATCH RESEND V5] x86 sp

Re: [PATCH V5] x86 spinlock: Fix memory corruption on completing completions

2015-02-15 Thread Raghavendra K T
On 02/15/2015 09:47 PM, Oleg Nesterov wrote: Well, I regret I mentioned the lack of barrier after enter_slowpath ;) On 02/15, Raghavendra K T wrote: @@ -46,7 +46,8 @@ static __always_inline bool static_key_false(struct static_key *key); static inline void __ticket_enter_slowpath(arch_spinl

Re: arm: warning at virt/kvm/arm/vgic.c:1468

2015-02-15 Thread Jan Kiszka
On 2015-02-15 16:30, Marc Zyngier wrote: > On Sun, Feb 15 2015 at 3:07:50 pm GMT, Jan Kiszka wrote: >> On 2015-02-15 15:59, Marc Zyngier wrote: >>> On Sun, Feb 15 2015 at 2:40:40 pm GMT, Jan Kiszka >>> wrote: On 2015-02-15 14:37, Marc Zyngier wrote: > On Sun, Feb 15 2015 at 8:53:30 am

Re: arm: warning at virt/kvm/arm/vgic.c:1468

2015-02-15 Thread Jan Kiszka
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2015-02-15 19:01, Jan Kiszka wrote: > On 2015-02-15 16:30, Marc Zyngier wrote: >> On Sun, Feb 15 2015 at 3:07:50 pm GMT, Jan Kiszka >> wrote: >>> On 2015-02-15 15:59, Marc Zyngier wrote: On Sun, Feb 15 2015 at 2:40:40 pm GMT, Jan Kiszka

[GIT PULL 0/2] KVM/ARM Fixes for 3.20

2015-02-15 Thread Christoffer Dall
Hi Paolo, The following changes since commit bfa76d49576599a4b9f9b7a71f23d73d6dcff735: Linux 3.19 (2015-02-08 18:54:22 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git tags/kvm-arm-fixes-3.20 for you to fetch changes up to 42e3

Re: [PATCH] ARM: KVM: Fix size check in __coherent_cache_guest_page

2015-02-15 Thread Christoffer Dall
On Fri, Feb 13, 2015 at 11:07:17PM +0100, Paolo Bonzini wrote: > > > On 13/02/2015 05:57, Christoffer Dall wrote: > > On Sat, Feb 07, 2015 at 10:21:20PM +0100, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> The check is supposed to catch page-unaligned sizes, not the > >> inverse. > >> > >>

[GIT PULL 1/2] ARM: KVM: Fix size check in __coherent_cache_guest_page

2015-02-15 Thread Christoffer Dall
From: Jan Kiszka The check is supposed to catch page-unaligned sizes, not the inverse. Signed-off-by: Jan Kiszka Signed-off-by: Christoffer Dall --- arch/arm/include/asm/kvm_mmu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/include/asm/kvm_mmu.h b/arch/arm/inc

[GIT PULL 2/2] arm/arm64: KVM: Add exit reaons to kvm_exit event tracing

2015-02-15 Thread Christoffer Dall
From: Wei Huang This patch extends trace_kvm_exit() to include KVM exit reasons (i.e. EC of HSR). The tracing function then dumps both exit reason and PC of vCPU, shown as the following. Tracing tools can use this new exit_reason field to better understand the behavior of guest VMs. 886.301252:

Re: [PATCH V5] x86 spinlock: Fix memory corruption on completing completions

2015-02-15 Thread Oleg Nesterov
On 02/15, Raghavendra K T wrote: > > * Raghavendra K T [2015-02-15 11:25:44]: > > Resending the V5 with smp_mb__after_atomic() change without bumping up > revision Reviewed-by: Oleg Nesterov Of course, this needs the acks from maintainers. And I agree that SLOWPATH in .head makes xadd() in unl

vexpress: Horribly slow MMC emulation on ARM host

2015-02-15 Thread Jan Kiszka
Hi, this basically concludes my problems of getting KVM running on the Jetson TK1 board with QEMU: all fine now, provided I switch from qemu-system-arm -machine vexpress-a15 -sd disk.img ... to qemu-system-arm -machine vexpress-a15 \ -drive file=disk.img,if=none,id=disk \ -device vi