Re: [PATCH v6 28/46] vhost: make features 64 bit

2014-11-28 Thread Jason Wang
On Fri, Nov 28, 2014 at 4:10 AM, Michael S. Tsirkin wrote: We need to use bit 32 for virtio 1.0 Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index 3eda654..c

Re: [PATCH v6 29/46] vhost: add memory access wrappers

2014-11-28 Thread Jason Wang
On Fri, Nov 28, 2014 at 4:10 AM, Michael S. Tsirkin wrote: Add guest memory access wrappers to handle virtio endianness conversions. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vhost.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/vhos

Re: [PATCH v6 30/46] vhost/net: force len for TX to host endian

2014-11-28 Thread Jason Wang
On Fri, Nov 28, 2014 at 4:10 AM, Michael S. Tsirkin wrote: vhost/net keeps a copy of some used ring but (ab)uses length field for internal house-keeping. This works because for tx used length is always 0. Suppress sparse errors: we use native endian-ness internally but never expose it to gues

Re: [PATCH v6 33/46] vhost/net: larger header for virtio 1.0

2014-11-28 Thread Jason Wang
On Fri, Nov 28, 2014 at 4:10 AM, Michael S. Tsirkin wrote: Signed-off-by: Michael S. Tsirkin --- drivers/vhost/net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index cae22f9..1ac58d0 100644 --- a/drivers/vhost/net.c +++ b/

Re: [question] lots of interrupts injected to vm when pressing some key w/o releasing

2014-11-28 Thread Wanpeng Li
Hi all, On Thu, Nov 27, 2014 at 03:20:43PM +0800, Zhang Haoyu wrote: >>> I tested win-server-2008 with "-cpu >>> core2duo,hv_spinlocks=0x,hv_relaxed,hv_time", >>> this problem still happened, about 200,000 vmexits per-second, >>> bringing very bad experience, just like being s

[PATCH] xsave: export get_xsave_addr

2014-11-28 Thread Tiejun Chen
After commit, 1d7fe1d1, "KVM: x86: support XSAVES usage in the host", is introduced, ... Building modules, stage 2. MODPOST 20 modules ERROR: "get_xsave_addr" [arch/x86/kvm/kvm.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 so we need to export get_xsave_addr()

Re: [PATCH RFC v4 00/16] qemu: towards virtio-1 host support

2014-11-28 Thread Cornelia Huck
On Thu, 27 Nov 2014 18:35:40 +0200 "Michael S. Tsirkin" wrote: > On Thu, Nov 27, 2014 at 05:28:42PM +0100, Cornelia Huck wrote: > > On Thu, 27 Nov 2014 18:18:25 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Nov 27, 2014 at 05:06:51PM +0100, Cornelia Huck wrote: > > > > > > So we shou

Re: [PATCH RFC v4 00/16] qemu: towards virtio-1 host support

2014-11-28 Thread Cornelia Huck
On Thu, 27 Nov 2014 18:38:59 +0200 "Michael S. Tsirkin" wrote: > Also, let's focus on one device, e.g. -net for now. Yes, I'm currently looking at net. > Then probably virtio scsi. > That's because blk needs to be reworked to support ANY_LAYOUT. I had focused on blk because that's the other de

Re: [question] lots of interrupts injected to vm when pressing some key w/o releasing

2014-11-28 Thread Zhang Haoyu
>Hi all, >On Thu, Nov 27, 2014 at 03:20:43PM +0800, Zhang Haoyu wrote: I tested win-server-2008 with "-cpu core2duo,hv_spinlocks=0x,hv_relaxed,hv_time", this problem still happened, about 200,000 vmexits per-second, bringing very bad experience, just like b

Re: [PATCH RFC 1/2] KVM: don't check for PF_VCPU when yielding

2014-11-28 Thread Raghavendra KT
Was able to test the patch, here is the result: I have not tested with bigger VMs though. Results make it difficult to talk about any side effect of patch if any. System 16 core 32cpu (+ht) sandybridge with 4 guests of 16vcpu each +---+---+---++---+

Re: [PATCH] xsave: export get_xsave_addr

2014-11-28 Thread Paolo Bonzini
On 28/11/2014 10:28, Tiejun Chen wrote: > After commit, 1d7fe1d1, "KVM: x86: support XSAVES usage in the host", > is introduced, > > ... > Building modules, stage 2. > MODPOST 20 modules > ERROR: "get_xsave_addr" [arch/x86/kvm/kvm.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *

Re: [PATCH RFC 1/2] KVM: don't check for PF_VCPU when yielding

2014-11-28 Thread Christian Borntraeger
Am 28.11.2014 um 11:08 schrieb Raghavendra KT: > Was able to test the patch, here is the result: I have not tested with > bigger VMs though. Results make it difficult to talk about any side > effect of > patch if any. Thanks a log. If our assumption is correct, then this patch should have no side

Re: [PATCH RFC 1/2] KVM: don't check for PF_VCPU when yielding

2014-11-28 Thread Raghavendra K T
On 11/28/2014 04:28 PM, Christian Borntraeger wrote: Am 28.11.2014 um 11:08 schrieb Raghavendra KT: Was able to test the patch, here is the result: I have not tested with bigger VMs though. Results make it difficult to talk about any side effect of patch if any. Thanks a log. If our assumptio

[GIT PULL 05/11] KVM: s390: refactor interrupt injection code

2014-11-28 Thread Christian Borntraeger
From: Jens Freimann In preparation for the rework of the local interrupt injection code, factor out injection routines from kvm_s390_inject_vcpu(). Signed-off-by: Jens Freimann Reviewed-by: David Hildenbrand Signed-off-by: Christian Borntraeger --- arch/s390/kvm/interrupt.c | 221 +++

[GIT PULL 01/11] KVM: s390: Small fixes for the PFMF handler

2014-11-28 Thread Christian Borntraeger
From: Thomas Huth This patch includes two small fixes for the PFMF handler: First, the start address for PFMF has to be masked according to the current addressing mode, which is now done with kvm_s390_logical_to_effective(). Second, the protection exceptions have a lower priority than the specifi

[GIT PULL 07/11] KVM: s390: add defines for virtio and pfault interrupt code

2014-11-28 Thread Christian Borntraeger
From: Jens Freimann Get rid of open coded value for virtio and pfault completion interrupts. Signed-off-by: Jens Freimann Reviewed-by: David Hildenbrand Signed-off-by: Christian Borntraeger --- arch/s390/kvm/interrupt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[GIT PULL 11/11] KVM: s390: allow injecting all kinds of machine checks

2014-11-28 Thread Christian Borntraeger
From: Jens Freimann Allow to specify CR14, logout area, external damage code and failed storage address. Since more then one machine check can be indicated to the guest at a time we need to combine all indication bits with already pending requests. Signed-off-by: Jens Freimann Reviewed-by: Cor

[GIT PULL 10/11] KVM: s390: handle pending local interrupts via bitmap

2014-11-28 Thread Christian Borntraeger
From: Jens Freimann This patch adapts handling of local interrupts to be more compliant with the z/Architecture Principles of Operation and introduces a data structure which allows more efficient handling of interrupts. * get rid of li->active flag, use bitmap instead * Keep interrupts in a bitm

[GIT PULL 08/11] KVM: s390: refactor interrupt delivery code

2014-11-28 Thread Christian Borntraeger
From: Jens Freimann Move delivery code for cpu-local interrupt from the huge do_deliver_interrupt() to smaller functions which handle one type of interrupt. Signed-off-by: Jens Freimann Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- arch/s

[GIT PULL 02/11] KVM: s390: Fix rewinding of the PSW pointing to an EXECUTE instruction

2014-11-28 Thread Christian Borntraeger
From: Thomas Huth A couple of our interception handlers rewind the PSW to the beginning of the instruction to run the intercepted instruction again during the next SIE entry. This normally works fine, but there is also the possibility that the instruction did not get run directly but via an EXECU

[GIT PULL 00/11] KVM: s390: Several changes for 3.19 (kvm/next)

2014-11-28 Thread Christian Borntraeger
/linux/kernel/git/kvms390/linux.git tags/kvm-s390-next-20141128 for you to fetch changes up to fc2020cfe9f8102d17dad79ed96dc68a9d84b19e: KVM: s390: allow injecting all kinds of machine checks (2014-11-28 13:59:05 +0100) KVM: s390

[GIT PULL 03/11] KVM: s390: trigger the right CPU exit for floating interrupts

2014-11-28 Thread Christian Borntraeger
When injecting a floating interrupt and no CPU is idle we kick one CPU to do an external exit. In case of I/O we should trigger an I/O exit instead. This does not matter for Linux guests as external and I/O interrupts are enabled/disabled at the same time, but play safe anyway. The same holds true

[GIT PULL 04/11] KVM: S390: Create helper function get_guest_storage_key

2014-11-28 Thread Christian Borntraeger
From: "Jason J. Herne" Define get_guest_storage_key which can be used to get the value of a guest storage key. This compliments the functionality provided by the helper function set_guest_storage_key. Both functions are needed for live migration of s390 guests that use storage keys. Signed-off-b

[GIT PULL 09/11] KVM: s390: add bitmap for handling cpu-local interrupts

2014-11-28 Thread Christian Borntraeger
From: Jens Freimann Adds a bitmap to the vcpu structure which is used to keep track of local pending interrupts. Also add enum with all interrupt types sorted in order of priority (highest to lowest) Signed-off-by: Jens Freimann Reviewed-by: Thomas Huth Reviewed-by: Cornelia Huck Reviewed-by:

[GIT PULL 06/11] KVM: s390: external param not valid for cpu timer and ckc

2014-11-28 Thread Christian Borntraeger
From: David Hildenbrand The 32bit external interrupt parameter is only valid for timing-alert and service-signal interrupts. Signed-off-by: David Hildenbrand Signed-off-by: Christian Borntraeger --- arch/s390/kvm/interrupt.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --

Re: [GIT PULL 05/11] KVM: s390: refactor interrupt injection code

2014-11-28 Thread Paolo Bonzini
On 28/11/2014 14:25, Christian Borntraeger wrote: > > +static int __inject_prog_irq(struct kvm_vcpu *vcpu, > + struct kvm_s390_interrupt_info *inti) > +{ Why the __s? :) Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message t

Re: [GIT PULL 08/11] KVM: s390: refactor interrupt delivery code

2014-11-28 Thread Paolo Bonzini
On 28/11/2014 14:25, Christian Borntraeger wrote: > +static int __must_check __deliver_cpu_timer(struct kvm_vcpu *vcpu) > +{ > + int rc; Same here... Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [GIT PULL 09/11] KVM: s390: add bitmap for handling cpu-local interrupts

2014-11-28 Thread Paolo Bonzini
On 28/11/2014 14:25, Christian Borntraeger wrote: > > +struct kvm_s390_irq_payload { > + struct kvm_s390_io_info io; > + struct kvm_s390_ext_info ext; > + struct kvm_s390_pgm_info pgm; > + struct kvm_s390_emerg_info emerg; > + struct kvm_s390_extcall_info extcall; > + st

Re: [GIT PULL 00/11] KVM: s390: Several changes for 3.19 (kvm/next)

2014-11-28 Thread Paolo Bonzini
ut XSAVES (2014-11-23 18:33:37 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git > tags/kvm-s390-next-20141128 > > for you to fetch changes up to fc2020cfe9f8102d17dad79ed96dc68a9d84b19e: > >

Re: [Xen-devel] [PATCH] xen: privcmd: schedule() after private hypercall when non CONFIG_PREEMPT

2014-11-28 Thread Luis R. Rodriguez
On Thu, Nov 27, 2014 at 06:50:31PM +, Andrew Cooper wrote: > On 27/11/14 18:36, Luis R. Rodriguez wrote: > > On Thu, Nov 27, 2014 at 07:36:31AM +0100, Juergen Gross wrote: > >> On 11/26/2014 11:26 PM, Luis R. Rodriguez wrote: > >>> From: "Luis R. Rodriguez" > >>> > >>> Some folks had reported

How does qemu know the virtual memory of the guest os?

2014-11-28 Thread Jidong Xiao
Hi, I notice that Qemu supports dump virtual memory of Guest OS. As this page suggests: http://doc.opensuse.org/products/draft/SLES/SLES-kvm_sd_draft/cha.qemu.monitor.html To save the content of the virtual machine memory to a disk or console output, use the following commands: memsave

Re: [PATCH] KVM: Introduce dynamically registered hypercall capability

2014-11-28 Thread Phil White
Good questions. One thing that prompted this code is the presence and proliferation of architecture specific hypercalls in include/uapi/linux/kvm_para.h. I'm not sure why the tree has continued on for as long as it has with a list of reserved hypercall indices -- most of which are unused on any gi

[Bug 88671] BUG at drivers/pci/ats.c:62! the second time booting a kvm guest with pci passthrough

2014-11-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=88671 --- Comment #5 from Tom Stellard --- Thanks for the tip about vfio-pci. I can now sometimes get two working guest boots per host boot. -- You are receiving this mail because: You are watching the assignee of the bug. -- To unsubscribe from this

[Bug 88671] BUG at drivers/pci/ats.c:62! the second time booting a kvm guest with pci passthrough

2014-11-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=88671 Tom Stellard changed: What|Removed |Added Component|kvm |Video(DRI - non Intel) Version|

[Bug 88671] Radeon driver fails to reset hardware properly after kvm guest reboot

2014-11-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=88671 Tom Stellard changed: What|Removed |Added Summary|BUG at |Radeon driver fails to |

Re: [RFC PATCH 3/5] KVM: ARM VGIC add kvm_io_bus_ frontend

2014-11-28 Thread Shannon Zhao
On 2014/11/25 5:26, Nikolay Nikolaev wrote: > In io_mem_abort remove the call to vgic_handle_mmio. The target is to have > a single MMIO handling path - that is through the kvm_io_bus_ API. > > Register a kvm_io_device in kvm_vgic_init on the whole vGIC MMIO region. > Both read and write calls are

Re: [RFC PATCH 4/5] ARM: enable linking against eventfd and irqchip

2014-11-28 Thread Shannon Zhao
On 2014/11/25 5:27, Nikolay Nikolaev wrote: > This enables compilation of the eventfd feature on ARM. > Only enable on ARM? I think we should enable it on ARM64 as well because the eventfd featrue is common for ARM32 and ARM64. Thanks, Shannon > Signed-off-by: Nikolay Nikolaev > --- > arch/a