Re: [PATCH 00/17] RFC: userfault v2

2014-11-01 Thread zhanghailiang
On 2014/11/1 3:39, Peter Feiner wrote: On Fri, Oct 31, 2014 at 11:29:49AM +0800, zhanghailiang wrote: Agreed, but for doing live memory snapshot (VM is running when do snapsphot), we have to do this (block the write action), because we have to save the page before it is dirtied by writing actio

Re: [PATCH v12 2/6] KVM: Add generic support for dirty page logging

2014-11-01 Thread James Hogan
Hi Mario, On Wed, Oct 22, 2014 at 03:34:07PM -0700, Mario Smarduch wrote: > +/** > + * kvm_vm_ioctl_get_dirty_log - get and clear the log of dirty pages in a > slot > + * @kvm: kvm instance > + * @log: slot id and address to which we copy the log > + * > + * We need to keep it in mind that VCPU t

Re: [PATCH] KVM: x86: fix access memslots w/o hold srcu read lock

2014-11-01 Thread Paolo Bonzini
On 01/11/2014 03:49, Wanpeng Li wrote: > > This is also not enough. I see the warning in the below path during the > test: > > kvm_arch_vcpu_ioctl_run > -> kvm_apic_accept_events > -> kvm_vcpu_reset Hmm, better bypass the problem altogether: diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.