Re: [RFC PATCH v2 6/6] KVM: emulate: remove memopp and rip_relative

2014-04-13 Thread Paolo Bonzini
Il 10/04/2014 20:03, Bandan Das ha scritto: /* Fields above regs are cleared together. */ This comment is not accurate anymore after patch 4. Since you're fixing it, please add another comment saying where the cleared fields start, too. + ctxt->memop.addr.mem.ea = (u32)ctxt->

Re: [RFC PATCH v2 3/6] KVM: emulate: cleanup decode_rm

2014-04-13 Thread Paolo Bonzini
Il 10/04/2014 20:03, Bandan Das ha scritto: - if (ctxt->rex_prefix) { - ctxt->modrm_reg = (ctxt->rex_prefix & 4) << 1; /* REX.R */ - index_reg = (ctxt->rex_prefix & 2) << 2; /* REX.X */ - ctxt->modrm_rm = base_reg = (ctxt->rex_prefix & 1) << 3; /*

[PATCH RFC untested] kvm/x86: implement hv EOI assist

2014-04-13 Thread Michael S. Tsirkin
It seems that it's easy to implement the EOI assist on top of the PV EOI feature: simply convert the page address to the format expected by PV EOI. Signed-off-by: Michael S. Tsirkin --- Warning: untested! As I'll be off-line for a couple of days, sending this out for early review. Review/commen

[no subject]

2014-04-13 Thread Marcus White
Hello, I had some basic questions regarding KVM, and would appreciate any help:) I have been reading about the KVM architecture, and as I understand it, the guest shows up as a regular process in the host itself.. I had some questions around that.. 1. Are the guest processes implemented as a co

Re: [PATCH v4 0/4] KVM: enable Intel SMAP for KVM

2014-04-13 Thread Marcelo Tosatti
On Fri, Apr 11, 2014 at 08:16:28PM -0400, Paolo Bonzini wrote: > Il 10/04/2014 16:01, Marcelo Tosatti ha scritto: > >On Tue, Apr 08, 2014 at 04:38:08PM -0400, Paolo Bonzini wrote: > >>Il 07/04/2014 21:06, Wu, Feng ha scritto: > >Even though the tests do not cover the CPL=3/implicit access case,

Re: [PATCH v4 0/4] KVM: enable Intel SMAP for KVM

2014-04-13 Thread H. Peter Anvin
I would like to see this in 3.15. -hpa On April 13, 2014 2:57:38 PM PDT, Marcelo Tosatti wrote: >On Fri, Apr 11, 2014 at 08:16:28PM -0400, Paolo Bonzini wrote: >> Il 10/04/2014 16:01, Marcelo Tosatti ha scritto: >> >On Tue, Apr 08, 2014 at 04:38:08PM -0400, Paolo Bonzini wrote: >> >>Il 07/0

[PATCH] KVM: PPC: Book3S HV: Add missing code for transaction reclaim on guest exit

2014-04-13 Thread Paul Mackerras
Testing by Michael Neuling revealed that commit e4e38121507a ("KVM: PPC: Book3S HV: Add transactional memory support") is missing the code that saves away the checkpointed state of the guest when switching to the host. This adds that code, which was in earlier versions of the patch but went missin

[PATCH v2] virtio-scsi: Skip setting affinity on uninitialized vq

2014-04-13 Thread Fam Zheng
virtscsi_init calls virtscsi_remove_vqs on err, even before initializing the vqs. The latter calls virtscsi_set_affinity, so let's check the pointer there before setting affinity on it. This fixes a panic when setting device's num_queues=2 on RHEL 6.5: qemu-system-x86_64 ... \ -device virtio-scsi

Re: [PATCH v2 1/3] KVM: nVMX: Don't advertise single context invalidation for invept

2014-04-13 Thread Jan Kiszka
On 2014-04-11 21:35, Marcelo Tosatti wrote: > On Fri, Apr 11, 2014 at 08:53:09PM +0200, Jan Kiszka wrote: >> On 2014-04-11 20:35, Bandan Das wrote: >>> Jan Kiszka writes: >>> On 2014-04-11 19:26, Bandan Das wrote: > Jan Kiszka writes: > >> On 2014-04-11 02:27, Bandan Das wrote: >

Re: [PATCH v3] powerpc: kvm: make _PAGE_NUMA take effect

2014-04-13 Thread Alexander Graf
On 13.04.14 04:27, Liu ping fan wrote: On Fri, Apr 11, 2014 at 10:03 PM, Alexander Graf wrote: On 11.04.2014, at 13:45, Liu Ping Fan wrote: When we mark pte with _PAGE_NUMA we already call mmu_notifier_invalidate_range_start and mmu_notifier_invalidate_range_end, which will mark existing g