Il 18/04/2013 08:54, Gleb Natapov ha scritto:
> I like the comment since it provides example that can be looked at to
> understand the problem, so if you make the comment more generic leave
> the example please :)
Agreed. :)
Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm"
Gleb Natapov wrote on 18/04/2013 09:38:43 AM:
> On Wed, Apr 17, 2013 at 08:07:40PM +0300, Abel Gordon wrote:
> > Allocate a shadow vmcs used by the processor to shadow part of the
fields
> > stored in the software defined VMCS12 (let L1 access fields without
causing
> > exits). Note we keep a s
Gleb Natapov wrote on 18/04/2013 09:41:16 AM:
> On Wed, Apr 17, 2013 at 08:09:40PM +0300, Abel Gordon wrote:
> > Synchronize between the VMCS12 software controlled structure and the
> > processor-specific shadow vmcs
> >
> > Signed-off-by: Abel Gordon
> > ---
> > arch/x86/kvm/vmx.c | 32 ++
On Thu, Apr 18, 2013 at 10:07:36AM +0300, Abel Gordon wrote:
>
>
> Gleb Natapov wrote on 18/04/2013 09:41:16 AM:
>
>
> > On Wed, Apr 17, 2013 at 08:09:40PM +0300, Abel Gordon wrote:
> > > Synchronize between the VMCS12 software controlled structure and the
> > > processor-specific shadow vmcs
On Thu, Apr 18, 2013 at 10:07:11AM +0300, Abel Gordon wrote:
>
>
> Gleb Natapov wrote on 18/04/2013 09:38:43 AM:
>
> > On Wed, Apr 17, 2013 at 08:07:40PM +0300, Abel Gordon wrote:
> > > Allocate a shadow vmcs used by the processor to shadow part of the
> fields
> > > stored in the software defi
Gleb Natapov wrote on 18/04/2013 10:11:22 AM:
> On Thu, Apr 18, 2013 at 10:07:11AM +0300, Abel Gordon wrote:
> >
> >
> > Gleb Natapov wrote on 18/04/2013 09:38:43 AM:
> >
> > > On Wed, Apr 17, 2013 at 08:07:40PM +0300, Abel Gordon wrote:
> > > > Allocate a shadow vmcs used by the processor to
On Wed, Apr 17, 2013 at 09:52:39PM +0200, Martin Wawro wrote:
> Hi Stefan,
>
> > The host is interesting too if you suspect KVM is involved in the
> > performance issue (rather than it being purely an application issue
> > inside the guest). For example, pidstat (from the sysstat package) on
> >
Hi Stefan,
This morning we had to reboot the guest system again. pidstat logging
was not
enabled on the host (planned to do that later, hate myself for that).
Again it
looks like the schedulerinside the guest just does not want to schedule
anymore
(or takes coffee breaksinbetween), because tasks a
On Tue, Apr 16, 2013 at 01:49:18PM -0600, Alex Williamson wrote:
> We hope to at some point deprecate KVM legacy device assignment in
> favor of VFIO-based assignment. Towards that end, allow legacy
> device assignment to be deconfigured.
>
> Signed-off-by: Alex Williamson
Acked-by: Gleb Natapov
On Thu, Apr 18, 2013 at 09:05:52AM +0800, Asias He wrote:
> This helper is useful to check if a feature is supported.
>
> Signed-off-by: Asias He
> Reviewed-by: Stefan Hajnoczi
Why do we need the locking here by the way?
It seems features don't change while vhost
is running.
> ---
> drivers/v
On Thu, Apr 18, 2013 at 09:05:53AM +0800, Asias He wrote:
> Signed-off-by: Asias He
> ---
> drivers/vhost/tcm_vhost.c | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
> index 88ebb79..8f05528 100644
> --- a/drivers
Il 18/04/2013 01:03, Andrew Honig ha scritto:
> I don't have a significant objection to freeing the memory in
> kvm_arch_free_memslot, although I think it's a little harder to
> understand. I like the idea of being symmetric (memory is allocated
> by calling kvm_set_memory_region and freed using t
Il 18/04/2013 01:41, Wei Yongjun ha scritto:
> From: Wei Yongjun
>
> Fix to return a negative error code from the error handling
> case instead of 0, as returned elsewhere in this function.
>
> Signed-off-by: Wei Yongjun
> ---
> arch/x86/kvm/x86.c | 4 +++-
> 1 file changed, 3 insertions(+), 1
On Thu, Apr 18, 2013 at 10:06:06AM +0300, Michael S. Tsirkin wrote:
> On Thu, Apr 18, 2013 at 09:05:52AM +0800, Asias He wrote:
> > This helper is useful to check if a feature is supported.
> >
> > Signed-off-by: Asias He
> > Reviewed-by: Stefan Hajnoczi
>
> Why do we need the locking here by t
On Thu, Apr 18, 2013 at 10:09:53AM +0300, Michael S. Tsirkin wrote:
> On Thu, Apr 18, 2013 at 09:05:53AM +0800, Asias He wrote:
> > Signed-off-by: Asias He
> > ---
> > drivers/vhost/tcm_vhost.c | 18 ++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/vhost/tcm_v
On Thu, Apr 18, 2013 at 09:05:54AM +0800, Asias He wrote:
> In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for
> virtio-scsi), hotplug support is added to virtio-scsi.
>
> This patch adds hotplug and hotunplug support to tcm_vhost.
>
> You can create or delete a LUN in targetcli to ho
This series of patches implements shadow-vmcs capability for nested VMX.
Shadow-vmcs - background and overview:
In Intel VMX, vmread and vmwrite privileged instructions are used by the
hypervisor to read and modify the guest and host specifications (VMCS). In a
nested virtualization environmen
On Thu, Apr 18, 2013 at 09:05:51AM +0800, Asias He wrote:
> Changes in v7:
> - Add vhost_work_flush for vs->vs_event_work to this series
>
> Asias He (3):
> tcm_vhost: Introduce tcm_vhost_check_feature()
> tcm_vhost: Add helper to check if endpoint is setup
> tcm_vhost: Add hotplug/hotunplug
Add definitions for all the vmcs control fields/bits
required to enable vmcs-shadowing
Signed-off-by: Abel Gordon
---
arch/x86/include/asm/vmx.h|3 +++
arch/x86/include/uapi/asm/msr-index.h |2 ++
2 files changed, 5 insertions(+)
--- .before/arch/x86/include/asm/vmx.h 2013-
Add logic required to detect if shadow-vmcs is supported by the
processor. Introduce a new kernel module parameter to specify if L0 should use
shadow vmcs (or not) to run L1.
Signed-off-by: Abel Gordon
---
arch/x86/kvm/vmx.c | 25 -
1 file changed, 24 insertions(+), 1 d
Prepare vmread and vmwrite bitmaps according to a pre-specified list of fields.
These lists are intended to specifiy most frequent accessed fields so we can
minimize the number of fields that are copied from/to the software controlled
VMCS12 format to/from to processor-specific shadow vmcs. The lis
Refactor existent code so we re-use vmcs12_write_any to copy fields from the
shadow vmcs specified by the link pointer (used by the processor,
implementation-specific) to the VMCS12 software format used by L0 to hold
the fields in L1 memory address space.
Signed-off-by: Abel Gordon
---
arch/x86/
handle_vmon doesn't check if L1 is already in root mode (VMXON
was previously called). This patch adds this missing check and calls
nested_vmx_failValid if VMX is already ON.
We need this check because L0 will allocate the shadow vmcs when L1
executes VMXON and we want to avoid host leaks (due to s
On Thu, Apr 18, 2013 at 04:32:30PM +0800, Asias He wrote:
> On Thu, Apr 18, 2013 at 10:09:53AM +0300, Michael S. Tsirkin wrote:
> > On Thu, Apr 18, 2013 at 09:05:53AM +0800, Asias He wrote:
> > > Signed-off-by: Asias He
> > > ---
> > > drivers/vhost/tcm_vhost.c | 18 ++
> > > 1 fi
Allocate a shadow vmcs used by the processor to shadow part of the fields
stored in the software defined VMCS12 (let L1 access fields without causing
exits). Note we keep a shadow vmcs only for the current vmcs12. Once a vmcs12
becomes non-current, its shadow vmcs is released.
Signed-off-by: Abe
Unmap vmcs12 and release the corresponding shadow vmcs
Signed-off-by: Abel Gordon
---
arch/x86/kvm/vmx.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
--- .before/arch/x86/kvm/vmx.c 2013-04-18 11:28:23.0 +0300
+++ .after/arch/x86/kvm/vmx.c 2013-04-18
Introduce a function used to copy fields from the processor-specific shadow
vmcs to the software controlled VMCS12
Signed-off-by: Abel Gordon
---
arch/x86/kvm/vmx.c | 35 +++
1 file changed, 35 insertions(+)
--- .before/arch/x86/kvm/vmx.c 2013-04-18 11:28:23.0
Introduce a function used to copy fields from the software controlled VMCS12
to the processor-specific shadow vmcs
Signed-off-by: Abel Gordon
---
arch/x86/kvm/vmx.c | 45 +++
1 file changed, 45 insertions(+)
--- .before/arch/x86/kvm/vmx.c 2013-04-18 11
Synchronize between the VMCS12 software controlled structure and the
processor-specific shadow vmcs
Signed-off-by: Abel Gordon
---
arch/x86/kvm/vmx.c | 32
1 file changed, 32 insertions(+)
--- .before/arch/x86/kvm/vmx.c 2013-04-18 11:28:23.0 +0300
+++
Once L1 loads VMCS12 we enable shadow-vmcs capability and copy all the VMCS12
shadowed fields to the shadow vmcs. When we release the VMCS12, we also
disable shadow-vmcs capability.
Signed-off-by: Abel Gordon
---
arch/x86/kvm/vmx.c | 11 +++
1 file changed, 11 insertions(+)
--- .befo
On Thu, Apr 18, 2013 at 04:25:21PM +0800, Asias He wrote:
> On Thu, Apr 18, 2013 at 10:06:06AM +0300, Michael S. Tsirkin wrote:
> > On Thu, Apr 18, 2013 at 09:05:52AM +0800, Asias He wrote:
> > > This helper is useful to check if a feature is supported.
> > >
> > > Signed-off-by: Asias He
> > > R
On Thu, Apr 18, 2013 at 10:20:05AM +0200, Paolo Bonzini wrote:
> Il 18/04/2013 01:03, Andrew Honig ha scritto:
> > I don't have a significant objection to freeing the memory in
> > kvm_arch_free_memslot, although I think it's a little harder to
> > understand. I like the idea of being symmetric (m
On Thu, Apr 18, 2013 at 10:34:29AM +0300, Michael S. Tsirkin wrote:
> On Thu, Apr 18, 2013 at 09:05:54AM +0800, Asias He wrote:
> > In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for
> > virtio-scsi), hotplug support is added to virtio-scsi.
> >
> > This patch adds hotplug and hotunplu
On Thu, Apr 18, 2013 at 11:37:59AM +0300, Abel Gordon wrote:
> Unmap vmcs12 and release the corresponding shadow vmcs
>
> Signed-off-by: Abel Gordon
> ---
> arch/x86/kvm/vmx.c | 20
> 1 file changed, 12 insertions(+), 8 deletions(-)
>
> --- .before/arch/x86/kvm/vmx.c
On Tue, Apr 16, 2013 at 02:46:47AM +0200, Andreas Färber wrote:
> From: Igor Mammedov
>
> ... so it could be called without requiring CPUArchState.
>
> Signed-off-by: Igor Mammedov
> Reviewed-by: Eduardo Habkost
> Signed-off-by: Andreas Färber
Acked-by: Gleb Natapov
> ---
> cpus.c
On Thu, Apr 18, 2013 at 04:59:08PM +0800, Asias He wrote:
> On Thu, Apr 18, 2013 at 10:34:29AM +0300, Michael S. Tsirkin wrote:
> > On Thu, Apr 18, 2013 at 09:05:54AM +0800, Asias He wrote:
> > > In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for
> > > virtio-scsi), hotplug support is a
On 04/11/13 11:29, Stefan Hajnoczi wrote:
> On Mon, Apr 08, 2013 at 12:27:06PM +, Zhanghaoyu (A) wrote:
>> On Sun, Apr 07, 2013 at 04:58:07AM +, Zhanghaoyu (A) wrote:
>> I start a kvm VM with vnc(using the zrle protocol) connect, sometimes
>> qemu program crashed during starting pe
On Wed, Apr 17, 2013 at 05:39:04PM -0300, Marcelo Tosatti wrote:
> On Fri, Mar 22, 2013 at 09:15:24PM +0200, Gleb Natapov wrote:
> > On Fri, Mar 22, 2013 at 08:37:33PM +0800, Xiao Guangrong wrote:
> > > On 03/22/2013 08:12 PM, Gleb Natapov wrote:
> > > > On Fri, Mar 22, 2013 at 08:03:04PM +0800, Xi
On Wed, Apr 17, 2013 at 08:25:07PM -0300, Marcelo Tosatti wrote:
> On Tue, Apr 16, 2013 at 06:18:52PM +0200, Borislav Petkov wrote:
> > On Sun, Apr 14, 2013 at 01:03:20PM +0200, Borislav Petkov wrote:
> > > On Sun, Apr 14, 2013 at 12:31:12PM +0300, Pekka Enberg wrote:
> > > > I obviously support ha
On Thu, Apr 18, 2013 at 11:46 AM, Borislav Petkov wrote:
> ok, maybe I wasn't clear enough. My proposal was to actually add all (or
> maybe not *all* of them, but most) those selects above to the KVM_GUEST
> config option. Because, you very probably want to select all that stuff
> above anyway if
On 04/18/2013 09:25 AM, Stefan Hajnoczi wrote:
Hi Stefan,
> I see. That's a good reason to carefully monitor the host for things
> that could interfere with guest performance.
>
> Stefan
Seems that today is a bad day for our server. We had to give him the
boot (again).
Also the results of the pi
Gleb Natapov wrote on 18/04/2013 12:12:18 PM:
> On Thu, Apr 18, 2013 at 11:37:59AM +0300, Abel Gordon wrote:
> > Unmap vmcs12 and release the corresponding shadow vmcs
> >
> > Signed-off-by: Abel Gordon
> > ---
> > arch/x86/kvm/vmx.c | 20
> > 1 file changed, 12 inserti
On Thu, Apr 18, 2013 at 11:55:33AM +0200, Geert Uytterhoeven wrote:
> On Thu, Apr 18, 2013 at 11:46 AM, Borislav Petkov wrote:
> > ok, maybe I wasn't clear enough. My proposal was to actually add all (or
> > maybe not *all* of them, but most) those selects above to the KVM_GUEST
> > config option.
On Wed, Apr 17, 2013 at 10:54:32AM -0700, Andrew Honig wrote:
>
> If userspace creates and destroys multiple VMs within the same process
> we leak 20k of memory in the userspace process context per VM. This
> patch frees the memory in kvm_arch_destroy_vm. If the process exits
> without closing t
On Thu, Apr 18, 2013 at 01:16:34PM +0300, Abel Gordon wrote:
>
>
> Gleb Natapov wrote on 18/04/2013 12:12:18 PM:
>
> > On Thu, Apr 18, 2013 at 11:37:59AM +0300, Abel Gordon wrote:
> > > Unmap vmcs12 and release the corresponding shadow vmcs
> > >
> > > Signed-off-by: Abel Gordon
> > > ---
> >
qemu64 is the default CPU model for QEMU/KVM on x86-64, but its family number
definition is not accurate. The vendor of 'qemu64' is defined as 'AMD'. For AMD
processors, AMD K8 (i.e. Family 15) firstly introduced SSE3 instruction set.
'qemu64' already has 'CPUID_EXT_SSE3' in its ext_features, bu
On Tue, Apr 16, 2013 at 02:32:46PM +0800, Xiao Guangrong wrote:
> pte_list_clear_concurrently allows us to reset pte-desc entry
> out of mmu-lock. We can reset spte out of mmu-lock if we can protect the
> lifecycle of sp, we use this way to achieve the goal:
>
> unmap_memslot_rmap_nolock():
> for-
On Thu, Apr 18, 2013 at 10:45:38AM +, Ren, Yongjie wrote:
> qemu64 is the default CPU model for QEMU/KVM on x86-64, but its family number
> definition is not accurate. The vendor of 'qemu64' is defined as 'AMD'. For
> AMD
> processors, AMD K8 (i.e. Family 15) firstly introduced SSE3 instruct
> > On Mon, Apr 08, 2013 at 12:27:06PM +, Zhanghaoyu (A) wrote:
> >> On Sun, Apr 07, 2013 at 04:58:07AM +, Zhanghaoyu (A) wrote:
> >> I start a kvm VM with vnc(using the zrle protocol) connect, sometimes
> >> qemu program crashed during starting period, received signal SIGABRT.
> >
On 04/18/2013 07:00 PM, Gleb Natapov wrote:
> On Tue, Apr 16, 2013 at 02:32:46PM +0800, Xiao Guangrong wrote:
>> pte_list_clear_concurrently allows us to reset pte-desc entry
>> out of mmu-lock. We can reset spte out of mmu-lock if we can protect the
>> lifecycle of sp, we use this way to achieve t
This series of patches implements shadow-vmcs capability for nested VMX.
Shadow-vmcs - background and overview:
In Intel VMX, vmread and vmwrite privileged instructions are used by the
hypervisor to read and modify the guest and host specifications (VMCS). In a
nested virtualization environmen
Add definitions for all the vmcs control fields/bits
required to enable vmcs-shadowing
Signed-off-by: Abel Gordon
---
arch/x86/include/asm/vmx.h|3 +++
arch/x86/include/uapi/asm/msr-index.h |2 ++
2 files changed, 5 insertions(+)
--- .before/arch/x86/include/asm/vmx.h 2013-
Add logic required to detect if shadow-vmcs is supported by the
processor. Introduce a new kernel module parameter to specify if L0 should use
shadow vmcs (or not) to run L1.
Signed-off-by: Abel Gordon
---
arch/x86/kvm/vmx.c | 25 -
1 file changed, 24 insertions(+), 1 d
Prepare vmread and vmwrite bitmaps according to a pre-specified list of fields.
These lists are intended to specifiy most frequent accessed fields so we can
minimize the number of fields that are copied from/to the software controlled
VMCS12 format to/from to processor-specific shadow vmcs. The lis
Refactor existent code so we re-use vmcs12_write_any to copy fields from the
shadow vmcs specified by the link pointer (used by the processor,
implementation-specific) to the VMCS12 software format used by L0 to hold
the fields in L1 memory address space.
Signed-off-by: Abel Gordon
---
arch/x86/
handle_vmon doesn't check if L1 is already in root mode (VMXON
was previously called). This patch adds this missing check and calls
nested_vmx_failValid if VMX is already ON.
We need this check because L0 will allocate the shadow vmcs when L1
executes VMXON and we want to avoid host leaks (due to s
Allocate a shadow vmcs used by the processor to shadow part of the fields
stored in the software defined VMCS12 (let L1 access fields without causing
exits). Note we keep a shadow vmcs only for the current vmcs12. Once a vmcs12
becomes non-current, its shadow vmcs is released.
Signed-off-by: Abe
Unmap vmcs12 and release the corresponding shadow vmcs
Signed-off-by: Abel Gordon
---
arch/x86/kvm/vmx.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
--- .before/arch/x86/kvm/vmx.c 2013-04-18 13:31:35.0 +0300
+++ .after/arch/x86/kvm/vmx.c 2013-04-18
Introduce a function used to copy fields from the processor-specific shadow
vmcs to the software controlled VMCS12
Signed-off-by: Abel Gordon
---
arch/x86/kvm/vmx.c | 35 +++
1 file changed, 35 insertions(+)
--- .before/arch/x86/kvm/vmx.c 2013-04-18 13:31:35.0
On Thu, Apr 18, 2013 at 07:22:23PM +0800, Xiao Guangrong wrote:
> On 04/18/2013 07:00 PM, Gleb Natapov wrote:
> > On Tue, Apr 16, 2013 at 02:32:46PM +0800, Xiao Guangrong wrote:
> >> pte_list_clear_concurrently allows us to reset pte-desc entry
> >> out of mmu-lock. We can reset spte out of mmu-loc
Introduce a function used to copy fields from the software controlled VMCS12
to the processor-specific shadow vmcs
Signed-off-by: Abel Gordon
---
arch/x86/kvm/vmx.c | 45 +++
1 file changed, 45 insertions(+)
--- .before/arch/x86/kvm/vmx.c 2013-04-18 13
Synchronize between the VMCS12 software controlled structure and the
processor-specific shadow vmcs
Signed-off-by: Abel Gordon
---
arch/x86/kvm/vmx.c | 32
1 file changed, 32 insertions(+)
--- .before/arch/x86/kvm/vmx.c 2013-04-18 13:31:35.0 +0300
+++
Once L1 loads VMCS12 we enable shadow-vmcs capability and copy all the VMCS12
shadowed fields to the shadow vmcs. When we release the VMCS12, we also
disable shadow-vmcs capability.
Signed-off-by: Abel Gordon
---
arch/x86/kvm/vmx.c | 11 +++
1 file changed, 11 insertions(+)
--- .befo
On 04/18/2013 07:38 PM, Gleb Natapov wrote:
> On Thu, Apr 18, 2013 at 07:22:23PM +0800, Xiao Guangrong wrote:
>> On 04/18/2013 07:00 PM, Gleb Natapov wrote:
>>> On Tue, Apr 16, 2013 at 02:32:46PM +0800, Xiao Guangrong wrote:
pte_list_clear_concurrently allows us to reset pte-desc entry
ou
On Thu, Apr 18, 2013 at 02:34:25PM +0300, Abel Gordon wrote:
> This series of patches implements shadow-vmcs capability for nested VMX.
>
> Shadow-vmcs - background and overview:
>
> In Intel VMX, vmread and vmwrite privileged instructions are used by the
> hypervisor to read and modify the gue
On 04/18/2013 02:34 PM, Abel Gordon wrote:
> This series of patches implements shadow-vmcs capability for nested VMX.
>
> Shadow-vmcs - background and overview:
>
> In Intel VMX, vmread and vmwrite privileged instructions are used by the
> hypervisor to read and modify the guest and host specif
On Thu, Apr 18, 2013 at 12:00:49PM +, Zhanghaoyu (A) wrote:
> I start 10 VMs(windows xp), then running geekbench tool on them, about 2
> days, one of them was reset,
> I found the reset operation is done by
> int kvm_cpu_exec(CPUArchState *env)
> {
> ...
>switch (run->exit_reason)
On Thu, Apr 18, 2013 at 12:00 PM, Martin Wawro wrote:
> On 04/18/2013 09:25 AM, Stefan Hajnoczi wrote:
>> I see. That's a good reason to carefully monitor the host for things
>> that could interfere with guest performance.
>>
>> Stefan
> Seems that today is a bad day for our server. We had to giv
On 04/18/2013 03:14 PM, Stefan Hajnoczi wrote:
Dear Stefan,
> No answer but some more questions.
>
> Regarding the kvm_stat output, the exits are caused by 68,000
> pagefaults/second (pf_fixed). Perhaps someone can explain what this
> means?
>
> The host has 8 cores, the guest has 7. Host pidst
On Apr 18, 2013, at 3:55 PM, Gleb Natapov wrote:
> On Thu, Apr 18, 2013 at 12:00:49PM +, Zhanghaoyu (A) wrote:
>> I start 10 VMs(windows xp), then running geekbench tool on them, about 2
>> days, one of them was reset,
>> I found the reset operation is done by
>> int kvm_cpu_exec(CPUArchStat
On Thu, Apr 18, 2013 at 10:03:06AM -0300, Marcelo Tosatti wrote:
> On Thu, Apr 18, 2013 at 12:00:16PM +0800, Xiao Guangrong wrote:
> > >
> > > What is the justification for this?
> >
> > We want the rmap of being deleted memslot is removed-only that is
> > needed for unmapping rmap out of mmu-lo
On Thu, Apr 18, 2013 at 11:46:29AM +0200, Borislav Petkov wrote:
> On Wed, Apr 17, 2013 at 08:25:07PM -0300, Marcelo Tosatti wrote:
> > On Tue, Apr 16, 2013 at 06:18:52PM +0200, Borislav Petkov wrote:
> > > On Sun, Apr 14, 2013 at 01:03:20PM +0200, Borislav Petkov wrote:
> > > > On Sun, Apr 14, 201
On Thu, Apr 18, 2013 at 12:00:16PM +0800, Xiao Guangrong wrote:
> >
> > What is the justification for this?
>
> We want the rmap of being deleted memslot is removed-only that is
> needed for unmapping rmap out of mmu-lock.
>
> ==
> 1) do not corrupt the rmap
> 2) keep pte-list-descs availab
On Thu, Apr 18, 2013 at 12:42:39PM +0300, Gleb Natapov wrote:
> > > that, but if not then less code is better.
> >
> > The number of sp->role.invalid=1 pages is small (only shadow roots). It
> > can grow but is bounded to a handful. No improvement visible there.
> >
> > The number of shadow pages
We have a capability enquire system that allows user space to ask kvm
whether a feature is available.
The point behind this system is that we can have different kernel
configurations with different capabilities and user space can adjust
accordingly.
Because features can always be non existent, we
The prototype has been stale for a while, I can't spot any real function
define behind it. Let's just remove it.
Signed-off-by: Alexander Graf
---
include/linux/kvm_host.h |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_ho
From: Scott Wood
Enabling this capability connects the vcpu to the designated in-kernel
MPIC. Using explicit connections between vcpus and irqchips allows
for flexibility, but the main benefit at the moment is that it
simplifies the code -- KVM doesn't need vm-global state to remember
which MPIC
From: Scott Wood
Hook the MPIC code up to the KVM interfaces, add locking, etc.
Signed-off-by: Scott Wood
[agraf: add stub function for kvmppc_mpic_set_epr, non-booke, 64bit]
Signed-off-by: Alexander Graf
---
Documentation/virtual/kvm/devices/mpic.txt | 37 ++
arch/powerpc/include/asm/kvm_h
From: Scott Wood
Remove some parts of the code that are obviously QEMU or Raven specific
before fixing style issues, to reduce the style issues that need to be
fixed.
Signed-off-by: Scott Wood
Signed-off-by: Alexander Graf
---
arch/powerpc/kvm/mpic.c | 344 ---
Now that all the irq routing and irqfd pieces are generic, we can expose
real irqchip support to all of KVM's internal helpers.
This allows us to use irqfd with the in-kernel MPIC.
Signed-off-by: Alexander Graf
---
arch/powerpc/include/asm/kvm_host.h |7 ++
arch/powerpc/include/uapi/asm/kvm
From: Scott Wood
Remove braces that Linux style doesn't permit, remove space after
'*' that Lindent added, keep error/debug strings contiguous, etc.
Substitute type names, debug prints, etc.
Signed-off-by: Scott Wood
Signed-off-by: Alexander Graf
---
arch/powerpc/kvm/mpic.c | 445 ++
From: Scott Wood
This is QEMU's hw/openpic.c from commit
abd8d4a4d6dfea7ddea72f095f993e1de941614e ("Update version for
1.4.0-rc0"), run through Lindent with no other changes to ease merging
future changes between Linux and QEMU. Remaining style issues
(including those introduced by Lindent) will
The code as is doesn't make any sense on non-e500 platforms. Restrict it
there, so that people don't get wrong ideas on what would actually work.
This patch should get reverted as soon as it's possible to either run e500
guests on non-e500 hosts or the MPIC emulation gains support for non-e500
mod
Hi,
This patch set contains a fully working implementation of the in-kernel MPIC
from Scott with a few fixups and a new version of my irqfd generalization
patch set.
Major changes to my last irqfd set are:
- depend on CONFIG_ defines rather than __KVM defines
- fix compile issues
- fix the
The current irq_comm.c file contains pieces of code that are generic
across different irqchip implementations, as well as code that is
fully IOAPIC specific.
Split the generic bits out into irqchip.c.
Signed-off-by: Alexander Graf
---
arch/x86/kvm/Makefile |2 +-
include/trace/events/k
Setting up IRQ routes is nothing IOAPIC specific. Extract everything
that really is generic code into irqchip.c and only leave the ioapic
specific bits to irq_comm.c.
Signed-off-by: Alexander Graf
---
include/linux/kvm_host.h |3 ++
virt/kvm/irq_comm.c | 76 ++-
Now that we have most irqfd code completely platform agnostic, let's move
irqfd's resample capability return to generic code as well.
Signed-off-by: Alexander Graf
---
arch/x86/kvm/x86.c |1 -
virt/kvm/kvm_main.c |3 +++
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arc
From: Scott Wood
Currently, devices that are emulated inside KVM are configured in a
hardcoded manner based on an assumption that any given architecture
only has one way to do it. If there's any need to access device state,
it is done through inflexible one-purpose-only IOCTLs (e.g.
KVM_GET/SET_
Quite a bit of code in KVM has been conditionalized on availability of
IOAPIC emulation. However, most of it is generically applicable to
platforms that don't have an IOPIC, but a different type of irq chip.
Make code that only relies on IRQ routing, not an APIC itself, on
CONFIG_HAVE_KVM_IRQ_ROUT
Now that all pieces are in place for reusing generic irq infrastructure,
we can copy x86's implementation of KVM_IRQ_LINE irq injection and simply
reuse it for PPC, as it will work there just as well.
Signed-off-by: Alexander Graf
---
arch/powerpc/include/uapi/asm/kvm.h |1 +
arch/powerpc/kv
The concept of routing interrupt lines to an irqchip is nothing
that is IOAPIC specific. Every irqchip has a maximum number of pins
that can be linked to irq lines.
So let's add a new define that allows us to reuse generic code for
non-IOAPIC platforms.
Signed-off-by: Alexander Graf
---
arch/x8
The IRQ routing set ioctl lives in the hacky device assignment code inside
of KVM today. This is definitely the wrong place for it. Move it to the much
more natural kvm_main.c.
Signed-off-by: Alexander Graf
---
virt/kvm/assigned-dev.c | 30 --
virt/kvm/kvm_main.c
I need your assistance to move funds from Singapore. I will forward
details upon your request.
Cham Tao Soon
This message was sent using IMP, the Internet Messaging Program.
--
To unsubscribe from this list: send the line "u
On 04/18/2013 09:11:57 AM, Alexander Graf wrote:
The code as is doesn't make any sense on non-e500 platforms.
Why? What actually breaks?
You never answered my earlier question about whether 74xx is
supported. MPC86xx is 74xx-derived and has an FSL MPIC.
Plus, as pointed out earlier, this
> -Original Message-
> From: Gleb Natapov [mailto:g...@redhat.com]
> Sent: Thursday, April 18, 2013 7:08 PM
> To: Ren, Yongjie
> Cc: Marcelo Tosatti; kvm@vger.kernel.org; qemu-de...@nongnu.org;
> ehabk...@redhat.com
> Subject: Re: [PATCH] target-i386: upgrade family number of qemu64 CPU
> m
On 18.04.2013, at 16:29, Scott Wood wrote:
> On 04/18/2013 09:11:57 AM, Alexander Graf wrote:
>> The code as is doesn't make any sense on non-e500 platforms.
>
> Why? What actually breaks?
It broke even compiling, because book3s doesn't provide anything for EPR for
example. I fixed up the iss
On Thu, Apr 18, 2013 at 02:47:21PM +, Ren, Yongjie wrote:
> > -Original Message-
> > From: Gleb Natapov [mailto:g...@redhat.com]
> > Sent: Thursday, April 18, 2013 7:08 PM
> > To: Ren, Yongjie
> > Cc: Marcelo Tosatti; kvm@vger.kernel.org; qemu-de...@nongnu.org;
> > ehabk...@redhat.com
>
On 04/18/2013 09:29 PM, Marcelo Tosatti wrote:
> On Thu, Apr 18, 2013 at 10:03:06AM -0300, Marcelo Tosatti wrote:
>> On Thu, Apr 18, 2013 at 12:00:16PM +0800, Xiao Guangrong wrote:
What is the justification for this?
>>>
>>> We want the rmap of being deleted memslot is removed-only that
On Fri, Apr 05, 2013 at 10:08:04AM +0100, Marc Zyngier wrote:
> On 04/04/13 23:10, Geoff Levand wrote:
> > Hi,
> >
> > On Tue, 2013-04-02 at 14:25 +0100, Marc Zyngier wrote:
> >> + @ Jump to the trampoline page
> >> + ldr r2, =#PAGE_MASK
> >> + adr r3, target
> >> + bic r3, r3, r2
On 18/04/13 16:54, Russell King - ARM Linux wrote:
> On Fri, Apr 05, 2013 at 10:08:04AM +0100, Marc Zyngier wrote:
>> On 04/04/13 23:10, Geoff Levand wrote:
>>> Hi,
>>>
>>> On Tue, 2013-04-02 at 14:25 +0100, Marc Zyngier wrote:
+ @ Jump to the trampoline page
+ ldr r2, =#PAGE_MASK
>
1 - 100 of 118 matches
Mail list logo
