Re: [PATCH] vhost_net: remove tx polling state

2013-03-11 Thread Jason Wang
On 03/11/2013 12:50 AM, Michael S. Tsirkin wrote: > On Thu, Mar 07, 2013 at 12:31:56PM +0800, Jason Wang wrote: >> After commit 2b8b328b61c799957a456a5a8dab8cc7dea68575 (vhost_net: handle >> polling >> errors when setting backend), we in fact track the polling state through >> poll->wqh, so there'

Re: [PATCH] vhost_net: remove tx polling state

2013-03-11 Thread Jason Wang
On 03/11/2013 03:09 PM, Jason Wang wrote: > On 03/11/2013 12:50 AM, Michael S. Tsirkin wrote: >> On Thu, Mar 07, 2013 at 12:31:56PM +0800, Jason Wang wrote: >>> After commit 2b8b328b61c799957a456a5a8dab8cc7dea68575 (vhost_net: handle >>> polling >>> errors when setting backend), we in fact track t

Re: [PATCH uq/master 2/2] kvm: forward INIT signals coming from the chipset

2013-03-11 Thread Paolo Bonzini
Il 10/03/2013 16:24, Gleb Natapov ha scritto: > On Sun, Mar 10, 2013 at 04:04:39PM +0100, Paolo Bonzini wrote: >> Il 10/03/2013 15:55, Gleb Natapov ha scritto: > Why not move INIT case from below as is? Vcpu is reset to correct sate > by QEMU just like during system_reset. APs wou

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-03-11 Thread Abel Gordon
"Nadav Har'El" wrote on 11/03/2013 12:43:35 AM: > On Sun, Mar 10, 2013, Abel Gordon wrote about "[PATCH 10/11] KVM: > nVMX: Synchronize VMCS12 content with the shadow vmcs": > > nested_vmx_vmexit(vcpu); > > + if (enable_shadow_vmcs) > > + copy_vmcs12_to_shadow(to_vmx(vcpu)); > > I was

Re: win2k guest vm won't boot under Fedora 18 KVM

2013-03-11 Thread Stefan Hajnoczi
On Sat, Mar 09, 2013 at 12:43:32PM -0700, Earl Marwil wrote: > Hi, > > I'm looking for some guidance on how to get to the root cause of an > issue that I am observing with a win2k guest that won't boot under > Fedora 18 on one system but will boot on another. A few days ago I > posted on the fedor

Re: [PATCH] vhost_net: remove tx polling state

2013-03-11 Thread Michael S. Tsirkin
On Mon, Mar 11, 2013 at 03:33:16PM +0800, Jason Wang wrote: > On 03/11/2013 03:09 PM, Jason Wang wrote: > > On 03/11/2013 12:50 AM, Michael S. Tsirkin wrote: > >> On Thu, Mar 07, 2013 at 12:31:56PM +0800, Jason Wang wrote: > >>> After commit 2b8b328b61c799957a456a5a8dab8cc7dea68575 (vhost_net: hand

Re: win2k guest vm won't boot under Fedora 18 KVM

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 09:09:13AM +0100, Stefan Hajnoczi wrote: > On Sat, Mar 09, 2013 at 12:43:32PM -0700, Earl Marwil wrote: > > Hi, > > > > I'm looking for some guidance on how to get to the root cause of an > > issue that I am observing with a win2k guest that won't boot under > > Fedora 18 o

Re: [PATCH] vhost_net: remove tx polling state

2013-03-11 Thread Michael S. Tsirkin
On Mon, Mar 11, 2013 at 03:09:10PM +0800, Jason Wang wrote: > On 03/11/2013 12:50 AM, Michael S. Tsirkin wrote: > > On Thu, Mar 07, 2013 at 12:31:56PM +0800, Jason Wang wrote: > >> After commit 2b8b328b61c799957a456a5a8dab8cc7dea68575 (vhost_net: handle > >> polling > >> errors when setting backen

Re: [PATCH] vhost_net: remove tx polling state

2013-03-11 Thread Jason Wang
On 03/11/2013 04:29 PM, Michael S. Tsirkin wrote: > On Mon, Mar 11, 2013 at 03:09:10PM +0800, Jason Wang wrote: >> On 03/11/2013 12:50 AM, Michael S. Tsirkin wrote: >>> On Thu, Mar 07, 2013 at 12:31:56PM +0800, Jason Wang wrote: After commit 2b8b328b61c799957a456a5a8dab8cc7dea68575 (vhost_net:

Re: [PATCH] vhost_net: remove tx polling state

2013-03-11 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 12:31:56PM +0800, Jason Wang wrote: > After commit 2b8b328b61c799957a456a5a8dab8cc7dea68575 (vhost_net: handle > polling > errors when setting backend), we in fact track the polling state through > poll->wqh, so there's no need to duplicate the work with an extra > vhost_ne

Re: [STRAWMAN PATCH] KVM: PPC: Add ioctl to specify interrupt controller architecture to emulate

2013-03-11 Thread Alexander Graf
Am 09.03.2013 um 03:26 schrieb Paul Mackerras : > On Fri, Mar 08, 2013 at 12:04:30PM +0100, Alexander Graf wrote: >> >> >> Am 08.03.2013 um 11:37 schrieb Paul Mackerras : >> >>> I have >>> used the first argument (cap->args[0]) to specify which interrupt >>> controller you want to connect the

Re: [PATCH RFC 0/2] kvm: Better yield_to candidate using preemption notifiers

2013-03-11 Thread Gleb Natapov
On Mon, Mar 04, 2013 at 11:31:46PM +0530, Raghavendra K T wrote: > This patch series further filters better vcpu candidate to yield to > in PLE handler. The main idea is to record the preempted vcpus using > preempt notifiers and iterate only those preempted vcpus in the > handler. Note that the v

Re: kvm + ceph performance issues

2013-03-11 Thread Wolfgang Hennerbichler
On 03/08/2013 09:35 AM, Stefan Hajnoczi wrote: > Please try using virtio-blk instead of IDE. there is no difference if I use virtio-blk. > If the guest still jerks try using the Linux rbd block driver instead of > QEMU -drive rbd:. I haven't used Ceph much but there should be > documentation

Re: [PATCH] kvm: remove cast for kmalloc return value

2013-03-11 Thread Gleb Natapov
On Sun, Mar 10, 2013 at 03:46:00PM +0200, Ioan Orghici wrote: > Signed-off-by: Ioan Orghici > --- > arch/x86/kvm/vmx.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 7cc566b..35c2c8f 100644 > --- a/arch/x86/kvm/vmx.c >

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Paolo Bonzini
Il 10/03/2013 19:10, Gleb Natapov ha scritto: > On Sun, Mar 10, 2013 at 06:19:07PM +0100, Paolo Bonzini wrote: >> Il 10/03/2013 16:35, Gleb Natapov ha scritto: > However, it would effectively redefine the meaning of > KVM_MP_STATE_INIT_RECEIVED and KVM_MP_STATE_SIPI_RECEIVED, respectively >

Re: [kvmarm] [GIT PULL v2] KVM/ARM Fixes for 3.9-rc1

2013-03-11 Thread Marc Zyngier
On 08/03/13 11:31, Gleb Natapov wrote: > On Fri, Mar 08, 2013 at 04:12:41AM +0100, Marc Zyngier wrote: >> On Thu, 7 Mar 2013 16:09:00 -0300, Marcelo Tosatti >> wrote: >>> On Thu, Mar 07, 2013 at 07:57:23AM +0100, Marc Zyngier wrote: On Wed, 6 Mar 2013 20:40:00 -0800, Christoffer Dall >>

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 11:14:39AM +0100, Paolo Bonzini wrote: > Il 10/03/2013 19:10, Gleb Natapov ha scritto: > > On Sun, Mar 10, 2013 at 06:19:07PM +0100, Paolo Bonzini wrote: > >> Il 10/03/2013 16:35, Gleb Natapov ha scritto: > > However, it would effectively redefine the meaning of > >

Re: [kvmarm] [GIT PULL v2] KVM/ARM Fixes for 3.9-rc1

2013-03-11 Thread Marc Zyngier
On 08/03/13 19:26, Christoffer Dall wrote: > On Thu, Mar 7, 2013 at 7:12 PM, Marc Zyngier wrote: >> On Thu, 7 Mar 2013 16:09:00 -0300, Marcelo Tosatti >> wrote: >>> On Thu, Mar 07, 2013 at 07:57:23AM +0100, Marc Zyngier wrote: On Wed, 6 Mar 2013 20:40:00 -0800, Christoffer Dall wr

Re: [kvmarm] [GIT PULL v2] KVM/ARM Fixes for 3.9-rc1

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 10:38:23AM +, Marc Zyngier wrote: > On 08/03/13 19:26, Christoffer Dall wrote: > > On Thu, Mar 7, 2013 at 7:12 PM, Marc Zyngier wrote: > >> On Thu, 7 Mar 2013 16:09:00 -0300, Marcelo Tosatti > >> wrote: > >>> On Thu, Mar 07, 2013 at 07:57:23AM +0100, Marc Zyngier wrote

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 11:28, Gleb Natapov ha scritto: >> Not really true---we do exit with that state and EINTR when we get a >> SIPI. Perhaps that can be changed. > > That's implementation detail. We can jump to the beginning of the > function instead. Nowhere we document that entering > KVM_MP_STATE_SIP

Re: TCP small packets throughput and multiqueue virtio-net

2013-03-11 Thread Michael S. Tsirkin
On Fri, Mar 08, 2013 at 07:05:15AM -0800, Eric Dumazet wrote: > On Fri, 2013-03-08 at 14:24 +0800, Jason Wang wrote: > > Hello all: > > > > I meet an issue when testing multiqueue virtio-net. When I testing guest > > small packets stream sending performance with netperf. I find an > > regression o

Re: [PATCH V4 1/5] virtio-scsi: redo allocation of target data

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 03:43, Wanlong Gao ha scritto: > virtio_scsi_target_state is now empty, but we will find new uses > for it in the next few patches. However, dropping the sglist lets > us turn the array-of-pointers into a simple array, which simplifies > the allocation. > > However, we do not leave

Re: [PATCH 1/2] tcm_vhost: Wait for pending requests in vhost_scsi_flush()

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 06:09, Asias He ha scritto: > This patch makes vhost_scsi_flush() wait for all the pending requests > issued before the flush operation to be finished. There is no protection against issuing concurrent flush operations. If we later would like to make the flush a ioctl (for example f

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 12:25:57PM +0100, Paolo Bonzini wrote: > Il 11/03/2013 11:28, Gleb Natapov ha scritto: > >> Not really true---we do exit with that state and EINTR when we get a > >> SIPI. Perhaps that can be changed. > > > > That's implementation detail. We can jump to the beginning of the

Re: [PATCH 1/2] tcm_vhost: Wait for pending requests in vhost_scsi_flush()

2013-03-11 Thread Michael S. Tsirkin
On Mon, Mar 11, 2013 at 12:36:37PM +0100, Paolo Bonzini wrote: > Il 11/03/2013 06:09, Asias He ha scritto: > > This patch makes vhost_scsi_flush() wait for all the pending requests > > issued before the flush operation to be finished. > > There is no protection against issuing concurrent flush ope

Re: [PATCH V2 0/6] tcm_vhost hotplug/hotunplug support and locking/flushing fix

2013-03-11 Thread Michael S. Tsirkin
On Fri, Mar 08, 2013 at 10:21:41AM +0800, Asias He wrote: > Changes in v2: > - Remove code duplication in tcm_vhost_{hotplug,hotunplug} > - Fix racing of vs_events_nr > - Add flush fix patch to this series > Asias He (6): > tcm_vhost: Add missed lock in vhost_scsi_clear_endpoint() > tcm_vhost:

Re: [PATCH 1/2] tcm_vhost: Wait for pending requests in vhost_scsi_flush()

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 12:53, Michael S. Tsirkin ha scritto: > On Mon, Mar 11, 2013 at 12:36:37PM +0100, Paolo Bonzini wrote: >> Il 11/03/2013 06:09, Asias He ha scritto: >>> This patch makes vhost_scsi_flush() wait for all the pending requests >>> issued before the flush operation to be finished. >> >> The

Re: [PATCH v5 5/5] KVM : VMX: Use posted interrupt to deliver virtual interrupt

2013-03-11 Thread Gleb Natapov
On Fri, Mar 08, 2013 at 09:23:21AM +0800, Yang Zhang wrote: > From: Yang Zhang > > If posted interrupt is avaliable, then uses it to inject virtual > interrupt to guest. > > Signed-off-by: Yang Zhang > --- > arch/x86/kvm/irq.c |2 +- > arch/x86/kvm/lapic.c | 16 +--- > arch

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 12:51, Gleb Natapov ha scritto: >> > >> > Agreed, but we still have the problem of how to signal from userspace. >> > For that do you have any other suggestion than mp_state? And if we keep >> > mp_state to signal from userspace, giving INIT_RECEIVED the >> > "wait-for-SIPI" semanti

RE: [PATCH v5 5/5] KVM : VMX: Use posted interrupt to deliver virtual interrupt

2013-03-11 Thread Zhang, Yang Z
Gleb Natapov wrote on 2013-03-11: > On Fri, Mar 08, 2013 at 09:23:21AM +0800, Yang Zhang wrote: >> From: Yang Zhang >> >> If posted interrupt is avaliable, then uses it to inject virtual >> interrupt to guest. >> >> Signed-off-by: Yang Zhang >> --- >> arch/x86/kvm/irq.c |2 +- >> arch/x8

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 02:31:46PM +0100, Paolo Bonzini wrote: > Il 11/03/2013 12:51, Gleb Natapov ha scritto: > >> > > >> > Agreed, but we still have the problem of how to signal from userspace. > >> > For that do you have any other suggestion than mp_state? And if we keep > >> > mp_state to sig

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Jan Kiszka
On 2013-03-11 14:54, Gleb Natapov wrote: > On Mon, Mar 11, 2013 at 02:31:46PM +0100, Paolo Bonzini wrote: >> Il 11/03/2013 12:51, Gleb Natapov ha scritto: > > Agreed, but we still have the problem of how to signal from userspace. > For that do you have any other suggestion than mp_state

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 03:01:40PM +0100, Jan Kiszka wrote: > > We are not moving away from mp_state, we are moving away from using > > mp_state for signaling because with nested virt INIT does not always > > change mp_state, not only that it can change mp_state long after signal > > is received af

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Jan Kiszka
On 2013-03-11 15:05, Gleb Natapov wrote: > On Mon, Mar 11, 2013 at 03:01:40PM +0100, Jan Kiszka wrote: >>> We are not moving away from mp_state, we are moving away from using >>> mp_state for signaling because with nested virt INIT does not always >>> change mp_state, not only that it can change mp

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 03:06:18PM +0100, Jan Kiszka wrote: > On 2013-03-11 15:05, Gleb Natapov wrote: > > On Mon, Mar 11, 2013 at 03:01:40PM +0100, Jan Kiszka wrote: > >>> We are not moving away from mp_state, we are moving away from using > >>> mp_state for signaling because with nested virt INIT

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Jan Kiszka
On 2013-03-11 15:09, Gleb Natapov wrote: > On Mon, Mar 11, 2013 at 03:06:18PM +0100, Jan Kiszka wrote: >> On 2013-03-11 15:05, Gleb Natapov wrote: >>> On Mon, Mar 11, 2013 at 03:01:40PM +0100, Jan Kiszka wrote: > We are not moving away from mp_state, we are moving away from using > mp_state

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 03:10:45PM +0100, Jan Kiszka wrote: > On 2013-03-11 15:09, Gleb Natapov wrote: > > On Mon, Mar 11, 2013 at 03:06:18PM +0100, Jan Kiszka wrote: > >> On 2013-03-11 15:05, Gleb Natapov wrote: > >>> On Mon, Mar 11, 2013 at 03:01:40PM +0100, Jan Kiszka wrote: > > We are not m

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Jan Kiszka
On 2013-03-11 15:12, Gleb Natapov wrote: > On Mon, Mar 11, 2013 at 03:10:45PM +0100, Jan Kiszka wrote: >> On 2013-03-11 15:09, Gleb Natapov wrote: >>> On Mon, Mar 11, 2013 at 03:06:18PM +0100, Jan Kiszka wrote: On 2013-03-11 15:05, Gleb Natapov wrote: > On Mon, Mar 11, 2013 at 03:01:40PM +

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 15:05, Gleb Natapov ha scritto: > On Mon, Mar 11, 2013 at 03:01:40PM +0100, Jan Kiszka wrote: >>> We are not moving away from mp_state, we are moving away from using >>> mp_state for signaling because with nested virt INIT does not always >>> change mp_state, not only that it can chan

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 14:54, Gleb Natapov ha scritto: >> Setting the mp_state to INIT_RECEIVED is that interface, and it already >> works, for APs at least. This patch extends it to work for the BSP as well. > > It does not for AP either. If AP has vmx on mp_sate should not be set to > INIT_RECEIVED. mp_s

[PATCH -next] vhost-blk: remove unused variable

2013-03-11 Thread Wei Yongjun
From: Wei Yongjun The variable vq is initialized but never used otherwise, so remove the unused variable. Signed-off-by: Wei Yongjun --- drivers/vhost/blk.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/vhost/blk.c b/drivers/vhost/blk.c index 658c5f9..d9b245b 100644 --- a/drive

Re: [PATCH -next] vhost-blk: remove unused variable

2013-03-11 Thread Michael S. Tsirkin
On Mon, Mar 11, 2013 at 10:39:27PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > The variable vq is initialized but never used > otherwise, so remove the unused variable. > > Signed-off-by: Wei Yongjun Which branch does this target? > --- > drivers/vhost/blk.c | 3 --- > 1 file changed,

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Jan Kiszka
On 2013-03-11 15:23, Paolo Bonzini wrote: > Il 11/03/2013 15:05, Gleb Natapov ha scritto: >> On Mon, Mar 11, 2013 at 03:01:40PM +0100, Jan Kiszka wrote: We are not moving away from mp_state, we are moving away from using mp_state for signaling because with nested virt INIT does not always

KVM call agenda for 2013-03-12

2013-03-11 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: KVM call agenda for 2013-03-12

2013-03-11 Thread Stefan Hajnoczi
On Mon, Mar 11, 2013 at 4:42 PM, Juan Quintela wrote: > > Please send in any agenda topics you are interested in. Overview of mentoring for Google Summer of Code 2013: * Post project ideas here: http://wiki.qemu.org/Google_Summer_of_Code_2013 * Who can be a mentor? * What's in it for the ment

Re: [kvmarm] [GIT PULL v2] KVM/ARM Fixes for 3.9-rc1

2013-03-11 Thread Christoffer Dall
On Mon, Mar 11, 2013 at 3:38 AM, Marc Zyngier wrote: > On 08/03/13 19:26, Christoffer Dall wrote: >> On Thu, Mar 7, 2013 at 7:12 PM, Marc Zyngier wrote: >>> On Thu, 7 Mar 2013 16:09:00 -0300, Marcelo Tosatti >>> wrote: On Thu, Mar 07, 2013 at 07:57:23AM +0100, Marc Zyngier wrote: > On W

Re: latest kvm-kmod + kvm git vs. 3.8.* distro kernel

2013-03-11 Thread Jan Kiszka
On 2013-03-07 23:00, Gabriel L. Somlo wrote: > Hi Jan, > > I'm trying to use your kvm-kmod git repo to build KVM git master > against the latest two Fedora 18 kernels (3.7.9-205 and 3.8.1-201), > and I'm running into a bit of trouble: There were several things missing, I've just pushed them into

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 03:28:03PM +0100, Paolo Bonzini wrote: > Il 11/03/2013 14:54, Gleb Natapov ha scritto: > >> Setting the mp_state to INIT_RECEIVED is that interface, and it already > >> works, for APs at least. This patch extends it to work for the BSP as > >> well. > > > > It does not for

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 04:36:33PM +0100, Jan Kiszka wrote: > On 2013-03-11 15:23, Paolo Bonzini wrote: > > Il 11/03/2013 15:05, Gleb Natapov ha scritto: > >> On Mon, Mar 11, 2013 at 03:01:40PM +0100, Jan Kiszka wrote: > We are not moving away from mp_state, we are moving away from using > >>>

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Jan Kiszka
On 2013-03-11 18:23, Gleb Natapov wrote: > On Mon, Mar 11, 2013 at 04:36:33PM +0100, Jan Kiszka wrote: >> On 2013-03-11 15:23, Paolo Bonzini wrote: >>> Il 11/03/2013 15:05, Gleb Natapov ha scritto: On Mon, Mar 11, 2013 at 03:01:40PM +0100, Jan Kiszka wrote: >> We are not moving away from m

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Jan Kiszka
On 2013-03-11 18:34, Jan Kiszka wrote: > On 2013-03-11 18:23, Gleb Natapov wrote: >> On Mon, Mar 11, 2013 at 04:36:33PM +0100, Jan Kiszka wrote: >>> On 2013-03-11 15:23, Paolo Bonzini wrote: Il 11/03/2013 15:05, Gleb Natapov ha scritto: > On Mon, Mar 11, 2013 at 03:01:40PM +0100, Jan Kiszk

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 18:20, Gleb Natapov ha scritto: > On Mon, Mar 11, 2013 at 03:28:03PM +0100, Paolo Bonzini wrote: >> Il 11/03/2013 14:54, Gleb Natapov ha scritto: Setting the mp_state to INIT_RECEIVED is that interface, and it already works, for APs at least. This patch extends it to work f

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 06:34:03PM +0100, Jan Kiszka wrote: > On 2013-03-11 18:23, Gleb Natapov wrote: > > On Mon, Mar 11, 2013 at 04:36:33PM +0100, Jan Kiszka wrote: > >> On 2013-03-11 15:23, Paolo Bonzini wrote: > >>> Il 11/03/2013 15:05, Gleb Natapov ha scritto: > On Mon, Mar 11, 2013 at 03

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 06:39:44PM +0100, Paolo Bonzini wrote: > Il 11/03/2013 18:20, Gleb Natapov ha scritto: > > On Mon, Mar 11, 2013 at 03:28:03PM +0100, Paolo Bonzini wrote: > >> Il 11/03/2013 14:54, Gleb Natapov ha scritto: > Setting the mp_state to INIT_RECEIVED is that interface, and it

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Jan Kiszka
On 2013-03-11 18:41, Gleb Natapov wrote: > On Mon, Mar 11, 2013 at 06:34:03PM +0100, Jan Kiszka wrote: >> On 2013-03-11 18:23, Gleb Natapov wrote: >>> On Mon, Mar 11, 2013 at 04:36:33PM +0100, Jan Kiszka wrote: On 2013-03-11 15:23, Paolo Bonzini wrote: > Il 11/03/2013 15:05, Gleb Natapov h

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 07:05:48PM +0100, Jan Kiszka wrote: > On 2013-03-11 18:41, Gleb Natapov wrote: > > On Mon, Mar 11, 2013 at 06:34:03PM +0100, Jan Kiszka wrote: > >> On 2013-03-11 18:23, Gleb Natapov wrote: > >>> On Mon, Mar 11, 2013 at 04:36:33PM +0100, Jan Kiszka wrote: > On 2013-03-11

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Jan Kiszka
On 2013-03-11 19:13, Gleb Natapov wrote: > On Mon, Mar 11, 2013 at 07:05:48PM +0100, Jan Kiszka wrote: >> On 2013-03-11 18:41, Gleb Natapov wrote: >>> On Mon, Mar 11, 2013 at 06:34:03PM +0100, Jan Kiszka wrote: On 2013-03-11 18:23, Gleb Natapov wrote: > On Mon, Mar 11, 2013 at 04:36:33PM +

Re: KVM call agenda for 2013-03-12

2013-03-11 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda topics you are interested in. Heads up!! I am just told that we are back at the Time Zone shuffling time. US and Canada has changed the to Time Saving this weekend, and then for almost everybody else the meeting is 1h sooner. For instance

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 07:27:44PM +0100, Jan Kiszka wrote: > On 2013-03-11 19:13, Gleb Natapov wrote: > > On Mon, Mar 11, 2013 at 07:05:48PM +0100, Jan Kiszka wrote: > >> On 2013-03-11 18:41, Gleb Natapov wrote: > >>> On Mon, Mar 11, 2013 at 06:34:03PM +0100, Jan Kiszka wrote: > On 2013-03-11

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Jan Kiszka
On 2013-03-11 19:39, Gleb Natapov wrote: > On Mon, Mar 11, 2013 at 07:27:44PM +0100, Jan Kiszka wrote: >> On 2013-03-11 19:13, Gleb Natapov wrote: >>> On Mon, Mar 11, 2013 at 07:05:48PM +0100, Jan Kiszka wrote: On 2013-03-11 18:41, Gleb Natapov wrote: > On Mon, Mar 11, 2013 at 06:34:03PM +

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 07:47:03PM +0100, Jan Kiszka wrote: > On 2013-03-11 19:39, Gleb Natapov wrote: > > On Mon, Mar 11, 2013 at 07:27:44PM +0100, Jan Kiszka wrote: > >> On 2013-03-11 19:13, Gleb Natapov wrote: > >>> On Mon, Mar 11, 2013 at 07:05:48PM +0100, Jan Kiszka wrote: > On 2013-03-11

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Jan Kiszka
On 2013-03-11 19:51, Gleb Natapov wrote: >>> On Intel: >>> CPU 1 CPU 2 in a guest mode >>> send INIT >>> send SIPI >>> INIT vmexit >>> vmxoff >>> reset and start from SIPI vector

Re: [PATCH] x86: kvm: reset the bootstrap processor when it gets an INIT

2013-03-11 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 08:01:30PM +0100, Jan Kiszka wrote: > On 2013-03-11 19:51, Gleb Natapov wrote: > >>> On Intel: > >>> CPU 1 CPU 2 in a guest mode > >>> send INIT > >>> send SIPI > >>> INIT vmexit > >>> v

Re: latest kvm-kmod + kvm git vs. 3.8.* distro kernel

2013-03-11 Thread Gabriel L. Somlo
Works great now, thanks ! --Gabriel On Mon, Mar 11, 2013 at 05:30:45PM +0100, Jan Kiszka wrote: > On 2013-03-07 23:00, Gabriel L. Somlo wrote: > > > > I'm trying to use your kvm-kmod git repo to build KVM git master > > against the latest two Fedora 18 kernels (3.7.9-205 and 3.8.1-201), > > and

Re: [PATCH 1/2] tcm_vhost: Wait for pending requests in vhost_scsi_flush()

2013-03-11 Thread Asias He
On Mon, Mar 11, 2013 at 12:36:37PM +0100, Paolo Bonzini wrote: > Il 11/03/2013 06:09, Asias He ha scritto: > > This patch makes vhost_scsi_flush() wait for all the pending requests > > issued before the flush operation to be finished. > > There is no protection against issuing concurrent flush ope

Re: [PATCH 1/2] tcm_vhost: Wait for pending requests in vhost_scsi_flush()

2013-03-11 Thread Asias He
On Mon, Mar 11, 2013 at 01:53:56PM +0200, Michael S. Tsirkin wrote: > On Mon, Mar 11, 2013 at 12:36:37PM +0100, Paolo Bonzini wrote: > > Il 11/03/2013 06:09, Asias He ha scritto: > > > This patch makes vhost_scsi_flush() wait for all the pending requests > > > issued before the flush operation to b

VMX: x86: handle host TSC calibration failure

2013-03-11 Thread Marcelo Tosatti
If the host TSC calibration fails, tsc_khz is zero (see tsc_init.c). Handle such case properly in KVM (instead of dividing by zero). https://bugzilla.redhat.com/show_bug.cgi?id=859282 Signed-off-by: Marcelo Tosatti diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 35b4912..19741b9 100

Re: [PATCH V2 0/6] tcm_vhost hotplug/hotunplug support and locking/flushing fix

2013-03-11 Thread Asias He
On Mon, Mar 11, 2013 at 02:03:27PM +0200, Michael S. Tsirkin wrote: > On Fri, Mar 08, 2013 at 10:21:41AM +0800, Asias He wrote: > > Changes in v2: > > - Remove code duplication in tcm_vhost_{hotplug,hotunplug} > > - Fix racing of vs_events_nr > > - Add flush fix patch to this series > > Asias He (6

[PATCH 1/4] tcm_vhost: Add missed lock in vhost_scsi_clear_endpoint()

2013-03-11 Thread Asias He
tv_tpg->tv_tpg_vhost_count should be protected by tv_tpg->tv_tpg_mutex. Signed-off-by: Asias He Reviewed-by: Stefan Hajnoczi --- drivers/vhost/tcm_vhost.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c index 9951297..b3e50d7 100644

[PATCH 2/4] tcm_vhost: Introduce tcm_vhost_check_endpoint()

2013-03-11 Thread Asias He
This helper is useful to check if vs->vs_endpoint is setup by vhost_scsi_set_endpoint() Signed-off-by: Asias He Reviewed-by: Stefan Hajnoczi --- drivers/vhost/tcm_vhost.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c inde

[PATCH 3/4] tcm_vhost: Fix vs->vs_endpoint checking in vhost_scsi_handle_vq()

2013-03-11 Thread Asias He
vs->vs_endpoint is protected by the vs->dev.mutex. Use tcm_vhost_check_endpoint() to do check. The helper does the needed locking for us. Signed-off-by: Asias He Reviewed-by: Stefan Hajnoczi --- drivers/vhost/tcm_vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH 4/4] tcm_vhost: Flush vhost_work in vhost_scsi_flush()

2013-03-11 Thread Asias He
We also need to flush the vhost_works. One is the completion vhost_work, the other is event vhost_work. Signed-off-by: Asias He Reviewed-by: Stefan Hajnoczi --- drivers/vhost/tcm_vhost.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c in

[PATCH 0/4] tcm_vhost lock and flush fix

2013-03-11 Thread Asias He
Asias He (4): tcm_vhost: Add missed lock in vhost_scsi_clear_endpoint() tcm_vhost: Introduce tcm_vhost_check_endpoint() tcm_vhost: Fix vs->vs_endpoint checking in vhost_scsi_handle_vq() tcm_vhost: Flush vhost_work in vhost_scsi_flush() drivers/vhost/tcm_vhost.c | 19 ++- 1

[PATCH V3 0/2] tcm_vhost hotplug/hotunplug support

2013-03-11 Thread Asias He
Changes in v3: - Separate the bug fix to another thread Changes in v2: - Remove code duplication in tcm_vhost_{hotplug,hotunplug} - Fix racing of vs_events_nr - Add flush fix patch to this series Asias He (2): tcm_vhost: Introduce tcm_vhost_check_feature() tcm_vhost: Add hotplug/hotunplug su

[PATCH V3 1/2] tcm_vhost: Introduce tcm_vhost_check_feature()

2013-03-11 Thread Asias He
This helper is useful to check if a feature is supported. Signed-off-by: Asias He Reviewed-by: Stefan Hajnoczi --- drivers/vhost/tcm_vhost.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c index c5157cd..ee6dc47 100644 ---

[PATCH V3 2/2] tcm_vhost: Add hotplug/hotunplug support

2013-03-11 Thread Asias He
In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for virtio-scsi), hotplug support is added to virtio-scsi. This patch adds hotplug and hotunplug support to tcm_vhost. You can create or delete a LUN in targetcli to hotplug or hotunplug a LUN in guest. Signed-off-by: Asias He Reviewed-

[PATCH V2 WIP 0/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-11 Thread Asias He
This is on top of Paolo and Nick's work. Current status: Works now (guest boots fine, no hang any more) with seabios's virtio-scsi disabled. Rebased to latest qemu.org/master Change details are in commit log. TODO: Make seabios happy. Paolo Bonzini (2): virtio-scsi: create VirtIOSCSICommon

[PATCH V2 WIP 1/2] virtio-scsi: create VirtIOSCSICommon

2013-03-11 Thread Asias He
From: Paolo Bonzini Signed-off-by: Paolo Bonzini --- hw/virtio-scsi.c | 199 +-- hw/virtio-scsi.h | 127 include/qemu/osdep.h | 4 ++ 3 files changed, 180 insertions(+), 150 deletions(-) diff --git a/hw/

[PATCH V2 WIP 2/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-11 Thread Asias He
From: Paolo Bonzini The WWPN specified in configfs is passed to "-device vhost-scsi-pci". The tgpt field of the SET_ENDPOINT ioctl is obsolete now, so it is not available from the QEMU command-line. Instead, I hardcode it to zero. Changes in V2: - Add backend guest masking support (nab) -