Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Blue Swirl
On Thu, Sep 6, 2012 at 3:42 AM, Alexander Graf wrote: > > On 05.09.2012, at 15:38, Blue Swirl wrote: > >> On Wed, Sep 5, 2012 at 7:22 PM, Anthony Liguori >> wrote: >>> Blue Swirl writes: >>> On Wed, Sep 5, 2012 at 3:41 PM, Anthony Liguori wrote: > Avi Kivity writes: > >

Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Blue Swirl
On Thu, Sep 6, 2012 at 4:06 PM, Andreas Färber wrote: > Am 06.09.2012 10:44, schrieb Jan Kiszka: >> On 2012-08-30 20:30, Jan Kiszka wrote: >>> This adds PCI device assignment for i386 targets using the classic KVM >>> interfaces. This version is 100% identical to what is being maintained >>> in qe

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Blue Swirl
On Thu, Sep 6, 2012 at 8:44 AM, Avi Kivity wrote: > On 09/05/2012 10:04 PM, Blue Swirl wrote: >> >> Reinventing a disassembler for ever growing x86 assembly is >> no fun. > > We can try linking to a disassembler library. I use udis86 to > disassemble instructions in kvm tracepoints > (http://udis

Re: [RFC][PATCH] Improving directed yield scalability for PLE handler

2012-09-08 Thread Srikar Dronamraju
> > signed-off-by: Andrew Theurer > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index fbf1fd0..c767915 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -4844,6 +4844,9 @@ bool __sched yield_to(struct task_struct *p, bool > preempt) > > again: > p_rq = ta

Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Alexander Graf
On 08.09.2012, at 10:06, Blue Swirl wrote: > On Thu, Sep 6, 2012 at 8:44 AM, Avi Kivity wrote: >> On 09/05/2012 10:04 PM, Blue Swirl wrote: >>> >>> Reinventing a disassembler for ever growing x86 assembly is >>> no fun. >> >> We can try linking to a disassembler library. I use udis86 to >>

Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Blue Swirl
On Sat, Sep 8, 2012 at 9:28 AM, Alexander Graf wrote: > > > On 08.09.2012, at 10:06, Blue Swirl wrote: > >> On Thu, Sep 6, 2012 at 8:44 AM, Avi Kivity wrote: >>> On 09/05/2012 10:04 PM, Blue Swirl wrote: Reinventing a disassembler for ever growing x86 assembly is no fun. >>> >>> W

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-08 Thread Paolo Bonzini
Il 08/09/2012 07:06, Rusty Russell ha scritto: >> > Do we really know there are no hypervisors implementing it? > As much as can be known. Qemu doesn't, lkvm doesn't. > However, there are cases in which it would be nice to have it. Repurposing the bit to how it has been used so far (as a guest->

Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Alexander Graf
On 08.09.2012, at 12:16, Blue Swirl wrote: > On Sat, Sep 8, 2012 at 9:28 AM, Alexander Graf wrote: >> >> >> On 08.09.2012, at 10:06, Blue Swirl wrote: >> >>> On Thu, Sep 6, 2012 at 8:44 AM, Avi Kivity wrote: On 09/05/2012 10:04 PM, Blue Swirl wrote: > > Reinventing a disasse

Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Blue Swirl
On Sat, Sep 8, 2012 at 12:13 PM, Alexander Graf wrote: > > > On 08.09.2012, at 12:16, Blue Swirl wrote: > >> On Sat, Sep 8, 2012 at 9:28 AM, Alexander Graf wrote: >>> >>> >>> On 08.09.2012, at 10:06, Blue Swirl wrote: >>> On Thu, Sep 6, 2012 at 8:44 AM, Avi Kivity wrote: > On 09/05/20

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-08 Thread Fengguang Wu
On Fri, Sep 07, 2012 at 06:32:48PM -0700, Yinghai Lu wrote: > > with this one in pci/next pci config in /sys are not created. > > > > 10:~ # lspci -tv > > pcilib: Cannot open /sys/bus/pci/devices/:00:03.0/config > > lspci: Unable to read the standard configuration space header of > > device 00

Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-08 Thread Alexander Graf
On 08.09.2012, at 14:30, Blue Swirl wrote: > On Sat, Sep 8, 2012 at 12:13 PM, Alexander Graf wrote: >> >> >> On 08.09.2012, at 12:16, Blue Swirl wrote: >> >>> On Sat, Sep 8, 2012 at 9:28 AM, Alexander Graf wrote: On 08.09.2012, at 10:06, Blue Swirl wrote: > On

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-08 Thread Yinghai Lu
On Sat, Sep 8, 2012 at 6:42 AM, Fengguang Wu wrote: > On Fri, Sep 07, 2012 at 06:32:48PM -0700, Yinghai Lu wrote: > >> > with this one in pci/next pci config in /sys are not created. >> > >> > 10:~ # lspci -tv >> > pcilib: Cannot open /sys/bus/pci/devices/:00:03.0/config >> > lspci: Unable to

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-08 Thread Feng Tang
On Sat, 8 Sep 2012 21:42:20 +0800 Fengguang Wu wrote: > On Fri, Sep 07, 2012 at 06:32:48PM -0700, Yinghai Lu wrote: > > > > with this one in pci/next pci config in /sys are not created. > > > > > > 10:~ # lspci -tv > > > pcilib: Cannot open /sys/bus/pci/devices/:00:03.0/config > > > lspci: U

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-08 Thread Yinghai Lu
On Sat, Sep 8, 2012 at 8:34 AM, Feng Tang wrote: >> This makes lspci work again on my side. The caveat is, kzalloc() will >> zero out all data while the new local variable leaves some data >> uninitialized. > > Yes, thanks for the quick root cause and fix to the bug in my code. Can you resubmit y

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-08 Thread Bjorn Helgaas
On Sat, Sep 08, 2012 at 11:40:52AM -0700, Yinghai Lu wrote: > On Sat, Sep 8, 2012 at 8:34 AM, Feng Tang wrote: > >> This makes lspci work again on my side. The caveat is, kzalloc() will > >> zero out all data while the new local variable leaves some data > >> uninitialized. > > > > Yes, thanks for

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-08 Thread Michael S. Tsirkin
On Fri, Sep 07, 2012 at 04:44:40PM +0200, Paolo Bonzini wrote: > Il 07/09/2012 16:25, Michael S. Tsirkin ha scritto: > >> > Silent deflate is deflating just by using the page, without using the > >> > deflateq at all. So it can be done even from GFP_ATOMIC context. > > BTW I don't see a need to av

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-08 Thread Michael S. Tsirkin
On Sat, Sep 08, 2012 at 02:36:00PM +0930, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > On Fri, Sep 07, 2012 at 04:09:50PM +0930, Rusty Russell wrote: > >> > So it looks like a bug: we should teach driver to tell host first on > >> > leak? > >> > Yan, Vadim, can you comment please? > >>

Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-08 Thread Michael S. Tsirkin
On Fri, Sep 07, 2012 at 06:00:50PM +0200, Paolo Bonzini wrote: > Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: > > Cc: Stefan Hajnoczi > > Cc: Zhi Yong Wu > > Cc: Michael S. Tsirkin > > Cc: Paolo Bonzini > > Signed-off-by: Nicholas Bellinger > > --- > > hw/virtio-pci.c |2 ++ > >