Re: Large sized guest taking for ever to boot...

2012-06-13 Thread Gleb Natapov
On Tue, Jun 12, 2012 at 11:44:07AM -0700, Chegu Vinod wrote: > On 6/12/2012 8:39 AM, Gleb Natapov wrote: > >On Tue, Jun 12, 2012 at 08:33:59AM -0700, Chegu Vinod wrote: > >>I rebuilt the 3.4.1 kernel in the guest from scratch and retried my > >>experiments and measured > >>the boot times... > >> >

Re: Bug? 100% load on core after physically removing USB storage from host

2012-06-13 Thread Emmanuel Noobadmin
On 6/12/12, Stefan Hajnoczi wrote: Further tests done on the following set only >> qemu-kvm-0.12.1.2-2.209.el6_2.4.x86_64 >> on SLES 6, 2.6.32-220.7.1.el.x86_64 (Intel 82801JI ICH10) >> 1. VMM add physical host usb device -> select storage to guest >> 2. VMM remove hardware >> 3. Physically rem

Re: [PATCH 3/3] deal with guest panicked event

2012-06-13 Thread Wen Congyang
At 06/12/2012 09:29 PM, Paolo Bonzini Wrote: > Il 21/05/2012 08:50, Wen Congyang ha scritto: >> +DEF("onpanic", HAS_ARG, QEMU_OPTION_onpanic, \ >> +"-onpanic report|pause|quit\n" \ >> +"action when the guest is panicked [default=report]", >> +QEMU_ARCH_ALL) >> +STEXI >>

[PATCH RFC 0/2] Improve virtio-blk performance

2012-06-13 Thread Asias He
This patchset implements bio-based IO path for virito-blk to improve performance. Fio test shows it gives, 28%, 24%, 21%, 16% IOPS boost and 32%, 17%, 21%, 16% latency improvement for sequential read/write, random read/write respectively. Asias He (2): block: Add blk_bio_map_sg() helper virti

[PATCH RFC 1/2] block: Add blk_bio_map_sg() helper

2012-06-13 Thread Asias He
Add a helper to map a bio to a scatterlist, modelled after blk_rq_map_sg. This helper is useful for any driver that wants to create a scatterlist from its ->make_request_fn method. Cc: Jens Axboe Cc: Tejun Heo Cc: Shaohua Li Cc: linux-ker...@vger.kernel.org Signed-off-by: Christoph Hellwig Si

[PATCH RFC 2/2] virtio-blk: Add bio-based IO path for virtio-blk

2012-06-13 Thread Asias He
This patch introduces bio-based IO path for virtio-blk. Compared to request-based IO path, bio-based IO path uses driver provided ->make_request_fn() method to bypasses the IO scheduler. It handles the bio to device directly without allocating a request in block layer. This reduces the IO path in

Re: [PATCH 3/3] deal with guest panicked event

2012-06-13 Thread Paolo Bonzini
Il 13/06/2012 09:02, Wen Congyang ha scritto: >>> >> +Other possible actions are: >>> >> +@code{pause} (emit QEVENT_GUEST_PANICKED and pause VM), >>> >> +@code{quit} (emit QEVENT_GUEST_PANICKED and quit VM). >> > >> > Rather than just "quit", there should be choices for "shutdown", >> > "poweroff"

Re: [PATCH 3/3] deal with guest panicked event

2012-06-13 Thread Wen Congyang
At 06/13/2012 03:53 PM, Paolo Bonzini Wrote: > Il 13/06/2012 09:02, Wen Congyang ha scritto: >> +Other possible actions are: >> +@code{pause} (emit QEVENT_GUEST_PANICKED and pause VM), >> +@code{quit} (emit QEVENT_GUEST_PANICKED and quit VM). Rather than just "quit", there sho

Re: Large sized guest taking for ever to boot...

2012-06-13 Thread Avi Kivity
On 06/13/2012 10:12 AM, Gleb Natapov wrote: >> >> I tried that and didn't make any difference...i.e. the RHEL6.3 RC1 >> guest booted in about ~1 min. >> > Thank you. So this means that ticket spinlock is not to blame for the > slow down compared ti RHEL kernel. > > Where 3.4.1 spends most of the

Re: Bug? 100% load on core after physically removing USB storage from host

2012-06-13 Thread Stefan Hajnoczi
On Wed, Jun 13, 2012 at 8:23 AM, Emmanuel Noobadmin wrote: > On 6/12/12, Stefan Hajnoczi wrote: > > Further tests done on the following set only >>> qemu-kvm-0.12.1.2-2.209.el6_2.4.x86_64 >>> on SLES 6, 2.6.32-220.7.1.el.x86_64  (Intel 82801JI ICH10) > >>> 1. VMM add physical host usb device -> s

Re: [PATCHv6 6/8] kvm: only sync when attention bits set

2012-06-13 Thread Michael S. Tsirkin
On Tue, Jun 12, 2012 at 07:27:48PM -0300, Marcelo Tosatti wrote: > On Sun, Jun 03, 2012 at 10:28:29AM +0300, Michael S. Tsirkin wrote: > > Commit eb0dc6d0368072236dcd086d7fdc17fd3c4574d4 introduced apic > > attention bitmask but kvm still syncs lapic unconditionally. > > As that commit suggested an

Re: [PATCHv6 6/8] kvm: only sync when attention bits set

2012-06-13 Thread Michael S. Tsirkin
On Wed, Jun 13, 2012 at 11:19:24AM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 12, 2012 at 07:27:48PM -0300, Marcelo Tosatti wrote: > > On Sun, Jun 03, 2012 at 10:28:29AM +0300, Michael S. Tsirkin wrote: > > > Commit eb0dc6d0368072236dcd086d7fdc17fd3c4574d4 introduced apic > > > attention bitmas

Re: [PATCHv3 RFC 0/2] kvm: direct msix injection

2012-06-13 Thread Michael S. Tsirkin
On Tue, Jun 12, 2012 at 08:07:03PM -0300, Marcelo Tosatti wrote: > On Mon, Jun 11, 2012 at 02:19:17PM +0300, Michael S. Tsirkin wrote: > > We can deliver certain interrupts, notably MSIX, > > from atomic context. > > Here's an untested patch to do this (compiled only). > > > > Changes from v2: > >

Re: [PATCHv6 2/8] kvm: optimize ISR lookups

2012-06-13 Thread Michael S. Tsirkin
On Tue, Jun 12, 2012 at 06:08:33PM -0300, Marcelo Tosatti wrote: > On Sun, Jun 03, 2012 at 10:27:59AM +0300, Michael S. Tsirkin wrote: > > We perform ISR lookups twice: during interrupt > > injection and on EOI. Typical workloads only have > > a single bit set there. So we can avoid ISR scans by >

Re: [PATCHv6 2/8] kvm: optimize ISR lookups

2012-06-13 Thread Michael S. Tsirkin
On Wed, Jun 13, 2012 at 12:02:42PM +0300, Michael S. Tsirkin wrote: > > Instead of isr_cache what about a highest_isr field? > > > > > When setting ISR: > > > > if (apic->highest_isr < me) > > apic->highest_isr = me; > > > > To be invalidated on TPR updates properly. > > > > Its more meani

Re: [PATCH 2/5] drivers/net/ethernet/dec/tulip: Use standard __set_bit_le() function

2012-06-13 Thread Akinobu Mita
2012/6/13 Takuya Yoshikawa : > From: Takuya Yoshikawa > > To introduce generic set_bit_le() later, we remove our own definition > and use a proper non-atomic bitops function: __set_bit_le(). > > Signed-off-by: Takuya Yoshikawa > Acked-by: Grant Grundler > --- >  drivers/net/ethernet/dec/tulip/de

RE: Biweekly KVM Test report, kernel 51bfd299... qemu a1fce560...

2012-06-13 Thread Ren, Yongjie
> -Original Message- > From: Marcelo Tosatti [mailto:mtosa...@redhat.com] > Sent: Wednesday, June 13, 2012 7:25 AM > To: Kevin Wolf > Cc: Stefan Hajnoczi; Ren, Yongjie; Avi Kivity; kvm@vger.kernel.org; Liu, > RongrongX; Anthony Liguori > Subject: Re: Biweekly KVM Test report, kernel 51bfd29

Re: Biweekly KVM Test report, kernel 51bfd299... qemu a1fce560...

2012-06-13 Thread Kevin Wolf
Am 13.06.2012 12:28, schrieb Ren, Yongjie: >> -Original Message- >> From: Marcelo Tosatti [mailto:mtosa...@redhat.com] >> Sent: Wednesday, June 13, 2012 7:25 AM >> To: Kevin Wolf >> Cc: Stefan Hajnoczi; Ren, Yongjie; Avi Kivity; kvm@vger.kernel.org; Liu, >> RongrongX; Anthony Liguori >> Sub

SYSRET 64-Bit Breakout

2012-06-13 Thread Clark, Robert Graham
All, I've been looking at http://www.kb.cert.org/vuls/id/649219 Xen appears to be vulnerable as do a number of other products. KVM isn't listed. Some discussion on IRC indicates that KVM isn't likely to be vulnerable. Can anyone confirm please? -Rob -- To unsubscribe from this list: send the l

Re: [PATCH 2/5] drivers/net/ethernet/dec/tulip: Use standard __set_bit_le() function

2012-06-13 Thread Takuya Yoshikawa
On Wed, 13 Jun 2012 18:43:40 +0900 Akinobu Mita wrote: > Should this hash_table be converted from u16 hash_table[32] to > DECLARE_BITMAP(hash_table, 16 * 32) to ensure that it is aligned > on long-word boundary? I think hash_table is already long-word aligned because it is placed right after a p

Re: SYSRET 64-Bit Breakout

2012-06-13 Thread Avi Kivity
On 06/13/2012 03:26 PM, Clark, Robert Graham wrote: > All, > > I've been looking at http://www.kb.cert.org/vuls/id/649219 > > Xen appears to be vulnerable as do a number of other products. KVM isn't > listed. Some discussion on IRC indicates that KVM isn't likely to be > vulnerable. > > Can an

Re: asm/kvm_para.h from asm-generic (was: Re: linux-next: triage for April 19, 2012)

2012-06-13 Thread Geert Uytterhoeven
On Tue, Jun 12, 2012 at 11:07 PM, Geert Uytterhoeven wrote: > On Wed, May 30, 2012 at 10:52 AM, Geert Uytterhoeven > wrote: >> On Mon, May 28, 2012 at 5:04 PM, Geert Uytterhoeven >> wrote: >>> On Mon, May 28, 2012 at 4:37 PM, Avi Kivity wrote: On 05/25/2012 11:59 PM, Geert Uytterhoeven wro

Re: asm/kvm_para.h from asm-generic (was: Re: linux-next: triage for April 19, 2012)

2012-06-13 Thread Geert Uytterhoeven
On Wed, Jun 13, 2012 at 2:46 PM, Geert Uytterhoeven wrote: > "make headers_check" is also broken on m32r since Avi's fix, as m32r > doesn't even > have : BTW, you don't need to install any cross-compilers for headers_check, just do make ARCH=xxx headers_check if you want to give it a try... Gr

Re: FreeBSD guest ICMP packet loss (Solved)

2012-06-13 Thread Andy Smith
Hi, we seem to have solved this, or at least realised that the issue is specific to an OS build and doesn't affect other FreeBSD servers. Basically we had 4 servers all cloned from the same virtual server, all of these are affected by the packet loss issue I described. Additionally our netw

Re: [PATCHv3 RFC 1/2] kvm: implement kvm_set_msi_inatomic

2012-06-13 Thread Gleb Natapov
On Mon, Jun 11, 2012 at 02:19:22PM +0300, Michael S. Tsirkin wrote: > We do not want a potential broadcast to all VCPUs to run in > a host IRQ handler. Implement an API that sends an MSI > interrupt but only if it's safe from interrupt context, > that is if it is a unicast. > We will still iterate

Re: [PATCH 2/5] drivers/net/ethernet/dec/tulip: Use standard __set_bit_le() function

2012-06-13 Thread Akinobu Mita
2012/6/13 Takuya Yoshikawa : > On Wed, 13 Jun 2012 18:43:40 +0900 > Akinobu Mita wrote: > >> Should this hash_table be converted from u16 hash_table[32] to >> DECLARE_BITMAP(hash_table, 16 * 32) to ensure that it is aligned >> on long-word boundary? > > I think hash_table is already long-word alig

Re: [PATCH 2/5] drivers/net/ethernet/dec/tulip: Use standard __set_bit_le() function

2012-06-13 Thread Takuya Yoshikawa
On Wed, 13 Jun 2012 22:31:13 +0900 Akinobu Mita wrote: > >> Should this hash_table be converted from u16 hash_table[32] to > >> DECLARE_BITMAP(hash_table, 16 * 32) to ensure that it is aligned > >> on long-word boundary? > > > > I think hash_table is already long-word aligned because it is placed

Re: [PATCHv3 RFC 0/2] kvm: direct msix injection

2012-06-13 Thread Avi Kivity
On 06/13/2012 02:07 AM, Marcelo Tosatti wrote: > On Mon, Jun 11, 2012 at 02:19:17PM +0300, Michael S. Tsirkin wrote: >> We can deliver certain interrupts, notably MSIX, >> from atomic context. >> Here's an untested patch to do this (compiled only). >> >> Changes from v2: >> Don't inject broadcast

[Bug 13855] sles10sp2 i386 guest hangs on reboot

2012-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=13855 Alan changed: What|Removed |Added Status|NEW |RESOLVED CC|

[Bug 13855] sles10sp2 i386 guest hangs on reboot

2012-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=13855 Alan changed: What|Removed |Added Status|RESOLVED|CLOSED -- Configure bugmail: https://bugzilla

[PATCH 0/5] Big real mode - addendum

2012-06-13 Thread Avi Kivity
Some testing unconvered a few more missing instructions; here they are. Avi Kivity (5): KVM: x86 emulator: emulate BSWAP KVM: x86 emulator: emulate LLDT KVM: x86 emulator: make read_segment_descriptor() return the address KVM: x86 emulator: make loading TR set the busy bit KVM: x86 emula

[PATCH 2/5] KVM: x86 emulator: emulate LLDT

2012-06-13 Thread Avi Kivity
Opcode 0F 00 /2. Used by isolinux durign the protected mode transition. Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 4eea1e4..85f7a5f 100644 --- a/arch/

[PATCH 1/5] KVM: x86 emulator: emulate BSWAP

2012-06-13 Thread Avi Kivity
Opcodes 0F C8 - 0F CF. Used by the SeaBIOS cdrom code (though not in big real mode). Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index c804db2..4e

[PATCH 4/5] KVM: x86 emulator: make loading TR set the busy bit

2012-06-13 Thread Avi Kivity
Guest software doesn't actually depend on it, but vmx will refuse us entry if we don't. Set the bit in both the cached segment and memory, just to be nice. Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/x86

[PATCH 3/5] KVM: x86 emulator: make read_segment_descriptor() return the address

2012-06-13 Thread Avi Kivity
Some operations want to modify the descriptor later on, so save the address for future use. Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 85f7a5f..d304

[PATCH 5/5] KVM: x86 emulator: implement LTR

2012-06-13 Thread Avi Kivity
Opcode 0F 00 /3. Encountered during Windows XP secondary processor bringup. Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index dff416f..218e731 100644 --- a/

[PATCH 0/4] virtio-scsi performance improvements

2012-06-13 Thread Paolo Bonzini
This series reorganizes the locking in virtio-scsi, introducing separate scatterlists for each target and "pipelining" the locks so that one command can be queued while the other is prepared. This improves performance when there are multiple in-flight operations. For example, a simple "if=/dev/sd

[PATCH 1/4] virtio-scsi: unlock during kick

2012-06-13 Thread Paolo Bonzini
Separate virtqueue_kick_prepare from virtqueue_notify, so that the expensive vmexit is done without holding the lock. Signed-off-by: Paolo Bonzini --- drivers/scsi/virtio_scsi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/

[PATCH 3/4] virtio-scsi: release sg_lock after add_buf

2012-06-13 Thread Paolo Bonzini
We do not need the sglist after calling virtqueue_add_buf. Hence we can "pipeline" the locked operations and start preparing the sglist for the next request while we kick the virtqueue. Together with the previous two patches, this improves performance as follows. For a simple "if=/dev/sda of=/de

[PATCH 4/4] virtio-scsi: split scatterlist per target

2012-06-13 Thread Paolo Bonzini
To improve performance for I/O to different targets, add a separate scatterlist for each of them. Signed-off-by: Paolo Bonzini --- drivers/scsi/virtio_scsi.c | 141 +--- 1 files changed, 94 insertions(+), 47 deletions(-) diff --git a/drivers/scsi/virtio_

[PATCH 2/4] virtio-scsi: split locking per vq

2012-06-13 Thread Paolo Bonzini
Keep a separate lock for each virtqueue. While not particularly important now, it prepares the code for when we will add support for multiple request queues. It is also more tidy as soon as we introduce a separate lock for the sglist. Signed-off-by: Paolo Bonzini --- drivers/scsi/virtio_scsi.c

Re: SYSRET 64-Bit Breakout

2012-06-13 Thread Paolo Bonzini
Il 13/06/2012 14:26, Clark, Robert Graham ha scritto: > All, > > I've been looking at http://www.kb.cert.org/vuls/id/649219 > > Xen appears to be vulnerable as do a number of other products. KVM > isn't listed. Some discussion on IRC indicates that KVM isn't likely to > be vulnerable. > > Can an

[Bug 36222] kvm: 100% CPU usage after 3.0.0-rc1 guest shutdown

2012-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=36222 Alan changed: What|Removed |Added Status|NEW |RESOLVED CC|

[Bug 36222] kvm: 100% CPU usage after 3.0.0-rc1 guest shutdown

2012-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=36222 Alan changed: What|Removed |Added Status|RESOLVED|CLOSED -- Configure bugmail: https://bugzilla

Re: [PATCH 2/5] drivers/net/ethernet/dec/tulip: Use standard __set_bit_le() function

2012-06-13 Thread Ben Hutchings
On Wed, 2012-06-13 at 23:00 +0900, Takuya Yoshikawa wrote: > On Wed, 13 Jun 2012 22:31:13 +0900 > Akinobu Mita wrote: > > > >> Should this hash_table be converted from u16 hash_table[32] to > > >> DECLARE_BITMAP(hash_table, 16 * 32) to ensure that it is aligned > > >> on long-word boundary? > > >

Re: [PATCH 2/5] drivers/net/ethernet/dec/tulip: Use standard __set_bit_le() function

2012-06-13 Thread Grant Grundler
On Wed, Jun 13, 2012 at 7:00 AM, Takuya Yoshikawa wrote: > On Wed, 13 Jun 2012 22:31:13 +0900 > Akinobu Mita wrote: > >> >> Should this hash_table be converted from u16 hash_table[32] to >> >> DECLARE_BITMAP(hash_table, 16 * 32) to ensure that it is aligned >> >> on long-word boundary? >> > >> >

Re: [PATCHv3 RFC 1/2] kvm: implement kvm_set_msi_inatomic

2012-06-13 Thread Michael S. Tsirkin
On Wed, Jun 13, 2012 at 04:01:24PM +0300, Gleb Natapov wrote: > On Mon, Jun 11, 2012 at 02:19:22PM +0300, Michael S. Tsirkin wrote: > > We do not want a potential broadcast to all VCPUs to run in > > a host IRQ handler. Implement an API that sends an MSI > > interrupt but only if it's safe from int

Re: [PATCHv3 RFC 1/2] kvm: implement kvm_set_msi_inatomic

2012-06-13 Thread Gleb Natapov
On Wed, Jun 13, 2012 at 06:59:50PM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 13, 2012 at 04:01:24PM +0300, Gleb Natapov wrote: > > On Mon, Jun 11, 2012 at 02:19:22PM +0300, Michael S. Tsirkin wrote: > > > We do not want a potential broadcast to all VCPUs to run in > > > a host IRQ handler. Imp

Re: [PATCHv3 RFC 1/2] kvm: implement kvm_set_msi_inatomic

2012-06-13 Thread Michael S. Tsirkin
On Wed, Jun 13, 2012 at 07:01:01PM +0300, Gleb Natapov wrote: > On Wed, Jun 13, 2012 at 06:59:50PM +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 13, 2012 at 04:01:24PM +0300, Gleb Natapov wrote: > > > On Mon, Jun 11, 2012 at 02:19:22PM +0300, Michael S. Tsirkin wrote: > > > > We do not want a po

[Bug 14224] kvm_amd: BUG: scheduling while atomic

2012-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=14224 Alan changed: What|Removed |Added Status|NEW |RESOLVED CC|

[Bug 14224] kvm_amd: BUG: scheduling while atomic

2012-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=14224 Alan changed: What|Removed |Added Status|RESOLVED|CLOSED -- Configure bugmail: https://bugzilla

[Bug 14250] System hangs after loading module kvm-intel

2012-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=14250 Alan changed: What|Removed |Added CC||a...@lxorguk.ukuu.org.uk Component|kvm

Accessing input information

2012-06-13 Thread Muhammed Aydin
Dear KVM list, I was wondering where I might be able to access the inputs to KVM within the code. For example, we can change the amount of memory with the -m flag, and we can specify a different image when we call KVM, sudo /usr/local/kvm/bin/qemu-system-x86_64 ubuntu.img -m 1024 (just 2 inputs,

[Bug 14435] KVM + bridge + VLAN

2012-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=14435 Alan changed: What|Removed |Added Status|NEW |RESOLVED CC|

[Bug 14435] KVM + bridge + VLAN

2012-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=14435 Alan changed: What|Removed |Added Status|RESOLVED|CLOSED -- Configure bugmail: https://bugzilla

[Bug 14401] KVM module error

2012-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=14401 Alan changed: What|Removed |Added Status|NEW |RESOLVED CC|

[Bug 14401] KVM module error

2012-06-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=14401 Alan changed: What|Removed |Added Status|RESOLVED|CLOSED -- Configure bugmail: https://bugzilla

Re: [PATCHv6 2/8] kvm: optimize ISR lookups

2012-06-13 Thread Marcelo Tosatti
On Wed, Jun 13, 2012 at 12:02:43PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 12, 2012 at 06:08:33PM -0300, Marcelo Tosatti wrote: > > On Sun, Jun 03, 2012 at 10:27:59AM +0300, Michael S. Tsirkin wrote: > > > We perform ISR lookups twice: during interrupt > > > injection and on EOI. Typical wor

Re: [PATCHv6 6/8] kvm: only sync when attention bits set

2012-06-13 Thread Marcelo Tosatti
On Wed, Jun 13, 2012 at 11:35:07AM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 13, 2012 at 11:19:24AM +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 12, 2012 at 07:27:48PM -0300, Marcelo Tosatti wrote: > > > On Sun, Jun 03, 2012 at 10:28:29AM +0300, Michael S. Tsirkin wrote: > > > > Commit eb0

Re: [PATCHv6 6/8] kvm: only sync when attention bits set

2012-06-13 Thread Michael S. Tsirkin
On Wed, Jun 13, 2012 at 05:53:36PM -0300, Marcelo Tosatti wrote: > On Wed, Jun 13, 2012 at 11:35:07AM +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 13, 2012 at 11:19:24AM +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 12, 2012 at 07:27:48PM -0300, Marcelo Tosatti wrote: > > > > On Sun, Jun 0

Re: [PATCH 2/5] drivers/net/ethernet/dec/tulip: Use standard __set_bit_le() function

2012-06-13 Thread Takuya Yoshikawa
On Wed, 13 Jun 2012 08:21:18 -0700 Grant Grundler wrote: > >> >> Should this hash_table be converted from u16 hash_table[32] to > >> >> DECLARE_BITMAP(hash_table, 16 * 32) to ensure that it is aligned > >> >> on long-word boundary? > >> > > >> > I think hash_table is already long-word aligned bec

Re: [PATCH v6 5/9] KVM: MMU: introduce SPTE_MMU_WRITEABLE bit

2012-06-13 Thread Marcelo Tosatti
On Tue, May 29, 2012 at 02:49:14PM +0800, Xiao Guangrong wrote: > This bit indicates whether the spte can be writable on MMU, that means > the corresponding gpte is writable and the corresponding gfn is not > protected by shadow page protection > > Signed-off-by: Xiao Guangrong > --- > arch/x86/

Re: 1.1 release?

2012-06-13 Thread Marcelo Tosatti
On Thu, Jun 07, 2012 at 11:10:01AM +0400, Michael Tokarev wrote: > Are there any issues with 1.1 release of qemu-kvm? > > The RCs were followed qemu RCs quite closely, but > the final 1.1 is still not released, anything wrong > with it? > > Thanks! > > /mjt WinXP.32 install is still failing due

Re: [PATCHv6 8/8] kvm: host side for eoi optimization

2012-06-13 Thread Marcelo Tosatti
On Sun, Jun 03, 2012 at 10:28:43AM +0300, Michael S. Tsirkin wrote: > Implementation of PV EOI using shared memory. > This reduces the number of exits an interrupt > causes as much as by half. > > The idea is simple: there's a bit, per APIC, in guest memory, > that tells the guest that it does not

Re: [PATCH v6 6/9] KVM: MMU: fast path of handling guest page fault

2012-06-13 Thread Marcelo Tosatti
On Tue, May 29, 2012 at 02:50:32PM +0800, Xiao Guangrong wrote: > If the the present bit of page fault error code is set, it indicates > the shadow page is populated on all levels, it means what we do is > only modify the access bit which can be done out of mmu-lock > > Currently, in order to simp

Re: [PATCH] KVM: change PT_FIRST_AVAIL_BITS_SHIFT to avoid conflict with EPT Dirty bit

2012-06-13 Thread Marcelo Tosatti
On Thu, Jun 07, 2012 at 06:26:07PM +0800, Xudong Hao wrote: > EPT Dirty bit use bit 9 as Intel SDM definition, to avoid conflict, change > PT_FIRST_AVAIL_BITS_SHIFT to 10. > > Signed-off-by: Xudong Hao > Signed-off-by: Xiantao Zhang Applied, thanks. -- To unsubscribe from this list: send the l

Re: [PATCHv6 6/8] kvm: only sync when attention bits set

2012-06-13 Thread Marcelo Tosatti
On Thu, Jun 14, 2012 at 12:04:23AM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 13, 2012 at 05:53:36PM -0300, Marcelo Tosatti wrote: > > On Wed, Jun 13, 2012 at 11:35:07AM +0300, Michael S. Tsirkin wrote: > > > On Wed, Jun 13, 2012 at 11:19:24AM +0300, Michael S. Tsirkin wrote: > > > > On Tue, Ju

Re: [PATCH 0/3] kvm/s390 patches for 3.6

2012-06-13 Thread Marcelo Tosatti
On Mon, Jun 11, 2012 at 04:06:56PM +0200, Cornelia Huck wrote: > Avi, Marcelo, > > here are some s390 patches for the next release. A bugfix, a tracing > related update (real tracing support for s390 will follow once we > have sorted out the architectural vs. internal tracepoint split), > and a pa

[GIT PULL] KVM update for 3.5-rc2

2012-06-13 Thread Marcelo Tosatti
Linus, Please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git master To receive a spurious warning fix on CPU offline path. Marcelo Tosatti (1): x86: kvmclock: remove check_and_clear_guest_paused warning arch/x86/kernel/kvmclock.c |5 - 1 file changed, 5 deletions(-)

Re: [PATCH v6 5/9] KVM: MMU: introduce SPTE_MMU_WRITEABLE bit

2012-06-13 Thread Takuya Yoshikawa
On Wed, 13 Jun 2012 18:39:05 -0300 Marcelo Tosatti wrote: > > /* Return true if the spte is dropped. */ > > -static bool spte_write_protect(struct kvm *kvm, u64 *sptep, bool *flush) > > +static bool > > +spte_write_protect(struct kvm *kvm, u64 *sptep, bool *flush, bool > > pt_protect) > > { >

Re: [PATCH v6 6/9] KVM: MMU: fast path of handling guest page fault

2012-06-13 Thread Takuya Yoshikawa
On Wed, 13 Jun 2012 19:40:02 -0300 Marcelo Tosatti wrote: > mmu_spte_update is handling several different cases. Please rewrite > it, add a comment on top of it (or spread comments on top of each > significant code line) with all cases it is handling (also recheck it > regarding new EPT accessed/

RE: [PATCH v3] KVM: x86: Implement PCID/INVPCID for guests with EPT

2012-06-13 Thread Mao, Junjie
Terribly sorry for the late reply. I'm out of work for some unexpected issues the last few weeks. > >> > So i think that checking whether EPT _and_ VPID are supported > >> > should be a precondition to enable PCID support for guests. > >> > > >> > >> Should this check be carried out on L0 too? If

[PATCH v4] KVM: x86: Implement PCID/INVPCID for guests with EPT

2012-06-13 Thread Mao, Junjie
This patch handles PCID/INVPCID for guests. Process-context identifiers (PCIDs) are a facility by which a logical processor may cache information for multiple linear-address spaces so that the processor may retain cached information when software switches to a different linear address space. Refer

Re: [PATCH RFC 1/2] block: Add blk_bio_map_sg() helper

2012-06-13 Thread Tejun Heo
On Wed, Jun 13, 2012 at 03:41:46PM +0800, Asias He wrote: > Add a helper to map a bio to a scatterlist, modelled after > blk_rq_map_sg. > > This helper is useful for any driver that wants to create > a scatterlist from its ->make_request_fn method. This may not be possible but I really wanna avoi

Re: [PATCH v6 5/9] KVM: MMU: introduce SPTE_MMU_WRITEABLE bit

2012-06-13 Thread Xiao Guangrong
On 06/14/2012 05:39 AM, Marcelo Tosatti wrote: >> +if (pt_protect) >> +spte &= ~SPTE_MMU_WRITEABLE; >> spte = spte & ~PT_WRITABLE_MASK; >> -mmu_spte_update(sptep, spte); >> + >> +*flush = mmu_spte_update(sptep, spte); > > This clears previous flush value when looping

Re: [PATCH v6 5/9] KVM: MMU: introduce SPTE_MMU_WRITEABLE bit

2012-06-13 Thread Xiao Guangrong
On 06/14/2012 09:13 AM, Takuya Yoshikawa wrote: > On Wed, 13 Jun 2012 18:39:05 -0300 > Marcelo Tosatti wrote: > >>> /* Return true if the spte is dropped. */ >>> -static bool spte_write_protect(struct kvm *kvm, u64 *sptep, bool *flush) >>> +static bool >>> +spte_write_protect(struct kvm *kvm, u

Re: [PATCH RFC 1/2] block: Add blk_bio_map_sg() helper

2012-06-13 Thread Asias He
On 06/14/2012 10:31 AM, Tejun Heo wrote: On Wed, Jun 13, 2012 at 03:41:46PM +0800, Asias He wrote: Add a helper to map a bio to a scatterlist, modelled after blk_rq_map_sg. This helper is useful for any driver that wants to create a scatterlist from its ->make_request_fn method. This may not

Re: [PATCH v6 6/9] KVM: MMU: fast path of handling guest page fault

2012-06-13 Thread Xiao Guangrong
On 06/14/2012 06:40 AM, Marcelo Tosatti wrote: > On Tue, May 29, 2012 at 02:50:32PM +0800, Xiao Guangrong wrote: >> If the the present bit of page fault error code is set, it indicates >> the shadow page is populated on all levels, it means what we do is >> only modify the access bit which can be

[PATCH next] kvm: Use pr_

2012-06-13 Thread Joe Perches
Use a more current logging style. Convert printks to pr_. Add pr_fmt. All logging messages are now prefixed with "kvm: ", "kvm_intel: " or "kvm_amd: " Coalesce formats, align arguments. Add a few missing newlines. Signed-off-by: Joe Perches --- arch/x86/kvm/cpuid.c |4 +- arch/x86/k

Re: asm/kvm_para.h from asm-generic (was: Re: linux-next: triage for April 19, 2012)

2012-06-13 Thread Paul Mundt
On Wed, Jun 13, 2012 at 02:46:32PM +0200, Geert Uytterhoeven wrote: > There's a similar rule for kvm_para.h: > > ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h \ > $(srctree)/include/asm-$(SRCARCH)/kvm_para.h),) > header-y += kvm_para.h > endif > > It's thi