Re: [PATCH v3 3/4] KVM: SVM: Fix CPL updates

Am 05.02.2012 12:16, schrieb Gleb Natapov: > On Fri, Feb 03, 2012 at 07:29:24PM +0100, Kevin Wolf wrote: >> Keep CPL at 0 in real mode and at 3 in VM86. In protected/long mode, use >> RPL rather than DPL of the code segment. >> >> Signed-off-by: Kevin Wolf >> --- >> arch/x86/kvm/svm.c | 19

Re: [Qemu-devel] [RFC] Next gen kvm api

On 02/05/2012 06:36 PM, Anthony Liguori wrote: > On 02/05/2012 03:51 AM, Gleb Natapov wrote: >> On Sun, Feb 05, 2012 at 11:44:43AM +0200, Avi Kivity wrote: >>> On 02/05/2012 11:37 AM, Gleb Natapov wrote: On Thu, Feb 02, 2012 at 06:09:54PM +0200, Avi Kivity wrote: > Device model > -

Re: [PATCH for 3.3] KVM: Fix write protection race during dirty logging

On 02/06/2012 07:12 AM, Takuya Yoshikawa wrote: > (2012/02/06 14:02), Xiao Guangrong wrote: > >> I am worrying if other paths(such as like >> kvm_mmu_notifier_invalidate_page) >> which unmap/modify writeable ptes and flush TLBs out of mmu lock have >> the >> same problem? >> > > Yes, I think so ...

Re: windows PIO question

On 02/05/2012 11:01 PM, Nikola Ciprich wrote: > > Not all PIO operations are DMA. Provide a trace and we can look. > > Hi, > here's snippet: > > qemu-kvm-16441 [000] 12887154.698329: kvm_pio: pio_read > at 0xc002 size 1 count 1 > qemu-kvm-16441 [000] 12887154.698331:

Pe: [PATCH v5 1/3] virtio-scsi: first version

Hello Paolo, first let me say that your patch is working fine on my local clone of the qemu repository. Let me ask just one question about the format of the data being transmitted over the virtqueue. Paolo Bonzini wrote: +cmd->req.cmd = (struct virtio_scsi_cmd_req){ +

Re: [PATCH v3 3/4] KVM: SVM: Fix CPL updates

On Mon, Feb 06, 2012 at 10:18:35AM +0100, Kevin Wolf wrote: > Am 05.02.2012 12:16, schrieb Gleb Natapov: > > On Fri, Feb 03, 2012 at 07:29:24PM +0100, Kevin Wolf wrote: > >> Keep CPL at 0 in real mode and at 3 in VM86. In protected/long mode, use > >> RPL rather than DPL of the code segment. > >> >

[PATCH 0/6] Fixes for kvm on s390

Avi, Marcelo, here are some fixes for kvm on s390. Patch 1 (Sanitize fpc registers for KVM_SET_FPU) fixes a kernel bug that can be triggered by a user, this should go into 3.3. Patch 2 (do store status after handling STOP_ON_STOP bit) reorders some stop actions but also fixes a scheduling while at

[PATCH 3/6] kvm-s390: make sigp restart return busy when stop pending

From: Jens Freimann On reboot the guest sends in smp_send_stop() a sigp stop to all CPUs except for current CPU. Then the guest switches to the IPL cpu by sending a restart to the IPL CPU, followed by a sigp stop to the current cpu. Since restart is handled by userspace it's possible that the re

[PATCH 5/6] kvm-s390: add stop_on_stop flag when doing stop and store

From: Jens Freimann When we do a stop and store status we need to pass ACTION_STOP_ON_STOP flag to __sigp_stop(). Signed-off-by: Jens Freimann Signed-off-by: Christian Borntraeger --- arch/s390/kvm/sigp.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/s390/kvm

[PATCH 1/6] kvm-s390: Sanitize fpc registers for KVM_SET_FPU

From: Christian Borntraeger commit 7eef87dc99e419b1cc051e4417c37e4744d7b661 (KVM: s390: fix register setting) added a load of the floating point control register to the KVM_SET_FPU path. Lets make sure that the fpc is valid. Signed-off-by: Christian Borntraeger --- arch/s390/kvm/kvm-s390.c |

[PATCH 6/6] kvm-s390: provide control registers via kvm_run

There are several cases were we need the control registers for userspace. Lets also provide those in kvm_run. Signed-off-by: Christian Borntraeger --- arch/s390/include/asm/kvm.h |2 ++ arch/s390/kvm/kvm-s390.c|9 - 2 files changed, 10 insertions(+), 1 deletions(-) diff --gi

[PATCH 2/6] kvm-s390: do store status after handling STOP_ON_STOP bit

From: Jens Freimann In handle_stop() handle the stop bit before doing the store status as described for "Stop and Store Status" in the Principles of Operation. We have to give up the local_int.lock before calling kvm store status since it calls gmap_fault() which might sleep. Since local_int.lock

[PATCH 4/6] kvm-s390: ignore sigp stop overinitiative

From: Jens Freimann In __inject_sigp_stop() do nothing when the CPU is already in stopped state. Signed-off-by: Jens Freimann Signed-off-by: Christian Borntraeger --- arch/s390/kvm/sigp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/s390/kvm/sigp.c b/arch/s3

Re: [PATCH 0/4] KVM: Introduce kvm_memory_slot::arch

(2012/01/30 12:48), Takuya Yoshikawa wrote: This is the first step to separate the architecture specific members. The rmap and dirty_bitmap can be treated later based on this. Any further comments? If patch 4 (v3) looks controversial, please consider taking patch 1 to 3. I may use gfn_to_in

Re: [PATCH 0/4] KVM: Introduce kvm_memory_slot::arch

On 02/06/2012 12:10 PM, Takuya Yoshikawa wrote: > (2012/01/30 12:48), Takuya Yoshikawa wrote: >> This is the first step to separate the architecture specific members. >> The rmap and dirty_bitmap can be treated later based on this. > > > Any further comments? > > > If patch 4 (v3) looks controversi

Re: [PATCH 1/2] kvm tool: Report error and don't segfault if kvm__init() fails

Hi Michael, On Mon, 6 Feb 2012, Michael Ellerman wrote: Signed-off-by: Michael Ellerman --- tools/kvm/builtin-run.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c index 95d35a5..569246e 100644 --- a/tools/kvm/builtin

Re: [PATCH] kvm-tool: Don't try to cleanup ioeventfd if we never initialised it

On Mon, 6 Feb 2012, Michael Ellerman wrote: Since 44287dd (Repair running on non ioeventfd-capable platforms) it's possible that ioeventfd__init() fails, but the VM still runs. This means we end up calling ioeventfd__exit(), which writes() and then reads() epoll_stop_fd. Because we failed the in

Re: [PATCH 1/2] kvm tool: Report error and don't segfault if kvm__init() fails

On Mon, Feb 06, 2012 at 12:22:04PM +0200, Pekka Enberg wrote: > Hi Michael, > > On Mon, 6 Feb 2012, Michael Ellerman wrote: > >Signed-off-by: Michael Ellerman > >--- > >tools/kvm/builtin-run.c |5 + > >1 files changed, 5 insertions(+), 0 deletions(-) > > > >diff --git a/tools/kvm/builtin-r

Re: [PATCH v3 4/4] KVM: x86 emulator: Allow PM/VM86 switch during task switch

On 02/03/2012 08:29 PM, Kevin Wolf wrote: > Task switches can switch between Protected Mode and VM86. The current > mode must be updated during the task switch emulation so that the new > segment selectors are interpreted correctly. > > In order to let privilege checks succeed, rflags needs to be u

Re: [PATCH v3 3/4] KVM: SVM: Fix CPL updates

Am 06.02.2012 10:57, schrieb Gleb Natapov: > On Mon, Feb 06, 2012 at 10:18:35AM +0100, Kevin Wolf wrote: >> Am 05.02.2012 12:16, schrieb Gleb Natapov: >>> On Fri, Feb 03, 2012 at 07:29:24PM +0100, Kevin Wolf wrote: Keep CPL at 0 in real mode and at 3 in VM86. In protected/long mode, use R

Re: [PATCH v3 4/4] KVM: x86 emulator: Allow PM/VM86 switch during task switch

Am 06.02.2012 11:32, schrieb Avi Kivity: > On 02/03/2012 08:29 PM, Kevin Wolf wrote: >> Task switches can switch between Protected Mode and VM86. The current >> mode must be updated during the task switch emulation so that the new >> segment selectors are interpreted correctly. >> >> In order to le

[PATCH] qemu-kvm: Fix GSI handling with in-kernel irqchip

Interrupt routing with in-kernel irqchip was always a mess. Now this increased after latest upstream merge: we started to call ioapic_set_irq also for kernel-handled interrupts. Reduce this mess again by using the upstream kvm_piix3_gsi_handler. It is aware of the PIIX3-specific routing in KVM mod

[PATCH] qemu-kvm: Couple in-kernel PIT enabling to in-kernel irqchip

Upstream will not support disabling the in-kernel PIT separately. In preparation of merging qemu-kvm, couple our KVM PIT to in-kernel irqchip support as well. Leave the related command line option in place, just issuing a warning that it has no function anymore. Signed-off-by: Jan Kiszka --- hw/

Re: [PATCH 1/2] kvm tool: Report error and don't segfault if kvm__init() fails

On Mon, 2012-02-06 at 12:22 +0200, Pekka Enberg wrote: > On Mon, 6 Feb 2012, Michael Ellerman wrote: > > diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c > > index 95d35a5..569246e 100644 > > --- a/tools/kvm/builtin-run.c > > +++ b/tools/kvm/builtin-run.c > > @@ -997,6 +997,11 @@ stat

[PATCH] qemu-kvm: Prevent user space APIC code execution with in-kernel irqchip

As qemu-kvm merged the kernel APIC into the user space model, we need to replicate the kernel APIC's logic here until the mess is cleaned up. So far we triggered the timer start and apic_update_irq calls unwillingly. Signed-off-by: Jan Kiszka --- hw/apic.c |6 ++ 1 files changed, 6 inser

Re: [PATCH 3/6] kvm-s390: make sigp restart return busy when stop pending

Am 06.02.2012 10:59, schrieb Christian Borntraeger: +static int __sigp_restart(struct kvm_vcpu *vcpu, u16 cpu_addr) +{ + int rc = 0; + struct kvm_s390_float_interrupt *fi =&vcpu->kvm->arch.float_int; + + spin_lock(&fi->lock); + if (fi->local_int[cpu_addr]->action_bits& AC

Re: [PATCH] emulator: add movdqa tests

2012/2/1 Avi Kivity : > On 02/01/2012 11:08 AM, Takuya Yoshikawa wrote: >> What is the status of Stefan's work? > > Stefan's on vacation. Back now. I will try to get back to movdqa soon. Stefan -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord..

Re: [PATCH 3/6] kvm-s390: make sigp restart return busy when stop pending

On 06/02/12 12:53, Carsten Otte wrote: > Am 06.02.2012 10:59, schrieb Christian Borntraeger: >> +static int __sigp_restart(struct kvm_vcpu *vcpu, u16 cpu_addr) >> +{ >> +int rc = 0; >> +struct kvm_s390_float_interrupt *fi =&vcpu->kvm->arch.float_int; >> + >> +spin_lock(&fi->lock); >> +

Re: [Qemu-devel] [RFC] Next gen kvm api

On 02/06/2012 03:34 AM, Avi Kivity wrote: On 02/05/2012 06:36 PM, Anthony Liguori wrote: On 02/05/2012 03:51 AM, Gleb Natapov wrote: On Sun, Feb 05, 2012 at 11:44:43AM +0200, Avi Kivity wrote: On 02/05/2012 11:37 AM, Gleb Natapov wrote: On Thu, Feb 02, 2012 at 06:09:54PM +0200, Avi Kivity wro

Re: [Qemu-devel] [RFC] Next gen kvm api

On 02/06/2012 03:33 PM, Anthony Liguori wrote: >> Look at arch/x86/kvm/i8254.c:pit_ioport_read() for a counterexample. >> There are also interactions with other devices (for example the >> apic/ioapic interaction via the apic bus). > > > Hrm, maybe I'm missing it, but the path that would be hot is:

Re: [Qemu-devel] [RFC] Next gen kvm api

On 02/06/2012 07:54 AM, Avi Kivity wrote: On 02/06/2012 03:33 PM, Anthony Liguori wrote: Look at arch/x86/kvm/i8254.c:pit_ioport_read() for a counterexample. There are also interactions with other devices (for example the apic/ioapic interaction via the apic bus). Hrm, maybe I'm missing it, b

Re: [Qemu-devel] [RFC] Next gen kvm api

On 02/06/2012 04:00 PM, Anthony Liguori wrote: >> Do guests always read an unlatched counter? Doesn't seem reasonable >> since they can't get a stable count this way. > > > Perhaps. You could have the latching done by writing to persisted > scratch memory but then locking becomes an issue. Oh, y

[PATCH] qemu-kvm: Drop broken --no-cpu-emulation

Doesn't build for quite a while now, let's remove the rotting bits. Signed-off-by: Jan Kiszka --- Makefile.target |6 +--- configure | 10 - exec.c |2 - target-i386/fake-exec.c | 52 --- 4 fil

Re: [PATCH 0/9] pci-assign: 64bit MMIO + better MSI-X table support

HI Alex, I can give it a try. Please send me all patches as one file if possible. I was about to report yet another problem with Guest MSI-X smp affinity not being honoured by KVM while injecting interrupts. Its again in the context of 82599 device (tried with Linux as guest). I had a hunch th

virtio_ioport_write unexpected address

Hi, We're setting up some KVM systems with their disk image stored in a sparse raw file on an NFS4 server. The NFS4 filesystem is mounted with the hard option, which means that I/O to it is blocked indefinitely when the server goes down, and will be properly handled when the server returns.

Re: [Qemu-devel] [RFC] Next gen kvm api

On Sun, Feb 5, 2012 at 5:14 AM, Avi Kivity wrote: > On 02/03/2012 12:13 AM, Rob Earhart wrote: >> On Thu, Feb 2, 2012 at 8:09 AM, Avi Kivity > > wrote: >> >>     The kvm api has been accumulating cruft for several years now. >>      This is >>     due to feature creep, fixi

Re: [PATCH uq/master] kvm: Allow to set shadow MMU size

On Wed, Jan 25, 2012 at 06:14:15PM +0100, Jan Kiszka wrote: > Introduce the KVM-specific machine option kvm_shadow_mem. It allows to > set a custom shadow MMU size for the virtual machine. This is useful for > stress testing e.g. > > Only x86 supports this for now, but it is in principle a generic

Re: [PATCH] KVM: Fix compilation on non-x86

On Wed, Jan 25, 2012 at 06:33:03PM +0100, Alexander Graf wrote: > Commit 84b058d broke compilation for KVM on non-x86 targets, which > don't have KVM_CAP_IRQ_ROUTING defined. > > Fix by not using the unavailable constant when it's not around. > > Signed-off-by: Alexander Graf Applied, thanks.

Re: [PATCH] reset edge sense circuit of i8259 on init

On Tue, Jan 24, 2012 at 03:06:05PM +0200, Gleb Natapov wrote: > The spec says that during initialization "The edge sense circuit is > reset which means that following initialization an interrupt request > (IR) input must make a low-to-high transition to generate an interrupt", > but currently if ed

Re: [PATCH 0/9] pci-assign: 64bit MMIO + better MSI-X table support

On Mon, 2012-02-06 at 21:25 +0530, Shashidhar Patil wrote: > HI Alex, > I can give it a try. Please send me all patches as one file if possible. > I was about to report yet another problem with Guest MSI-X smp affinity > not being honoured by KVM while injecting interrupts. Its again in the co

Re: [PATCH v2] KVM: Factor out kvm_vcpu_kick to arch-generic code

On Tue, Jan 24, 2012 at 11:27:39PM -0500, Christoffer Dall wrote: > The kvm_vcpu_kick function performs roughly the same funcitonality on > most all architectures, so we shouldn't have separate copies. > > PowerPC keeps a pointer to interchanging waitqueues on the vcpu_arch > structure and to acco

Re: [Qemu-devel] [RFC] Next gen kvm api

On 02/06/2012 11:41 AM, Rob Earhart wrote: On Sun, Feb 5, 2012 at 5:14 AM, Avi Kivity wrote: On 02/03/2012 12:13 AM, Rob Earhart wrote: On Thu, Feb 2, 2012 at 8:09 AM, Avi Kivitymailto:a...@redhat.com>> wrote: The kvm api has been accumulating cruft for several years now. This is

KVM call agenda for Tuesday 7

Hi Please send in any agenda items you are interested in covering. Cheers, Juan. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Qemu-devel] [RFC] Next gen kvm api

On 02/03/2012 04:52 PM, Anthony Liguori wrote: > On 02/03/2012 12:07 PM, Eric Northup wrote: >> On Thu, Feb 2, 2012 at 8:09 AM, Avi Kivity wrote: >> [...] >>> >>> Moving to syscalls avoids these problems, but introduces new ones: >>> >>> - adding new syscalls is generally frowned upon, and kvm wil

Re: [PATCH v2] KVM: Factor out kvm_vcpu_kick to arch-generic code

On 2012-02-06 19:25, Marcelo Tosatti wrote: >> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >> index c38efd7..a1761ff 100644 >> --- a/arch/x86/kvm/x86.c >> +++ b/arch/x86/kvm/x86.c >> @@ -2252,7 +2252,6 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu) >> kvm_make_requ

Re: [PATCH v2] KVM: Factor out kvm_vcpu_kick to arch-generic code

On Mon, Feb 06, 2012 at 09:06:04PM +0100, Jan Kiszka wrote: > On 2012-02-06 19:25, Marcelo Tosatti wrote: > >> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > >> index c38efd7..a1761ff 100644 > >> --- a/arch/x86/kvm/x86.c > >> +++ b/arch/x86/kvm/x86.c > >> @@ -2252,7 +2252,6 @@ void kvm_arch

Re: [PATCH v2] KVM: Fix assigned device MSI-X entry setting leak

On Tue, 2012-01-31 at 21:11 +0200, Michael S. Tsirkin wrote: > On Mon, Jan 30, 2012 at 02:05:54PM -0700, Alex Williamson wrote: > > We need to prioritize our matching when setting MSI-X vector > > entries. Unused entries should only be used if we don't find > > an exact match or else we risk dupli

Re: Partial review of kvm arm git patches.

On Thu, 2 Feb 2012 09:48:22 -0500, Christoffer Dall wrote: > On Thu, Feb 2, 2012 at 12:04 AM, Rusty Russell wrote: > > Hi all, > > > >        Started reading through the git tree at > > git://github.com/virtualopensystems/linux-kvm-arm.git (kvm-a15-v6-stage > > branch), and noticed some things.

Re: [Qemu-devel] [RFC] Next gen kvm api

On 03.02.2012, at 03:09, Anthony Liguori wrote: > On 02/02/2012 10:09 AM, Avi Kivity wrote: >> The kvm api has been accumulating cruft for several years now. This is >> due to feature creep, fixing mistakes, experience gained by the >> maintainers and developers on how to do things, ports to new

[PATCH v8] kvm: make vcpu life cycle separated from kvm instance

From: Liu Ping Fan Currently, vcpu will be destructed only after kvm instance is destroyed. This result to vcpu keep idle in kernel, but can not be freed when it is unplugged in guest. Change this to vcpu's destruction before kvm instance, so vcpu CAN be destroyed before kvm instance. By this wa

Re: [PATCH v8] kvm: make vcpu life cycle separated from kvm instance

(2012/02/07 11:34), Liu Ping Fan wrote: > static int kvm_vcpu_release(struct inode *inode, struct file *filp) Is this a hot path? If no, do you really need to pre-allocate the space for the next vcpus? > { > + int i; > struct kvm_vcpu *vcpu = filp->private_data; > + struct kvm

Re: [PATCH v8] kvm: make vcpu life cycle separated from kvm instance

2012/2/7 Takuya Yoshikawa : > (2012/02/07 11:34), Liu Ping Fan wrote: > >>   static int kvm_vcpu_release(struct inode *inode, struct file *filp) > > Is this a hot path? > If no, do you really need to pre-allocate the space for the next vcpus? > No, it is not a hot path, I will try your way in next

Re: [PATCH v2] KVM: Fix assigned device MSI-X entry setting leak

On Mon, Feb 06, 2012 at 02:46:29PM -0700, Alex Williamson wrote: > On Tue, 2012-01-31 at 21:11 +0200, Michael S. Tsirkin wrote: > > On Mon, Jan 30, 2012 at 02:05:54PM -0700, Alex Williamson wrote: > > > We need to prioritize our matching when setting MSI-X vector > > > entries. Unused entries shou

[PATCH] KVM: x86: Avoid NULL dereference in kvm_apic_accept_pic_intr()

A test case which does the following: ioctl(vmfd, KVM_CREATE_VCPU, 0); ioctl(vmfd, KVM_CREATE_IRQCHIP); ioctl(cpufd, KVM_RUN); Can oops in kvm_apic_accept_pic_intr() because vcpu->arch.apic == NULL. Because irqchip_in_kernel() is false when we create the vcpu we leave vcpu->arch.apic uninitia

Re: [Qemu-devel] [RFC] Next gen kvm api

On Mon, 2012-02-06 at 13:46 -0600, Scott Wood wrote: > On 02/03/2012 04:52 PM, Anthony Liguori wrote: > > On 02/03/2012 12:07 PM, Eric Northup wrote: > >> On Thu, Feb 2, 2012 at 8:09 AM, Avi Kivity wrote: > >> [...] > >>> > >>> Moving to syscalls avoids these problems, but introduces new ones: > >