[PATCH] KVM: fix a syntax error in pmu.c

2011-12-29 Thread Ren, Yongjie
Fix a syntax error in arch/x86/kvm/pmu.c Signed-off-by: Yongjie Ren --- diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c index 061a03f..8f142bf 100644 --- a/arch/x86/kvm/pmu.c +++ b/arch/x86/kvm/pmu.c @@ -170,9 +170,9 @@ static void reprogram_counter(struct kvm_pmc *pmc, u32 type,

Re: [PATCH] KVM: fix a syntax error in pmu.c

2011-12-29 Thread Gleb Natapov
On Thu, Dec 29, 2011 at 09:40:37AM +, Ren, Yongjie wrote: > Fix a syntax error in arch/x86/kvm/pmu.c > That is fixed already in kvm.git next branch. > Signed-off-by: Yongjie Ren > --- > diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c > index 061a03f..8f142bf 100644 > --- a/arch/x86/kvm/

RE: [PATCH] KVM: fix a syntax error in pmu.c

2011-12-29 Thread Ren, Yongjie
> -Original Message- > From: Gleb Natapov [mailto:g...@redhat.com] > Sent: Thursday, December 29, 2011 5:46 PM > To: Ren, Yongjie > Cc: a...@redhat.com; kvm@vger.kernel.org > Subject: Re: [PATCH] KVM: fix a syntax error in pmu.c > > On Thu, Dec 29, 2011 at 09:40:37AM +, Ren, Yongjie wr

Re: [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2011-12-29 Thread Isaku Yamahata
On Thu, Dec 29, 2011 at 04:55:11PM +0200, Avi Kivity wrote: > On 12/29/2011 04:49 PM, Isaku Yamahata wrote: > > > > Great, then we agreed with list/reattach basically. > > > > (Maybe identity scheme needs reconsideration.) > > > > > > I guess we miscommunicated. Why is reattach needed? If you ha

Re: [PATCH 2/2] umem: chardevice for kvm postcopy

2011-12-29 Thread Isaku Yamahata
Thank you for review. On Thu, Dec 29, 2011 at 01:17:51PM +0200, Avi Kivity wrote: > > + default n > > + help > > + User process backed memory driver provides /dev/umem device. > > + The /dev/umem device is designed for some sort of distributed > > + shared memory. Especially post-c

Re: [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2011-12-29 Thread Avi Kivity
On 12/29/2011 03:26 AM, Isaku Yamahata wrote: > This is Linux kernel driver for qemu/kvm postcopy live migration. > This is used by qemu/kvm postcopy live migration patch. > > TODO: > - Consider FUSE/CUSE option > So far several mmap patches for FUSE/CUSE are floating around. (their > purpose i

Re: [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2011-12-29 Thread Avi Kivity
On 12/29/2011 04:18 PM, Isaku Yamahata wrote: > > > > > > The issue is how to solve the page fault, not whether TASK_INTERRUPTIBLE > > > or > > > TASK_UNINTERRUPTIBLE. > > > I can think of several options. > > > - When daemon X is dead, all page faults are served by zero pages. > > > - When daemon

RE: [PATCH] Expose tsc deadline timer cpuid to guest

2011-12-29 Thread Liu, Jinsong
Jan Kiszka wrote: > On 2011-12-28 18:35, Liu, Jinsong wrote: diff --git a/qemu-kvm.h b/qemu-kvm.h index 2bd5602..8c6c2ea 100644 --- a/qemu-kvm.h +++ b/qemu-kvm.h @@ -260,6 +260,7 @@ extern int kvm_irqchip; extern int kvm_pit; extern int kvm_pit_reinject; e

Re: [PATCH 2/2] umem: chardevice for kvm postcopy

2011-12-29 Thread Avi Kivity
On 12/29/2011 02:22 PM, Isaku Yamahata wrote: > > > > A simpler approach is the open("/dev/umem") returns an mmap()able fd. > > You need to call an ioctl() to set the size, etc. but only you only > > operate on that fd. > > So you are suggesting that /dev/umem and /dev/umemctl should be introduce

Re: [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2011-12-29 Thread Avi Kivity
On 12/29/2011 04:49 PM, Isaku Yamahata wrote: > > > Great, then we agreed with list/reattach basically. > > > (Maybe identity scheme needs reconsideration.) > > > > I guess we miscommunicated. Why is reattach needed? If you have the > > fd, nothing else is needed. > > What if malicious process c

Re: [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2011-12-29 Thread Avi Kivity
On 12/29/2011 06:00 PM, Avi Kivity wrote: > The NFS client has exactly the same issue, if you mount it with the intr > option. In fact you could use the NFS client as a trivial umem/cuse > prototype. Actually, NFS can return SIGBUS, it doesn't care about restarting daemons. -- error compiling c

Re: [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2011-12-29 Thread Isaku Yamahata
On Thu, Dec 29, 2011 at 02:55:42PM +0200, Avi Kivity wrote: > On 12/29/2011 02:39 PM, Isaku Yamahata wrote: > > > > ioctl commands: > > > > > > > > UMEM_DEV_CRATE_UMEM: create umem device for qemu > > > > UMEM_DEV_LIST: list created umem devices > > > > UMEM_DEV_REATTACH: re-attach the created umem

Re: [PATCH 21/21] postcopy: implement postcopy livemigration

2011-12-29 Thread Avi Kivity
On 12/29/2011 03:26 AM, Isaku Yamahata wrote: > This patch implements postcopy livemigration. > > > +/* RAM is allocated via umem for postcopy incoming mode */ > +#define RAM_POSTCOPY_UMEM_MASK (1 << 1) > + > typedef struct RAMBlock { > uint8_t *host; > ram_addr_t offset; > @@ -485,6

Re: [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2011-12-29 Thread Isaku Yamahata
On Thu, Dec 29, 2011 at 01:24:32PM +0200, Avi Kivity wrote: > On 12/29/2011 03:26 AM, Isaku Yamahata wrote: > > This is Linux kernel driver for qemu/kvm postcopy live migration. > > This is used by qemu/kvm postcopy live migration patch. > > > > TODO: > > - Consider FUSE/CUSE option > > So far se

Re: [PATCH v6] kvm: make vcpu life cycle separated from kvm instance

2011-12-29 Thread Avi Kivity
On 12/29/2011 04:03 PM, Liu ping fan wrote: > > Why do we want an independent grace period, is hotunplugging a vcpu that > > much different from hotunplugging memory? > > > I thought that if less readers on the same srcu lock, then > synchronize_srcu_expedited() may success to return more quickly.

Re: [RFC PATCH 0/4] Network performance regression

2011-12-29 Thread Amos Kong
- Original Message - > This patchset adds a new network perf testcase for Windows, > refactors old netperf test, and support numa resource control. > Process the raw results to a standard format at the end of test, > then we can compute average and compare with old results. > > Welcome to

Re: [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2011-12-29 Thread Isaku Yamahata
On Thu, Dec 29, 2011 at 04:35:36PM +0200, Avi Kivity wrote: > On 12/29/2011 04:18 PM, Isaku Yamahata wrote: > > > > > > > > The issue is how to solve the page fault, not whether > > > > TASK_INTERRUPTIBLE or > > > > TASK_UNINTERRUPTIBLE. > > > > I can think of several options. > > > > - When daemo

Better qemu/kvm defaults (was Re: [RFC PATCH 0/4] Gang scheduling in CFS)

2011-12-29 Thread Dor Laor
On 12/26/2011 11:05 AM, Avi Kivity wrote: On 12/26/2011 05:14 AM, Nikunj A Dadhania wrote: btw you can get an additional speedup by enabling x2apic, for default_send_IPI_mask_logical(). In the host? In the host, for the guest: qemu -cpu ...,+x2apic It seems to me that we should impro

Re: [Android-virt] [PATCH v5 05/13] ARM: KVM: Inject IRQs and FIQs from userspace

2011-12-29 Thread Christoffer Dall
On Dec 12, 2011, at 12:40 PM, Avi Kivity wrote: > On 12/12/2011 06:31 PM, Peter Maydell wrote: >> On 11 December 2011 23:01, Jan Kiszka wrote: >>> Enabling in-kernel irqchips usually means "switching worlds". So the >>> semantics of these particular IRQ inject interface details may change >>> wi

Re: [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2011-12-29 Thread Isaku Yamahata
On Thu, Dec 29, 2011 at 03:52:58PM +0200, Avi Kivity wrote: > On 12/29/2011 03:49 PM, Isaku Yamahata wrote: > > > > > > qemu can have an extra thread that wait4()s the daemon, and relaunch > > > it. This extra thread would not be blocked by the page fault. It can > > > keep the fd so it isn't lo

Re: [PATCH 2/2] umem: chardevice for kvm postcopy

2011-12-29 Thread Avi Kivity
On 12/29/2011 03:26 AM, Isaku Yamahata wrote: > This is a character device to hook page access. > The page fault in the area is reported to another user process by > this chardriver. Then, the process fills the page contents and > resolves the page fault. > > > +config UMEM > +tristate "/

Re: [PATCH v6] kvm: make vcpu life cycle separated from kvm instance

2011-12-29 Thread Liu ping fan
On Wed, Dec 28, 2011 at 5:53 PM, Avi Kivity wrote: > On 12/28/2011 08:54 AM, Liu ping fan wrote: >> >> >> >>   struct kvm_vcpu { >> >>       struct kvm *kvm; >> >> +     struct list_head list; >> >>   #ifdef CONFIG_PREEMPT_NOTIFIERS >> >>       struct preempt_notifier preempt_notifier; >> >>   #en

Re: [Qemu-devel] Better qemu/kvm defaults (was Re: [RFC PATCH 0/4] Gang scheduling in CFS)

2011-12-29 Thread Anthony Liguori
On 12/29/2011 10:07 AM, Dor Laor wrote: On 12/26/2011 11:05 AM, Avi Kivity wrote: On 12/26/2011 05:14 AM, Nikunj A Dadhania wrote: btw you can get an additional speedup by enabling x2apic, for default_send_IPI_mask_logical(). In the host? In the host, for the guest: qemu -cpu ...,+x2apic

Re: [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2011-12-29 Thread Avi Kivity
On 12/29/2011 05:53 PM, Isaku Yamahata wrote: > On Thu, Dec 29, 2011 at 04:55:11PM +0200, Avi Kivity wrote: > > On 12/29/2011 04:49 PM, Isaku Yamahata wrote: > > > > > Great, then we agreed with list/reattach basically. > > > > > (Maybe identity scheme needs reconsideration.) > > > > > > > > I gue

Re: [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2011-12-29 Thread Avi Kivity
On 12/29/2011 03:49 PM, Isaku Yamahata wrote: > > > > qemu can have an extra thread that wait4()s the daemon, and relaunch > > it. This extra thread would not be blocked by the page fault. It can > > keep the fd so it isn't lost. > > > > The unkillability of process A is a security issue; it co

Re: Better qemu/kvm defaults (was Re: [RFC PATCH 0/4] Gang scheduling in CFS)

2011-12-29 Thread Avi Kivity
On 12/29/2011 06:07 PM, Dor Laor wrote: > On 12/26/2011 11:05 AM, Avi Kivity wrote: >> On 12/26/2011 05:14 AM, Nikunj A Dadhania wrote: btw you can get an additional speedup by enabling x2apic, for default_send_IPI_mask_logical(). >>> In the host? >>> >> >> In the host, for the

Re: [PATCH 0/2][RFC] postcopy migration: Linux char device for postcopy

2011-12-29 Thread Avi Kivity
On 12/29/2011 02:39 PM, Isaku Yamahata wrote: > > > ioctl commands: > > > > > > UMEM_DEV_CRATE_UMEM: create umem device for qemu > > > UMEM_DEV_LIST: list created umem devices > > > UMEM_DEV_REATTACH: re-attach the created umem device > > > UMEM_DEV_LIST and UMEM_DEV_REATTACH are used w

Re: [Qemu-devel] [PATCH 00/21][RFC] postcopy live migration

2011-12-29 Thread Anthony Liguori
On 12/28/2011 07:25 PM, Isaku Yamahata wrote: Intro = This patch series implements postcopy live migration.[1] As discussed at KVM forum 2011, dedicated character device is used for distributed shared memory between migration source and destination. Now we can discuss/benchmark/compare with p

[PATCH 0/5] virt: Config file unification

2011-12-29 Thread Lucas Meneghel Rodrigues
Make kvm and libvirt test configs mostly shared, so it's easy to maintain those config files. Chris Evich (5): virt: Adding common config among libvirt and kvm tests virt: Remove sample config from kvm and libvirt folders virt: Move vm_type into separate tests.cfg.sample virt: libvirt_vm:

[PATCH 3/5] virt: Move vm_type into separate tests.cfg.sample

2011-12-29 Thread Lucas Meneghel Rodrigues
Moved vm_type setting into seperate tests.cfg.sample so that base.cfg.sample can be shared between virt test types. Signed-off-by: Chris Evich --- client/tests/kvm/tests.cfg.sample |5 + client/tests/libvirt/tests.cfg.sample |5 + client/virt/base.cfg.sample |4

[PATCH 4/5] virt: libvirt_vm: Avoid re-copying kernel and initrd on install

2011-12-29 Thread Lucas Meneghel Rodrigues
Added simple workaround for virt-install's insistence on re-copying kernel and initrd files from a specific directory layout. Added a note that this code should be cleaned up if/when corresponding part of unattended_install test is cleaned. Signed-off-by: Chris Evich --- client/virt/libvirt_vm.

[PATCH 5/5] virt: Fixup extra_params usage and config

2011-12-29 Thread Lucas Meneghel Rodrigues
Created a special category, 'kernel_params', for options passed to the kernel which we are booting, such as the installer kernels. With this patch we don't mess up with the other uses of extra_params still keeping consistency between libvirt and kvm tests. Signe-off-by: Lucas Meneghel Rodrigues -

[Autotest] [PATCH] virt: Add the parameter --vnclisten to the virt-install command

2011-12-29 Thread tangchen
Hi, My colleague happened to find that when installing a Guest, we cannot access to it by VNC because of the missing parameter "--vnclisten=0.0.0.0" in virt-install. Here is the patch, please comment! :) Signed-off-by: Gu Yanhua --- client/virt/libvirt_vm.py |8 1 files changed