Re: [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-19 Thread Michael S. Tsirkin
On Wed, Oct 19, 2011 at 08:41:48AM +0200, Jan Kiszka wrote: > > a single GSI and vice versa. As there are less GSIs than possible > > MSI > > messages, we could run out of them when creating routes, statically > > or > > lazily. > > > > What

Re: [PATCH] Code clean up for percpu_xxx() functions

2011-10-19 Thread Alex,Shi
> Well do the obvious (where you can see that interrupts or preemption are > disabled in the function or in a calling function). Leave the rest as is > and provide separate patches for them? Thanks for comments! I initialized the patch as following accordingly, And cc to more maintainers for revi

Re: [PATCH] Code clean up for percpu_xxx() functions

2011-10-19 Thread Avi Kivity
On 10/19/2011 11:23 AM, Alex,Shi wrote: > > Well do the obvious (where you can see that interrupts or preemption are > > disabled in the function or in a calling function). Leave the rest as is > > and provide separate patches for them? > > Thanks for comments! I initialized the patch as following

Re: [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-19 Thread Avi Kivity
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/18/2011 09:41 PM, Jan Kiszka wrote: > > Looks OK to me. > > Same here. - -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Com

Re: [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index

2011-10-19 Thread Michael S. Tsirkin
On Thu, Jun 09, 2011 at 06:41:56AM -0400, Mark Wu wrote: > On 06/09/2011 05:14 AM, Tejun Heo wrote: > > Hello, > > > > On Thu, Jun 09, 2011 at 08:51:05AM +0930, Rusty Russell wrote: > >> On Wed, 08 Jun 2011 09:08:29 -0400, Mark Wu wrote: > >>> Hi Rusty, > >>> Yes, I can't figure out an instance o

Re: [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-19 Thread Jan Kiszka
On 2011-10-19 08:33, Lai Jiangshan wrote: > On 10/19/2011 03:41 AM, Jan Kiszka wrote: >> On 2011-10-17 18:00, Lai Jiangshan wrote: >>> On 10/17/2011 05:49 PM, Avi Kivity wrote: On 10/17/2011 11:40 AM, Lai Jiangshan wrote: >>> >> >> LINT1 may have been programmed as a level -trigger

[kvm-autotest] cgroup-kvm: Four new BlkioThrottle tests (second pass)

2011-10-19 Thread Lukas Doktor
Hi guys, This is a patchset with four new tests to KVM specific cgroup testing. Also I made some modifications into (general) cgroup_common library which makes cgroup testing better readable and more safe to execute. Please find the details in each patch. Also please beware of qemu-kvm bugs wh

[PATCH 1/4] [kvm-autotest] client.tests.kvm.tests.cgroup: add_*_drive / rm_drive; bugfixies

2011-10-19 Thread Lukas Doktor
* functions for adding and removal of drive to vm using host-file or host-scsi_debug device. * move get_children_pids() into base_utils.py * client.virt.kvm_monitor: add 'debug=True' parameter into monitor.info() cmd * client.common_lib.base_utils: add etraceback() function for formating traceb

[PATCH 2/4] client.tests.cgroup: cleanup and structural changes

2011-10-19 Thread Lukas Doktor
* Use exceptions instead of returns * cgroup and cgroup-kvm tests were modified to fit * other code cleanups Signed-off-by: Lukas Doktor --- client/tests/cgroup/cgroup.py| 169 +- client/tests/cgroup/cgroup_common.py | 140 ++--

[PATCH 3/4] client.tests.cgroup: {set,get}_property functions unification; bugfixes

2011-10-19 Thread Lukas Doktor
* override "check" parameter to True / False / String (different value) * add checkprop parameter to change the property which is used to check the value. * use more sane "set_property_h" function name instead of "set_prop" * change raise error.TestFail for error.TestError * get_property: r

[PATCH 4/4] [kvm-autotest] client.tests.kvm.tests.cgroup: New subtest: TestBlkioThrottle*

2011-10-19 Thread Lukas Doktor
* Four new subtests for testing blkio.throttle.{read,write}_bps_device cgroup functionalities. * TestBlkioThrottleRead/Write let dd read/write for 1 minute and verifies the correct throughput. * TestBlkioThrottleMultipleRead/Write let dd read/write while switching multiple cgroups with

Re: [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-19 Thread Jan Kiszka
On 2011-10-19 11:03, Michael S. Tsirkin wrote: >>> I thought we need to match APIC ID. That needs a table lookup, no? >> >> Yes. But that's completely independent of a concrete MSI message. In >> fact, this is the same thing we need when interpreting an IOAPIC >> redirection table entry. So let's c

Re: Booting up an old Windows 3.1 harddisk image

2011-10-19 Thread John Stoffel
Avi & Guys, Thanks for your patience, I just got the sucker booting by switching the -M option to be an isapc system. And I was wrong about it being a Gateway, it's a packard Bell system running Windows 3.1, talk about a blast from the past. I think I still have the keyboard around somehwere.

Re: [PATCH] KVM: SVM: Keep intercepting task switching with NPT enabled

2011-10-19 Thread Roedel, Joerg
On Tue, Oct 18, 2011 at 01:37:32PM -0400, Avi Kivity wrote: > On 10/18/2011 06:35 PM, Roedel, Joerg wrote: > > On Tue, Oct 18, 2011 at 12:23:11PM -0400, Jan Kiszka wrote: > > > AMD processors apparently have a bug in the hardware task switching > > > support when NPT is enabled. If the task switch

Re: Nested Virtualization Of Hyper-V 2K8R2

2011-10-19 Thread Joerg Roedel
Hi Jim, On Tue, Oct 18, 2011 at 07:28:52PM +0100, Jim wrote: > Sure, the KVM command is : > > /usr/bin/kvm -enable-nesting -no-kvm-irqchip -S -M pc-0.14 -enable-kvm > -m 2048 -smp 2,sockets=2,cores=1,threads=1 -name hyperv1 -uuid > 8c5d8f1f-5767-b388-d408-1b53a1b66e72 -nodefconfig -nodefaults

Re: [PATCH] KVM: x86: Simplify kvm timer handler

2011-10-19 Thread Marcelo Tosatti
On Wed, Sep 14, 2011 at 09:58:32AM +0200, Jan Kiszka wrote: > The vcpu reference of a kvm_timer can't become NULL while the timer is > valid, so drop this redundant test. This also makes it pointless to > carry a separate __kvm_timer_fn, fold it into kvm_timer_fn. > > Signed-off-by: Jan Kiszka >

Re: Nested Virtualization Of Hyper-V 2K8R2

2011-10-19 Thread Jim
On 19/10/2011 16:06, Jim wrote: Hi Joerg, I added the -cpu phenom,-hv but it made no difference. I then tried to call it from the command line (rather then via virsh) and get this : # /usr/bin/kvm -cpu phenom,-hv *CPU feature hv not found* I played around a little and found 'svm' seemed

[PATCH 1/1 V6] qemu: fix improper nmi emulation

2011-10-19 Thread Lai Jiangshan
On 10/19/2011 06:57 PM, Jan Kiszka wrote: >>> >>> Looks OK to me. >>> >>> Please don't forget to bake a qemu-only patch for those bits that apply >>> to upstream as well (ie. the user space APIC path). >>> >>> Jan >>> >> >> I did forget it. >> Did you mean we need to add "#ifdef KVM_CAP_IRQCHIP" b

Re: [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

2011-10-19 Thread Lai Jiangshan
On 10/19/2011 05:29 PM, Avi Kivity wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/18/2011 09:41 PM, Jan Kiszka wrote: >> >> Looks OK to me. >> >> > > Same here. Who will merge it? Thanks, Lai > > - -- > I have a truly marvellous patch that fixes the bug which this > si

Re: Running KVM inside a chroot

2011-10-19 Thread David Ahern
On 10/18/2011 04:29 AM, Avi Kivity wrote: >> >> Almost all the exits show "[FAILED TO PARSE]", would this be a problem? >> > > Did you 'make install' trace-cmd? run it from outside the chroot. You need to install the plugins: make install_plugins David -- To unsubscribe from this list: send th

Re: [PATCH] Code clean up for percpu_xxx() functions

2011-10-19 Thread Christoph Lameter
On Wed, 19 Oct 2011, Alex,Shi wrote: > Thanks for comments! I initialized the patch as following accordingly, > And cc to more maintainers for review. I checked all code except xen/kvm > part, totally a idiot for them. Acked-by: Christoph Lameter -- To unsubscribe from this list: send the line

[ANNOUNCE] qemu-kvm-0.15.1

2011-10-19 Thread Marcelo Tosatti
qemu-kvm-0.15.1 is now available. This release is based on the upstream qemu 0.15.1, plus kvm-specific enhancements. Please see http://wiki.qemu.org/ChangeLog/0.15 for a list of changes in this release. This release can be used with the kvm kernel modules provided by your distribution kernel, or

Re: [PATCH] pci-assign: Fix MSI-X MMIO page registration

2011-10-19 Thread Marcelo Tosatti
On Wed, Oct 12, 2011 at 07:02:37PM +0200, Jan Kiszka wrote: > The MSI-X page must start below the address that comes after the end of > a region. Otherwise we risk to register it twice. This bug existed since > day #1 of the MSI-X support and was now reveal by > > memory.c:1201: memory_region_add_

Re: [patch] KVM: make checks stricter in coalesced_mmio_in_range()

2011-10-19 Thread Marcelo Tosatti
On Wed, Oct 19, 2011 at 09:15:10AM +0300, Dan Carpenter wrote: > My testing version of Smatch complains that addr and len come from > the user and they can wrap. The path is: > -> kvm_vm_ioctl() > -> kvm_vm_ioctl_unregister_coalesced_mmio() > -> coalesced_mmio_in_range() > > I don'

Re: [patch 0/4] Fixes for kvm-s390

2011-10-19 Thread Marcelo Tosatti
On Tue, Oct 18, 2011 at 12:27:11PM +0200, Christian Borntraeger wrote: > Avi, Marcelo, > > here are 4 fixes for kvm on s390: > 1. check cpu_id prior to using it > 2. fix return value of kvm_arch_init_vm > 3. fix register setting > 4. implement sigp external call > > All patches have been tested i

RE: [net-next-2.6 PATCH 0/8 RFC v2] macvlan: MAC Address filtering support for passthru mode

2011-10-19 Thread Rose, Gregory V
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Roopa Prabhu > Sent: Tuesday, October 18, 2011 11:26 PM > To: net...@vger.kernel.org > Cc: s...@us.ibm.com; dragos.tatu...@gmail.com; a...@arndb.de; > kvm@vger.kernel.org; m...@red

Re: [net-next-2.6 PATCH 0/8 RFC v2] macvlan: MAC Address filtering support for passthru mode

2011-10-19 Thread Roopa Prabhu
On 10/19/11 2:06 PM, "Rose, Gregory V" wrote: >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Roopa Prabhu >> Sent: Tuesday, October 18, 2011 11:26 PM >> To: net...@vger.kernel.org >> Cc: s...@us.ibm.com; dragos.tatu...@

Re: [PATCH] Code clean up for percpu_xxx() functions

2011-10-19 Thread Alex,Shi
> Acked-by: Christoph Lameter Thanks, Christoph! and resend for code style problem correction. >From b8d595063259a636778b14c43f3cf024e908fd25 Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Thu, 20 Oct 2011 10:25:50 +0800 Subject: [PATCH 1/2] Code clean up for percpu_xxx() functions

Re: [PATCH] Code clean up for percpu_xxx() functions

2011-10-19 Thread Alex,Shi
> All of the kvm usage is in preemption disabled contexts. Thanks! So would you like to ack this patch? === >From 8ca7e6e40d75eab598c4fb4f8d555299b747adfa Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Thu, 20 Oct 2011 10:31:51 +0800 Subject: [PATCH 2/2] Change this_cpu_xxx to __this_cpu_xxx f

Re: Running KVM inside a chroot

2011-10-19 Thread Jorge Lucangeli Obes
On Tue, Oct 18, 2011 at 10:46 AM, Avi Kivity wrote: > On 10/18/2011 07:39 PM, Jorge Lucangeli Obes wrote: >> On Tue, Oct 18, 2011 at 10:28 AM, Avi Kivity wrote: >> > On 10/18/2011 06:43 PM, Jorge Lucangeli Obes wrote: >> >> https://docs.google.com/leaf?id=0B78o7gMWkuFeYzUzODViMjUtNzliNy00ODc5LWIw

Re: [PATCH] Code clean up for percpu_xxx() functions

2011-10-19 Thread Eric Dumazet
Le jeudi 20 octobre 2011 à 10:44 +0800, Alex,Shi a écrit : > > Acked-by: Christoph Lameter > > Thanks, Christoph! > and resend for code style problem correction. > Sorry this huge patch brings too many potential bugs. I ask you a separate patch for the networking part, because I dont want to

Re: [PATCH] Code clean up for percpu_xxx() functions

2011-10-19 Thread Alex,Shi
> Sorry this huge patch brings too many potential bugs. > > I ask you a separate patch for the networking part, because I dont want > to Ack all the other parts. > Thanks a lot for review! I split the first patch into 2 according your suggestion. The second one for network here: >From d5d7112

Re: [PATCH] Code clean up for percpu_xxx() functions

2011-10-19 Thread Alex,Shi
> Sorry this huge patch brings too many potential bugs. > > I ask you a separate patch for the networking part, because I dont want > to Ack all the other parts. Thanks a lot for review! I split the first patch into 2 according your suggestion. The first one is here: >From 516756ad094c49f8ddc4

Re: [PATCH] Code clean up for percpu_xxx() functions

2011-10-19 Thread Alex,Shi
On Thu, 2011-10-20 at 14:04 +0800, Alex,Shi wrote: > > Sorry this huge patch brings too many potential bugs. > > > > I ask you a separate patch for the networking part, because I dont want > > to Ack all the other parts. > > > > Thanks a lot for review! I split the first patch into 2 according y