[PATCH 0/4] KVM: x86 emulator: Clean up decoder a bit

2011-07-30 Thread Takuya Yoshikawa
Passed emulator.flat test: SUMMARY: 88 tests, 0 failures Takuya -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/4] KVM: x86 emulator: Use ctxt->_eip directly in do_insn_fetch_byte()

2011-07-30 Thread Takuya Yoshikawa
From: Takuya Yoshikawa Instead of passing ctxt->_eip from insn_fetch() call sites, get it from ctxt in do_insn_fetch_byte(). This is done by replacing the argument _eip of insn_fetch() with _ctxt, which should be better than letting the macro use ctxt silently in its body. Though this changes t

[PATCH 2/4] KVM: x86 emulator: Drop _size argument from insn_fetch()

2011-07-30 Thread Takuya Yoshikawa
From: Takuya Yoshikawa _type is enough to know the size. Signed-off-by: Takuya Yoshikawa --- arch/x86/kvm/emulate.c | 44 ++-- 1 files changed, 22 insertions(+), 22 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index fbb2e3

[PATCH 3/4] KVM: x86 emulator: Let compiler know insn_fetch() rarely fails

2011-07-30 Thread Takuya Yoshikawa
From: Takuya Yoshikawa Fetching the instruction which was to be executed by the guest cannot fail normally. So compiler should always predict that it will succeed. Signed-off-by: Takuya Yoshikawa --- arch/x86/kvm/emulate.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 4/4] KVM: x86 emulator: Make x86_decode_insn() return proper macros

2011-07-30 Thread Takuya Yoshikawa
From: Takuya Yoshikawa Return EMULATION_OK/FAILED consistently. Also treat instruction fetch errors, not restricted to X86EMUL_UNHANDLEABLE, as EMULATION_FAILED; although this cannot happen in practice, the current logic will continue the emulation even if the decoder fails to fetch the instruct

Re: Windows7 crashes inside the VM when starting a certain program

2011-07-30 Thread André Weidemann
On 29.07.2011 13:37, Gleb Natapov wrote: On Fri, Jul 29, 2011 at 09:20:35AM +0200, André Weidemann wrote: On 27.07.2011 10:56, Gleb Natapov wrote: On Tue, Jul 26, 2011 at 12:57:44PM +0200, André Weidemann wrote: Hi, On 26.07.2011 12:08, Gleb Natapov wrote: On Tue, Jul 26, 2011 at 07:29:04AM

Re: kvm PCI assignment & VFIO ramblings

2011-07-30 Thread Alex Williamson
On Sat, 2011-07-30 at 09:58 +1000, Benjamin Herrenschmidt wrote: > Hi folks ! > > So I promised Anthony I would try to summarize some of the comments & > issues we have vs. VFIO after we've tried to use it for PCI pass-through > on POWER. It's pretty long, there are various items with more or less

Re: kvm PCI assignment & VFIO ramblings

2011-07-30 Thread Benjamin Herrenschmidt
On Sat, 2011-07-30 at 09:58 +1000, Benjamin Herrenschmidt wrote: > Hi folks ! > > So I promised Anthony I would try to summarize some of the comments & > issues we have vs. VFIO after we've tried to use it for PCI pass-through > on POWER. It's pretty long, there are various items with more or less

Re: kvm PCI assignment & VFIO ramblings

2011-07-30 Thread Benjamin Herrenschmidt
On Sat, 2011-07-30 at 12:20 -0600, Alex Williamson wrote: > On x86, the USB controllers don't typically live behind a PCIe-to-PCI > bridge, so don't suffer the source identifier problem, but they do often > share an interrupt. But even then, we can count on most modern devices > supporting PCI2.3

Re: kvm PCI assignment & VFIO ramblings

2011-07-30 Thread Benjamin Herrenschmidt
On Sat, 2011-07-30 at 12:20 -0600, Alex Williamson wrote: > On x86, the USB controllers don't typically live behind a PCIe-to-PCI > bridge, so don't suffer the source identifier problem, but they do often > share an interrupt. But even then, we can count on most modern devices > supporting PCI2.3

Re: [PATCH RFC net-next] virtio_net: refill buffer right after being used

2011-07-30 Thread Shirley Ma
On Fri, 2011-07-29 at 16:58 -0700, Mike Waychison wrote: > On Fri, Jul 29, 2011 at 3:55 PM, Shirley Ma > wrote: > > Resubmit it with a typo fix. > > > > Signed-off-by: Shirley Ma > > --- > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index 0c7321c..c8201d4 100644 > >