Re: [Qemu-devel] [RFC v5 12/86] memory: add ioeventfd support

2011-07-22 Thread Avi Kivity
On 07/21/2011 10:55 PM, Blue Swirl wrote: On Wed, Jul 20, 2011 at 7:49 PM, Avi Kivity wrote: > As with the rest of the memory API, the caller associates an eventfd > with an address, and the memory API takes care of registering or > unregistering when the address is made visible or invisible

Re: [tip:tools/kvm] kvm tools, qcow: Fix copy-on-write image corruption

2011-07-22 Thread Pekka Enberg
On Thu, 21 Jul 2011, Kevin Wolf wrote: Hm, I must have missed this patch on the KVM mailing list... It wasn't on the list, sorry. You should also error out before creating a new L2 table as its refcount would have to be updated, too. On the other hand, the patch is a bit too restrictive, beca

Re: [tip:tools/kvm] kvm tools, qcow: Fix copy-on-write image corruption

2011-07-22 Thread Kevin Wolf
Am 22.07.2011 10:21, schrieb Pekka Enberg: > On Thu, 21 Jul 2011, Kevin Wolf wrote: >> Hm, I must have missed this patch on the KVM mailing list... > > It wasn't on the list, sorry. > >> You should also error out before creating a new L2 table as its refcount >> would have to be updated, too. On

[PATCH v1 1/1] Submit the codes for QEMU disk I/O limits.

2011-07-22 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu --- Makefile.objs |2 +- block.c | 248 + block.h |1 - block/blk-queue.c | 99 + block/blk-queue.h | 73 block_int.h | 21 + blockd

[PATCH v1 0/1] The draft of the codes for QEMU disk I/O limits

2011-07-22 Thread Zhi Yong Wu
The main goal of the patch is to effectively cap the disk I/O speed or counts of one single VM. It is only one draft, so it unavoidably has some drawbacks, if you catch them, please let me know. The patch will mainly introduce one global timer and one block queue for each I/O limits enabled dri

Re: [PATCH v1 1/1] Submit the codes for QEMU disk I/O limits.

2011-07-22 Thread Stefan Hajnoczi
On Fri, Jul 22, 2011 at 10:20 AM, Zhi Yong Wu wrote: > +static void bdrv_block_timer(void *opaque) > +{ > +    BlockDriverState *bs = opaque; > +    BlockQueue *queue = bs->block_queue; > +    uint64_t intval = 1; > + > +    while (!QTAILQ_EMPTY(&queue->requests)) { > +        BlockIORequest *requ

Re: [PATCH] cpu hotplug issue

2011-07-22 Thread Jan Kiszka
On 2011-07-21 14:45, Gleb Natapov wrote: > On Thu, Jul 21, 2011 at 02:51:18PM +0300, Gleb Natapov wrote: Jan can you look at this please? >>> >>> I can't promise to do debugging myself. >>> >>> Also, as I never succeeded in getting anything working with CPU hotplug, >>> even back in the days i

[RFC 1/2] KVM: Record instruction set in all vmexit tracepoints

2011-07-22 Thread Stefan Hajnoczi
The kvm_exit tracepoint recently added the isa argument to aid decoding exit_reason. The semantics of exit_reason depend on the instruction set (vmx or svm) and the isa argument allows traces to be analyzed on other machines. Add the isa argument to kvm_nested_vmexit and kvm_nested_vmexit_inject

[RFC 0/2] KVM: Fix kvm_exit trace event format

2011-07-22 Thread Stefan Hajnoczi
Currently both perf and trace-cmd cannot parse the kvm:kvm_exit trace event format. This patch is an attempt to make formatting work without changing the kvm:kvm_exit prototype. Since this event is a core KVM operation, no doubt there are existing trace analysis scripts that rely on it and I don'

[RFC 2/2] KVM: Use __print_symbolic() for vmexit tracepoints

2011-07-22 Thread Stefan Hajnoczi
The vmexit tracepoints format the exit_reason to make it human-readable. Since the exit_reason depends on the instruction set (vmx or svm), formatting is handled with ftrace_print_symbols_seq() by referring to the appropriate exit reason table. However, the ftrace_print_symbols_seq() function is n

[PATCH 0/3] Check for supported SCSI commands

2011-07-22 Thread Hannes Reinecke
Markus Armbruster pointed out that not every SCSI command is supported for a given device type. Based on his patch this series cleans up the SCSI device type and adds a check for supported commands. Hannes Reinecke (3): scsi: Sanitize command definitions scsi-disk: Remove drive_kind scsi-dis

[PATCH 1/3] scsi: Sanitize command definitions

2011-07-22 Thread Hannes Reinecke
Adding some missing command definitions and update the existing ones. No functional change. Signed-off-by: Hannes Reinecke --- hw/scsi-bus.c | 71 ++-- hw/scsi-defs.h| 60 hw/scsi-disk.c|

[PATCH 2/3] scsi-disk: Remove drive_kind

2011-07-22 Thread Hannes Reinecke
Instead of using our own type structure we can be using the SCSI type from the parent device. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c | 156 ++-- 1 files changed, 129 insertions(+), 27 deletions(-) diff --git a/hw/scsi-disk.c b/hw/s

[PATCH 3/3] scsi-disk: Check for supported commands

2011-07-22 Thread Hannes Reinecke
Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c | 102 1 files changed, 0 insertions(+), 102 deletions(-) diff --git a/hw/scs

Re: [Qemu-devel] [PATCH 1/3] scsi: Sanitize command definitions

2011-07-22 Thread Markus Armbruster
Hannes Reinecke writes: > Adding some missing command definitions and update the existing ones. > No functional change. Add: LOCATE_10, UNMAP, VARLENGTH_CDB, WRITE_FILEMARKS_16, EXTENDED_COPY, ATA_PASSTHROUGH, ACCESS_CONTROL_IN, ACCESS_CONTROL_OUT, COMPARE_AND_WRITE, VERIFY_16, SYNCHRONIZE_CACHE

Re: [Qemu-devel] [PATCH 3/3] scsi-disk: Check for supported commands

2011-07-22 Thread Markus Armbruster
Hannes Reinecke writes: > Not every command is support for any device type. This patch adds > a check for rejecting unsupported commands. > > Signed-off-by: Hannes Reinecke Commit message says "patch adds", patch only deletes. Looks like something wrent wrong with 2/3 and 3/3. -- To unsubscrib

Re: [Qemu-devel] [PATCH 1/3] scsi: Sanitize command definitions

2011-07-22 Thread Hannes Reinecke
On 07/22/2011 04:07 PM, Markus Armbruster wrote: Hannes Reinecke writes: Adding some missing command definitions and update the existing ones. No functional change. Add: LOCATE_10, UNMAP, VARLENGTH_CDB, WRITE_FILEMARKS_16, EXTENDED_COPY, ATA_PASSTHROUGH, ACCESS_CONTROL_IN, ACCESS_CONTROL_OUT

Re: [Qemu-devel] [PATCH 3/3] scsi-disk: Check for supported commands

2011-07-22 Thread Hannes Reinecke
On 07/22/2011 04:09 PM, Markus Armbruster wrote: Hannes Reinecke writes: Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke Commit message says "patch adds", patch only deletes. Looks like something w

[PATCH 0/6][v2] Check for supported SCSI commands

2011-07-22 Thread Hannes Reinecke
Markus Armbruster pointed out that not every SCSI command is supported for a given device type. Based on his patch and suggestiongs this series cleans up the SCSI device type and adds a check for supported commands. Hannes Reinecke (6): scsi-disk: Codingstyle fixes scsi: Remove references to S

[PATCH 1/6] scsi-disk: Codingstyle fixes

2011-07-22 Thread Hannes Reinecke
Replace tabs with spaces. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 05d14ab..910d3b5 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -526,7 +526,7 @@ static i

[PATCH 2/6] scsi: Remove references to SET_WINDOW

2011-07-22 Thread Hannes Reinecke
SET_WINDOW command is vendor-specific only. So we shouldn't try to emulate it. Signed-off-by: Hannes Reinecke --- hw/scsi-bus.c |2 -- hw/scsi-defs.h |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 8b1a412..facc98d 100644 --- a/hw

[PATCH 3/6] scsi: Remove REZERO_UNIT emulation

2011-07-22 Thread Hannes Reinecke
REZERO_UNIT command is obsolete. Remove support for it. Signed-off-by: Hannes Reinecke --- hw/scsi-bus.c |3 --- hw/scsi-defs.h |1 - hw/scsi-disk.c |7 --- 3 files changed, 0 insertions(+), 11 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index facc98d..52a6784 10064

[PATCH 5/6] scsi-disk: Remove 'drive_kind'

2011-07-22 Thread Hannes Reinecke
Instead of using its own definitions scsi-disk should be using the device type of the parent device. Signed-off-by: Hannes Reinecke --- hw/scsi-defs.h |6 +- hw/scsi-disk.c | 48 2 files changed, 29 insertions(+), 25 deletions(-) diff -

[PATCH 6/6] scsi-disk: Check for supported commands

2011-07-22 Thread Hannes Reinecke
Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c | 104 +++- 1 files changed, 103 insertions(+), 1 deletions(-) diff --git a/hw/scs

[PATCH 4/6] scsi: Sanitize command definitions

2011-07-22 Thread Hannes Reinecke
Sanitize SCSI command definitions. Add _10 suffix to READ_CAPACITY, WRITE_VERIFY, VERIFY, READ_LONG, WRITE_LONG, and WRITE_SAME. Add new command definitions for LOCATE_10, UNMAP, VARLENGTH_CDB, WRITE_FILEMARKS_16, EXTENDED_COPY, ATA_PASSTHROUGH, ACCESS_CONTROL_IN, ACCESS_CONTROL_OUT, COMPARE_AND_WR

[PATCH v3] pci: correct pci config size default for cap version 2 endpoints

2011-07-22 Thread Donald Dutile
v3: remove all boundary tests. just fix the obvious bug. : boundary test is not necessary; get this fix in & post boundary test in another separate patch. v2: do local boundary check with respect to legacy PCI header length, and don't depend on it in pci_add_capability(). : fix com

Re: [PATCH v3] pci: correct pci config size default for cap version 2 endpoints

2011-07-22 Thread Alex Williamson
On Fri, 2011-07-22 at 11:59 -0400, Donald Dutile wrote: > v3: remove all boundary tests. just fix the obvious bug. > : boundary test is not necessary; get this fix in & > post boundary test in another separate patch. > > v2: do local boundary check with respect to legacy PCI header lengt

Re: [PATCH v4] MMIO: Make coalesced mmio use a device per zone

2011-07-22 Thread Marcelo Tosatti
On Wed, Jul 20, 2011 at 08:59:00PM +0300, Sasha Levin wrote: > This patch changes coalesced mmio to create one mmio device per > zone instead of handling all zones in one device. > > Doing so enables us to take advantage of existing locking and prevents > a race condition between coalesced mmio re

Re: [PATCH] kvm: get_msr support for HV_X64_MSR_APIC_ASSIST_PAGE

2011-07-22 Thread Marcelo Tosatti
On Thu, Jul 21, 2011 at 03:38:10PM -0700, Mike Waychison wrote: > "get" support for the HV_X64_MSR_APIC_ASSIST_PAGE msr was missing, even > though it is explicitly enumerated as something the vmm should save in > msrs_to_save and reported to userland via the KVM_GET_MSR_INDEX_LIST > ioctl. > > Add

[Bug 39802] New: Kernel error in KVM

2011-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=39802 Summary: Kernel error in KVM Product: Virtualization Version: unspecified Kernel Version: 2.6.32 Platform: All OS/Version: Linux Tree: Mainline Status: NEW S

[Bug 39802] Kernel error in KVM

2011-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=39802 Yuri H. Sierakowski changed: What|Removed |Added Platform|All |x86-64 -- Configure bugmail: h

[Bug 39802] Kernel error in KVM

2011-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=39802 --- Comment #1 from Yuri H. Sierakowski 2011-07-22 18:00:19 --- Kernel failure message 1: NETDEV WATCHDOG: eth0 (atl1c): transmit queue 0 timed out Modules linked in: microcode usb_storage tun ip6table_filter ip6_tables ebtable_nat ebtables

Re: [PATCH v3] pci: correct pci config size default for cap version 2 endpoints

2011-07-22 Thread Chris Wright
* Donald Dutile (ddut...@redhat.com) wrote: > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > index 36ad6b0..34db52e 100644 > --- a/hw/device-assignment.c > +++ b/hw/device-assignment.c > @@ -1419,16 +1419,18 @@ static int assigned_device_pci_cap_init(PCIDevice > *pci_dev) > }

Re: [PATCH v3] pci: correct pci config size default for cap version 2 endpoints

2011-07-22 Thread Alex Williamson
On Fri, 2011-07-22 at 14:24 -0700, Chris Wright wrote: > * Donald Dutile (ddut...@redhat.com) wrote: > > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > > index 36ad6b0..34db52e 100644 > > --- a/hw/device-assignment.c > > +++ b/hw/device-assignment.c > > @@ -1419,16 +1419,18 @@ stati

Re: [PATCH v3] pci: correct pci config size default for cap version 2 endpoints

2011-07-22 Thread Chris Wright
* Alex Williamson (alex.william...@redhat.com) wrote: > On Fri, 2011-07-22 at 14:24 -0700, Chris Wright wrote: > > * Donald Dutile (ddut...@redhat.com) wrote: > > > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > > > index 36ad6b0..34db52e 100644 > > > --- a/hw/device-assignment.c >