Re: [PATCH] KVM Test: Add re.IGNORECASE to re.compile to verify_ip_address_ in kvm_utils.py

2009-10-28 Thread Michael Goldish
Thanks for catching this. While we're at it, why not remove the 2 occurrences of re.IGNORECASE that have no effect? We can also replace re.search(regex, o) with the slightly shorter regex.search(o), but that's just a cosmetic change. - Original Message - From: "Chen Cao" To: l...@redhat.c

Re: [KVM PATCH v3 3/3] KVM: Directly inject interrupts if they support lockless operation

2009-10-28 Thread Michael S. Tsirkin
On Tue, Oct 27, 2009 at 02:54:40PM -0400, Gregory Haskins wrote: > Michael S. Tsirkin wrote: > > On Mon, Oct 26, 2009 at 12:22:08PM -0400, Gregory Haskins wrote: > >> IRQFD currently uses a deferred workqueue item to execute the injection > >> operation. It was originally designed this way because

Re: [KVM PATCH v3 2/3] KVM: export lockless GSI attribute

2009-10-28 Thread Michael S. Tsirkin
On Mon, Oct 26, 2009 at 12:22:03PM -0400, Gregory Haskins wrote: > Certain GSI's support lockless injecton, but we have no way to detect > which ones at the GSI level. Knowledge of this attribute will be > useful later in the series so that we can optimize irqfd injection > paths for cases where w

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Hannes Reinecke
Am Tue 27 Oct 2009 05:47:21 PM CET schrieb Gerd Hoffmann : Hi, The device can be accessed by -drive if=raid,file=XXX Don't extend that qemu automagic please. The new way to handle this is: -drive if=none,id=mydisk,file=/path/to/some/disk.img -device megasas,id=raid -device scsi-di

Re: BUG with Win7 and user-return-notifier

2009-10-28 Thread Avi Kivity
On 10/27/2009 03:25 PM, Avi Kivity wrote: On 10/27/2009 03:24 PM, Avi Kivity wrote: Worked for me - getting to the initial prompt. Do you have CONFIG_USER_RETURN_NOTIFIER=y in your .config? If you do, send your own .config, will try to reproduce. As I can't reproduce it, can you sen

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Avi Kivity
On 10/28/2009 10:11 AM, Hannes Reinecke wrote: The problem is I don't have any documentation for the LSI parallel SCSI controller. So I don't know if and in what shape I/O is passed down, nor anything else. And as the SCSI disk emulation is really tied into the LSI parallel SCSI controller, any

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Christoph Hellwig
On Wed, Oct 28, 2009 at 09:11:29AM +0100, Hannes Reinecke wrote: > The problem is I don't have any documentation for the LSI parallel > SCSI controller. So I don't know if and in what shape I/O is passed > down, nor anything else. And as the SCSI disk emulation is really > tied into the LSI paralle

Re: [Qemu-devel] [PATCH 3/4] scsi-disk: Factor out SCSI command emulation

2009-10-28 Thread Christoph Hellwig
On Tue, Oct 27, 2009 at 04:28:59PM +0100, Hannes Reinecke wrote: > > Other drives might want to use SCSI command emulation without > going through the SCSI disk abstraction, as this imposes too > many limits on the emulation. Might be a good idea to move something like this first into the series

Re: [PATCH] KVM Test: Add re.IGNORECASE to re.compile to verify_ip_address_ in kvm_utils.py

2009-10-28 Thread Cao, Chen
On Wed, Oct 28, 2009 at 03:20:41AM -0400, Michael Goldish wrote: > Thanks for catching this. > While we're at it, why not remove the 2 occurrences of re.IGNORECASE > that have no effect? I just chose to ignore the code that does not break the tests. I'd like to send a patch to remove the 2 're.IG

[KVM-Autotest Patch] KVM Test: Add re.IGNORECASE to re.compile to verify_ip_address_ in kvm_utils.py - v2

2009-10-28 Thread Cao, Chen
Since the mac address is (changed to) lowercase and the output of 'arping' is in uppercase, we need re.IGNORECASE in the re.compile. And substitute re.search(regex, 0, ...) with regex.search(o), as Michael Goldish (mgold...@redhat.com) suggested. Signed-off-by: Cao, Chen --- client/tests/kvm/kv

Re: [patch 2/3] KVM: x86: disallow KVM_{SET,GET}_LAPIC without in kernel irqchip

2009-10-28 Thread Avi Kivity
On 10/27/2009 07:50 PM, Michael S. Tsirkin wrote: Can the value of irqchip_in_kernel be changed by userspace after we have checked it? If yes, this check won't help ... A change from false to true is possible, but not the reverse. -- error compiling committee.c: too many arguments to funct

Re: [PATCH v2] fix qemu-kvm sigsegv at exit

2009-10-28 Thread Avi Kivity
On 10/27/2009 05:33 PM, Marcelo Tosatti wrote: Michael reported a qemu-kvm SIGSEGV at shutdown: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x411d0940 (LWP 14446)] 0x0040afb4 in qemu_mod_timer (ts=0x19f0fd0, expire_time=62275467335) at /home/mst/scm/qem

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
I think this patch is a good idea. Comments: - If we've decided to put all the configuration in config files (rather than the control file) let's split up the main one into kvm_test_library.cfg and kvm_tests.cfg.sample. The latter should look like this: include kvm_test_library.cfg include kvm_

Re: [PATCH 0/5]: Fix kdump under KVM

2009-10-28 Thread Avi Kivity
On 10/27/2009 06:41 PM, Chris Lalancette wrote: This patch series aims to get kdump working inside a KVM guest. The current problem with using kdump is that KVM always delivers PIT interrupts to the BSP, and the BSP only. While this is technically allowed by the MPS spec, most motherboards actua

Re: [Alacrityvm-devel] [KVM PATCH v2 1/2] KVM: export lockless GSI attribute

2009-10-28 Thread Avi Kivity
On 10/26/2009 05:38 PM, Gregory Haskins wrote: Instead of a lockless attribute, how about a ->set_atomic() method. For msi this can be the same as ->set(), for non-msi it can be a function that schedules the work (which will eventually call ->set()). The benefit is that we make a decision only

Re: [PATCH 0/5]: Fix kdump under KVM

2009-10-28 Thread Chris Lalancette
Avi Kivity wrote: > On 10/27/2009 06:41 PM, Chris Lalancette wrote: >> This patch series aims to get kdump working inside a KVM guest. >> The current problem with using kdump is that KVM always delivers >> PIT interrupts to the BSP, and the BSP only. While this is >> technically allowed by the MPS

Re: [PATCH 5/5] Fix kdump under KVM.

2009-10-28 Thread Chris Lalancette
Marcelo Tosatti wrote: > On Tue, Oct 27, 2009 at 05:41:07PM +0100, Chris Lalancette wrote: >> This patch is the main point of the series. In order for >> kdump to properly work inside a KVM guest, we need to make >> sure that all VCPUs in virtual wire APIC mode get kicked >> to try and pick up the

Re: [patch 2/3] KVM: x86: disallow KVM_{SET,GET}_LAPIC without in kernel irqchip

2009-10-28 Thread Michael S. Tsirkin
On Wed, Oct 28, 2009 at 11:32:00AM +0200, Avi Kivity wrote: > On 10/27/2009 07:50 PM, Michael S. Tsirkin wrote: >> Can the value of irqchip_in_kernel be changed by userspace >> after we have checked it? If yes, this check won't help ... >> > > A change from false to true is possible, but not th

Re: [patch 2/3] KVM: x86: disallow KVM_{SET,GET}_LAPIC without in kernel irqchip

2009-10-28 Thread Gleb Natapov
On Wed, Oct 28, 2009 at 12:20:42PM +0200, Michael S. Tsirkin wrote: > On Wed, Oct 28, 2009 at 11:32:00AM +0200, Avi Kivity wrote: > > On 10/27/2009 07:50 PM, Michael S. Tsirkin wrote: > >> Can the value of irqchip_in_kernel be changed by userspace > >> after we have checked it? If yes, this check w

Re: [PATCH 0/5]: Fix kdump under KVM

2009-10-28 Thread Avi Kivity
On 10/28/2009 12:13 PM, Chris Lalancette wrote: The kick from i8254 code is pretty bad, as you mention. I forget why it is needed at all - shouldn't kvm_set_irq() end up kicking the correct As I understand it, that's not quite how it works. From what I can see, what happens is that the

Re: [patch 2/3] KVM: x86: disallow KVM_{SET,GET}_LAPIC without in kernel irqchip

2009-10-28 Thread Avi Kivity
On 10/28/2009 12:20 PM, Michael S. Tsirkin wrote: Hmm. If we want to rely on this, we have to play with memory barriers to write/read it. Doable, but hard to get right. Can we always have the irqchip object exist? It doesn't use a lot of memory, does it? Maybe have it inline, save an extra indir

Re: [patch 2/3] KVM: x86: disallow KVM_{SET,GET}_LAPIC without in kernel irqchip

2009-10-28 Thread Michael S. Tsirkin
On Wed, Oct 28, 2009 at 12:30:39PM +0200, Gleb Natapov wrote: > On Wed, Oct 28, 2009 at 12:20:42PM +0200, Michael S. Tsirkin wrote: > > On Wed, Oct 28, 2009 at 11:32:00AM +0200, Avi Kivity wrote: > > > On 10/27/2009 07:50 PM, Michael S. Tsirkin wrote: > > >> Can the value of irqchip_in_kernel be ch

Re: [patch 2/3] KVM: x86: disallow KVM_{SET,GET}_LAPIC without in kernel irqchip

2009-10-28 Thread Gleb Natapov
On Wed, Oct 28, 2009 at 12:32:24PM +0200, Michael S. Tsirkin wrote: > On Wed, Oct 28, 2009 at 12:30:39PM +0200, Gleb Natapov wrote: > > On Wed, Oct 28, 2009 at 12:20:42PM +0200, Michael S. Tsirkin wrote: > > > On Wed, Oct 28, 2009 at 11:32:00AM +0200, Avi Kivity wrote: > > > > On 10/27/2009 07:50 P

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Gerd Hoffmann
Hi, In order to support SCSI command emulation I had to update / patch up the existing SCSI disk support. This might be not to everyones taste, so I'm open to alternative suggestions. But I certainly do _not_ want to update the SCSI disk emulation, as this is really quite tied to the SCSI par

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Lucas Meneghel Rodrigues
One thing that just occurred to me is, if we have a test config "library" as you said, it's perfectly possible to put the actual test set definitions and other config files inside the control file as strings. This way one can control configuration inside the control file, making it more convenient

RE: [ANNOUNCE] kvm-kmod-2.6.31.5

2009-10-28 Thread Dietmar Maurer
> This release has been tested on x86 down to host kernel 2.6.27 and > builds down to 2.6.24. Building against older kernels is expected to be > broken, but if anyone provides patches to fix it, I'm open to merge > them. I am still not able to build with our 2.6.24 kernel. ./sync -v kvm-kmod-2.6

Re: [ANNOUNCE] kvm-kmod-2.6.31.5

2009-10-28 Thread Jan Kiszka
Dietmar Maurer wrote: >> This release has been tested on x86 down to host kernel 2.6.27 and >> builds down to 2.6.24. Building against older kernels is expected to be >> broken, but if anyone provides patches to fix it, I'm open to merge >> them. > > I am still not able to build with our 2.6.24 ke

RE: [ANNOUNCE] kvm-kmod-2.6.31.5

2009-10-28 Thread Dietmar Maurer
Well, we use the ubuntu tree: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary They have a few more patches applied: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=history;f=include/asm-x86/msr.h;h=cfe169475b5b50a448326ef3c34f50100ac83faf;hb=HEAD Seems the last two pat

Re: [ANNOUNCE] kvm-kmod-2.6.31.5

2009-10-28 Thread Jan Kiszka
Dietmar Maurer wrote: >>> So I can simply skip 'make sync'? >> The release tarball contains all required sources (as described, they >> were obtained from 2.6.31.5). So you do have to sync, > > So I need to run 'make sync'? Ouch. Of course I meant "you do *not* have to sync". Practically, there

Re: [PATCH 5/5] Fix kdump under KVM.

2009-10-28 Thread Marcelo Tosatti
On Wed, Oct 28, 2009 at 11:21:42AM +0100, Chris Lalancette wrote: > Marcelo Tosatti wrote: > > On Tue, Oct 27, 2009 at 05:41:07PM +0100, Chris Lalancette wrote: > >> This patch is the main point of the series. In order for > >> kdump to properly work inside a KVM guest, we need to make > >> sure t

Re: [ANNOUNCE] kvm-kmod-2.6.31.5

2009-10-28 Thread Jan Kiszka
Dietmar Maurer wrote: > Well, we use the ubuntu tree: > > http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary > > They have a few more patches applied: > > http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=history;f=include/asm-x86/msr.h;h=cfe169475b5b50a448326ef3c34f50100ac8

RE: [ANNOUNCE] kvm-kmod-2.6.31.5

2009-10-28 Thread Dietmar Maurer
> Do you know if there is anything to tell this ubuntu-patched kernel > apart from a vanilla version? If so, we could adjust the check in > x86/external-module-compat.h to avoid this breakage. no, not really > Locally, you could > simply comment out the double definition for now. Yes, that will

Re: [Alacrityvm-devel] [KVM PATCH v2 1/2] KVM: export lockless GSI attribute

2009-10-28 Thread Gregory Haskins
Avi Kivity wrote: > On 10/26/2009 05:38 PM, Gregory Haskins wrote: Instead of a lockless attribute, how about a ->set_atomic() method. For msi this can be the same as ->set(), for non-msi it can be a function that schedules the work (which will eventually call ->set()). >>

Re: [KVM PATCH v3 3/3] KVM: Directly inject interrupts if they support lockless operation

2009-10-28 Thread Gregory Haskins
Michael S. Tsirkin wrote: > On Tue, Oct 27, 2009 at 02:54:40PM -0400, Gregory Haskins wrote: >> Michael S. Tsirkin wrote: >>> On Mon, Oct 26, 2009 at 12:22:08PM -0400, Gregory Haskins wrote: IRQFD currently uses a deferred workqueue item to execute the injection operation. It was origina

Re: [KVM PATCH v3 2/3] KVM: export lockless GSI attribute

2009-10-28 Thread Gregory Haskins
Michael S. Tsirkin wrote: > On Mon, Oct 26, 2009 at 12:22:03PM -0400, Gregory Haskins wrote: >> Certain GSI's support lockless injecton, but we have no way to detect >> which ones at the GSI level. Knowledge of this attribute will be >> useful later in the series so that we can optimize irqfd inje

Re: [Alacrityvm-devel] [KVM PATCH v2 1/2] KVM: export lockless GSI attribute

2009-10-28 Thread Avi Kivity
On 10/28/2009 03:19 PM, Gregory Haskins wrote: Yes, and it also contains the work_struct. What if we make the work_struct (and any additional state) part of the set_atomic() argument list? Does it simplify things? Hmmm, that might not, but we could do a kmalloc(GFP_ATOMIC) for such param

Re: [Alacrityvm-devel] [KVM PATCH v2 1/2] KVM: export lockless GSI attribute

2009-10-28 Thread Gregory Haskins
Avi Kivity wrote: > On 10/28/2009 03:19 PM, Gregory Haskins wrote: >>> Yes, and it also contains the work_struct. >>> >>> What if we make the work_struct (and any additional state) part of the >>> set_atomic() argument list? Does it simplify things? >>> >> Hmmm, that might not, but we could

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Gerd Hoffmann
Hi, From a really quick view fixing up the data xfer code paths doesn't look too bad. Think I'll give it a try. Oh well. The interface pretty obviously designed for the esp, which is the oldest scsi adapter in qemu ... ESP: There is no scatter-gather support in the hardware. So for larg

Re: BUG with Win7 and user-return-notifier

2009-10-28 Thread Jan Kiszka
Avi Kivity wrote: > On 10/27/2009 03:25 PM, Avi Kivity wrote: >> On 10/27/2009 03:24 PM, Avi Kivity wrote: >>> Worked for me - getting to the initial prompt. Do you have >>> >>>CONFIG_USER_RETURN_NOTIFIER=y >>> >>> in your .config? >>> >> If you do, send your own .config, will try to reproduce

[PULL REQUEST] merge latest upstream qemu networking bits

2009-10-28 Thread Mark McLoughlin
Hey, Below is a pull request to merge latest qemu.git/master into qemu-kvm.git/next The most notable thing here is that all our networking changes are now upstream - i.e. there are no longer qemu-kvm specific changes to net.[ch], net-queue.[ch], savevm.c and hw/virtio-net.c This has resulted in

block virtio excessive VIRTIO_PCI_ISR reads

2009-10-28 Thread Saul Tamari
Hi, There seems to be a bug in the VirtIO guest device driver (tested with 2.6.31.5 kernel). The bug causes frequent & excessive VIRTIO_PCI_ISR reads (causing PIO vm-exits) for a device that is not being used. The setup I’m using includes two VirtIO block devices – vda & vdb. While running heavy

TG3, kvm, ipv6 & tso data corruption bug?

2009-10-28 Thread Rik van Riel
I have been tracking down what I thought was a KVM related network issue for a while, however it appears it could be a hardware issue. The symptom is that data in network packets gets corrupted, before the checksum is calculated. This means the remote host can get corrupted data, with no way to

Re: block virtio excessive VIRTIO_PCI_ISR reads

2009-10-28 Thread Anthony Liguori
Saul Tamari wrote: Hi, There seems to be a bug in the VirtIO guest device driver (tested with 2.6.31.5 kernel). The bug causes frequent & excessive VIRTIO_PCI_ISR reads (causing PIO vm-exits) for a device that is not being used. The setup I’m using includes two VirtIO block devices – vda & vdb.

Re: block virtio excessive VIRTIO_PCI_ISR reads

2009-10-28 Thread Michael Tokarev
Anthony Liguori wrote: Saul Tamari wrote: Hi, There seems to be a bug in the VirtIO guest device driver (tested with 2.6.31.5 kernel). The bug causes frequent & excessive VIRTIO_PCI_ISR reads (causing PIO vm-exits) for a device that is not being used. The setup I’m using includes two VirtIO bl

Re: block virtio excessive VIRTIO_PCI_ISR reads

2009-10-28 Thread Saul Tamari
yep! What do I have to do to turn on MSI-x? Make this PCI capability in QEMU's virtio?? Thanks, Saul On Wed, Oct 28, 2009 at 4:59 PM, Michael Tokarev wrote: [snip] > > So the next question is how to use MSI-x.. ;) > > Thanks! > > /mjt > -- To unsubscribe from this list: send the line "unsubsc

Re: xp guest, blue screen c0000221 on boot

2009-10-28 Thread Andrew Olney
Thanks. In pursuing this suggestion I discovered that I also can't make new XP VMs. Setup fails with "the disk may be damaged". The image was created with qemu-img create xp_new.img 13G And the setup command is kvm -cdrom xp/xp_pro.iso -hda xp_new.img -boot d -m 512 -no-acpi -usb -usbdevice

Re: xp guest, blue screen c0000221 on boot

2009-10-28 Thread Avi Kivity
On 10/28/2009 05:27 PM, Andrew Olney wrote: Thanks. In pursuing this suggestion I discovered that I also can't make new XP VMs. Setup fails with "the disk may be damaged". The image was created with qemu-img create xp_new.img 13G And the setup command is kvm -cdrom xp/xp_pro.iso -hda xp_new.

[PATCH] x86: Make sure get_user_desc() doesn't sign extend.

2009-10-28 Thread Chris Lalancette
The current implementation of get_user_desc() sign extends the return value because of integer promotion rules. For the most part, this doesn't matter, because the top bit of base2 is usually 0. If, however, that bit is 1, then the entire value will be 0x... which is probably not what the cal

Re: xp guest, blue screen c0000221 on boot

2009-10-28 Thread Yaniv Kaul
On 10/28/2009 5:27 PM, Andrew Olney wrote: Thanks. In pursuing this suggestion I discovered that I also can't make new XP VMs. Setup fails with "the disk may be damaged". The image was created with qemu-img create xp_new.img 13G And the setup command is kvm -cdrom xp/xp_pro.iso -hda xp_new.i

Re: vhost-net patches

2009-10-28 Thread Michael S. Tsirkin
On Tue, Oct 27, 2009 at 09:36:18AM -0700, Shirley Ma wrote: > Hello Michael, > > On Tue, 2009-10-27 at 17:27 +0200, Michael S. Tsirkin wrote: > > Possibly GFP_ATOMIC allocations in vring_add_indirect are failing? > > Is there a chance you are tight on guest memory for some reason? > > with vhost,

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
- "Lucas Meneghel Rodrigues" wrote: > One thing that just occurred to me is, if we have a test config > "library" as you said, it's perfectly possible to put the actual test > set definitions and other config files inside the control file as > strings. This way one can control configuration

Re: block virtio excessive VIRTIO_PCI_ISR reads

2009-10-28 Thread Saul Tamari
BTW. The kernel I'm using has MSI-x support enabled and this same thing also occurs on the default FC11 2.6.29.4-167 kernel. Below is a partial dump of 'lspci -vv'. I only pasted the output from the virtio networking device and from the virtio block device. You can notice that the block device doe

Re: vhost-net patches

2009-10-28 Thread Shirley Ma
On Tue, 2009-10-27 at 22:58 +0200, Michael S. Tsirkin wrote: > How large is large here? I usually allocate 1G. I used to have 512, for this run I allocated 1G. > > I do see performance improves to 3xxxMb/s, and occasionally > > reaches 40xxMb/s. > > This is same as userspace, isn't it? A little

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
One more comment on this patch: If you plan to make 'noinstall' the default build mode, then let's not run the build test at all by default. If we run it with 'noinstall', it will just run the preprocessor and postprocessor, and those will kill any living VMs because no VMs are required for the b

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Lucas Meneghel Rodrigues
On Wed, Oct 28, 2009 at 1:43 PM, Michael Goldish wrote: > Sounds great, except it won't allow you to debug your configuration > using kvm_config.py.  So the question now is what's more important -- > the ability to debug or ease of use when running from the server. Here we have 2 use cases: 1) U

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Lucas Meneghel Rodrigues
On Wed, Oct 28, 2009 at 1:57 PM, Michael Goldish wrote: > One more comment on this patch: > > If you plan to make 'noinstall' the default build mode, then let's > not run the build test at all by default.  If we run it with 'noinstall', > it will just run the preprocessor and postprocessor, and th

Re: BUG with Win7 and user-return-notifier

2009-10-28 Thread Avi Kivity
On 10/28/2009 04:01 PM, Jan Kiszka wrote: Avi Kivity wrote: On 10/27/2009 03:25 PM, Avi Kivity wrote: On 10/27/2009 03:24 PM, Avi Kivity wrote: Worked for me - getting to the initial prompt. Do you have CONFIG_USER_RETURN_NOTIFIER=y in your .config? If you

Re: [PATCH 5/5] Nested VMX patch 5 implements vmlaunch and vmresume

2009-10-28 Thread Orit Wasserman
Gleb Natapov wrote on 25/10/2009 11:44:31: > From: > > Gleb Natapov > > To: > > Orit Wasserman/Haifa/i...@ibmil > > Cc: > > Abel Gordon/Haifa/i...@ibmil, aligu...@us.ibm.com, Ben-Ami Yassour1/ > Haifa/i...@ibmil, kvm@vger.kernel.org, md...@us.ibm.com, Muli Ben- > Yehuda/Haifa/i...@ibmil > > Da

Re: TG3, kvm, ipv6 & tso data corruption bug?

2009-10-28 Thread Matt Carlson
On Wed, Oct 28, 2009 at 07:46:55AM -0700, Rik van Riel wrote: > I have been tracking down what I thought was a KVM related network > issue for a while, however it appears it could be a hardware issue. > > The symptom is that data in network packets gets corrupted, before > the checksum is calculat

Re: vhost-net patches

2009-10-28 Thread Shirley Ma
Hello Michael, On Wed, 2009-10-28 at 17:39 +0200, Michael S. Tsirkin wrote: > Here's another hack to try. It will break raw sockets, > but just as a test: This patch looks better than previous one for guest to host TCP_STREAM performance. The transmission queue full still exists, but TCP_STREAM r

kvm memory leak (Was Re: vhost-net patches)

2009-10-28 Thread Michael S. Tsirkin
On Tue, Oct 27, 2009 at 09:36:18AM -0700, Shirley Ma wrote: > Hello Michael, > > On Tue, 2009-10-27 at 17:27 +0200, Michael S. Tsirkin wrote: > > Possibly GFP_ATOMIC allocations in vring_add_indirect are failing? > > Is there a chance you are tight on guest memory for some reason? > > with vhost,

Re: [Autotest] [PATCH] KVM Test: Add re.IGNORECASE to re.compile to verify_ip_address_ in kvm_utils.py

2009-10-28 Thread Lucas Meneghel Rodrigues
Thanks guys, applied! On Wed, Oct 28, 2009 at 7:30 AM, Cao, Chen wrote: > On Wed, Oct 28, 2009 at 03:20:41AM -0400, Michael Goldish wrote: >> Thanks for catching this. >> While we're at it, why not remove the 2 occurrences of re.IGNORECASE >> that have no effect? > > I just chose to ignore the co

Re: vhost-net patches

2009-10-28 Thread Michael S. Tsirkin
On Wed, Oct 28, 2009 at 09:45:37AM -0700, Shirley Ma wrote: > Hello Michael, > > On Wed, 2009-10-28 at 17:39 +0200, Michael S. Tsirkin wrote: > > Here's another hack to try. It will break raw sockets, > > but just as a test: > > This patch looks better than previous one for guest to host TCP_STRE

[RFC] allow userspace to set MSR no-ops

2009-10-28 Thread David Windsor
Hi, I've encountered a situation in which I would like to allow userspace to set the MSRs which KVM should not emulate and instead implement these as no-ops. I have not seen any work in this space, furthermore there is an item on the KVM TODO that is very similar to what I'm trying to do. The us

Re: [ANNOUNCE] kvm-kmod-2.6.31.5

2009-10-28 Thread Jan Kiszka
Dietmar Maurer wrote: >> Do you know if there is anything to tell this ubuntu-patched kernel >> apart from a vanilla version? If so, we could adjust the check in >> x86/external-module-compat.h to avoid this breakage. > > no, not really OK, but I think I have a plan B. The next kvm-kmod release

KVM virtio network performance on RHEL5.4

2009-10-28 Thread Tom Lendacky
I've been trying to understand why the performance from guest to guest over a 10GbE link using virtio, as measured by netperf, dramatically decreases when the socket buffer size is increased on the receiving guest. This is an Intel X3210 4-core 2.13GHz system running RHEL5.4. I don't see this

Re: vhost-net patches

2009-10-28 Thread Arnd Bergmann
On Monday 26 October 2009, Shirley Ma wrote: > On Sun, 2009-10-25 at 11:11 +0200, Michael S. Tsirkin wrote: > > What is vnet0? > > That's a tap interface. I am binding raw socket to a tap interface and > it doesn't work. Does it support? Is the tap device connected to a bridge as you'd normally

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
- "Lucas Meneghel Rodrigues" wrote: > On Wed, Oct 28, 2009 at 1:43 PM, Michael Goldish > wrote: > > Sounds great, except it won't allow you to debug your configuration > > using kvm_config.py.  So the question now is what's more important > -- > > the ability to debug or ease of use when ru

Re: vhost-net patches

2009-10-28 Thread Shirley Ma
Hello Miachel, On Wed, 2009-10-28 at 18:53 +0200, Michael S. Tsirkin wrote: > what exactly do you mean by transmission queue size? > tx_queue_len? > I think what should help with transmission queue full is > actually sndbuf parameter for tap in qemu. I didn't see my email out, I resend the respon

Re: vhost-net patches

2009-10-28 Thread Shirley Ma
Hello Arnd, On Wed, 2009-10-28 at 18:46 +0100, Arnd Bergmann wrote: > You can probably connect it like this: > > qemu - vhost_net - vnet0 == /dev/tun - qemu > > To connect two guests. > > I've also used a bidirectional pipe before, to connect two tap > interfaces to each other. However, if you

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Ryan Harper
* Michael Goldish [2009-10-28 10:43]: > > - "Lucas Meneghel Rodrigues" wrote: > > > One thing that just occurred to me is, if we have a test config > > "library" as you said, it's perfectly possible to put the actual test > > set definitions and other config files inside the control file as

Re: [Autotest] [PATCH] KVM test: Add new program cd_hash.py

2009-10-28 Thread Michael Goldish
- "Lucas Meneghel Rodrigues" wrote: > A new program that evaluates hash strings, intended > to help kvm autotest administrators was added, cd_hash. > > Usage: cd_hash.py [options] > > Options: > -h, --helpshow this help message and exit > -i FILENAME, --iso=FILENAME >

Re: [RFC] allow userspace to set MSR no-ops

2009-10-28 Thread Richard Winthers
Is this interface supposed to support changing MSR handing at runtime or is the ioctl only meant to be called prior to KVM_RUN? Thanks, Richard On Wed, Oct 28, 2009 at 1:23 PM, David Windsor wrote: > > Hi, > > I've encountered a situation in which I would like to allow userspace > to set the MSR

[PATCH] KVM: Reorder IOCTLs in main kvm.h

2009-10-28 Thread Jan Kiszka
Obviously, people tend to extend this header at the bottom - more or less blindly. Ensure that deprecated stuff gets its own corner again by moving things to the top. Also add some comments and reindent IOCTLs to make them more readable and reduce the risk of number collisions. Signed-off-by: Jan

Re: [Qemu-devel] [PATCH 3/4] scsi-disk: Factor out SCSI command emulation

2009-10-28 Thread Hannes Reinecke
Am Wed 28 Oct 2009 09:42:47 AM CET schrieb Christoph Hellwig : On Tue, Oct 27, 2009 at 04:28:59PM +0100, Hannes Reinecke wrote: Other drives might want to use SCSI command emulation without going through the SCSI disk abstraction, as this imposes too many limits on the emulation. Might be a

[RFC] allow userspace to set MSR no-ops

2009-10-28 Thread David Windsor
Hi, I've encountered a situation in which I would like to allow userspace to set the MSRs which KVM should not emulate and instead implement these as no-ops. I have not seen any work in this space, furthermore there is an item on the KVM TODO that is very similar to what I'm trying to do. The us

qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-28 Thread Dustin Kirkland
I believe that we have identified a regression in qemu-kvm-0.11.0. The kvm process crashes for older guests with virtio networking, when the guest's incoming network connection is saturated. The subject guest is Ubuntu 8.04 Hardy, 2.6.24 kernel with virtio backports. For your convenience, I have

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-28 Thread Hannes Reinecke
Am Wed 28 Oct 2009 02:58:33 PM CET schrieb Gerd Hoffmann : Hi, From a really quick view fixing up the data xfer code paths doesn't look too bad. Think I'll give it a try. Oh well. The interface pretty obviously designed for the esp, which is the oldest scsi adapter in qemu ... ESP: There

Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-28 Thread Dustin Kirkland
On Wed, Oct 28, 2009 at 2:22 PM, Dustin Kirkland wrote: > I have not reproduced the problem: >  a) by saturating the guest's outgoing network >  b) with newer guests ( >= 2.6.27 ) >  c) on kvm-84 on the host d) or by using e1000, or rtl8139 NIC models. :-Dustin -- To unsubscribe from this list:

Re: [Autotest] [PATCH] KVM test: Add new program cd_hash.py

2009-10-28 Thread Lucas Meneghel Rodrigues
You do have a point. I will fix both programs to not use flags and send it to the mailing list. On Wed, Oct 28, 2009 at 4:23 PM, Michael Goldish wrote: > > - "Lucas Meneghel Rodrigues" wrote: > >> A new program that evaluates hash strings, intended >> to help kvm autotest administrators was

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Lucas Meneghel Rodrigues
Ryan, Michael: I absolutely agree that the ability to debug stuff is important, but the ability to make things straightforward to use from the web interface or cli is also important. A longer term goal is to have our test farm and make any developer able to schedule a job on the test farm easily a

Re: BUG with Win7 and user-return-notifier

2009-10-28 Thread Jan Kiszka
Avi Kivity wrote: > On 10/28/2009 04:01 PM, Jan Kiszka wrote: >> Avi Kivity wrote: >> >>> On 10/27/2009 03:25 PM, Avi Kivity wrote: >>> On 10/27/2009 03:24 PM, Avi Kivity wrote: > Worked for me - getting to the initial prompt. Do you have > > CONFIG_USER_RE

[patch 3/3] KVM: only clear irq_source_id if irqchip is present

2009-10-28 Thread Marcelo Tosatti
Otherwise kvm might attempt to dereference a NULL pointer. Signed-off-by: Marcelo Tosatti Index: kvm/virt/kvm/irq_comm.c === --- kvm.orig/virt/kvm/irq_comm.c +++ kvm/virt/kvm/irq_comm.c @@ -243,6 +243,10 @@ void kvm_free_irq_source_

[patch 2/3] KVM: x86: disallow KVM_{SET,GET}_LAPIC without allocated in-kernel lapic

2009-10-28 Thread Marcelo Tosatti
Otherwise kvm might attempt to dereference a NULL pointer. Signed-off-by: Marcelo Tosatti Index: kvm/arch/x86/kvm/x86.c === --- kvm.orig/arch/x86/kvm/x86.c +++ kvm/arch/x86/kvm/x86.c @@ -1893,6 +1893,9 @@ long kvm_arch_vcpu_ioctl(st

[patch 1/3] KVM: x86: disallow multiple KVM_CREATE_IRQCHIP

2009-10-28 Thread Marcelo Tosatti
Otherwise kvm will leak memory on multiple KVM_CREATE_IRQCHIP. Also serialize multiple accesses with kvm->lock. Signed-off-by: Marcelo Tosatti Index: kvm/arch/x86/kvm/x86.c === --- kvm.orig/arch/x86/kvm/x86.c +++ kvm/arch/x86/kvm/x

[patch 0/3] ioctl fixes v2

2009-10-28 Thread Marcelo Tosatti
Addressing comments. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
It's OK to log the debug output when running the framework, but Ryan says he makes heavy use of kvm_config.py, which means he may not find this comfortable enough. Ryan, what do you think? Another option is to allow editing any file from the web GUI in addition to the control file. I don't think

Re: vhost-net patches

2009-10-28 Thread Shirley Ma
Hello Michael, When I am testing deferring skb allocation patch, I found this problem. Simply removing and reloading guest virtio_net module would cause guest exit with errors. It is easy to reproduce it: [r...@localhost ~]# rmmod virtio_net [r...@localhost ~]# modprobe virtio_net vhost_net_ini

Re: [RFC] allow userspace to set MSR no-ops

2009-10-28 Thread David Windsor
It is intended to be used only during startup, typically by a launcher that is aware which MSRs should be emulated as no-ops. On Wed, Oct 28, 2009 at 2:28 PM, Richard Winthers wrote: > Is this interface supposed to support changing MSR handing at runtime or is > the ioctl only meant to be called

CPU change causes hanging of .NET apps

2009-10-28 Thread Erik Rull
Hi all, when changing the CPU from the default QEMU32 one to e.g. the n270 or the core2duo no .NET apps will work under Windows XP as guest. Switching back and everything is fine. The Pentium Emulation on the other side works fine! The Application loads but it hangs with 99% CPU usage and ca.

Interrupt Assignment on host

2009-10-28 Thread Erik Rull
Hi all, after several tests it seems that the interrupt assignment on the host systems influences the kvm performance drastically. If eth0, video and usb are on seperate interrupts the perfomance is way better than if they are shared (that means on the same one). Normally this should not matter.

Re: CPU change causes hanging of .NET apps

2009-10-28 Thread Javier Guerra
On Wed, Oct 28, 2009 at 4:13 PM, Erik Rull wrote: > Any Ideas what happens here? I also started applications that were NOT > started with the QEMU32 CPU to prevent a caching - same problem. just a couple guesses: - maybe there's some JIT'ed code cached somewhere in the filesystem - maybe the ex

Re: [PATCH v2] fix qemu-kvm sigsegv at exit

2009-10-28 Thread Marcelo Tosatti
On Wed, Oct 28, 2009 at 11:42:56AM +0200, Avi Kivity wrote: > On 10/27/2009 05:33 PM, Marcelo Tosatti wrote: >> Michael reported a qemu-kvm SIGSEGV at shutdown: >> >> Program received signal SIGSEGV, Segmentation fault. >> [Switching to Thread 0x411d0940 (LWP 14446)] >> 0x0040afb4 in qemu_m

kvm-kmod broken with user-return-notifiers

2009-10-28 Thread Zachary Amsden
With current upstream changes, VMX operation now relies on have the user-notifiers infrastructure. This makes kvm-kmod use on older kernels untenable. I looked a bit at fixing the underlying problem by simulating the user-return callback when we context switch, but it is uglier than I would

Re: CPU change causes hanging of .NET apps

2009-10-28 Thread Brian Jackson
On Wednesday 28 October 2009 16:13:37 Erik Rull wrote: > Hi all, > > when changing the CPU from the default QEMU32 one to e.g. the n270 or the > core2duo no .NET apps will work under Windows XP as guest. Switching back > and everything is fine. The Pentium Emulation on the other side works fine!

Re: [PATCH 17/27] Make head_64.S aware of KVM real mode code

2009-10-28 Thread Benjamin Herrenschmidt
On Wed, 2009-10-21 at 17:03 +0200, Alexander Graf wrote: > We need to run some KVM trampoline code in real mode. Unfortunately, real mode > only covers 8MB on Cell so we need to squeeze ourselves as low as possible. > > Also, we need to trap interrupts to get us back from guest state to host state

Re: [PATCH 18/27] Add Book3s_64 offsets to asm-offsets.c

2009-10-28 Thread Benjamin Herrenschmidt
On Wed, 2009-10-21 at 17:03 +0200, Alexander Graf wrote: > We need to access some VCPU fields from assembly code. In order to get > the proper offsets, we have to define them in asm-offsets.c. > > Signed-off-by: Alexander Graf Acked-by: Benjamin Herrenschmidt > --- > arch/powerpc/kernel/asm-o

Re: [PATCH 19/27] Export symbols for KVM module

2009-10-28 Thread Benjamin Herrenschmidt
On Wed, 2009-10-21 at 17:03 +0200, Alexander Graf wrote: > We want to be able to build KVM as a module. To enable us doing so, we > need some more exports from core Linux parts. > > This patch exports all functions and variables that are required for KVM. > > Signed-off-by: Alexander Graf Acked

Re: [PATCH 20/27] Split init_new_context and destroy_context

2009-10-28 Thread Benjamin Herrenschmidt
On Wed, 2009-10-21 at 17:03 +0200, Alexander Graf wrote: > For KVM we need to allocate a new context id, but don't really care about > all the mm context around it. > > So let's split the alloc and destroy functions for the context id, so we can > grab one without allocating an mm context. No obj

Re: [PATCH 22/27] Add fields to PACA

2009-10-28 Thread Benjamin Herrenschmidt
On Wed, 2009-10-21 at 17:03 +0200, Alexander Graf wrote: > For KVM we need to store some information in the PACA, so we > need to extend it. > > This patch adds KVM SLB shadow related entries to the PACA and > a field that indicates if we're inside a guest. > > Signed-off-by: Alexander Graf > --

  1   2   >