Re: [FIX REQUEST] Need better management for include/linux/*.h

2009-07-12 Thread Avi Kivity
On 07/11/2009 12:18 PM, Jaswinder Singh Rajput wrote: Hello all, As include/linux/*.h file count is going to reach 1000. We need to do some better techniques to reduce the number of files and add some hierarchy levels like sub directories where possible. Like atmel is not exporting to user-spa

Re: question about arch/s390/kvm/interrupt.c

2009-07-12 Thread Avi Kivity
(copying some s390 people) On 07/10/2009 02:47 PM, Julia Lawall wrote: In a recent version of linux-next, the function kvm_s390_handle_wait contains the following code: add_wait_queue(&vcpu->arch.local_int.wq,&wait); while (list_empty(&vcpu->arch.local_int.list)&&

Re: [PATCH v2] add KVM module parameters documentation

2009-07-12 Thread Avi Kivity
On 07/10/2009 03:20 PM, Andre Przywara wrote: Signed-off-by: Andre Przywara Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordom

Re: [Qemu-devel] Planning for the 0.11.0 release

2009-07-12 Thread Avi Kivity
On 07/10/2009 08:06 PM, Anthony Liguori wrote: BTW, this is one of the challenges of doing pulls. I did the pull and then deleted every qemu-io patch in my queue since I assumed that everything that should go in was part of hch's pull request. In general, that's the only sane way to do pulls

Re: slow guest performance with build load, looking for ideas

2009-07-12 Thread Avi Kivity
On 07/09/2009 09:01 PM, Erik Jacobson wrote: Please drop -usbdevice tablet and set the host I/O scheduler to deadline. Add cache=none to the -drive options. yes, these changes make a difference. Before starting qemu-kvm, I did this to change the IO scheduler: BEFORE: # for f in /sys/

Re: [KVM PATCH v10 2/2] KVM: add ioeventfd support

2009-07-12 Thread Avi Kivity
On 07/09/2009 06:00 PM, Gregory Haskins wrote: + bool wildcard = args->flags& KVM_IOEVENTFD_FLAG_DATAMATCH ? + true : false; Doh! Inverted logic. "wildcard" should be "false" if DATAMATCH is defined in the flags. Avi, please reverse true/false her

Re: [KVM PATCH v10 0/2] ioeventfd (formerly iosignalfd)

2009-07-12 Thread Avi Kivity
On 07/08/2009 12:08 AM, Gregory Haskins wrote: (Applies to kvm.git/master:3abaf217) This is v10 of the series. For more details, please see the header to patch 2/2. This series has been tested against the kvm-eventfd unit test, and appears to be functioning properly. You can download this tes

Re: [PATCH] remove leftover:

2009-07-12 Thread Avi Kivity
On 07/08/2009 03:34 PM, Glauber Costa wrote: get rid of kvm_callbacks structure definition Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.o

Re: [FIX REQUEST] Need better management for include/linux/*.h

2009-07-12 Thread Andi Kleen
Jaswinder Singh Rajput writes: > Hello all, > > As include/linux/*.h file count is going to reach 1000. > > We need to do some better techniques to reduce the number of files and > add some hierarchy levels like sub directories where possible. Why? 100 or 1000 really doesn't make much difference

Re: [PATCH v2 0/9] Move closer to upstream

2009-07-12 Thread Avi Kivity
On 07/10/2009 11:17 PM, Glauber Costa wrote: Hi, This is another step at getting us closer to qemu upstream. I'm getting rid of USE_KVM, replacing it with the combination of KVM_UPSTREAM and CONFIG_KVM The goal is to slowly reduce that isolation. To demonstrate what I aim for, the last patches

Re: Tap initialization

2009-07-12 Thread Avi Kivity
On 07/08/2009 08:17 AM, Stephane Bakhos wrote: I've been having some problem with recent releases when it comes to tap initialization. It seems that the script is ran after the tap is opened. I think this is a bit weird and useless as I want the script to setup the tap by itself. In net.

Re: [PATCH v2 9/9] reuse upstream breakpoint code

2009-07-12 Thread Gleb Natapov
On Fri, Jul 10, 2009 at 04:18:00PM -0400, Glauber Costa wrote: > Drop KVM_UPSTREAM around functions we intend to reuse. > This allow us to share code in kvm-all.c, that is equal in qemu-kvm.c > Can we push on_vcpu() to upstream? Then we will be able to reuse kvm_update_guest_debug() from upstream

Re: [PATCH] kvm/mmu: fix MMU_DEBUG compile breakage

2009-07-12 Thread Avi Kivity
On 07/09/2009 05:36 PM, Joerg Roedel wrote: Signed-off-by: Joerg Roedel Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [PATCH] Move irq routing data structure to rcu locking

2009-07-12 Thread Avi Kivity
On 07/09/2009 04:13 PM, Gleb Natapov wrote: Change it from list to array to make RCU handling simpler. Signed-off-by: Gleb Natapov diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index f54a0d3..12d8d2b 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -161,

Re: [PATCH] Move irq routing data structure to rcu locking

2009-07-12 Thread Gleb Natapov
On Sun, Jul 12, 2009 at 12:50:05PM +0300, Avi Kivity wrote: > On 07/09/2009 04:13 PM, Gleb Natapov wrote: >> Change it from list to array to make RCU handling simpler. >> >> Signed-off-by: Gleb Natapov >> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h >> index f54a0d3..12d8d2b 100

Re: [autotest] [PATCH 1/6] add ebizzy in autotest

2009-07-12 Thread sudhir kumar
On Sat, Jul 11, 2009 at 6:05 AM, Martin Bligh wrote: > On Fri, Jul 10, 2009 at 4:29 AM, sudhir kumar wrote: >> So is there any plan for adding this patch set in the patch queue? I >> would love to incorporate all the comments if any. > > Yup, just was behind on patches. > > I added it now - the mai

Re: [PATCH] Move exception handling to the same place as other events.

2009-07-12 Thread Avi Kivity
On 07/09/2009 03:33 PM, Gleb Natapov wrote: Signed-off-by: Gleb Natapov Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [PATCH] Reduce interface between kvm general and kvm arch.

2009-07-12 Thread Avi Kivity
On 07/09/2009 03:33 PM, Gleb Natapov wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 05b6bc7..cf20dc1 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1666,9 +1666,7 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu) for (;;) { prepare_to_wait

Re: [PATCH] Reduce interface between kvm general and kvm arch.

2009-07-12 Thread Gleb Natapov
On Sun, Jul 12, 2009 at 02:03:17PM +0300, Avi Kivity wrote: > On 07/09/2009 03:33 PM, Gleb Natapov wrote: >> >> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c >> index 05b6bc7..cf20dc1 100644 >> --- a/virt/kvm/kvm_main.c >> +++ b/virt/kvm/kvm_main.c >> @@ -1666,9 +1666,7 @@ void kvm_vcpu_bl

Re: [PATCH] kvm_cpu_get_interrupt() is implemented only by x86.

2009-07-12 Thread Avi Kivity
On 07/09/2009 03:33 PM, Gleb Natapov wrote: Move it from global .h file to arch/x86 Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] IRQ was moved to its own lock.

2009-07-12 Thread Avi Kivity
On 07/09/2009 03:33 PM, Gleb Natapov wrote: Signed-off-by: Gleb Natapov Applied, thanks. Please copy kvm-ia64 on ia64 patches. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majo

Re: [PATCH] Reduce interface between kvm general and kvm arch.

2009-07-12 Thread Avi Kivity
On 07/12/2009 02:02 PM, Gleb Natapov wrote: s390 has: int kvm_arch_vcpu_runnable(struct kvm_vcpu *vcpu) { /* kvm common code refers to this, but never calls it */ BUG(); return 0; } So this needs to be updated. Please coordinate with the s390 folks. s390 never calls kv

Re: [PATCH] Move irq routing data structure to rcu locking

2009-07-12 Thread Avi Kivity
On 07/12/2009 01:07 PM, Gleb Natapov wrote: On Sun, Jul 12, 2009 at 12:50:05PM +0300, Avi Kivity wrote: On 07/09/2009 04:13 PM, Gleb Natapov wrote: Change it from list to array to make RCU handling simpler. Signed-off-by: Gleb Natapov diff --git a/include/linux/kvm_host.h b/include/l

[PATCH 3/4] Move irq ack notifier list to arch independent code.

2009-07-12 Thread Gleb Natapov
Mask irq notifier list is already there. Signed-off-by: Gleb Natapov --- arch/ia64/include/asm/kvm_host.h |1 - arch/x86/include/asm/kvm_host.h |1 - include/linux/kvm_host.h |1 + virt/kvm/irq_comm.c |4 ++-- virt/kvm/kvm_main.c |1 + 5 fil

[PATCH 1/4] Move irq routing data structure to rcu locking

2009-07-12 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- include/linux/kvm_host.h |2 +- virt/kvm/irq_comm.c | 55 +- virt/kvm/kvm_main.c |1 - 3 files changed, 26 insertions(+), 32 deletions(-) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_hos

[PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-12 Thread Gleb Natapov
Use RCU locking for mask/ack notifiers lists. Signed-off-by: Gleb Natapov --- virt/kvm/irq_comm.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c index 5dde1ef..ba3a115 100644 --- a/virt/kvm/irq_comm.c +++ b/v

[PATCH 2/4] Unregister ack notifier callback on PIT freeing.

2009-07-12 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- arch/x86/kvm/i8254.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c index 8c3ac30..05e00a8 100644 --- a/arch/x86/kvm/i8254.c +++ b/arch/x86/kvm/i8254.c @@ -642,6 +642,8 @@ void kvm_free_pit(str

[PATCH 0/4] moving irq routing and notifiers to RCU locking

2009-07-12 Thread Gleb Natapov
Make PIT to unregister IRQ ack notifier. Move irq ack notifier list in teh same place where mask notifier list is. Gleb Natapov (4): Move irq routing data structure to rcu locking Unregister ack notifier callback on PIT freeing. Move irq ack notifier list to arch independent code. Convert

[PATCH] enable x2APIC without interrupt remapping under KVM

2009-07-12 Thread Gleb Natapov
KVM would like to provide x2APIC interface to a guest without emulating interrupt remapping device. The reason KVM prefers guest to use x2APIC is that x2APIC interface is better virtualizable and provides better performance than mmio xAPIC interface: - msr exits are faster than mmio (no page t

[PATCH] always report x2apic as supported feature

2009-07-12 Thread Gleb Natapov
We emulate x2apic in software, so host support is not required. Signed-off-by: Gleb Natapov diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 00844eb..c256da7 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -1497,6 +1497,9 @@ static void do_cpuid_ent(struct kvm_cpuid_entry2 *

Re: [PATCH] always report x2apic as supported feature

2009-07-12 Thread Avi Kivity
On 07/12/2009 04:10 PM, Gleb Natapov wrote: We emulate x2apic in software, so host support is not required. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord

[ANNOUNCE] kvm-88 release

2009-07-12 Thread Avi Kivity
kvm-87 wasn't so hot due to networking not working with rtl8139 and e1000. So kvm-88 fixes that and brings a bunch of new features (resizable sdl windows, multiboot, x2apic, and more). Enjoy. Changes from kvm-87: - merge upstream qemu.git - virtio indirect ring entries - improves block

[PATCH] remove unused structs from s390

2009-07-12 Thread Gleb Natapov
They are not used by common code without defines which s390 does not have. Signed-off-by: Gleb Natapov diff --git a/arch/s390/include/asm/kvm.h b/arch/s390/include/asm/kvm.h index 0b2f829..3dfcaeb 100644 --- a/arch/s390/include/asm/kvm.h +++ b/arch/s390/include/asm/kvm.h @@ -15,15 +15,6 @@ */

Re: [ANNOUNCE] kvm-88 release

2009-07-12 Thread Avi Kivity
On 07/12/2009 06:06 PM, John Rousseau wrote: On 07/12/2009 09:31 AM, Avi Kivity wrote: kvm-87 wasn't so hot due to networking not working with rtl8139 and e1000. So kvm-88 fixes that and brings a bunch of new features (resizable sdl windows, multiboot, x2apic, and more). Enjoy. Does anyone ha

Re: [ANNOUNCE] kvm-88 release

2009-07-12 Thread John Rousseau
On 07/12/2009 09:31 AM, Avi Kivity wrote: kvm-87 wasn't so hot due to networking not working with rtl8139 and e1000. So kvm-88 fixes that and brings a bunch of new features (resizable sdl windows, multiboot, x2apic, and more). Enjoy. Does anyone have this working with FC11? I installed FC11 o

Re: [ANNOUNCE] kvm-88 release (CAN NOT install modules on debian/amd64/2.6.30)

2009-07-12 Thread John Wong
when i make install, i see some warning message like this: WARNING: "__tracepoint_kvm_mmu_paging_element" [/ramdisk/kvm-88/kvm/kernel/x86/kvm.ko] undefined! WARNING: "__tracepoint_kvm_mmu_sync_page" [/ramdisk/kvm-88/kvm/kernel/x86/kvm.ko] undefined! WARNING: "__tracepoint_kvm_mmio" [/ramdisk/kvm

Re: [ANNOUNCE] kvm-88 release (CAN NOT install modules on debian/amd64/2.6.30)

2009-07-12 Thread Avi Kivity
On 07/12/2009 07:01 PM, John Wong wrote: when i insmod ./kvm.ko, i see the error message like this: sudo insmod ./kvm.ko insmod: error inserting './kvm.ko': -1 Unknown symbol in module and i can not load the modules on my debian/amd64 kernel-2.6.30 qemu-system-x86_64(kvm-88.tar.gz) is work on

Re: [ANNOUNCE] kvm-88 release

2009-07-12 Thread John Rousseau
On 07/12/2009 11:13 AM, Avi Kivity wrote: On 07/12/2009 06:06 PM, John Rousseau wrote: # /usr/local/bin/qemu-system-x86_64 -hda /home/jrr/vista-x86_64.img -m 1536M -net nic,vlan=0,macaddr=52:54:00:12:32:00 -net tap,vlan=0,ifname=tap1 -vga std -full-screen -smp 2 -usb -usbdevice tablet Can you

Re: R/W HG memory mappings with kvm?

2009-07-12 Thread Stephen Donnelly
On Sat, Jul 11, 2009 at 5:03 AM, Cam Macdonell wrote: > Oops, I realize now that I passed the driver patch both times.  Here is the > old patch. > > http://patchwork.kernel.org/patch/22363/ > > What are you compiling against?  the git tree or a particular version? The > above patch won't compile ag

Re: [autotest] [PATCH 1/6] add ebizzy in autotest

2009-07-12 Thread Lucas Meneghel Rodrigues
On Sun, Jul 12, 2009 at 7:08 AM, sudhir kumar wrote: > On Sat, Jul 11, 2009 at 6:05 AM, Martin Bligh wrote: >> On Fri, Jul 10, 2009 at 4:29 AM, sudhir kumar wrote: >>> So is there any plan for adding this patch set in the patch queue? I >>> would love to incorporate all the comments if any. >> >> Y

Re: [Autotest] [AUTOTEST] [PATCH 1/2] Add latest LTP test in autotest

2009-07-12 Thread sudhir kumar
On Tue, Jul 7, 2009 at 12:07 AM, Martin Bligh wrote: >>> Issues: LTP has a history of some of the testcases getting broken. > > Right, that's always the concern with doing this. > >>> Anyways >>> that has nothing to worry about with respect to autotest. One of the known >>> issue >>> is broken mem

[AUTOTEST] [PATCH 0/5] Add latest LTP test in autotest (v2)

2009-07-12 Thread sudhir kumar
Hi, Here is the version 2 of the patches to include latest ltp in autotest and enable execution under kvm guests. I have incorporated all the comments and approach. Please give a quick review and let me know if something better is to be done. Thanks -- Sudhir Kumar -- To unsubscribe from this lis

[AUTOTEST] [PATCH 1/5] update ltp.patch

2009-07-12 Thread sudhir kumar
This patch updates the ltp.patch in autotest to disable few testcases. This patch disables the default execution of some testcases which are either broken or are not required to be executed. If someone wants to execute only a subset of the testcases then one can update this patch to achieve the re

[AUTOTEST] [PATCH 2/5] add kvm_ltp.patch for kvm guests

2009-07-12 Thread sudhir kumar
Disable the testcases which are not required to be executed under kvm guests. This patch is specific to runs under kvm guests and will not be applied for bare metal runs. Therefore if one wants to include/exclude/whatever to the testruns can simply update this patch and things are done!! Signed-of

[AUTOTEST] [PATCH 3/5] add ltp control file for kvm guests

2009-07-12 Thread sudhir kumar
This patch adds the control file under kvm/autotest_control. Signed-off-by: Sudhir Kumar Index: autotest/client/tests/kvm/autotest_control/ltp.control === --- /dev/null +++ autotest/client/tests/kvm/autotest_control/ltp.control @@ -

[AUTOTEST] [PATCH 4/5] update ltp wrapper in autotest

2009-07-12 Thread sudhir kumar
This patch updates the ltp wrapper in autotest to execute the latest ltp. At present autotest contains ltp which is more than 1 year old. There have been added lots of testcases in ltp within this period. So this patch updates the wrapper to run the June2009 release of ltp. http://prdownloads.sourc

[AUTOTEST] [PATCH 5/5] view ltp_results.html under kvm guests' results.html

2009-07-12 Thread sudhir kumar
This patch creates a link to the results html file generated by the test under autotest. This is specific to the kvm part only. The assumption made is that the file name is _results.html and it is located under /results/ directory. This helps in quickly viewing the test results. The attached tar f