Jan Kiszka wrote:
Various fixes that were required to build against a 2.6.18 kernel, but
some affect newer kernels, too:
- replacements for uaccess.h and relay.h
- flush_work compat wrapper
- fix msi_enabled hack
- hack eventfd.c for INIT_WORK
Please split into separate patches.
Christian Ehrhardt wrote:
There already exists a loop which does this, see
make_all_cpus_request(). It uses an IPI (Marcelo, can't it use the
reschedule interrupt?). It has a couple of optimizations -- if the
request is already set, it skips the IPI, and it avoids the IPI for
vcpus out of
Marcelo Tosatti wrote:
On Mon, May 25, 2009 at 01:40:49PM +0200, ehrha...@linux.vnet.ibm.com wrote:
From: Christian Ehrhardt
To ensure vcpu's come out of guest context in certain cases this patch adds a
s390 specific way to kick them out of guest context. Currently it kicks them
out to reru
Josh Wilsdon wrote:
the kernel refuses to boot with the error message:
"This kernel requires an x86-64 CPU, but only detected an i686 CPU.
Unable to boot - please use a kernel appropriate for your CPU."
This should fix it:
http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commi
Eduardo Habkost wrote:
This will help distributions to package kvmtrace and kvmtrace_format, making
kvmtrace_format work out-of-the-box.
The directory is defined at the beginning of the script to make it easier for
distributions to customize the path at install-time, depending on packaging
param
Michael S. Tsirkin wrote:
On Tue, May 26, 2009 at 11:33:37AM +0900, Isaku Yamahata wrote:
On Mon, May 25, 2009 at 03:25:33PM +0300, Michael S. Tsirkin wrote:
Add inline routines for convenient access to pci devices
with correct (little) endianness. Will be used by MSI-X support.
Jan Kiszka wrote:
Well, if I look at the definition of MCI_STATUS_VAL as (1UL<<63),
something tells me: "Hey, only use me on 64-bit hosts!" But I have no
clue about details of this stuff, and from a second glance at it is
seems to include at least some parts that are valid on 32-bit as well.
Gleb Natapov wrote:
void kvm_arch_sync_events(struct kvm *kvm)
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 0934df3..34634e0 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -170,6 +170,17 @@ struct kvm {
#define kvm_printf(kvm, fmt ...) printk(K
On (Tue) May 26 2009 [10:49:35], Avi Kivity wrote:
> I had these two already, but not pushed. Maybe I need to have a script
> push my master branch somewhere, so you don't duplicate my work
> needlessly.
A 'next' branch that's the real bleeding-edge, while the patches get
tested and master get
Gleb Natapov wrote:
Signed-off-by: Gleb Natapov
---
arch/x86/kvm/i8254.c |2 +-
arch/x86/kvm/kvm_timer.h |2 +-
arch/x86/kvm/lapic.c |2 +-
arch/x86/kvm/timer.c |2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/
Avi Kivity wrote:
While I appreciate the efforts to add clean qemu/kvm integration in
upstream, it's driving me mad.
Every merge I'm faced with regressions (mostly due to changing code,
not to upstream breakage) and need to fix things. Work done during
merges is very likely to contain errors
Am Dienstag 26 Mai 2009 09:57:58 schrieb Avi Kivity:
> > I could add that behaviour, but that could make our normal interrupt
> > handling much slower. Therefore I don't want to call that function,
> > but on the other hand I like the "skip if the request is already set"
> > functionality and think
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Hi,
I've recently increased the number of guests (+20%) running on one of my
hosts and found that the responsiveness suffered.
Before that, the context switches were hovering around 10K, now they're
close to 30K. Or this could just be because I upgr
Gleb Natapov wrote:
Archs are free to use vcpu_id as they see fit. For x86 it is used as
vcpu's apic id.
You need a KVM_CAP to inform userspace that the vcpu id has changed meaning.
inline int kvm_is_mmio_pfn(pfn_t pfn)
{
if (pfn_valid(pfn)) {
@@ -1713,15 +1708,12 @@ static int
Michael S. Tsirkin wrote:
Implement bindings for virtio save/load. Use them in virtio pci.
Signed-off-by: Michael S. Tsirkin
---
Is anyone working to fill in load/save bindings so that saving virtio
devices works? Here's a trivial patch to do this (this one is on top of my
MSI-X patchset).
Com
On Mon, May 25, 2009 at 2:15 PM, Michael Goldish wrote:
>
> - "sudhir kumar" wrote:
>
>> The patch looks sane to me. A very good thing that can be done for
>> remote_login() is to tune the tmeouts. I have seen especialy with
>> windows guests or sometimes when the machine is heavily loaded th
On Tue, May 26, 2009 at 11:18:11AM +0300, Avi Kivity wrote:
> Gleb Natapov wrote:
>> void kvm_arch_sync_events(struct kvm *kvm)
>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
>> index 0934df3..34634e0 100644
>> --- a/include/linux/kvm_host.h
>> +++ b/include/linux/kvm_host.h
>
On Mon, May 25, 2009 at 03:25:20PM +0300, Michael S. Tsirkin wrote:
> Add routines to manage PCI capability list. First user will be MSI-X.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/pci.c | 98
> --
> hw/pci.h | 18 +
On Tue, May 26, 2009 at 11:30:21AM +0300, Avi Kivity wrote:
> Gleb Natapov wrote:
>> Signed-off-by: Gleb Natapov
>> ---
>> arch/x86/kvm/i8254.c |2 +-
>> arch/x86/kvm/kvm_timer.h |2 +-
>> arch/x86/kvm/lapic.c |2 +-
>> arch/x86/kvm/timer.c |2 +-
>> 4 files changed, 4
On Tue, May 26, 2009 at 11:07:33AM +0300, Avi Kivity wrote:
> Michael S. Tsirkin wrote:
>> On Tue, May 26, 2009 at 11:33:37AM +0900, Isaku Yamahata wrote:
>>
>>> On Mon, May 25, 2009 at 03:25:33PM +0300, Michael S. Tsirkin wrote:
>>>
Add inline routines for convenient access to pci dev
On Tue, May 26, 2009 at 11:34:01AM +0300, Avi Kivity wrote:
> Gleb Natapov wrote:
>> Archs are free to use vcpu_id as they see fit. For x86 it is used as
>> vcpu's apic id.
>>
>>
>
> You need a KVM_CAP to inform userspace that the vcpu id has changed meaning.
>
Will add.
>> inline int kvm_is_m
Gleb Natapov wrote:
+
+#define kvm_for_each_vcpu(idx, vcpup, kvm) \
+ for (idx = 0, vcpup = kvm_get_vcpu(kvm, idx); \
+idx < atomic_read(&kvm->online_vcpus) && vcpup; \
+vcpup = kvm_get_vcpu(kvm, ++idx))
+
This will stop when reaching the first em
Gleb Natapov wrote:
Don't the vcpu ioctls need to be updated? They get the vcpu id as a
parameter.
Are you sure they do? vcpu ioctls are issued on vcpu fd, no need to pass
vcpu id as a parameter.
You're right, I was confused with an earlier version of the interface,
and with
Avi Kivity wrote:
> Jan Kiszka wrote:
>> Various fixes that were required to build against a 2.6.18 kernel, but
>> some affect newer kernels, too:
>>
>>- replacements for uaccess.h and relay.h
>> - flush_work compat wrapper
>> - fix msi_enabled hack
>> - hack eventfd.c for INIT_WORK
>>
>
Antoine Martin wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Hi,
I've recently increased the number of guests (+20%) running on one of my
hosts and found that the responsiveness suffered.
How many guests? How many vcpus?
Before that, the context switches were hovering around 10
Jan Kiszka wrote:
Maybe I need to have a script
push my master branch somewhere, so you don't duplicate my work needlessly.
That would be highly appreciated.
I'm thinking how to do it. pushing requires an ssh key, and I don't
want to leave one around without a passphrase, which
Avi Kivity wrote:
> Jan Kiszka wrote:
>
>
>
>>> Maybe I need to have a script
>>> push my master branch somewhere, so you don't duplicate my work
>>> needlessly.
>>>
>>>
>>
>> That would be highly appreciated.
>>
>
> I'm thinking how to do it. pushing requires an ssh key, and I don't
On Tue, May 26, 2009 at 05:49:26PM +0900, Isaku Yamahata wrote:
> On Mon, May 25, 2009 at 03:25:20PM +0300, Michael S. Tsirkin wrote:
> > Add routines to manage PCI capability list. First user will be MSI-X.
> >
> > Signed-off-by: Michael S. Tsirkin
> > ---
> > hw/pci.c | 98
> > +
Christian Bornträger wrote:
Am Dienstag 26 Mai 2009 09:57:58 schrieb Avi Kivity:
I could add that behaviour, but that could make our normal interrupt
handling much slower. Therefore I don't want to call that function,
but on the other hand I like the "skip if the request is already set"
funct
Jan Kiszka wrote:
I'm thinking how to do it. pushing requires an ssh key, and I don't
want to leave one around without a passphrase, which would be required
by a cron job.
Any ideas?
Local commit hook that triggers the push (and ask you for the phrase
interactively)? But that also d
pci_find_capability_list has a bug so it'd stop at the first
capability. This only happens to work as we only support
a single capability (MSI-X). Here's a fix.
Found-by: Isaku Yamahata
Signed-off-by: Michael S. Tsirkin
---
This is a fixup for my patch "qemu: add routines to manage PCI
capabil
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
> Ah, -usbdevice tablet, interrupt generator from hell. Let it go and
> you'll see your context switch rate drop.
Indeed that solved it!
(only kept it for the one windows guest that really needs it)
Many many thanks.
>> - total-cpu-usage -d
Antoine Martin wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Ah, -usbdevice tablet, interrupt generator from hell. Let it go and
you'll see your context switch rate drop.
Indeed that solved it!
(only kept it for the one windows guest that really needs it)
Many many thanks.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Avi Kivity wrote:
> Antoine Martin wrote:
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA512
>>
>>
>>> Ah, -usbdevice tablet, interrupt generator from hell. Let it go and
>>> you'll see your context switch rate drop.
>>>
>> Indeed that sol
Gleb Natapov wrote:
It gets packet without virtio header and adds it if needed. Allows to
inject packets to vlan from outside. To send gracious arp for instance.
This is for announce_self(), no? If so, upstream has the same problems?
--
error compiling committee.c: too many arguments to f
It gets packet without virtio header and adds it if needed. Allows to
inject packets to vlan from outside. To send gracious arp for instance.
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 8e9178d..3c77b99 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -389,7 +389,7 @@ static int iov
Antoine Martin wrote:
Switching to a better vnc client (I use
vinagre) may allow you to drop it.
I thought I had tried them all in desperation (mouse going out of sync),
I'll try again.
Vinagre does mouse capture like SDL. It isn't perfect, but much better
than the standard vnc clien
On Tue, May 26, 2009 at 01:05:35PM +0300, Avi Kivity wrote:
> Gleb Natapov wrote:
>> It gets packet without virtio header and adds it if needed. Allows to
>> inject packets to vlan from outside. To send gracious arp for instance.
>>
>
> This is for announce_self(), no? If so, upstream has the
Gleb Natapov wrote:
On Tue, May 26, 2009 at 01:05:35PM +0300, Avi Kivity wrote:
Gleb Natapov wrote:
It gets packet without virtio header and adds it if needed. Allows to
inject packets to vlan from outside. To send gracious arp for instance.
This is for announce_self(), no?
> > -/* FIXME: load/save binding. */
> > -//pci_device_save(&vdev->pci_dev, f);
> > -//msix_save(&vdev->pci_dev, f);
>
> qdev regressed save/restore? What else is broken right now from the
> qdev commit?
>
> I'm beginning to think committing in the state it was in was a mistake.
> Pau
On Tue, 2009-05-26 at 13:11 +0300, Avi Kivity wrote:
> Gleb Natapov wrote:
> > On Tue, May 26, 2009 at 01:05:35PM +0300, Avi Kivity wrote:
> >
> >> Gleb Natapov wrote:
> >>
> >>> It gets packet without virtio header and adds it if needed. Allows to
> >>> inject packets to vlan from outside
Avi Kivity wrote:
Christian Bornträger wrote:
Am Dienstag 26 Mai 2009 09:57:58 schrieb Avi Kivity:
[...]
In our low-level interrupt handler we do check for signal_pending,
machine_check_pending and need_resched to leave the sie instruction.
For anything else a the host sees a cpu bound gue
On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote:
> It gets packet without virtio header and adds it if needed. Allows to
> inject packets to vlan from outside. To send gracious arp for instance.
Acked-by: Mark McLoughlin
This isn't ideal, but neither is the current VNET_HDR stuff and it d
Mark McLoughlin wrote:
On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote:
It gets packet without virtio header and adds it if needed. Allows to
inject packets to vlan from outside. To send gracious arp for instance.
Acked-by: Mark McLoughlin
This isn't ideal, but neither is the
Marcelo Tosatti wrote:
===
--- kvm-irqlock.orig/virt/kvm/coalesced_mmio.c
+++ kvm-irqlock/virt/kvm/coalesced_mmio.c
@@ -26,9 +26,12 @@ static int coalesced_mmio_in_range(struc
if (!is_write)
return 0;
-
Alexander Graf wrote:
Does it make sense to implement a generic mechanism for handling MSRs
in userspace? I imagine a mechanism analogous to PIO, adding a
KVM_EXIT_MSR code and a msr type in the kvm_run struct.
I'm happy to take a stab at implementing this if no one else is
already working on it
Marcelo Tosatti wrote:
On Sun, May 24, 2009 at 05:10:07PM +0300, Avi Kivity wrote:
Marcelo Tosatti wrote:
Subject says it all.
I hate those changelogs. I guess Subject never reviews code.
You might put some evidence that we're suffering from contention here
(I'm very will
Sheng Yang wrote:
We only trap one page for MSI-X entry now, so it's 4k/(128/8) = 256 entries at
most.
Applied, thanks.
-#define KVM_MAX_MSIX_PER_DEV 512
+#define KVM_MAX_MSIX_PER_DEV 256
struct kvm_assigned_msix_entry {
__u32 assigned_dev_id;
__u32 gsi;
Rusty Russell wrote:
On Tuesday 07 April 2009 00:49:17 Tomasz Chmielewski wrote:
Tomasz Chmielewski schrieb:
As I mentioned, it was using virtio net.
Guests running with e1000 (and virtio_blk) don't have this problem.
Also, virtio_console seem to be affected by this "slowness" issue.
I'm p
Signed-off-by: Jan Kiszka
---
external-module-compat-comm.h |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/external-module-compat-comm.h b/external-module-compat-comm.h
index e2342db..dad43ef 100644
--- a/external-module-compat-comm.h
+++ b/external-module-compat-com
In order to allow sync'ing the kmod dir against arbitrary kernels trees,
extend the sync script to accept alternative paths and adjust the
Makefile accordingly.
Changes in v2:
- drop KVM_VERSION override
- make use of set_defaults
- option help texts
Signed-off-by: Jan Kiszka
---
Makefile |
Signed-off-by: Jan Kiszka
---
external-module-compat-comm.h |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/external-module-compat-comm.h b/external-module-compat-comm.h
index d473ae7..e2342db 100644
--- a/external-module-compat-comm.h
+++ b/external-module-compat-com
eventfd.c has to be processed in order to wrap INIT_WORK.
Signed-off-by: Jan Kiszka
---
sync |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sync b/sync
index fc4311e..18f0200 100755
--- a/sync
+++ b/sync
@@ -124,7 +124,7 @@ def hack(T, arch, file):
hack_files = {
Signed-off-by: Jan Kiszka
---
external-module-compat-comm.h |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/external-module-compat-comm.h b/external-module-compat-comm.h
index dad43ef..131210a 100644
--- a/external-module-compat-comm.h
+++ b/external-module-compa
The is a flush of my current queue against kvm-kmod. Some are reposts,
some are split-ups, and a few are new (specifically the MCE fixes). I
did not include patches that you reported to have already in your queue.
Find the patches also at git://git.kiszka.org/kvm-kmod.git queue
Jan Kiszka (8):
Signed-off-by: Jan Kiszka
---
x86/external-module-compat.h |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h
index c33eb2e..cc984ab 100644
--- a/x86/external-module-compat.h
+++ b/x86/external-module-compat
Signed-off-by: Jan Kiszka
---
sync |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sync b/sync
index f3f4d6a..fc4311e 100755
--- a/sync
+++ b/sync
@@ -67,8 +67,8 @@ def __hack(data):
if match(r'^}'): kvm_arch_init = False
if match(r'MODULE_AUTHOR'):
Signed-off-by: Jan Kiszka
---
x86/external-module-compat.h |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h
index 3e6fc11..c33eb2e 100644
--- a/x86/external-module-compat.h
+++ b/x86/external-module-compat.h
@
Tomasz Chmielewski wrote:
I still observe this "slowness" with kvm-86 after the guest is running
for some time (virtio_net and virtio_console seem to be affected;
guest restart doesn't fix it).
Anything in guest dmesg?
--
error compiling committee.c: too many arguments to function
--
To
Jan Kiszka wrote:
The is a flush of my current queue against kvm-kmod. Some are reposts,
some are split-ups, and a few are new (specifically the MCE fixes). I
did not include patches that you reported to have already in your queue.
Find the patches also at git://git.kiszka.org/kvm-kmod.git queue
On Tue, May 26, 2009 at 02:15:37PM +0300, Avi Kivity wrote:
> Mark McLoughlin wrote:
>> On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote:
>>
>>> It gets packet without virtio header and adds it if needed. Allows to
>>> inject packets to vlan from outside. To send gracious arp for instance.
Avi Kivity wrote:
Tomasz Chmielewski wrote:
I still observe this "slowness" with kvm-86 after the guest is running
for some time (virtio_net and virtio_console seem to be affected;
guest restart doesn't fix it).
Anything in guest dmesg?
No.
No hints in syslog, dmesg...
Can it be that
Jan Kiszka wrote:
Signed-off-by: Jan Kiszka
---
x86/external-module-compat.h |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h
index c33eb2e..cc984ab 100644
--- a/x86/external-module-compat.h
+++ b/x86/ex
Tomasz Chmielewski wrote:
Avi Kivity wrote:
Tomasz Chmielewski wrote:
I still observe this "slowness" with kvm-86 after the guest is
running for some time (virtio_net and virtio_console seem to be
affected; guest restart doesn't fix it).
Anything in guest dmesg?
No.
No hints in syslog,
Gleb Natapov wrote:
On Tue, May 26, 2009 at 02:15:37PM +0300, Avi Kivity wrote:
Mark McLoughlin wrote:
On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote:
It gets packet without virtio header and adds it if needed. Allows to
inject packets to vlan from outside. To send gr
Hello Jan,
On Tue, 2009-05-26 at 13:52 +0200, Jan Kiszka wrote:
> Signed-off-by: Jan Kiszka
> ---
>
> x86/external-module-compat.h |4
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h
> index 3e6fc11..c33eb
Jes Sorensen wrote:
Ok,
Trying once more. After spending a couple of hours trying to follow
the QEMU dma codeflow, I have convinced myself Avi is right and those
two functions don't need to do the flushing as they all end up calling
dma_bdrv_cb() which calls dma_brdv_unmap(). I have added a coup
Jaswinder Singh Rajput wrote:
> Hello Jan,
>
> On Tue, 2009-05-26 at 13:52 +0200, Jan Kiszka wrote:
>> Signed-off-by: Jan Kiszka
>> ---
>>
>> x86/external-module-compat.h |4
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/x86/external-module-compat.h b/x86/extern
Jan Kiszka wrote:
I'm about to loose overview of all those issues I ran into with older
kernels (still more to fix, sigh), but I think to remember this was a
2.6.18 x86_32 problem. Wait... yes, 2.6.18 asm-i386 does not include this.
I have the same problem. I'll look at setting up automated
Avi Kivity wrote:
> Jan Kiszka wrote:
>> Signed-off-by: Jan Kiszka
>> ---
>>
>> x86/external-module-compat.h |8
>> 1 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h
>> index c33eb2e..cc984ab 100644
>> ---
On Tue, 2009-05-26 at 14:36 +0200, Jan Kiszka wrote:
> Jaswinder Singh Rajput wrote:
> > Hello Jan,
> >
> > On Tue, 2009-05-26 at 13:52 +0200, Jan Kiszka wrote:
> >> Signed-off-by: Jan Kiszka
> >> ---
> >>
> >> x86/external-module-compat.h |4
> >> 1 files changed, 4 insertions(+), 0 de
Jan Kiszka wrote:
> The is a flush of my current queue against kvm-kmod. Some are reposts,
> some are split-ups, and a few are new (specifically the MCE fixes). I
> did not include patches that you reported to have already in your queue.
>
> Find the patches also at git://git.kiszka.org/kvm-kmod.g
Avi Kivity wrote:
> Jan Kiszka wrote:
>> I'm about to loose overview of all those issues I ran into with older
>> kernels (still more to fix, sigh), but I think to remember this was a
>> 2.6.18 x86_32 problem. Wait... yes, 2.6.18 asm-i386 does not include
>> this.
>>
>
> I have the same problem
These defines are used by KVM now also on 32-bit hosts.
Signed-off-by: Jan Kiszka
---
arch/x86/include/asm/mce.h | 30 +++---
1 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h
index f6bb3ff..3b532bb
Jan Kiszka wrote:
Avi Kivity wrote:
Jan Kiszka wrote:
I'm about to loose overview of all those issues I ran into with older
kernels (still more to fix, sigh), but I think to remember this was a
2.6.18 x86_32 problem. Wait... yes, 2.6.18 asm-i386 does not include
this.
I have
Jan Kiszka wrote:
+
+#ifndef MCG_CTL_P
+#define MCG_CTL_P(1ULL<<8)
+#define MCG_STATUS_MCIP (1ULL<<2)
+#define MCI_STATUS_VAL (1ULL<<63)
+#define MCI_STATUS_OVER (1ULL<<62)
+#define MCI_STATUS_UC(1ULL<<61)
+#endif
This breaks on recent kernels (redefinition), so I remo
Jan Kiszka wrote:
These defines are used by KVM now also on 32-bit hosts.
Applied, thanks.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo
On Tue, May 26, 2009 at 02:24:33PM +0300, Avi Kivity wrote:
> Marcelo Tosatti wrote:
===
--- kvm-irqlock.orig/virt/kvm/coalesced_mmio.c
+++ kvm-irqlock/virt/kvm/coalesced_mmio.c
@@ -26,9 +26,12 @@ static int coalesc
KVM will always report the vendor ID of the physical CPU it is running on.
Allow to override this if explicitly requested on the command line.
It will not suffice to name a CPU type (like -cpu phenom), but you have
to explicitly set the vendor: -cpu phenom,vendor=AuthenticAMD
Signed-off-by: Andre
Marcelo Tosatti wrote:
Why not use slots_lock to protect the entire iodevice list (rcu one
day), and an internal spinlock for coalesced mmio?
Don't like using slots_lock to protect the entire iodevice list, its
reverse progress in my opinion. The PIO/MMIO device lists are data
structure
Changes in v2:
- added empty mce.h for 32-bit kernels
- fixed redefinition issue by pulling in mce.h early
Signed-off-by: Jan Kiszka
---
include-compat/asm-x86/mce.h |1 +
x86/external-module-compat.h | 10 ++
2 files changed, 11 insertions(+), 0 deletions(-)
create mode 100644
Jan Kiszka wrote:
Changes in v2:
- added empty mce.h for 32-bit kernels
- fixed redefinition issue by pulling in mce.h early
Applied, thanks.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a
From: Christian Borntraeger
This bug never appeared, since all current virtio drivers use
VIRTIO_DEV_ANY_ID for the vendor field. If a real vendor would be used,
the check in virtio_id_match is wrong - it returns 0 if
id->vendor == dev->id.vendor.
Signed-off-by: Christian Borntraeger
---
drive
Hello Rusty,
here are two patches that change the device matching of the virtio bus.
The patches have been refreshed agains linux-next and should apply
to your private virtio tree.
OK for linux-next?
Christian
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a me
From: Christian Borntraeger
This patch allows a virtio driver to use VIRTIO_DEV_ANY_ID for the
device id. This will be used by a test module that can be bound to
any virtio device.
Signed-off-by: Christian Borntraeger
---
drivers/virtio/virtio.c |2 +-
scripts/mod/file2alias.c |2 +-
Alan Cox wrote:
On Tue, 26 May 2009 20:54:41 +0930
Rusty Russell wrote:
When KVM is loaded, and hence VT set up, the vmcall instruction in an
lguest guest causes a #GP, not #UD.
Signed-off-by: Rusty Russell
Shouldn't that be fixed in KVM ?
KVM never saw that VMCALL or #GP.
--
Avi Kivity wrote:
Tomasz Chmielewski wrote:
Avi Kivity wrote:
Tomasz Chmielewski wrote:
I still observe this "slowness" with kvm-86 after the guest is
running for some time (virtio_net and virtio_console seem to be
affected; guest restart doesn't fix it).
Anything in guest dmesg?
No.
Tomasz Chmielewski wrote:
Maybe virtio is racy and a loaded host exposes the race.
I see it happening with virtio on 2.6.29.x guests as well.
So, what would you do if you saw it on your systems as well? ;)
Add some debug routines into virtio_* modules?
I'm no virtio expert. Maybe I'd inse
Gregory Haskins wrote:
> Today this function returns void and will internally BUG_ON if it fails.
> We want to create dynamic MMIO/PIO entries driven from userspace later in
> the series, so enhance this API to return an error code on failure.
>
> We also fix up all the callsites to check the retur
example: kernel_args = "ks=floppy console=ttyS0 noacpi"
fix modifies kvm_config.split_and_strip so it will only split once per line.
---
client/tests/kvm_runtest_2/kvm_config.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/client/tests/kvm_runtest_2/kvm_config.py
b/c
I've tried adding it as 'pcidevice host=' when launch the guest and via
hotplug w/ pci_add pci_addr=auto host host= after the guest is launched.
-Original Message-
From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf Of
Avi Kivity
Sent: Sunday, May 24, 2009 2:44 A
Michael Goldish wrote:
> Looks good to me. See some comments below.
>
> - "David Huff" wrote:
>
>> This patch will run pre and post scripts
>> defined in config file with the parameter pre_command
>> and post_command post_command.
>>
>> Also exports all the prameters in preprocess for passin
Avi Kivity wrote:
> Michael Goldish wrote:
>> This makes sense, thanks.
>>
>> One thing though -- I don't know if it's even worth mentioning -- we
>> always try to put a single space after a comma (I think the Python
>> style guide recommends that but I'm not sure). Generally we try to
>> follow th
resending patch set... first pass at spiting up tests into separate files...
These relatively simple changes to kvm_runtest_2 will allow for the addition of
new tests without having modifying kvm_runtest "code."
One would just add a newtest.py file and update the config file. This will
simpl
This will allow for adding of additional tests with out modifying the "code."
One would just add the testname.py file to the test_dir and edit the comfig
file.
fixed typo
---
client/tests/kvm_runtest_2/kvm_runtest_2.py | 32 +++---
1 files changed, 23 insertions(+), 9 del
---
client/tests/kvm_runtest_2/kvm_tests.py | 396 ---
1 files changed, 0 insertions(+), 396 deletions(-)
delete mode 100644 client/tests/kvm_runtest_2/kvm_tests.py
diff --git a/client/tests/kvm_runtest_2/kvm_tests.py
b/client/tests/kvm_runtest_2/kvm_tests.py
delete
autotest.py, boot.py, linux_s3.py, migration.py, yum_update.py
---
client/tests/kvm_runtest_2/kvm_tests/autotest.py | 145
client/tests/kvm_runtest_2/kvm_tests/boot.py | 45 ++
client/tests/kvm_runtest_2/kvm_tests/linux_s3.py | 53 +++
client/tests/kvm_r
On Wed, May 20, 2009 at 10:30:49AM -0400, Gregory Haskins wrote:
> +static int
> +irqfd_wakeup(wait_queue_t *wait, unsigned mode, int sync, void *key)
> +{
> + struct _irqfd *irqfd = container_of(wait, struct _irqfd, wait);
> +
> + /*
> + * The wake_up is called with interrupts disable
Michael S. Tsirkin wrote:
> On Wed, May 20, 2009 at 10:30:49AM -0400, Gregory Haskins wrote:
>
>> +static int
>> +irqfd_wakeup(wait_queue_t *wait, unsigned mode, int sync, void *key)
>> +{
>> +struct _irqfd *irqfd = container_of(wait, struct _irqfd, wait);
>> +
>> +/*
>> + * The wake
(Applies to kvm.git/master:74dfca0a)
This is v4 of the series. For more details, please see the header to
patch 3/3.
This series has been tested against the kvm-eventfd unit test, and
appears to be functioning properly. You can download this test here:
ftp://ftp.novell.com/dev/ghaskins/kvm-eve
1 - 100 of 122 matches
Mail list logo
