Re: [PATCH 6/6] Nested SVM: Improve interrupt injection

On 17.05.2009, at 08:48, Gleb Natapov wrote: On Fri, May 15, 2009 at 10:22:20AM +0200, Alexander Graf wrote: static void svm_set_irq(struct kvm_vcpu *vcpu, int irq) { struct vcpu_svm *svm = to_svm(vcpu); -nested_svm_intr(svm); +if(!(svm->vcpu.arch.hflags & HF_GIF_MASK)) +

Re: [PATCH] Set bit 1 in disabled processor's _STA

On Fri, May 15, 2009 at 08:14:43AM -0400, Glauber Costa wrote: > This patch sets bits 1 in disabled processor's _STA. > According to the ACPI spec, this bit means: > "Set if the device is enabled and decoding its resources." > > Without it, Windows 2008 device manager shows the processors > as ma

[ kvm-Bugs-2792656 ] System freeze after modprobe kvm-intel

Bugs item #2792656, was opened at 2009-05-16 15:32 Message generated for change (Comment added) made by avik You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2792656&group_id=180599 Please note that this message will contain a full copy of the comment thre

Re: event injection MACROs

On Fri, May 15, 2009 at 03:57:44PM +0800, Dong, Eddie wrote: > > And what if INTA already happened and CPU is ready to fetch IDT for > > interrupt vector and at this very moment CPU faults? > > If INTA happens, that means it is delivered. If its delivery triggers another > exception, that is what

Re: [PATCH 2/6] MMU: don't bail on PAT bits in PTE

Joerg Roedel wrote: Subject: [PATCH] kvm/mmu: fix reserved bit checking on 4kb pte level The reserved bits checking code looks at bit 7 of the pte to determine if it has to use the mask for a large pte or a normal pde. This does not work on 4kb pte level because bit 7 is used there for PAT. Acco

Re: [PATCH 4/6] Implement Hyper-V MSRs

Alexander Graf wrote: Hyper-V uses some MSRs, some of which are actually reserved for BIOS usage. But let's be nice today and have it its way, because otherwise it fails terribly. For MSRs where I could find a name I used the name, otherwise they're just added in their hex form for now. M

Re: [PATCH] Set bit 1 in disabled processor's _STA

On Sun, May 17, 2009 at 11:23:47AM +0300, Gleb Natapov wrote: > On Fri, May 15, 2009 at 08:14:43AM -0400, Glauber Costa wrote: > > This patch sets bits 1 in disabled processor's _STA. > > According to the ACPI spec, this bit means: > > "Set if the device is enabled and decoding its resources." > >

Re: [PATCH] Set bit 1 in disabled processor's _STA

On Sun, May 17, 2009 at 11:23:47AM +0300, Gleb Natapov wrote: > On Fri, May 15, 2009 at 08:14:43AM -0400, Glauber Costa wrote: > > This patch sets bits 1 in disabled processor's _STA. > > According to the ACPI spec, this bit means: > > "Set if the device is enabled and decoding its resources." > >

Re: [PATCH] Set bit 1 in disabled processor's _STA

On Sun, May 17, 2009 at 10:27:41AM -0300, Glauber Costa wrote: > On Sun, May 17, 2009 at 11:23:47AM +0300, Gleb Natapov wrote: > > On Fri, May 15, 2009 at 08:14:43AM -0400, Glauber Costa wrote: > > > This patch sets bits 1 in disabled processor's _STA. > > > According to the ACPI spec, this bit mea

Re: [PATCH] Set bit 1 in disabled processor's _STA

On Sun, May 17, 2009 at 11:31:07AM -0300, Glauber Costa wrote: > On Sun, May 17, 2009 at 11:23:47AM +0300, Gleb Natapov wrote: > > On Fri, May 15, 2009 at 08:14:43AM -0400, Glauber Costa wrote: > > > This patch sets bits 1 in disabled processor's _STA. > > > According to the ACPI spec, this bit mea

[RFC] KVM-Autotest: basic parallel test execution

Hi all, We've recently implemented a very simple form of parallel test execution into KVM-Autotest and we'd like some feedback on it. This suggestion allows the user to manually assign tests to hosts/queues. It also takes care of assigning different MAC address ranges to hosts/queues. By 'queue

Re: [PATCH] Set bit 1 in disabled processor's _STA

On Sun, May 17, 2009 at 05:30:06PM +0300, Gleb Natapov wrote: > On Sun, May 17, 2009 at 10:27:41AM -0300, Glauber Costa wrote: > > On Sun, May 17, 2009 at 11:23:47AM +0300, Gleb Natapov wrote: > > > On Fri, May 15, 2009 at 08:14:43AM -0400, Glauber Costa wrote: > > > > This patch sets bits 1 in dis

Re: [PATCH] Set bit 1 in disabled processor's _STA

On Sun, May 17, 2009 at 05:32:35PM +0300, Gleb Natapov wrote: > On Sun, May 17, 2009 at 11:31:07AM -0300, Glauber Costa wrote: > > On Sun, May 17, 2009 at 11:23:47AM +0300, Gleb Natapov wrote: > > > On Fri, May 15, 2009 at 08:14:43AM -0400, Glauber Costa wrote: > > > > This patch sets bits 1 in dis

Re: [PATCH] Set bit 1 in disabled processor's _STA

On Sun, May 17, 2009 at 12:06:22PM -0300, Glauber Costa wrote: > On Sun, May 17, 2009 at 05:30:06PM +0300, Gleb Natapov wrote: > > On Sun, May 17, 2009 at 10:27:41AM -0300, Glauber Costa wrote: > > > On Sun, May 17, 2009 at 11:23:47AM +0300, Gleb Natapov wrote: > > > > On Fri, May 15, 2009 at 08:14

Re: [PATCH] Set bit 1 in disabled processor's _STA

On Sun, May 17, 2009 at 12:07:27PM -0300, Glauber Costa wrote: > On Sun, May 17, 2009 at 05:32:35PM +0300, Gleb Natapov wrote: > > On Sun, May 17, 2009 at 11:31:07AM -0300, Glauber Costa wrote: > > > On Sun, May 17, 2009 at 11:23:47AM +0300, Gleb Natapov wrote: > > > > On Fri, May 15, 2009 at 08:14

Re: [PATCH] Set bit 1 in disabled processor's _STA

On Sun, May 17, 2009 at 06:21:45PM +0300, Gleb Natapov wrote: > On Sun, May 17, 2009 at 12:06:22PM -0300, Glauber Costa wrote: > > On Sun, May 17, 2009 at 05:30:06PM +0300, Gleb Natapov wrote: > > > On Sun, May 17, 2009 at 10:27:41AM -0300, Glauber Costa wrote: > > > > On Sun, May 17, 2009 at 11:23

[PATCH 0/17][REVIEW] Backport candidates for stable-0.10

This is a set of patches from master that I think are candidates for the stable-0.10 branch. They're all KVM specific. I tried to be conservative and didn't include any ia64, PPC, or passthrough fixes. I don't know the state of those subsystems well enough to judge whether the commits help or n

[PATCH 01/17] kvm: libkvm: protect irq injection status code with KVM_CAP_IRQ_INJECT_STATUS

From: Gleb Natapov Fixes builds with older kernel headers. Signed-off-by: Gleb Natapov Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori diff --git a/kvm/libkvm/libkvm.c b/kvm/libkvm/libkvm.c index 0ac1c28..7c65f31 100644 --- a/kvm/libkvm/libkvm.c +++ b/kvm/libkvm/libkvm.c @@ -667,9 +

[PATCH 02/17] kvm: testsuite: compile fix - avoid raw string literal

From: Jochen Roth This patch fixes compilation problems of kvm-userspace on current gcc 4.4 compilers which implement the following standard: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2442.htm Signed-off-by: Jochen Roth Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori

[PATCH 03/17] Fix build breakage on non-device-deassignment capable host kernels

From: Han, Weidong kvm_deassign_pci_device is defined when KVM_CAP_DEVICE_DEASSIGNMENT is defined. Signed-off-by: Weidong Han Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori diff --git a/hw/device-assignment.c b/hw/device-assignment.c index b7cbcec..56d70b4 100644 --- a/hw/device-as

[PATCH 04/17] kvm: extboot: Update number of HDs reported by BIOS

From: Gleb Natapov The Vista boot loaded expects the bios to report a correct count of the bootable disks; and extboot disks are bootable. This fixes Vista boot from virtio-blk issue. Signed-off-by: Gleb Natapov Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori diff --git a/kvm/extbo

[PATCH 05/17] Stop/start cpus before/after devices

From: Yaniv Kamay Stop cpus before devices when stopping the VM, start cpus after devices when starting VM. Otherwise a vcpu could access a stopped device. Acked-by: Dor Laor Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori diff --git a/qemu-kvm.c b/q

[PATCH 06/17] Use statfs to determine size of huge pages

From: Joerg Roedel The current method of finding out the size of huge pages does not work reliably anymore. Current Linux supports more than one huge page size but /proc/meminfo only show one of the supported sizes. To find out the real page size used can be found by calling statfs. This patch ch

[PATCH 07/17] Fixup 4GB+ memslot large page alignment

From: Marcelo Tosatti Need to align the 4GB+ memslot after we know its address, not before. Signed-off-by: Marcelo Tosatti Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori diff --git a/hw/pc.c b/hw/pc.c index 062c306..d6486a1 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -873,6 +873,7 @@ sta

[PATCH 08/17] Clear tap features on initialization

From: Avi Kivity tap features change how tap interprets data, so they must be cleared on initialization to prevent old settings from interfering with new guest instances. Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori diff --git a/net.c b/net.c index 08cd8c1..d8fb759 100644 --- a/ne

[PATCH 09/17] Propagate errors on failed migration.

From: Glauber Costa We're currently ignoring any errors if dirty logging fails. Set error on migration file if we're unable to put dirty logging on. Signed-off-by: Glauber Costa Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori diff --git a/vl.c b/vl.c index 5d02e10..dd2ae4c 100644 --

[PATCH 10/17] Support unregistering memory regions larger than a slot

From: Avi Kivity Unbreaks vga text mode after switching from graphics mode. Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori diff --git a/qemu-kvm.c b/qemu-kvm.c index fab00ac..10e2caa 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -889,14 +889,15 @@ void kvm_cpu_register_physical_memory

[PATCH 11/17] net: drop packet from tap device if all NICs are down

From: Mark McLoughlin If you do e.g. "set_link virtio.0 down" and there are packets pending on the tap interface, we currently buffer a packet and constantly try and send it until the link is up again. We actually just want to drop the packet if the NIC is down. Upstream qemu already does this,

[PATCH 11/17] net: drop packet from tap device if all NICs are down

From: Mark McLoughlin If you do e.g. "set_link virtio.0 down" and there are packets pending on the tap interface, we currently buffer a packet and constantly try and send it until the link is up again. We actually just want to drop the packet if the NIC is down. Upstream qemu already does this,

[PATCH 12/17] Increment virtio-net savevm version to avoid conflict with upstream QEMU.

When TAP_VNET_HDR eventually merges into upstream QEMU, it cannot change the format of the version 6 savevm data. This means that we're going to have to bump the version up to 7. I'm happy to reserve version 7 as having TAP_VNET_HDR support to allow time to include this support in upstream QEMU.

[PATCH 13/17] Increment version id for CPU save state

9 is reserved for KVM. KVM cannot support migration from any other version. [aliguori: incorporated Glauber's fix for save/restore breakage] Signed-off-by: Anthony Liguori Signed-off-by: Avi Kivity diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 2f8b4f6..367b4be 100644 --- a/target-i

[PATCH 15/17] Fix loading extboot option rom

From: Avi Kivity The buffer that is used to store the extboot filename is later overwritten by the vga rom loading code. Use strdup() to keep our filename. Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori diff --git a/hw/pc.c b/hw/pc.c index d6486a1..626450c 100644 --- a/hw/pc.c +++

[PATCH 16/17] virtio-net: Make save/load format independent of build options

From: Alex Williamson We can't rely on build switches to tell us if a save image includes a given field. Signed-off-by: Alex Williamson Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 27620ba..2da4c47 100644 --- a/hw/virtio-net.c

[PATCH 14/17] Fix build when objdir != srcdir

This requires adding the necessary bits to configure to create the directories and symlinks for libkvm. It also requires sticking KVM_CFLAGS in config-host.mak to ensure that it gets the right set of includes for the kernel headers. Signed-off-by: Anthony Liguori Signed-off-by: Avi Kivity Signe

[PATCH 17/17] virtio-net: Refuse loading if the source requires vnet header and the host doesn't support it

From: Alex Williamson Bail if the saved image requires vnet header support. Signed-off-by: Alex Williamson Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 2da4c47..f65ecd7 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -658

Re: [PATCH 0/17][REVIEW] Backport candidates for stable-0.10

Anthony Liguori wrote: kvm-stable-start is a local tag to: commit 8d890e234cdf5860395c4cb93b831ae37aab41e9 Author: Zhang, Yang Date: Thu Mar 5 15:10:22 2009 +0800 kvm: external module: add kvm-ia64.c to hack files list As best I can tell, the is the point where KVM's stable bran

Re: [PATCH 01/17] kvm: libkvm: protect irq injection status code with KVM_CAP_IRQ_INJECT_STATUS

Anthony Liguori wrote: From: Gleb Natapov Fixes builds with older kernel headers. Since we build with a specific set of headers now (rather that 'make sync'), this isn't necessary. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the

Re: [PATCH 03/17] Fix build breakage on non-device-deassignment capable host kernels

Anthony Liguori wrote: From: Han, Weidong kvm_deassign_pci_device is defined when KVM_CAP_DEVICE_DEASSIGNMENT is defined. Unneeded, since the headers are carried in qemu-kvm.git. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the lin

Re: [PATCH 05/17] Stop/start cpus before/after devices

Anthony Liguori wrote: From: Yaniv Kamay Stop cpus before devices when stopping the VM, start cpus after devices when starting VM. Otherwise a vcpu could access a stopped device. IIRC we decided this was unnecessary since everything is under qemu_mutex. However we might want to be on t

Re: [PATCH 06/17] Use statfs to determine size of huge pages

Anthony Liguori wrote: From: Joerg Roedel The current method of finding out the size of huge pages does not work reliably anymore. Current Linux supports more than one huge page size but /proc/meminfo only show one of the supported sizes. To find out the real page size used can be found by call

Re: [PATCH 10/17] Support unregistering memory regions larger than a slot

Anthony Liguori wrote: From: Avi Kivity Unbreaks vga text mode after switching from graphics mode. I think this was caused by a merge (and indeed the immediately preceding commit is a merge), so this is likely unneeded. -- error compiling committee.c: too many arguments to function --

Re: [PATCH 12/17] Increment virtio-net savevm version to avoid conflict with upstream QEMU.

Anthony Liguori wrote: When TAP_VNET_HDR eventually merges into upstream QEMU, it cannot change the format of the version 6 savevm data. This means that we're going to have to bump the version up to 7. I'm happy to reserve version 7 as having TAP_VNET_HDR support to allow time to include this s

Re: [PATCH 13/17] Increment version id for CPU save state

Anthony Liguori wrote: 9 is reserved for KVM. KVM cannot support migration from any other version. [aliguori: incorporated Glauber's fix for save/restore breakage] Signed-off-by: Anthony Liguori Signed-off-by: Avi Kivity I reverted this in master, so the end result is different. Pleas

Re: [PATCH 15/17] Fix loading extboot option rom

Anthony Liguori wrote: From: Avi Kivity The buffer that is used to store the extboot filename is later overwritten by the vga rom loading code. Use strdup() to keep our filename. This is a post-merge fixed, so likely unneeded on stable-0.10. Would be good to check though. -- error co

Re: [PATCH 0/17][REVIEW] Backport candidates for stable-0.10

Anthony Liguori wrote: This is a set of patches from master that I think are candidates for the stable-0.10 branch. They're all KVM specific. I tried to be conservative and didn't include any ia64, PPC, or passthrough fixes. I don't know the state of those subsystems well enough to judge whet

Re: [PATCH 1/2] Clean up MADT Table Creation

Beth Kon wrote: This patch is based on the recent patch from Vincent Minet. I split Vincent's changes into 2 patches (to separate MADT and RSDT table cleanup, as suggested by Marcelo) and added a bit to them. And to give credit where it is due, this cleanup is also related to the patch Marcelo pr

Re: [PATCH 2/2] Clean up RSDT Table Creation

Beth Kon wrote: This patch is also based on the patch by Vincent Minet. It corrects the size calculation of the RSDT, and checks for overflow of MAX_RSDT_ENTRIES, assuming that the external table entry count is contained within MAX_RSDT_ENTRIES. Signed-off-by: Beth Kon diff --git a/kvm/bios/

Re: [PATCH] kmod: Update .gitignore

Jan Kiszka wrote: Signed-off-by: Jan Kiszka --- .gitignore | 118 +++- Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH v3] kmod: Add distclean rule

Jan Kiszka wrote: The smaller the patch... sigh. > Remove the configure output config.kbuild, config.mak and arch links via distclean. Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe from this list: se

Re: [PATCH -v3] KVM: MCE: Add MCE support to KVM

Huang Ying wrote: The related MSRs are emulated. MCE capability is exported via extension KVM_CAP_MCE and ioctl KVM_X86_GET_MCE_CAP_SUPPORTED. A new vcpu ioctl command KVM_X86_SETUP_MCE is used to setup MCE emulation such as the mcg_cap. MCE is injected via vcpu ioctl command KVM_X86_SET_MCE. Ex

Re: [PATCH -tip] x86: kvm replace MSR_IA32_TIME_STAMP_COUNTER with MSR_IA32_TSC of msr-index.h

Jaswinder Singh Rajput wrote: If this patch looks sane to you can apply in kvm tree. Here is the updated patch based on kvm tree: [PATCH] x86: kvm replace MSR_IA32_TIME_STAMP_COUNTER with MSR_IA32_TSC of msr-index.h Use standard msr-index.h's MSR declaration. MSR_IA32_TSC is better than MSR_

Re: [PATCH -tip] x86: kvm/x86.c use MSR names in place of address

Jaswinder Singh Rajput wrote: [PATCH -tip] x86: kvm/x86.c use MSR names in place of address Replace 0xc0010010 with MSR_K8_SYSCFG and 0xc0010015 with MSR_K7_HWCR. Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe fro

Re: [PATCH] Allow to override sync source

Jan Kiszka wrote: In order to allow sync'ing the kmod dir against arbitrary kernels trees, extend the sync script to accept alternative paths and adjust the Makefile accordingly. @@ -17,6 +17,7 @@ ORIGMODDIR = $(patsubst %/build,%/kernel,$(KERNELDIR)) rpmrelease = devel +KVM_VERSION = kvm-d

Re: [RFC] KVM-Autotest: basic parallel test execution

Michael Goldish wrote: Drawbacks: - requires some initial work to be done by the user -- the user has to define exactly where each test should run For me, this is a major drawback. I'd really like a fire-and-forget solution. If I have to spend my own time getting this to work, vs. waiti

Re: virtio_net with RSS?

Fischer, Anna wrote: Are there any plans to enhance virtio_net with receive-side scaling capabilities, so that an SMP guest OS can balance its network processing load more equally across multiple CPUs? Yes, the MSI-X patches are the first steps towards this. We will enable each queue to

Re: KVM & VT-d2?

Fischer, Anna wrote: I thought that one use case of VT-d2 interrupt remapping was to be able to safely and more efficiently deliver interrupts to the CPU that runs the particular VCPU of the guest that owns the I/O device that issues the interrupt. Shouldn't there at least be some performance

Re: PCI pass-through of multi-function device

Fischer, Anna wrote: Does KVM allow passing through a full multi-function PCI device to a guest, and make that device appear as a whole multi-function device rather than as multiple PCI single-function devices (e.g. Xen only does the latter where all PCI devices appear with function ID being 0

Re: KVM 10/Gb Ethernet PCIe passthrough with Linux/iSCSI and large block sizes

Nicholas A. Bellinger wrote: Greetings all, The first test results for Linux/iSCSI Initiators and targets for large block sizes using 10 Gb/sec Ethernet + PCIe device-passthrough into Linux/KVM guests have been posted at: http://linux-iscsi.org/index.php/KVM-LIO-Target So far, the results have

Re: [PATCH 4/6] Implement Hyper-V MSRs

On 17.05.2009, at 11:54, Avi Kivity wrote: Alexander Graf wrote: Hyper-V uses some MSRs, some of which are actually reserved for BIOS usage. But let's be nice today and have it its way, because otherwise it fails terribly. For MSRs where I could find a name I used the name, otherwis

Re: [PATCH 3/6] Emulator: Inject #PF when page was not found

Alexander Graf wrote: If we couldn't find a page on read_emulated, it might be a good idea to tell the guest about that and inject a #PF. We do the same already for write faults. I don't know why it was not implemented for reads. I can't think why it was done for writes. Normally, a guest

Re: [PATCH 4/6] Implement Hyper-V MSRs

Alexander Graf wrote: case MSR_VM_CR: +case 0x4081: *data = 0; break; This probably is a Hyper-V MSR, but I don't see how it expects it to be present in real hardware. Are you sure this is really needed? Well hyper-v just crashes/reboots if it get a #gp on that msr

Re: [PATCH 5/6] Nested SVM: Implement INVLPGA

Joerg Roedel wrote: On Fri, May 15, 2009 at 10:22:19AM +0200, Alexander Graf wrote: SVM adds another way to do INVLPG by ASID which Hyper-V makes use of, so let's implement it! For now we just do the same thing invlpg does, as asid switching means we flush the mmu anyways. That might change

Re: [PATCH 5/6] Nested SVM: Implement INVLPGA

Avi Kivity wrote: Hmm, since we flush the TLB on every nested-guest entry I think we can make this function a nop. I think, unless it specified ASID 0? In that case you need a local tlb flush. (the kvm_mmu_reset_context() and kvm_mmu_load() are total overkills in any case). Oh, but

Re: [PATCH] Set bit 1 in disabled processor's _STA

Gleb Natapov wrote: Theoretically we can provide different values for different OSes, but this is just a guess work since there is no any documentation how CPU hot-plug should work on x86. ACPI in fact supports this, but I hope we don't have to do that. -- Do not meddle in the internals of

Re: [KVM PATCH v2 2/4] kvm: add return value to kvm_io_bus_register_dev

Gregory Haskins wrote: Today this function returns void and will internally BUG_ON if it fails. We want to create dynamic MMIO/PIO entries driven from userspace later in the series, so enhance this API to return an error code on failure. We also fix up all the callsites to check the return code

Re: [KVM PATCH v2 4/4] kvm: add iosignalfd support

Gregory Haskins wrote: + +struct _iosignalfd { Why the underscore? It's unorthodox for a structure. + u64 cookie; + u64 addr; + size_t length; + struct file *file; + struct list_head list; + st

Re: RFC: convert KVMTRACE to event traces

Marcelo Tosatti wrote: On Fri, May 15, 2009 at 01:10:34PM -0400, Christoph Hellwig wrote: On Thu, May 14, 2009 at 05:30:16PM -0300, Marcelo Tosatti wrote: + trace_kvm_cr_write(cr, val); switch (cr) { case 0: - kvm_set_c

Re: [PATCH 3/6] Emulator: Inject #PF when page was not found

On 17.05.2009, at 21:59, Avi Kivity wrote: Alexander Graf wrote: If we couldn't find a page on read_emulated, it might be a good idea to tell the guest about that and inject a #PF. We do the same already for write faults. I don't know why it was not implemented for reads. I can't think w

Re: KVM_HYPERCALL

Kumar, Venkat wrote: I am making a hypercall "kvm_hypercall0" with number 0 from a Linux guest. But I don't see the control coming to "handle_vmcall" or even "kvm_handle_exit". What could be the reason? No idea. kvm_handle_exit() is called very frequently, even without hypercalls. Are yo

Re: [PATCH 4/6] Implement Hyper-V MSRs

On 17.05.2009, at 22:00, Avi Kivity wrote: Alexander Graf wrote: case MSR_VM_CR: +case 0x4081: *data = 0; break; This probably is a Hyper-V MSR, but I don't see how it expects it to be present in real hardware. Are you sure this is really needed? Well hyper-v

Re: kvm-85 sometimes not starting on 2.6.30-rc5

Andrea, looks like the mother of all locks below. Nikola Ciprich wrote: Hi, sometimes trying to start kvm on 2.6.30-rc5 (with kvm module v85, userspace v85) fails with: kvm_create_vm: Interrupted system call Could not create KVM context and following backtrace appears in dmesg: [ 309.546138]

Re: profiling virtio (blk in this case)

Eran Rom wrote: The "Host<-->Guest" calls in virtio_blk (using the generic virtio kick/notify) are as follows: Guest->Host --- do_virtlkb_request calls kick in the guest side causing handle_output to be called on the host side. Host->Guest --- virtio_blk_rw_complete calls notify

Re: [PATCH 4/6] Implement Hyper-V MSRs

On 17.05.2009, at 22:00, Avi Kivity wrote: Alexander Graf wrote: case MSR_VM_CR: +case 0x4081: *data = 0; break; This probably is a Hyper-V MSR, but I don't see how it expects it to be present in real hardware. Are you sure this is really needed? Well hyper-v

Re: [PATCH v4] kvm: Use a bitmap for tracking used GSIs

Alex Williamson wrote: On Wed, 2009-05-13 at 08:33 -0600, Alex Williamson wrote: On Wed, 2009-05-13 at 08:15 -0600, Alex Williamson wrote: On Wed, 2009-05-13 at 16:55 +0300, Michael S. Tsirkin wrote: Very surprising: I haven't seen any driver disable MSI expect on device destruc

Re: [PATCH v3] kvm: Use a bitmap for tracking used GSIs

Alex Williamson wrote: On Wed, 2009-05-13 at 10:04 +0300, Michael S. Tsirkin wrote: On Tue, May 12, 2009 at 04:07:15PM -0600, Alex Williamson wrote: @@ -286,6 +289,9 @@ kvm_context_t kvm_init(struct kvm_callbacks *callbacks, int fd; kvm_context_t kvm; int r; +#if

Re: [PATCH v5] kvm: Use a bitmap for tracking used GSIs

Michael S. Tsirkin wrote: +#ifdef KVM_IOAPIC_NUM_PINS I think we should just export #define KVM_IOAPIC_NUM_PINS 0 for ppc in kernel headers (or in libkvm), and get rid of this ifdef completely. Avi, agree? ppc doesn't have an ioapic, so it shouldn't have this define. -- Do not me

Re: [PATCH v6] kvm: Use a bitmap for tracking used GSIs

Alex Williamson wrote: We're currently using a counter to track the most recent GSI we've handed out. This quickly hits KVM_MAX_IRQ_ROUTES when using device assignment with a driver that regularly toggles the MSI enable bit. This can mean only a few minutes of usable run time. Instead, track us

Re: [PATCH 3/6] Emulator: Inject #PF when page was not found

Alexander Graf wrote: I can't think why it was done for writes. Normally, a guest page fault would be trapped and reflected a long time before emulation, in FNAME(page_fault)(), after walk_addr(). Can you give some details on the situation? What instruction was executed, and why kvm tried

Re: [PATCH 0/6] Add rudimentary Hyper-V guest support

Alexander Graf wrote: In order to find out why things were slow with nested SVM I hacked intercept reporting into debugfs in my local tree and found pretty interesting results (using NPT): [...] So apparently the most intercepts come from the SVM helper calls (clgi, stgi, vmload, vmsave).

Re: Network I/O performance

Fischer, Anna wrote: Subject: Re: Network I/O performance Fischer, Anna wrote: I am running KVM with Fedora Core 8 on a 2.6.23 32-bit kernel. I use the tun/tap device model and the Linux bridge kernel module to connect my VM to the network. I have 2 10G Intel 82598 network devices

Re: Problem doing pci passthrough of the network card without VT-d

Passera, Pablo R wrote: Hi Anna, Are you expecting this to work using the 1:1 mapping for direct device assignment? Actually, I want to use the current qemu implementation for this. AFAIK from the code seems that qemu mmaps the device memory into the qemu pci subsystem memory space.

Re: [PATCHv6 4/4] virtio_pci: optional MSI-X support

Michael S. Tsirkin wrote: This implements optional MSI-X support in virtio_pci. MSI-X is used whenever the host supports at least 2 MSI-X vectors: 1 for configuration changes and 1 for virtqueues. Per-virtqueue vectors are allocated if enough vectors available. +static int vp_request_vectors(str

Re: XP smp using a lot of CPU

Erik Rull wrote: Hi all, very very interesting. I have a similar problem but the other way round. If my XP runs up tp 100% CPU usage "top" on the linux host reports "only" 33% cpu usage. I would expect around 50% because I only provide one core for the guest. I already increased the process p

Re: [PATCH v2] Shared memory device with interrupt support

Cam Macdonell wrote: I don't think so. With the mmap call, I specify MAP_FIXED which requires that the memory in the shared memory object be mapped to the address given in the first parameter (s->ivshmem_ptr). If MAP_FIXED is not specified then mmap would allocate the memory and map on to i

Re: [PATCH v2] Shared memory device with interrupt support

Cam Macdonell wrote: If my understanding is correct both the VM's who wants to communicate would gives this path in the command line with one of them specifying as "server". Exactly, the one with the "server" in the parameter list will wait for a connection before booting. hm, we may be a

Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

Mark McLoughlin wrote: Currently we only include $(KERNELDIR)/include in CFLAGS, but we also have $(KERNELDIR)/arch/$(arch)/include or else we'll get mis-matched headers. Signed-off-by: Mark McLoughlin --- kvm/user/config-i386.mak |1 - kvm/user/config-ia64.mak |1 + kvm/us

Re: [PATCH 1/6] kvm-s390: Fix memory slot versus run

Christian Ehrhardt wrote: The bad thing on vcpu->request in that case is that I don't want the async behaviour of vcpu->requests in that case, I want the memory slot updated in all vcpu's when the ioctl is returning. You mean, the hardware can access the vcpu control block even when the vcpu

Re: [PATCH] KVM: fix cpuid E2BIG handling for extended request types

Mark McLoughlin wrote: If we run out of cpuid entries for extended request types we should return -E2BIG, just like we do for the standard request types. Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe from this list

Re: [PATCH] Work around supported cpuid ioctl() brokenness

Mark McLoughlin wrote: KVM_GET_SUPPORTED_CPUID has been known to fail to return -E2BIG when it runs out of entries. Detect this by always trying again with a bigger table if the ioctl() fills the table. Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and q

Re: [PATCH 0/17][REVIEW] Backport candidates for stable-0.10

Avi Kivity wrote: Anthony Liguori wrote: kvm-stable-start is a local tag to: commit 8d890e234cdf5860395c4cb93b831ae37aab41e9 Author: Zhang, Yang Date: Thu Mar 5 15:10:22 2009 +0800 kvm: external module: add kvm-ia64.c to hack files list As best I can tell, the is the point wher

Re: [PATCH 12/17] Increment virtio-net savevm version to avoid conflict with upstream QEMU.

Avi Kivity wrote: Anthony Liguori wrote: When TAP_VNET_HDR eventually merges into upstream QEMU, it cannot change the format of the version 6 savevm data. This means that we're going to have to bump the version up to 7. I'm happy to reserve version 7 as having TAP_VNET_HDR support to allow

Re: [PATCH 0/17][REVIEW] Backport candidates for stable-0.10

Avi Kivity wrote: Anthony Liguori wrote: This is a set of patches from master that I think are candidates for the stable-0.10 branch. They're all KVM specific. I tried to be conservative and didn't include any ia64, PPC, or passthrough fixes. I don't know the state of those subsystems well

Re: [PATCH 12/17] Increment virtio-net savevm version to avoid conflict with upstream QEMU.

Anthony Liguori wrote: Avi Kivity wrote: Anthony Liguori wrote: When TAP_VNET_HDR eventually merges into upstream QEMU, it cannot change the format of the version 6 savevm data. This means that we're going to have to bump the version up to 7. I'm happy to reserve version 7 as having TAP_VNE

Re: [PATCH 0/17][REVIEW] Backport candidates for stable-0.10

Anthony Liguori wrote: 'git log origin/stable-0.10..origin/master' would have given you the same results ("all commits in master not present in stable"). You need to exclude commits from qemu/master too. git log ^qemu/master origin/stable-0.10..origin/master Gives the same result as what I

Re: [PATCH] Set bit 1 in disabled processor's _STA

On Sun, May 17, 2009 at 11:07:31PM +0300, Avi Kivity wrote: > Gleb Natapov wrote: >> >> Theoretically we can provide different values for different OSes, but >> this is just a guess work since there is no any documentation how CPU >> hot-plug should work on x86. >> > > ACPI in fact supports this

Re: [KVM-AUTOTEST][PATCH] timedrift support

Hello Yaniv Kaul: I am understand your means for timedrift testcase. * give up using ntp to query and sync the clock from guest to host. my question is below: 1. why we can not using the NTP staff in timedrift test case? Is there some positive bugs were point on NTP or we found that something of

Re: [KVM PATCH v2 2/4] kvm: add return value to kvm_io_bus_register_dev

Avi Kivity wrote: > Gregory Haskins wrote: >> Today this function returns void and will internally BUG_ON if it fails. >> We want to create dynamic MMIO/PIO entries driven from userspace >> later in >> the series, so enhance this API to return an error code on failure. >> >> We also fix up all the

Network hangs after some time

Hello, I'm needin' some help. The network in guests hangs(I can't ping from my house the guest) after some time(from 10 minutes to some hours) and stops in one guest and the others will stopping after. I have a host with ubuntu jaunty installed and the network is configured using bridge... If I lo

Re: [KVM PATCH v2 4/4] kvm: add iosignalfd support

Avi Kivity wrote: > Gregory Haskins wrote: >> + >> +struct _iosignalfd { >> > > Why the underscore? It's unorthodox for a structure. I tend to do that to denote "this is a private structure", but it makes more sense if we are building a factory interface for a corresponding public version of t

Re: [KVM-AUTOTEST][PATCH] timedrift support

On 5/18/2009 4:54 AM, Bear Yang wrote: Hello Yaniv Kaul: I am understand your means for timedrift testcase. * give up using ntp to query and sync the clock from guest to host. my question is below: 1. why we can not using the NTP staff in timedrift test case? Is there some positive bugs were po

  1   2   >