Re: Page allocation failures in guest

2009-08-26 Thread David Miller
From: Rusty Russell Date: Wed, 26 Aug 2009 21:48:58 +0930 > Dave, can you push this to Linus ASAP? Ok. > Subject: virtio: net refill on out-of-memory > > If we run out of memory, use keventd to fill the buffer. There's a > report of this happening: "Page allocation failures in guest", > Messa

Re: Page allocation failures in guest

2009-08-26 Thread Rusty Russell
On Wed, 26 Aug 2009 02:25:01 pm Pierre Ossman wrote: > On Wed, 26 Aug 2009 11:47:17 +0930 > Rusty Russell wrote: > > > On Fri, 14 Aug 2009 05:55:48 am Pierre Ossman wrote: > > > On Wed, 12 Aug 2009 15:01:52 +0930 > > > Rusty Russell wrote: > > > > Subject: virtio: net refill on out-of-memory > >

Re: Page allocation failures in guest

2009-08-25 Thread Pierre Ossman
On Wed, 26 Aug 2009 11:47:17 +0930 Rusty Russell wrote: > On Fri, 14 Aug 2009 05:55:48 am Pierre Ossman wrote: > > On Wed, 12 Aug 2009 15:01:52 +0930 > > Rusty Russell wrote: > > > Subject: virtio: net refill on out-of-memory > ... > > Patch applied. Now we wait. :) > > Any results? > It's b

Re: Page allocation failures in guest

2009-08-25 Thread Rusty Russell
On Fri, 14 Aug 2009 05:55:48 am Pierre Ossman wrote: > On Wed, 12 Aug 2009 15:01:52 +0930 > Rusty Russell wrote: > > Subject: virtio: net refill on out-of-memory ... > Patch applied. Now we wait. :) Any results? Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe kvm" in

Re: Page allocation failures in guest

2009-08-13 Thread Pierre Ossman
On Wed, 12 Aug 2009 15:01:52 +0930 Rusty Russell wrote: > On Wed, 12 Aug 2009 12:49:51 pm Rusty Russell wrote: > > On Tue, 11 Aug 2009 04:22:53 pm Avi Kivity wrote: > > > On 08/11/2009 09:32 AM, Pierre Ossman wrote: > > > > I doesn't get out of it though, or at least the virtio net driver > > > >

Re: Page allocation failures in guest

2009-08-12 Thread Avi Kivity
On 08/12/2009 11:22 AM, Pierre Ossman wrote: Will it still trigger the OOM killer with this patch, or will things behave slightly more gracefully? I don't think you mentioned the OOM killer in your original report? Did it trigger? I might have things backwards here, but I th

Re: Page allocation failures in guest

2009-08-12 Thread Pierre Ossman
On Wed, 12 Aug 2009 10:43:46 +0300 Avi Kivity wrote: > On 08/12/2009 09:19 AM, Pierre Ossman wrote: > > Will it still trigger the OOM killer with this patch, or will things > > behave slightly more gracefully? > > > > I don't think you mentioned the OOM killer in your original report? Did

Re: Page allocation failures in guest

2009-08-12 Thread Avi Kivity
On 08/12/2009 09:19 AM, Pierre Ossman wrote: Will it still trigger the OOM killer with this patch, or will things behave slightly more gracefully? I don't think you mentioned the OOM killer in your original report? Did it trigger? -- error compiling committee.c: too many arguments to f

Re: Page allocation failures in guest

2009-08-11 Thread Rusty Russell
On Wed, 12 Aug 2009 03:11:21 pm Avi Kivity wrote: > > + /* In theory, this can happen: if we don't get any buffers in > > +* we will*never* try to fill again. Sleeping in keventd if > > +* bad, but that is worse. */ > > + if (still_empty) { > > + msleep(100); > > +

Re: Page allocation failures in guest

2009-08-11 Thread Pierre Ossman
On Wed, 12 Aug 2009 12:49:51 +0930 Rusty Russell wrote: > > It's kind of the nature of networking devices :( > > I'd say your host now offers GSO features, so the guest allocates big > packets. > > > > I doesn't get out of it though, or at least the virtio net driver > > > wedges itself. > >

Re: Page allocation failures in guest

2009-08-11 Thread Avi Kivity
On 08/12/2009 08:31 AM, Rusty Russell wrote: +static void refill_work(struct work_struct *work) +{ + struct virtnet_info *vi; + bool still_empty; + + vi = container_of(work, struct virtnet_info, refill); + napi_disable(&vi->napi); + try_fill_recv(vi, GFP_KERNEL); +

Re: Page allocation failures in guest

2009-08-11 Thread Rusty Russell
On Wed, 12 Aug 2009 12:49:51 pm Rusty Russell wrote: > On Tue, 11 Aug 2009 04:22:53 pm Avi Kivity wrote: > > On 08/11/2009 09:32 AM, Pierre Ossman wrote: > > > I doesn't get out of it though, or at least the virtio net driver > > > wedges itself. > > There's a fixme to retry when this happens, but

Re: Page allocation failures in guest

2009-08-11 Thread Rusty Russell
On Tue, 11 Aug 2009 04:22:53 pm Avi Kivity wrote: > On 08/11/2009 09:32 AM, Pierre Ossman wrote: > > On Mon, 13 Jul 2009 23:59:52 +0900 > > Minchan Kim wrote: > > Any ideas here? Is the virtio net driver very GFP_ATOMIC happy so it > > drains all those pages? And why is this triggered by a kernel

Re: Page allocation failures in guest

2009-08-11 Thread Pierre Ossman
On Mon, 13 Jul 2009 23:59:52 +0900 Minchan Kim wrote: > On Mon, Jul 13, 2009 at 6:51 PM, Pierre Ossman wrote: > > Jul 12 23:04:54 loki kernel: Active_anon:14065 active_file:87384 > > inactive_anon:37480 > > Jul 12 23:04:54 loki kernel: inactive_file:95821 unevictable:4 dirty:8 > > writeback:0 u

Re: Page allocation failures in guest

2009-08-11 Thread Avi Kivity
On 08/11/2009 09:32 AM, Pierre Ossman wrote: On Mon, 13 Jul 2009 23:59:52 +0900 Minchan Kim wrote: On Mon, Jul 13, 2009 at 6:51 PM, Pierre Ossman wrote: Jul 12 23:04:54 loki kernel: Active_anon:14065 active_file:87384 inactive_anon:37480 Jul 12 23:04:54 loki kernel: inactive_file:

Re: Page allocation failures in guest

2009-07-13 Thread Minchan Kim
On Mon, Jul 13, 2009 at 6:51 PM, Pierre Ossman wrote: > I upgraded my Fedora 10 host to 2.6.29 a few days ago and since then > one of the guests keeps getting page allocation failures after a few > hours. I've upgraded the kernel in the guest from 2.6.27 to 2.6.29 > without any change. There are al