Re: Mask bit support's API

On Friday 03 December 2010 00:55:03 Michael S. Tsirkin wrote: > On Thu, Dec 02, 2010 at 10:54:24PM +0800, Sheng Yang wrote: > > On Thu, Dec 2, 2010 at 10:26 PM, Michael S. Tsirkin wrote: > > > On Thu, Dec 02, 2010 at 03:56:52PM +0200, Avi Kivity wrote: > > >> On 12/02/2010 03:47 PM, Michael S. Tsi

Re: Mask bit support's API

On Thu, Dec 02, 2010 at 10:54:24PM +0800, Sheng Yang wrote: > On Thu, Dec 2, 2010 at 10:26 PM, Michael S. Tsirkin wrote: > > On Thu, Dec 02, 2010 at 03:56:52PM +0200, Avi Kivity wrote: > >> On 12/02/2010 03:47 PM, Michael S. Tsirkin wrote: > >> >> > >> >>  Which case?  the readl() doesn't need acc

Re: Mask bit support's API

On Thu, Dec 2, 2010 at 10:26 PM, Michael S. Tsirkin wrote: > On Thu, Dec 02, 2010 at 03:56:52PM +0200, Avi Kivity wrote: >> On 12/02/2010 03:47 PM, Michael S. Tsirkin wrote: >> >> >> >>  Which case?  the readl() doesn't need access to the routing table, >> >>  just the entry. >> > >> >One thing th

Re: Mask bit support's API

On Thu, Dec 02, 2010 at 03:56:52PM +0200, Avi Kivity wrote: > On 12/02/2010 03:47 PM, Michael S. Tsirkin wrote: > >> > >> Which case? the readl() doesn't need access to the routing table, > >> just the entry. > > > >One thing that read should do is flush in the outstanding > >interrupts and flus

Re: Mask bit support's API

On 12/02/2010 03:47 PM, Michael S. Tsirkin wrote: > > Which case? the readl() doesn't need access to the routing table, > just the entry. One thing that read should do is flush in the outstanding interrupts and flush out the mask bit writes. The mask bit writes are synchronous. wrt interru

Re: Mask bit support's API

On Thu, Dec 02, 2010 at 03:09:43PM +0200, Avi Kivity wrote: > On 12/01/2010 04:36 AM, Yang, Sheng wrote: > >On Tuesday 30 November 2010 22:15:29 Avi Kivity wrote: > >> On 11/26/2010 04:35 AM, Yang, Sheng wrote: > >> > > > Shouldn't kvm also service reads from the pending bitmask? > >> > >

Re: Mask bit support's API

On 12/01/2010 04:36 AM, Yang, Sheng wrote: On Tuesday 30 November 2010 22:15:29 Avi Kivity wrote: > On 11/26/2010 04:35 AM, Yang, Sheng wrote: > > > > Shouldn't kvm also service reads from the pending bitmask? > > > > > > Of course KVM should service reading from pending bitmask. For

Re: Mask bit support's API

On Tuesday 30 November 2010 22:15:29 Avi Kivity wrote: > On 11/26/2010 04:35 AM, Yang, Sheng wrote: > > > > Shouldn't kvm also service reads from the pending bitmask? > > > > > > Of course KVM should service reading from pending bitmask. For > > > assigned device, it's kernel who would set th

Re: Mask bit support's API

On 11/26/2010 04:35 AM, Yang, Sheng wrote: > > > > Shouldn't kvm also service reads from the pending bitmask? > > Of course KVM should service reading from pending bitmask. For assigned > device, it's kernel who would set the pending bit; but I am not sure for > virtio. This interface is GE

Re: Mask bit support's API

On Wednesday 24 November 2010 09:59:23 Yang, Sheng wrote: > On Tuesday 23 November 2010 22:06:20 Avi Kivity wrote: > > On 11/23/2010 03:57 PM, Yang, Sheng wrote: > > > > > Yeah, but won't be included in this patchset. > > > > > > > > What API changes are needed? I'd like to see the complete A

Re: Mask bit support's API

On Tuesday 23 November 2010 22:06:20 Avi Kivity wrote: > On 11/23/2010 03:57 PM, Yang, Sheng wrote: > > > > Yeah, but won't be included in this patchset. > > > > > > What API changes are needed? I'd like to see the complete API. > > > > I am not sure about it. But I suppose the structure sho

Re: Mask bit support's API

On Tue, Nov 23, 2010 at 05:24:44PM +0200, Gleb Natapov wrote: > On Tue, Nov 23, 2010 at 05:11:19PM +0200, Michael S. Tsirkin wrote: > > On Tue, Nov 23, 2010 at 04:06:20PM +0200, Avi Kivity wrote: > > > >> > > > >> So instead of > > > >> > > > >> - guest reads/writes msix > > > >> - kvm filters m

Re: Mask bit support's API

On Tue, Nov 23, 2010 at 05:11:19PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 23, 2010 at 04:06:20PM +0200, Avi Kivity wrote: > > >> > > >> So instead of > > >> > > >> - guest reads/writes msix > > >> - kvm filters mmio, implements some, passes others to userspace > > >> > > >> we have > >

Re: Mask bit support's API

On Tue, Nov 23, 2010 at 04:06:20PM +0200, Avi Kivity wrote: > >> > >> So instead of > >> > >> - guest reads/writes msix > >> - kvm filters mmio, implements some, passes others to userspace > >> > >> we have > >> > >> - guest reads/writes msix > >> - kvm implements all > >> - some writes gene

Re: Mask bit support's API

On 11/23/2010 03:57 PM, Yang, Sheng wrote: > > > > Yeah, but won't be included in this patchset. > > What API changes are needed? I'd like to see the complete API. I am not sure about it. But I suppose the structure should be the same? In fact it's pretty hard for me to image what's needed

Re: Mask bit support's API

On Tuesday 23 November 2010 20:04:16 Michael S. Tsirkin wrote: > On Tue, Nov 23, 2010 at 02:09:52PM +0800, Yang, Sheng wrote: > > Hi Avi, > > > > I've purposed the following API for mask bit support. > > > > The main point is, QEmu can know which entries are enabled(by > > pci_enable_msix()). >

Re: Mask bit support's API

On Tuesday 23 November 2010 20:47:33 Avi Kivity wrote: > On 11/23/2010 10:30 AM, Yang, Sheng wrote: > > On Tuesday 23 November 2010 15:54:40 Avi Kivity wrote: > > > On 11/23/2010 08:35 AM, Yang, Sheng wrote: > > > > On Tuesday 23 November 2010 14:17:28 Avi Kivity wrote: > > > > > On 11/23/20

Re: Mask bit support's API

On Tue, Nov 23, 2010 at 02:47:33PM +0200, Avi Kivity wrote: > On 11/23/2010 10:30 AM, Yang, Sheng wrote: > >On Tuesday 23 November 2010 15:54:40 Avi Kivity wrote: > >> On 11/23/2010 08:35 AM, Yang, Sheng wrote: > >> > On Tuesday 23 November 2010 14:17:28 Avi Kivity wrote: > >> > > On 11/23/2

Re: Mask bit support's API

On 11/23/2010 10:30 AM, Yang, Sheng wrote: On Tuesday 23 November 2010 15:54:40 Avi Kivity wrote: > On 11/23/2010 08:35 AM, Yang, Sheng wrote: > > On Tuesday 23 November 2010 14:17:28 Avi Kivity wrote: > > > On 11/23/2010 08:09 AM, Yang, Sheng wrote: > > > > Hi Avi, > > > > > >

Re: Mask bit support's API

On Tue, Nov 23, 2010 at 02:09:52PM +0800, Yang, Sheng wrote: > Hi Avi, > > I've purposed the following API for mask bit support. > > The main point is, QEmu can know which entries are enabled(by > pci_enable_msix()). Unfortunately, it can't I think, unless all your guests are linux. "enabled e

Re: Mask bit support's API

On Tuesday 23 November 2010 15:54:40 Avi Kivity wrote: > On 11/23/2010 08:35 AM, Yang, Sheng wrote: > > On Tuesday 23 November 2010 14:17:28 Avi Kivity wrote: > > > On 11/23/2010 08:09 AM, Yang, Sheng wrote: > > > > Hi Avi, > > > > > > > > I've purposed the following API for mask bit suppor

Re: Mask bit support's API

On 11/23/2010 08:35 AM, Yang, Sheng wrote: On Tuesday 23 November 2010 14:17:28 Avi Kivity wrote: > On 11/23/2010 08:09 AM, Yang, Sheng wrote: > > Hi Avi, > > > > I've purposed the following API for mask bit support. > > > > The main point is, QEmu can know which entries are enabled(by >

Re: Mask bit support's API

On Tuesday 23 November 2010 14:17:28 Avi Kivity wrote: > On 11/23/2010 08:09 AM, Yang, Sheng wrote: > > Hi Avi, > > > > I've purposed the following API for mask bit support. > > > > The main point is, QEmu can know which entries are enabled(by > > pci_enable_msix()). And for enabled entries, kern

Re: Mask bit support's API

On 11/23/2010 08:09 AM, Yang, Sheng wrote: Hi Avi, I've purposed the following API for mask bit support. The main point is, QEmu can know which entries are enabled(by pci_enable_msix()). And for enabled entries, kernel own it, including MSI data/address and mask bit(routing table and mask bitm