Re: KVM: init bsp_vcpu before kvm_arch_vcpu_init

2009-06-29 Thread Avi Kivity
On 06/17/2009 04:07 PM, Marcelo Tosatti wrote: KVM: use vcpu_id instead of bsp_vcpu pointer in kvm_vcpu_is_bsp Change kvm_vcpu_is_bsp to use vcpu_id instead of bsp_vcpu pointer, which is only initialized at the end of kvm_vm_ioctl_create_vcpu. Applied, thanks. -- error compiling committee.

Re: KVM: init bsp_vcpu before kvm_arch_vcpu_init

2009-06-17 Thread Gleb Natapov
On Wed, Jun 17, 2009 at 10:07:59AM -0300, Marcelo Tosatti wrote: > On Wed, Jun 17, 2009 at 03:29:05PM +0300, Gleb Natapov wrote: > > On Tue, Jun 16, 2009 at 11:33:16AM -0300, Marcelo Tosatti wrote: > > > > > > On x86 mp_state is initialized by kvm_arch_vcpu_init. Right > > > now kvm_vcpu_is_bsp re

Re: KVM: init bsp_vcpu before kvm_arch_vcpu_init

2009-06-17 Thread Marcelo Tosatti
On Wed, Jun 17, 2009 at 03:29:05PM +0300, Gleb Natapov wrote: > On Tue, Jun 16, 2009 at 11:33:16AM -0300, Marcelo Tosatti wrote: > > > > On x86 mp_state is initialized by kvm_arch_vcpu_init. Right > > now kvm_vcpu_is_bsp returns false because kvm->bsp_vcpu has > > not been initialized, so vcpu_id

Re: KVM: init bsp_vcpu before kvm_arch_vcpu_init

2009-06-17 Thread Gleb Natapov
On Tue, Jun 16, 2009 at 11:33:16AM -0300, Marcelo Tosatti wrote: > > On x86 mp_state is initialized by kvm_arch_vcpu_init. Right > now kvm_vcpu_is_bsp returns false because kvm->bsp_vcpu has > not been initialized, so vcpu_id == 0 ends up with mp_state == > KVM_MP_STATE_UNINITIALIZED. > > Gleb do