Re: [SeaBIOS PATCH v2] hotplug: Add device per func in ACPI DSDT tables

2011-09-21 Thread Michael S. Tsirkin
On Wed, Sep 21, 2011 at 08:47:39AM -0400, Kevin O'Connor wrote: > On Wed, Sep 21, 2011 at 02:09:08PM +0300, Michael S. Tsirkin wrote: > > On Wed, Sep 21, 2011 at 01:39:22AM -0400, Amos Kong wrote: > > > - Original Message - > > > > How about moving code into functions so that it isn't dupli

Re: [SeaBIOS PATCH v2] hotplug: Add device per func in ACPI DSDT tables

2011-09-21 Thread Kevin O'Connor
On Wed, Sep 21, 2011 at 02:09:08PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 21, 2011 at 01:39:22AM -0400, Amos Kong wrote: > > - Original Message - > > > How about moving code into functions so that it isn't duplicated for > > > each PCI device. See the patch below as an example (100

Re: [SeaBIOS PATCH v2] hotplug: Add device per func in ACPI DSDT tables

2011-09-21 Thread Michael S. Tsirkin
On Wed, Sep 21, 2011 at 01:39:22AM -0400, Amos Kong wrote: > - Original Message - > > On Tue, Sep 20, 2011 at 06:45:57AM -0400, Amos Kong wrote: > > > From 48ea1c9188334b89a60b4f9e853e86fc04fda4a5 Mon Sep 17 00:00:00 > > > 2001 > > > From: Amos Kong > > > Date: Tue, 20 Sep 2011 15:38:43 +0

Re: [SeaBIOS PATCH v2] hotplug: Add device per func in ACPI DSDT tables

2011-09-20 Thread Amos Kong
- Original Message - > On Tue, Sep 20, 2011 at 06:45:57AM -0400, Amos Kong wrote: > > From 48ea1c9188334b89a60b4f9e853e86fc04fda4a5 Mon Sep 17 00:00:00 > > 2001 > > From: Amos Kong > > Date: Tue, 20 Sep 2011 15:38:43 +0800 > > Subject: [SeaBIOS PATCH v2] hotplug: Add device per func in ACP

Re: [SeaBIOS PATCH v2] hotplug: Add device per func in ACPI DSDT tables

2011-09-20 Thread Kevin O'Connor
On Tue, Sep 20, 2011 at 06:45:57AM -0400, Amos Kong wrote: > From 48ea1c9188334b89a60b4f9e853e86fc04fda4a5 Mon Sep 17 00:00:00 2001 > From: Amos Kong > Date: Tue, 20 Sep 2011 15:38:43 +0800 > Subject: [SeaBIOS PATCH v2] hotplug: Add device per func in ACPI DSDT tables > > Only func 0 is registere

Re: [SeaBIOS PATCH v2] hotplug: Add device per func in ACPI DSDT tables

2011-09-20 Thread Marcelo Tosatti
On Tue, Sep 20, 2011 at 06:45:57AM -0400, Amos Kong wrote: > >From 48ea1c9188334b89a60b4f9e853e86fc04fda4a5 Mon Sep 17 00:00:00 2001 > From: Amos Kong > Date: Tue, 20 Sep 2011 15:38:43 +0800 > Subject: [SeaBIOS PATCH v2] hotplug: Add device per func in ACPI DSDT tables > > Only func 0 is register