Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-09 Thread Cornelia Huck
On Wed, 8 Aug 2012 19:39:33 + Blue Swirl wrote: > On Wed, Aug 8, 2012 at 7:34 PM, Peter Maydell > wrote: > > On 8 August 2012 20:16, Blue Swirl wrote: > >> On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck > >> wrote: > >>> On Tue, 7 Aug 2012 21:00:59 + > >>> Blue Swirl wrote: > Pl

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 7:34 PM, Peter Maydell wrote: > On 8 August 2012 20:16, Blue Swirl wrote: >> On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck >> wrote: >>> On Tue, 7 Aug 2012 21:00:59 + >>> Blue Swirl wrote: Please use more descriptive names instead of acronyms, for example

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-08 Thread Peter Maydell
On 8 August 2012 20:16, Blue Swirl wrote: > On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck > wrote: >> On Tue, 7 Aug 2012 21:00:59 + >> Blue Swirl wrote: >>> Please use more descriptive names instead of acronyms, for example >>> SubChStatus. >> >> I'd rather leave these at the well-known sc

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-08 Thread Blue Swirl
On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck wrote: > On Tue, 7 Aug 2012 21:00:59 + > Blue Swirl wrote: > > >> > diff --git a/hw/s390x/css.c b/hw/s390x/css.c >> > new file mode 100644 >> > index 000..7941c44 >> > --- /dev/null >> > +++ b/hw/s390x/css.c >> > @@ -0,0 +1,440 @@ >> > +/* >>

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-08 Thread Cornelia Huck
On Wed, 8 Aug 2012 09:27:32 +0100 Peter Maydell wrote: > On 7 August 2012 15:52, Cornelia Huck wrote: > > +static void sch_handle_clear_func(SubchDev *sch) > > +{ > > +struct pmcw *p = &sch->curr_status.pmcw; > > +struct scsw *s = &sch->curr_status.scsw; > > +int path; > > + > > +

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-08 Thread Peter Maydell
On 7 August 2012 15:52, Cornelia Huck wrote: > +static void sch_handle_clear_func(SubchDev *sch) > +{ > +struct pmcw *p = &sch->curr_status.pmcw; > +struct scsw *s = &sch->curr_status.scsw; > +int path; > + > +/* Path management: In our simple css, we always choose the only path. *

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-08 Thread Cornelia Huck
On Tue, 7 Aug 2012 21:00:59 + Blue Swirl wrote: > > diff --git a/hw/s390x/css.c b/hw/s390x/css.c > > new file mode 100644 > > index 000..7941c44 > > --- /dev/null > > +++ b/hw/s390x/css.c > > @@ -0,0 +1,440 @@ > > +/* > > + * Channel subsystem base support. > > + * > > + * Copyright 2012

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-07 Thread Blue Swirl
On Tue, Aug 7, 2012 at 2:52 PM, Cornelia Huck wrote: > Provide a mechanism for qemu to provide fully virtual subchannels to > the guest. In the KVM case, this relies on the kernel's css support. > The !KVM case is not yet supported. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/Makefile.objs