Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-11 Thread Michael S. Tsirkin
On Wed, Jun 10, 2009 at 08:04:13PM +0100, Paul Brook wrote: > > > If we can't start a new qemu with the same hardware configuration then we > > > should not be allowing migration or loading of snapshots. > > > > OK, so I'll add an option in virtio-net to disable msi-x, and such > > an option will b

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Paul Brook
> > If we can't start a new qemu with the same hardware configuration then we > > should not be allowing migration or loading of snapshots. > > OK, so I'll add an option in virtio-net to disable msi-x, and such > an option will be added in any device with msi-x support. > Will that address your con

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2009 at 06:30:16PM +0100, Paul Brook wrote: > On Wednesday 10 June 2009, Michael S. Tsirkin wrote: > > On Wed, Jun 10, 2009 at 05:46:03PM +0100, Paul Brook wrote: > > > > > If you can't create an identical machine from scratch then I don't > > > > > consider snapshot/migration to be

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2009 at 05:46:03PM +0100, Paul Brook wrote: > > > If you can't create an identical machine from scratch then I don't > > > consider snapshot/migration to be a useful feature. i.e. as soon as you > > > shutdown and restart the guest it is liable to break anyway. > > > > Why is liable

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Paul Brook
On Wednesday 10 June 2009, Michael S. Tsirkin wrote: > On Wed, Jun 10, 2009 at 05:46:03PM +0100, Paul Brook wrote: > > > > If you can't create an identical machine from scratch then I don't > > > > consider snapshot/migration to be a useful feature. i.e. as soon as > > > > you shutdown and restart

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Paul Brook
> > If you can't create an identical machine from scratch then I don't > > consider snapshot/migration to be a useful feature. i.e. as soon as you > > shutdown and restart the guest it is liable to break anyway. > > Why is liable to break? A VM booted on an old version of qemu and migrated to a ne

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2009 at 05:08:15PM +0100, Paul Brook wrote: > On Wednesday 10 June 2009, Michael S. Tsirkin wrote: > > On Wed, Jun 10, 2009 at 04:15:04PM +0100, Paul Brook wrote: > > > > > That's seems just plain wrong to me. > > > > > Loading a VM shouldn't not > > > > > do anything that can't hap

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Paul Brook
On Wednesday 10 June 2009, Michael S. Tsirkin wrote: > On Wed, Jun 10, 2009 at 04:15:04PM +0100, Paul Brook wrote: > > > > That's seems just plain wrong to me. > > > > Loading a VM shouldn't not > > > > do anything that can't happen during normal operation. > > > > > > At least wrt pci, we are very

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2009 at 04:15:04PM +0100, Paul Brook wrote: > > > That's seems just plain wrong to me. > > > Loading a VM shouldn't not > > > do anything that can't happen during normal operation. > > > > At least wrt pci, we are very far from this state: load just overwrites > > all registers, rea

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Paul Brook
> > That's seems just plain wrong to me. > > Loading a VM shouldn't not > > do anything that can't happen during normal operation. > > At least wrt pci, we are very far from this state: load just overwrites > all registers, readonly or not, which can never happen during normal > operation. IMO tha

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2009 at 03:39:05PM +0100, Paul Brook wrote: > > > If we really need to avoid MSI-X capable devices then that should be done > > > explicity per-device. i.e. you have a different virtio-net device that > > > does not use MSI-X. > > > > > > Paul > > > > Why should it be done per-devic

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Paul Brook
> > If we really need to avoid MSI-X capable devices then that should be done > > explicity per-device. i.e. you have a different virtio-net device that > > does not use MSI-X. > > > > Paul > > Why should it be done per-device? Because otherwise you end up with the horrible hacks that you're curr

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2009 at 03:07:34PM +0100, Paul Brook wrote: > > > > Note that platform must set a flag to declare MSI supported. > > > > For PC this will be set by APIC. > > > > > > This sounds wrong. The device shouldn't know or care whether the system > > > has a MSI capable interrupt controller.

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Paul Brook
> > > Note that platform must set a flag to declare MSI supported. > > > For PC this will be set by APIC. > > > > This sounds wrong. The device shouldn't know or care whether the system > > has a MSI capable interrupt controller. That's for the guest OS to figure > > out. > > You are right of cours

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2009 at 12:19:42AM +0100, Paul Brook wrote: > On Monday 25 May 2009, Michael S. Tsirkin wrote: > > Add functions implementing MSI-X support. First user will be virtio-pci. > > Note that platform must set a flag to declare MSI supported. > > For PC this will be set by APIC. > > This

Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions

2009-06-09 Thread Paul Brook
On Monday 25 May 2009, Michael S. Tsirkin wrote: > Add functions implementing MSI-X support. First user will be virtio-pci. > Note that platform must set a flag to declare MSI supported. > For PC this will be set by APIC. This sounds wrong. The device shouldn't know or care whether the system has